Re: Quick poll: can we rename the INCLUDE and LIB variables in Makefiles?
Am 14.05.21 um 21:56 schrieb Arrigo Marchiori: I would go for option A- because option B- would lead to _very_ long command lines and I would expect problems. But would I stomp on anyone's feet if I did that? Would it be bad practice? Would it violate any standards? I am open to suggestions and criticism. Please let me hear your opinion! I'm not a core developer, so I don't know the details. However, renaming such essential keywords like "INCLUDE" and "LIB" is indeed a heavy change. IMHO it's the same like switching the build system to gmake, scons or whatever. It has to be done very carefully and would be an enormous obstacle for us. There are f...cking many makefiles that need to be changed. We have tried to change the build system more than one time and both were not done until the end. So, now we have a mix of 3-4 build systems inside the code. With a mix of renamed keywords it won't get easier to maintain the code and even not for new vontuneers to understand this. What is currently used for building on Windows? Any (good) need to chnge thisto VS 2015? Who should do this change and is there a guarantee that the person is doing it until the end? Is it for sure that this is only influencing how we can build on Windows or has it any side effects on the other platforms? If so, renaming is more than a normal obstacle. We need to discuss and decide this very detailed and carefully. Sorry for these strong words and questions. However, my gut feeling says "this is not a good idea". My 2 ct. Marcus - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] cbmarcum commented on pull request #129: Tests for warning dialog on certain hyperlinks in documents (i128450)…
cbmarcum commented on pull request #129: URL: https://github.com/apache/openoffice/pull/129#issuecomment-841493988 cherry-picked from trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] cbmarcum opened a new pull request #129: Tests for warning dialog on certain hyperlinks in documents (i128450)…
cbmarcum opened a new pull request #129: URL: https://github.com/apache/openoffice/pull/129 … (#128) * Refs #i128450 - added fvt test class for verifying a warning dialog for certain hyperlinks. Added a test method to bvt test so there is some coverage there. added UI mappings for hyperlink dialogs. * Refs #i128450 - removed http and https protcols. * Refs #i128450 - updated comments for change in fvt test method name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Quick poll: can we rename the INCLUDE and LIB variables in Makefiles?
Dear All, I am attempting to build AOO using Visual Studio 2015. While I am very far from being done, I need to take a ``heavy'' decision with respect to include and library paths. Apparently, VS 2015 is relying on _environment variables_ such as: - INCLUDE listing the paths in which to search for header files [1]; - LIB for listing the patch in which to search for libraries [2]. It looks like that the names "INCLUDE" and "LIB" are _already used_ across our Makefiles for command line parameters (see for example main/solenv/inc/target.mk). There is a conflict of names: the environment variables and the command line parameters have different syntax. Therefore, in order to let VC++ find everything it needs, we must either: A- rename the Makefile variables INCLUDE and LIB into something else (such as AOO_INCLUDE or CMDLINE_INCLUDE) B- forget about environment variables and only use command-line parameters (i.e. introduce VC_INCLUDE being the contents of Visual Studio's INCLUDE environment variable adapted to the command-line syntax). I would go for option A- because option B- would lead to _very_ long command lines and I would expect problems. But would I stomp on anyone's feet if I did that? Would it be bad practice? Would it violate any standards? I am open to suggestions and criticism. Please let me hear your opinion! References: 1: https://docs.microsoft.com/en-us/cpp/build/reference/i-additional-include-directories?view=msvc-140 2: https://docs.microsoft.com/en-us/cpp/build/reference/libpath-additional-libpath?view=msvc-140 -- Arrigo signature.asc Description: PGP signature
[GitHub] [openoffice-org] dave2wave merged pull request #27: Update index.html
dave2wave merged pull request #27: URL: https://github.com/apache/openoffice-org/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Hyperlink Warning Message
> On May 14, 2021, at 1:27 AM, Arrigo Marchiori wrote: > > > I agree, but how many 4.1.X versions do we want to publish before 4.2.0? > Now that we support two digits, please let us not point to 4.1.99 ! ;-) > FWIW, I tend to agree. We fixed the bug. Maybe its not the best solution, but I don't see why we should continue to "focus" on 4.1.X at the expense of 4.2.X. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice-org] jeanmicoste opened a new pull request #27: Update index.html
jeanmicoste opened a new pull request #27: URL: https://github.com/apache/openoffice-org/pull/27 Good link to writer.pdf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Release Notes for AOO 4.1.11
Keith, thanks for creating new notes. I've added a missing space to the headline. Also moved it to the previously created release schedule, sorry haven't told about it yet. I remember that you wanted to create a new template structure for the release notes. Is this already done? Or is it coming later? Thanks Marcus - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice-org] Pilot-Pirx merged pull request #26: Update msg_prop_l10n_hy.js
Pilot-Pirx merged pull request #26: URL: https://github.com/apache/openoffice-org/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Hyperlink Warning Message
Am 14.05.21 um 10:19 schrieb Matthias Seidel: Hi Arrigo, Am 14.05.21 um 07:27 schrieb Arrigo Marchiori: Hello Carl, all, On Thu, May 13, 2021 at 07:23:16PM -0400, Carl Marcum wrote: [...] Hopefully we can collect the exceptions in the BZ issue noted in this thread and then agree on the direction. The few I see so far are: 1. in-document links beginning with #. 2. .uno:XXX links 3. Links to local files. I think all 3 are candidates but that's just me. @Arrigo, were you planning on a PR for AOO41X ? If not, I can try at least some of it but again I'm not really a C++ guy yet :) I suggest we make up our minds on the intended solution first, and then start coding it. We have seen some interesting proposals, some of which were quite complex (adding configuration settings, dialogs etc). The three categories listed above would be candidates for whitelisting, and this would be the quickest fix. But someone fluent in UNO should first ensure all of us that no.2 is not going to reopen any other backdoors! Maybe this topic is worth a discussion with vote, the Apache way? So we get our roadmap fixed. There is also the suggestion (Dave's maybe?) that we add the 3 security levels (that are already in the code) for links to the UI settings and let the user lock it down or open it up from where it is now. Yes, I was referring to this and to Peter's ideas. Yes, but that will only work for trunk/AOO42X since we need to update the translations too. I agree, but how many 4.1.X versions do we want to publish before 4.2.0? Now that we support two digits, please let us not point to 4.1.99 ! ;-) As "soon" as all Release Blocker are fixed we can release 4.2.0 ;-) yes, the goal is easy but to reach it that is the challenge. Marcus - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Hyperlink Warning Message
Am 14.05.21 um 07:27 schrieb Arrigo Marchiori: On Thu, May 13, 2021 at 07:23:16PM -0400, Carl Marcum wrote: [...] I suggest we make up our minds on the intended solution first, and then start coding it. We have seen some interesting proposals, some of which were quite complex (adding configuration settings, dialogs etc). +1 Otherwise we may need more time with improving the fix again and again. A little Confluence page could be really helpful to collect the possible ways and with a column to express our all favorite way. Marcus - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Hyperlink Warning Message
Hi Arrigo, Am 14.05.21 um 07:27 schrieb Arrigo Marchiori: > Hello Carl, all, > > On Thu, May 13, 2021 at 07:23:16PM -0400, Carl Marcum wrote: > > [...] > >> Hopefully we can collect the exceptions in the BZ issue noted in this thread >> and then agree on the direction. >> >> The few I see so far are: >> 1. in-document links beginning with #. >> 2. .uno:XXX links >> 3. Links to local files. >> >> I think all 3 are candidates but that's just me. >> >> @Arrigo, were you planning on a PR for AOO41X ? >> >> If not, I can try at least some of it but again I'm not really a C++ guy yet >> :) > I suggest we make up our minds on the intended solution first, and > then start coding it. We have seen some interesting proposals, some of > which were quite complex (adding configuration settings, dialogs etc). > > The three categories listed above would be candidates for > whitelisting, and this would be the quickest fix. But someone fluent > in UNO should first ensure all of us that no.2 is not going to reopen > any other backdoors! > > Maybe this topic is worth a discussion with vote, the Apache way? So > we get our roadmap fixed. > There is also the suggestion (Dave's maybe?) that we add the 3 security levels (that are already in the code) for links to the UI settings and let the user lock it down or open it up from where it is now. > Yes, I was referring to this and to Peter's ideas. > >>> Yes, but that will only work for trunk/AOO42X since we need to update >>> the translations too. > I agree, but how many 4.1.X versions do we want to publish before 4.2.0? > Now that we support two digits, please let us not point to 4.1.99 ! ;-) As "soon" as all Release Blocker are fixed we can release 4.2.0 ;-) Regards, Matthias > > Best regards, smime.p7s Description: S/MIME Cryptographic Signature
[GitHub] [openoffice-org] tigran54 opened a new pull request #26: Update msg_prop_l10n_hy.js
tigran54 opened a new pull request #26: URL: https://github.com/apache/openoffice-org/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
