NordMike commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-739493620
It's for AOO42X because I'm trying to build upcoming release.
This is an automated message from the Apache Git
Pilot-Pirx commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-739506019
Yes, but patches are normally committed top->down.
So first in trunk and then in the branches...
And there is no branch for a release yet, AOO42X is still for develo
ardovm opened a new pull request #111:
URL: https://github.com/apache/openoffice/pull/111
Some Linux distributions, such as openSUSE, on x86_64 systems install
libraries in directories named "lib64" instead of "lib".
AOO418 and development branches do not compile successfully, becaus
NordMike commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-741613556
Should I rebase it for trunk or is AOO42X OK for now?
This is an automated message from the Apache Git Service
Pilot-Pirx commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-742520358
AOO42X is OK for now.
Can you tell me where this error is to be seen? Is there a log file?
This is an
Pilot-Pirx commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-742661749
OK, this seems to be fixed in trunk for some time:
https://github.com/apache/openoffice/commit/25a457539c4c9ee45d9cc1446a569f5b1532c064#diff-90c5bad7c7b6152ce7d0426fcd
NordMike commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-742669081
Yes, it's exactly the same. Backport it, please.
This is an automated message from the Apache Git Service.
To
Pilot-Pirx merged pull request #110:
URL: https://github.com/apache/openoffice/pull/110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Pilot-Pirx commented on pull request #110:
URL: https://github.com/apache/openoffice/pull/110#issuecomment-742672030
Done!
Thanks for finding this.
This is an automated message from the Apache Git Service.
To respond to th
cbmarcum commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744009606
When I open the pr89.odt file from the PR89.zip I see a discrepancy in the
characters 6th row left column vs. the image in the right column.
Also no problems on Windows with AOO 4.2.0-dev.
Do you have the font (Noto Sans CJK SC) insta
ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744016761
@cbmarcum thank you for the detailed review.
I don't know Korean, unfortunately, but from this page:
https://fonts.google.com/?subset=korean&preview.text=%ED%95%98&previe
cbmarcum commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744035475
I figured it out. I had Noto Sans CJK SC font's installed but they had
weight modifiers Light, Medium, Bold in the font names. Once I changed them it
appeared correctly. Thank
cbmarcum edited a comment on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744035475
I figured it out. I had Noto Sans CJK SC font's installed but they had
weight modifiers Light, Medium, Bold in the font names. Once I changed them it
appeared correctly
Pilot-Pirx commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-744752764
Did another build on Windows now. No problems with export.
This PR is OK from my point of view.
This is an
Grosskopf opened a new pull request #112:
URL: https://github.com/apache/openoffice/pull/112
A fix for [Bug 108383](https://bz.apache.org/ooo/show_bug.cgi?id=108383)
Repeating groupheaders were in the page's header while normal groupheaders
were in the pages body. So when a normal gr
leginee commented on pull request #112:
URL: https://github.com/apache/openoffice/pull/112#issuecomment-745358578
Awesome! Thanks for the patch.
While reviewing the patch, I noticed that some code has only commented out
and not removed. Is there any reason why we want to keep it?
Grosskopf commented on pull request #112:
URL: https://github.com/apache/openoffice/pull/112#issuecomment-745430027
Thank you for the quick answer :) True, we don't need that. I tried
Squashing it but that didn't quite work the way I expected xD is this ok?
Also, I committed this pat
leginee commented on pull request #112:
URL: https://github.com/apache/openoffice/pull/112#issuecomment-745573586
If not needed I would would opt that the dead code is removed. :) Can you
remove it? or should I check how I can incorporate this wish?
We need only the Apache License. I
cbmarcum opened a new pull request #1:
URL: https://github.com/apache/openoffice-mwiki/pull/1
Updated OOoIDLtags.php file to replace the deprecated ereg_replace methods
with the new preg_replace and updated arguments.
Also I bumped the minor version number present in the file.
cbmarcum merged pull request #1:
URL: https://github.com/apache/openoffice-mwiki/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Grosskopf commented on pull request #112:
URL: https://github.com/apache/openoffice/pull/112#issuecomment-746000980
> If not needed I would would opt that the dead code is removed. :) Can you
remove it? or should I check how I can incorporate this wish?
I think I did remove it, is it
leginee edited a comment on pull request #112:
URL: https://github.com/apache/openoffice/pull/112#issuecomment-746352262
> I think I did remove it, is it not gone? this commit history is messy...
Probably I had some caching issue or tomatos on my eyes. I did not see that
you removed
leginee commented on pull request #112:
URL: https://github.com/apache/openoffice/pull/112#issuecomment-746352262
> I think I did remove it, is it not gone? this commit history is messy...
Probably I had some caching issue or tomatos on my eyes. I did not see that
you removed the cod
ardovm opened a new pull request #113:
URL: https://github.com/apache/openoffice/pull/113
As per a recent thread on the dev@ mailing list, the "dmake clean" command
may wipe out the whole source tree, if the build environment was not set by
sourcing the appropriate `.Env` script.
Th
leginee commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747446201
hmm, that echo needs no quotes in
` echo Build environment not set; works without Quotes?`
looks strange. Is it special on make files that they can omit these?
ardovm commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747507745
@leginee I was also surprised it works :-)
Proof:
```
$ echo Hello world; echo Hallo Welt
Hello world
Hallo Welt
$
```
-
ardovm commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747509362
By the way, I followed that "pattern" as is it the same for the `install`
target in the same file:
```Makefile
install .PHONY :
@test "$(DESTDIR)$(prefix)" != "
leginee commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-747527573
Worth a test. :)
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dave2wave commented on pull request #74:
URL: https://github.com/apache/openoffice/pull/74#issuecomment-747643540
Please review your PRs and then start a thread on dev@openoffice to discuss
approval.
This is an automated mes
leginee commented on pull request #93:
URL: https://github.com/apache/openoffice/pull/93#issuecomment-748299936
How about we define a stlport::unique_ptr?
We use
auto_ptr for older builds and unique_ptr for newer.
T
leginee edited a comment on pull request #93:
URL: https://github.com/apache/openoffice/pull/93#issuecomment-748299936
How about we define a stlport::unique_ptr?
We use
auto_ptr for older builds and unique_ptr for newer.
but basically I am fine in general with building with gnu+
DonLewisFreeBSD commented on pull request #93:
URL: https://github.com/apache/openoffice/pull/93#issuecomment-748416075
> How about we define a stlport::unique_ptr?
> We use
> auto_ptr for older builds and unique_ptr for newer.
They are similar but unique_ptr is not a drop in re
leginee commented on pull request #93:
URL: https://github.com/apache/openoffice/pull/93#issuecomment-748442390
We need to find a method to do the modernization of the code. If we define
this in stlport then we would have one place to mess around with. Also the idea
is we could keep the su
Pilot-Pirx commented on pull request #113:
URL: https://github.com/apache/openoffice/pull/113#issuecomment-749494181
Is there any reason not to merge this PR?
This is an automated message from the Apache Git Service.
To respo
Pilot-Pirx merged pull request #113:
URL: https://github.com/apache/openoffice/pull/113
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
oooforum opened a new pull request #2:
URL: https://github.com/apache/openoffice-org/pull/2
Change URL to restore the Basic picture
This is an automated message from the Apache Git Service.
To respond to the message, please l
oooforum opened a new pull request #3:
URL: https://github.com/apache/openoffice-org/pull/3
Add charset to show these characters
This is an automated message from the Apache Git Service.
To respond to the message, please log
Pilot-Pirx merged pull request #2:
URL: https://github.com/apache/openoffice-org/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Pilot-Pirx merged pull request #3:
URL: https://github.com/apache/openoffice-org/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ne-oss opened a new pull request #114:
URL: https://github.com/apache/openoffice/pull/114
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Pilot-Pirx commented on pull request #114:
URL: https://github.com/apache/openoffice/pull/114#issuecomment-753512206
This one does not look like a reasonable PR...
This is an automated message from the Apache Git Service.
To
knmc closed pull request #114:
URL: https://github.com/apache/openoffice/pull/114
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cbmarcum opened a new pull request #115:
URL: https://github.com/apache/openoffice/pull/115
This work is for flaky BVT tests that randomly pass or fail during multiple
runs against the same build.
Basically I'm adding a thread sleep prior to the test assertion check.
So far this has r
Pilot-Pirx commented on pull request #3:
URL: https://github.com/apache/openoffice-org/pull/3#issuecomment-753690953
You could do that for the other pages as well...
This is an automated message from the Apache Git Service.
T
ardovm opened a new pull request #116:
URL: https://github.com/apache/openoffice/pull/116
This PR tries to address [bug
127952](https://bz.apache.org/ooo/show_bug.cgi?id=127952).
After applying it, the Linux builds should not crash when opening the [file
linked by the report](https:
jimjag merged pull request #116:
URL: https://github.com/apache/openoffice/pull/116
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cbmarcum merged pull request #115:
URL: https://github.com/apache/openoffice/pull/115
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
DiGro opened a new pull request #117:
URL: https://github.com/apache/openoffice/pull/117
[:space:] should represent any whitespace character in regular expressions.
However, in the older, before OOo 3.4, it did not find the tab \t.
Now it does due to changing the regexp engine sinc
jimjag merged pull request #116:
URL: https://github.com/apache/openoffice/pull/116
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cbmarcum merged pull request #115:
URL: https://github.com/apache/openoffice/pull/115
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
leginee commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-757465959
I checked through the code and for me it is fine. I have a question thought.
The assert call had always a parameter as a implicit nested Function. and
you broke that up, by d
cbmarcum commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-757522715
The reason was technical. My belief is the tests were passing and failing
randomly either from threading issues or processor speeds that didn't exist
when they were created.
ardovm opened a new pull request #118:
URL: https://github.com/apache/openoffice/pull/118
See [https://bz.apache.org/ooo/show_bug.cgi?id=125129]
This is an automated message from the Apache Git Service.
To respond to the mess
ardovm commented on pull request #32:
URL: https://github.com/apache/openoffice/pull/32#issuecomment-758148778
Please see my comment on the bug report.
Do we still believe this is a bug?
This is an automated message from t
leginee commented on pull request #115:
URL: https://github.com/apache/openoffice/pull/115#issuecomment-758453134
Hmm, can I add a review confirmetion somehow, I wonder.
This is an automated message from the Apache Git Servic
leginee commented on pull request #32:
URL: https://github.com/apache/openoffice/pull/32#issuecomment-758461218
I am not sure if this is a bug or not. We need to investigate this further.
This is an automated message from the
leginee edited a comment on pull request #32:
URL: https://github.com/apache/openoffice/pull/32#issuecomment-758461218
I am not sure if this is a bug or not. We should to investigate this further.
This is an automated message
ardovm commented on pull request #32:
URL: https://github.com/apache/openoffice/pull/32#issuecomment-759661243
@oooforum if you could follow the discussion on the BugZilla report, this
"crossing" of auto-grow height and auto-grow size may be intentional.
If it was so, then this PR should
ardovm edited a comment on pull request #32:
URL: https://github.com/apache/openoffice/pull/32#issuecomment-759661243
@oooforum if you could follow the discussion on the BugZilla report, this
"exchange" of auto-grow height and auto-grow size may be intentional.
If it was so, then this PR
DiGro opened a new pull request #1:
URL: https://github.com/apache/openoffice-project/pull/1
Line 223 ; "contributers" should be spelled with an "o" : Changed to
"contributors"
This is an automated message from the Apache Gi
DiGro closed pull request #1:
URL: https://github.com/apache/openoffice-project/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
DiGro opened a new pull request #2:
URL: https://github.com/apache/openoffice-project/pull/2
Line 223 : "contributers" should be "contributors". Changed.
This is an automated message from the Apache Git Service.
To respond
DiGro closed pull request #2:
URL: https://github.com/apache/openoffice-project/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Pilot-Pirx commented on pull request #1:
URL: https://github.com/apache/openoffice-project/pull/1#issuecomment-761868165
Has this ever been merged?
This is an automated message from the Apache Git Service.
To respond to the m
DiGro commented on pull request #1:
URL: https://github.com/apache/openoffice-project/pull/1#issuecomment-762174709
@Pilot-Pirx,
Matthias, I'm still struggling with Git.
Didn't get the change merged.
Dave has however made the change for me, so all is well
---
ardovm opened a new pull request #119:
URL: https://github.com/apache/openoffice/pull/119
It is possible that `$OUTPATH` directories are left by previous compilation
attempts.
A proof that `$OUTPATH` directories are used is the Perl script
`solenv/bin/download_external_dependencies.
JuanJ67m opened a new pull request #120:
URL: https://github.com/apache/openoffice/pull/120
Actually, Excel is the main worksheet for and construction and I think
OpenOffice could same, creating nodes for Dynamo BIM nodes to interconnect with
Privative software, Pyflow nodes to interconnec
Pilot-Pirx commented on pull request #118:
URL: https://github.com/apache/openoffice/pull/118#issuecomment-767530852
If there are no objections I will merge this code later this day.
This is an automated message from the Apac
Pilot-Pirx merged pull request #118:
URL: https://github.com/apache/openoffice/pull/118
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Pilot-Pirx commented on pull request #120:
URL: https://github.com/apache/openoffice/pull/120#issuecomment-767659572
What should this PR do?!
The same was opened in LO and is now closed.
I don't see any value here.
This
leginee commented on pull request #120:
URL: https://github.com/apache/openoffice/pull/120#issuecomment-767680908
I think it is a feature request, but I am unsure what to do with it.
This is an automated message from the Apac
JuanJ67m commented on pull request #120:
URL: https://github.com/apache/openoffice/pull/120#issuecomment-767781863
>
>
> What should this PR do?!
> The same was opened in LO and is now closed.
> I don't see any value here.
was reopened
-
JuanJ67m commented on pull request #120:
URL: https://github.com/apache/openoffice/pull/120#issuecomment-767782309
>
>
> I think it is a feature request, but I am unsure what to do with it.
create nodes to allow connect to others FOSS.
---
Pilot-Pirx commented on pull request #120:
URL: https://github.com/apache/openoffice/pull/120#issuecomment-767800130
> > What should this PR do?!
> > The same was opened in LO and is now closed.
> > I don't see any value here.
>
> was reopened
Yes, from you!
I am sure
leginee opened a new pull request #121:
URL: https://github.com/apache/openoffice/pull/121
Translation of some german comments of the interface.
Please review and see if you understand those and check for spelling errors.
Thanks.
I hope this will help to improve the way we read
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565566978
##
File path: main/sw/inc/shellio.hxx
##
@@ -106,11 +105,11 @@ public:
};
/ SwReader/Reader /
-// Basisklasse
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565602584
##
File path: main/sw/inc/shellio.hxx
##
@@ -106,11 +105,11 @@ public:
};
/ SwReader/Reader /
-// Basisklasse
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565603037
##
File path: main/sw/inc/shellio.hxx
##
@@ -161,32 +160,32 @@ class SwReader: public SwDocFac
SvStream* pStrm;
SotStorageRef pStg;
com
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565603678
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565606170
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565606703
##
File path: main/sw/inc/shellio.hxx
##
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
-// suche
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565607126
##
File path: main/sw/inc/shellio.hxx
##
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
-// suche
leginee commented on pull request #121:
URL: https://github.com/apache/openoffice/pull/121#issuecomment-768553149
Thank you for the quick review. I have some really bad mistakes there.
This is an automated message from the Ap
ardovm merged pull request #119:
URL: https://github.com/apache/openoffice/pull/119
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Pilot-Pirx commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-770998849
Any objections against merging this PR?
This is an automated message from the Apache Git Service.
To respond t
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568057490
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern s
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568116353
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
-
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568119970
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
-
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568185411
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568215534
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568216249
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568367366
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
-
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568367773
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern s
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568382378
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568382378
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568383955
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r568450657
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern s
401 - 500 of 728 matches
Mail list logo
