Re: [RELEASE]: propose RC4 on revision 1587478
+1 Thanks for the hard work 2014-04-17 22:59 GMT+08:00 Jürgen Schmidt : > Hi, > > I would like to propose a new RC3 based on revision 1587478 of our > AOO410 release branch. > > Integrated fixe for > https://issues.apache.org/ooo/show_bug.cgi?id=124682 > > The latest reported problems with digital signatures can be solved with > setting an additional environment variable on non windows platforms. A > wiki page will be created to describe in detail what the user have to > do. and the release notes will be updated as well. For now you can view > issue https://issues.apache.org/ooo/show_bug.cgi?id=124701 for some > details. > > I would like to invite everybody with valid certificates to check and > test this feature in detail and give us feedback. > > Juergen > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
A question about algorithm of basic module
Hi~
When I debug code for verifying VBA macros in a spreadsheet document, I
find there are recursive calls in calling stack. Each time when basic code
run to execute a macro step, finally it will send out a broadcast in order
to get a value for a variable. But when basic module response the
broadcast(get Notify), it will trigger another iteration of previous
calling stack. The same stack will be called recursively for many times.
See below stack. I think that is one reason of low performance of VBA code
execution.
So my question is why basic module use such broadcast mechanism to get a
value for a variable? Does such recursive calls work as design or maybe a
mistake? I haven't find VBA design documents in our wikis. So is there any
experienced guys on this area could teach me this?
Clarence
svl.dll!51e6729b()
[Frames below may be incorrect and/or missing, no symbols loaded for
svl.dll]
sb.dll!SbMethod::Broadcast(unsigned long nHintId=65536) Line 2122 +
0x39 bytes
sb.dll!SbxValue::SbxValue(const SbxValue & r={...}) Line 274
sb.dll!SbxVariable::SbxVariable(const SbxVariable & r={...}) Line 91
+ 0x64 bytes
sb.dll!SbxMethod::SbxMethod(const SbxMethod & r={...}) Line 40 + 0x8f
bytes
sb.dll!SbiRuntime::FindElement(SbxObject * pObj=0x0561ad10, unsigned
long nOp1=32778, unsigned long nOp2=0, unsigned long nNotFound=87560,
unsigned char bLocal='', unsigned char bStatic=0) Line 254 + 0x2e
bytes
sb.dll!SbiRuntime::StepFIND_Impl(SbxObject * pObj=0x0561ad10, unsigned
long nOp1=32778, unsigned long nOp2=0, unsigned long nNotFound=87560,
unsigned char bLocal='', unsigned char bStatic=0) Line 644 + 0x22
bytes
sb.dll!SbiRuntime::StepFIND(unsigned long nOp1=32778, unsigned long
nOp2=0) Line 651
sb.dll!SbiRuntime::Step() Line 750
sb.dll!SbModule::Run(SbMethod * pMeth=0x056a0498) Line 1157 + 0x8
bytes
>sb.dll!SbModule::Notify(SfxBroadcaster & rBC={...}, const SfxHint &
rHint={...}) Line 798
svl.dll!51e6729b()
sb.dll!SbMethod::Broadcast(unsigned long nHintId=65536) Line 2122 +
0x39 bytes
sb.dll!SbxValue::SbxValue(const SbxValue & r={...}) Line 274
sb.dll!SbxVariable::SbxVariable(const SbxVariable & r={...}) Line 91
+ 0x64 bytes
sb.dll!SbxMethod::SbxMethod(const SbxMethod & r={...}) Line 40 + 0x8f
bytes
sb.dll!SbiRuntime::FindElement(SbxObject * pObj=0x09ef3590, unsigned
long nOp1=32911, unsigned long nOp2=0, unsigned long nNotFound=87560,
unsigned char bLocal='', unsigned char bStatic=0) Line 254 + 0x2e
bytes
sb.dll!SbiRuntime::StepFIND_Impl(SbxObject * pObj=0x09ef3590, unsigned
long nOp1=32911, unsigned long nOp2=0, unsigned long nNotFound=87560,
unsigned char bLocal='', unsigned char bStatic=0) Line 644 + 0x22
bytes
sb.dll!SbiRuntime::StepFIND(unsigned long nOp1=32911, unsigned long
nOp2=0) Line 651
sb.dll!SbiRuntime::Step() Line 750
sb.dll!SbModule::Run(SbMethod * pMeth=0x09ea0608) Line 1157 + 0x8
bytes
sb.dll!SbModule::Notify(SfxBroadcaster & rBC={...}, const SfxHint &
rHint={...}) Line 798
svl.dll!51e6729b()
sb.dll!SbMethod::Broadcast(unsigned long nHintId=65536) Line 2122 +
0x39 bytes
sb.dll!SbxValue::SbxValue(const SbxValue & r={...}) Line 274
sb.dll!SbxVariable::SbxVariable(const SbxVariable & r={...}) Line 91
+ 0x64 bytes
sb.dll!SbxMethod::SbxMethod(const SbxMethod & r={...}) Line 40 + 0x8f
bytes
sb.dll!SbiRuntime::FindElement(SbxObject * pObj=0x146f5408, unsigned
long nOp1=32783, unsigned long nOp2=0, unsigned long nNotFound=87560,
unsigned char bLocal='', unsigned char bStatic=0) Line 254 + 0x2e
bytes
sb.dll!SbiRuntime::StepFIND_Impl(SbxObject * pObj=0x146f5408, unsigned
long nOp1=32783, unsigned long nOp2=0, unsigned long nNotFound=87560,
unsigned char bLocal='', unsigned char bStatic=0) Line 644 + 0x22
bytes
sb.dll!SbiRuntime::StepFIND(unsigned long nOp1=32783, unsigned long
nOp2=0) Line 651
sb.dll!SbiRuntime::Step() Line 750
sb.dll!SbModule::Run(SbMethod * pMeth=0x09f67bd0) Line 1157 + 0x8
bytes
sb.dll!SbModule::Notify(SfxBroadcaster & rBC={...}, const SfxHint &
rHint={...}) Line 798
svl.dll!51e6729b()
sb.dll!SbMethod::Broadcast(unsigned long nHintId=65536) Line 2122 +
0x39 bytes
sb.dll!SbxValue::Get(SbxValues & rRes={...}) Line 531
sb.dll!SbMethod::Call(SbxValue * pRet=0x0568ff40) Line 2076
basprov.uno.dll!basprov::BasicScriptImpl::invoke() + 0x292 bytes
Re: [VOTE]: Release Apache OpenOffice 4.1.0 (RC)
[ ] +1 Release this package as Apache OpenOffice 4.1.0 Thanks for hard working from all of you Clarence 2014-04-03 15:56 GMT+08:00 Jürgen Schmidt : > Hi all, > > this is a call for vote on releasing the available release candidate > (RC) as Apache OpenOffice 4.1.0. > > Apache OpenOffice 4.1 is a minor update with many bugfixes and at least > 2 major improvements. It's the first version where we have the > iAccessibility2 support integrated and available. A very huge step > forward to reach and better support disabled users especially on > Windows. The second improvement is the switch to 64 bit on MacOS. A long > and overdue "must do" shift forward to support newer APIs (replace > deprecated APIs) and platforms on MacOS. > And we can provide again more complete UI translations and have now > support for 38 languages. New languages for this release compared to > 4.0.1 are Bulgarian, Danish, Hebrew, Hindi, Norwegian Bokmal and Thai. > > Apache OpenOffice 4.1 will be a further key milestone to continue the > success of OpenOffice. > > An overview of the integrated release issues can be found under: > > http://people.apache.org/~jsc/milestones/4.1.0-rc/AOO4.1.0_RC_fixes.html > > The release candidate artifacts (1) (source release, as well as binary > releases for 38 languages) and further information how to verify and > review Apache OpenOffice 4.1.0 can be found on the following wiki page: > > > https://cwiki.apache.org/confluence/display/OOOUSERS/Development+Snapshot+Builds > > The RC is based on the release branch AOO410, revision 1583666! And a > fresh and clean RAT scan output of this revision can be found under > > http://people.apache.org/~jsc/milestones/4.1.0-rc/AOO4.1.0_RAT_Scan.html > > Please vote on releasing this package as Apache OpenOffice 4.1.0 > > The vote starts now and will be open until: > >Sunday evening, 6 April: 2014-04-06 11:00pm UTC. > > But we invite all people to vote (non binding) on this RC. We would like > to provide a release that is supported by the majority of our project > members. > >[ ] +1 Release this package as Apache OpenOffice 4.1.0 >[ ] 0 Don't care >[ ] -1 Do not release this package because... > > > > (1) the upload for the Linux 32 bit artifacts is still ongoing, but 64 > bit is already available. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: キ�`入力について
He said after he installed AOO, he cannot input Japanese. I'm not sure did he mean cannot input in AOO or other application. I can input Japanese in AOO at least, then told him my method. Don't know whether I understand him correctly 2014-02-28 23:41 GMT+08:00 jan i : > Please this an english speaking list, at least anybody who replies should > supply a translation in english. > > > rgds > jan I. > > > > 2014-02-28 16:37 GMT+01:00 Clarence GUO : > > > Open Officeの中に、日本�Z入力ができなくなって、そういう意味ですか？ > > �Wのほうは、日本�Z入力できる。方法は、Windows言�~バ�`で、日本�Zを�xぶんで、[ALT]と[`]キイ一�wに押下、そして日本�Z入力できる。 > > > > > > 2014-02-28 14:07 GMT+08:00 te.y...@gmail.com : > > > > > Open officeをインスト�`ルしたら日本�Z入力ができなくなってしまいました。 > > > 解�Q方法を教えてください。 > > > > > >
Re: キ�`入力について
Open Officeの中に、日本�Z入力ができなくなって、そういう意味ですか？ �Wのほうは、日本�Z入力できる。方法は、Windows言�~バ�`で、日本�Zを�xぶんで、[ALT]と[`]キイ一�wに押下、そして日本�Z入力できる。 2014-02-28 14:07 GMT+08:00 te.y...@gmail.com : > Open officeをインスト�`ルしたら日本�Z入力ができなくなってしまいました。 > 解�Q方法を教えてください。 >
First part of OOXML export code was committed to branch
Hi~ I committed the first part of OOXML export code to https://svn.apache.org/repos/asf/openoffice/branches/ooxml I also posted a wiki about OOXML export framework to https://cwiki.apache.org/confluence/display/OOOUSERS/OOXML+Export+Framework Status updated to https://cwiki.apache.org/confluence/display/OOOUSERS/OOXML+Export+Status, and first part of testing samples were attached to the wiki. There is an issue I'd like to highlight here is, although now with the framework, PPTX can be exported, but only a very fundamental structure was exported so that MS Office 2010 cannot open it. Some folders like master pages, themes of a PPTX don't exist in the exported file. As I will still work on spreadsheet and document, another developer Shao Zhi is working on shape export, we two have no effort on presentation at least in the following 3-4 months, in order to speed up the work, I'd like to know if any volunteer has interest in this field. Thanks & BRs Clarence
Re: wiki of OOXML export status
Kay, The status was updated. I will update this wiki weekly or biweekly. Thanks & BRs Clarence 2014-02-17 2:19 GMT+08:00 Kay Schenk : > On Sat, Feb 15, 2014 at 5:50 PM, Clarence GUO >wrote: > > > Hi, > > I posted a wiki about OOXML export status to > > https://cwiki.apache.org/confluence/display/OOOUSERS/OOXML+Export+Status > . > > Now all the works are still on my local, hasn't not been committed yet. > > I'll commit when fixed current problems and the framework of three > > applications are ready. > > > > Thanks & BRs, > > Clarence > > > > Thanks for the update! As soon as cwiki is back up, we can all have a look! > > > -- > > - > MzK > > "Cats do not have to be shown how to have a good time, > for they are unfailing ingenious in that respect." >-- James Mason >
Re: New committer: Clarence Guo (clarence_guo)
Thank you all. Wish to have more contributions to this project. Clarence 2014-02-16 1:24 GMT+08:00 Kay Schenk : > > On 02/14/2014 01:42 PM, Rob Weir wrote: > >> The Project Management Committee (PMC) for Apache OpenOffice has asked >> Clarence Guo to become a committer and we are pleased to announce that >> he has accepted and taken the ID "clarence_guo". >> >> A warm welcome to Clarence! >> >> Regards, >> >> Rob, on behalf of the Apache OpenOffice PMC >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> Welcome Clarence! > > -- > - > MzK > > "Cats do not have to be shown how to have a good time, > for they are unfailing ingenious in that respect." >-- James Mason > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: [CWiki] Account Whitelisting
Thanks Andrea, Now my first wiki was posted ' https://cwiki.apache.org/confluence/display/OOOUSERS/OOXML+Export+Status' Thanks Clarence 2014-02-14 21:19 GMT+08:00 Andrea Pescetti : > Clarence GUO wrote: > >> I created an account in cwiki because I want to share some project >> information in wiki. My account name is 'clarence.guo.bj'. Seems I have >> to >> send out a mail to activate my account so that I can create a wiki. >> > > Done. Account whitelisted, you can now edit/create pages. > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
wiki of OOXML export status
Hi, I posted a wiki about OOXML export status to https://cwiki.apache.org/confluence/display/OOOUSERS/OOXML+Export+Status. Now all the works are still on my local, hasn't not been committed yet. I'll commit when fixed current problems and the framework of three applications are ready. Thanks & BRs, Clarence
[CWiki] Account Whitelisting
Hi~ I created an account in cwiki because I want to share some project information in wiki. My account name is 'clarence.guo.bj'. Seems I have to send out a mail to activate my account so that I can create a wiki. Currently I cannot find 'create' button at the top tool bar area of cwiki page. Could anybody help me? Thanks & BRs, Clarence
Re: crash p1 bug, data loss - openoffice
Although I haven't reproduce the problem on my AOO4.1 against three applications, I find another problem with the same scenario for writer. Do same with Sam's reproduce steps against writer, in the last step, delete a column beneath that merged row, the whole table was deleted. 2014-01-27 Liu Ping > Hi,Sam > > I try to reproduce your issue on AOO4.1 and AOO4.0 (AOO400m3(Build:9702) > - Rev. 1503704)presentation and writer on Windows7 ，but fail to reproduce > Can you provide which product : presentation or writer , AOO4.0.0 version > build information ,which will be helpful for us to reproduce your issue > > Thanks > > > > On Sat, Jan 25, 2014 at 5:58 PM, Marcus (OOo) > wrote: > > > Am 01/25/2014 04:45 AM, schrieb Sam Jennings: > > > > > >> I have uncovered a bug in openoffice on windows 7, 64 pro > >> Openoffice 4.0.0 > >> > >> To reproduce this bug, make a table with 3 rows and 3 columns (maybe > >> other numbers would work as well) > >> > >> now merge the top row's cells > >> now select a column beneath that merged row, and delete it. > >> > >> that should crash openoffice and lose all your data. > >> > >> workaround? nothing fast. > >> > >> sorry, it's easier to mail your dev than painstakingly drudge your > >> website for the bug database and try to get past whatever prescreening > it > >> undoubtedly has. but great free software guys...but please fix that! > it's > >> a priorty 1...crash& data loss. > >> > > > > Thanks for telling us the problem. However, it's better suited in our > > bugtracker. So, please report it here: > > > > https://issues.apache.org/ooo/ > > > > Thanks > > > > Marcus > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > > For additional commands, e-mail: dev-h...@openoffice.apache.org > > > > >
Re: Contribute code for OOXML export
Hi~ Jan, Thanks Jan for your help. I'll work on this branch. About my patches, I picked some, see 123909, 123910, 123816, 122927... Clarence 2014-01-24 jan i > On 24 January 2014 08:14, Clarence GUO wrote: > > > As although I contributed 10+ changes, I'm not committer yet, could > anybody > > help me to create a branch? > > Thanks, > > > > https://svn.apache.org/repos/asf/openoffice/branches/ooxml created. Happy > programming. > > just write here on the list, whenever you want a merge from trunk. > > I cannot comment on how many changes is needed to become a committer, but I > must admit I have not seen your patches on this list ? > > rgds > jan I. > > > > Clarence > > > > > > 2014/1/23 Andrea Pescetti > > > > > On 22/01/2014 Clarence GUO wrote: > > > > > >> We have some pilot code for enabling OOXML export, developed > > >> by De Bin, Jian Yuan, Sun Ying, Jin Long... Although it still has some > > >> ways > > >> to go before ready for production, we'd like to contribute it first to > > AOO > > >> > > > > > > Very good news! Even if ODF remains the native and preferred format, > > users > > > regularly asked for better OOXML interoperability. I agree this should > > stay > > > in a branch and not integrated/released until it reaches the quality > > users > > > expect from OpenOffice. > > > > > > Regards, > > > Andrea. > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > > > For additional commands, e-mail: dev-h...@openoffice.apache.org > > > > > > > > >
Re: Contribute code for OOXML export
As although I contributed 10+ changes, I'm not committer yet, could anybody help me to create a branch? Thanks, Clarence 2014/1/23 Andrea Pescetti > On 22/01/2014 Clarence GUO wrote: > >> We have some pilot code for enabling OOXML export, developed >> by De Bin, Jian Yuan, Sun Ying, Jin Long... Although it still has some >> ways >> to go before ready for production, we'd like to contribute it first to AOO >> > > Very good news! Even if ODF remains the native and preferred format, users > regularly asked for better OOXML interoperability. I agree this should stay > in a branch and not integrated/released until it reaches the quality users > expect from OpenOffice. > > Regards, > Andrea. > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Contribute code for OOXML export
Hi~ All, Since Office 2007 Microsoft has defaulted to saving files in OOXML format. And soon, in April, Microsoft will stop supporting Office 2003, the last version of Office to write the binary format by default. So it becomes more and more important for AOO to have capability to support OOXML file format in order to help these users who need to work with OOXML files. AOO already has some capabilities for OOXML file import, but it needs many improvements. We have some pilot code for enabling OOXML export, developed by De Bin, Jian Yuan, Sun Ying, Jin Long... Although it still has some ways to go before ready for production, we'd like to contribute it first to AOO for further development so that more developers can work on the framework and continuously contribute their works. Since it still has many feature gaps, we propose to put it on a branch firstly, and continue to enhance it, and integrate it into a release only when we see it ready. Clarence
Re: [Call for review]123515 - Import the sample PPTX(with one slide) to AOO, the shape in slide is applied a default color incorrectly ( should be transparent)
Armin, Seems this fill value is only for PPT, in Excel 2010 and Word 2010, I haven't seen this choice in fill type. Clarence 2013/10/25 Armin Le Grand > Hi Clarence, > > > On 25.10.2013 03:25, Clarence GUO wrote: > >> So Armin, as you said "We have currently no internal concept to do >> something like that, and no support neither in ODF nor in the UNO API nor >> in the core." and "with 'none' is better than to fill with solid color, >> but >> will destroy all that 'hole' effects.", do you think it is acceptable if >> we >> temporarily map it to 'no-fill" as a fix and waiting for ODF, UNO API, >> core >> can all support it then do a fully support? >> > > Exactly; that's what I would do for now. > > Also we would need to discuss about what we will need to make that work in > a future version. To decide that, we need mor knowledge about: > - How to do in core > - How to do in API > - How in ODF > > To decide that it would be useful if you would try to find out what is > done in the MS formats to save/load it; to know this will be essential to > be able to im/export this. Is it a special FillType? Is it just a flag > somewhere at the object overriding FillType? Stuff like that. > > Without knowing this I see that this is just a bollean on an object; this > could be a new value for API and ODF or a 6th value for FillType. 2nd > approach may be problematic; if e.g. the FillType in the API is an enum it > will not be expendable in a compatible way. Also in ODF all installed > AOO/OOO's out there will not know what to do when stumbling over an unknown > FillType. Thus, maybe just a new flag 'BackgroundFill = true/false' may be > more safe. > That again has to be added not only to the shape, but to the attributes > and styles of AOO. > > BTW: Is this a Draw/Impress only feature request or exists something > similar for Writer/Calc...? > > >> Sincerely >> Clarence >> >> >> 2013/10/24 Armin Le Grand >> >> Hi Clarence, >>> >>> >>> On 24.10.2013 11:00, Clarence GUO wrote: >>> >>> I read ODF 1.2 standard, and found for draw:fill it only defined 5 >>>> values: >>>> none, solid, gradient, hatch, bitmap. There is not a value for >>>> usebackgroundfill. So seems if we want to fully support this attribute, >>>> we >>>> must change ODF standard first. >>>> And finally I found the difference between "no fill" and "use slide >>>> background fill". If the shape is inside the slide area, there's no >>>> difference. But once move the shape outside of the slide area, if >>>> applied >>>> "use slide background fill", the shape can still fill the background >>>> from >>>> the slide just as it increase the size of canvas; but for shapes applied >>>> "no fill", the background will become empty. >>>> >>>> There will be more differences when objects overlap. This is indeed the >>> only useful usage of that FillType in MS; it allows to create the >>> impresson >>> of 'holes' in any objects by forcing the page background to be painted at >>> that place. Thus, replacing with 'none' is better than to fill with solid >>> color, but will destroy all that 'hole' effects. >>> We have currently no internal concept to do something like that, and no >>> support neither in ODF nor in the UNO API nor in the core. >>> >>> Sincerely, >>> Armin >>> >>> >>> >>> 2013/10/24 Steve Yin >>>> >>>> Hi Clarence, >>>> >>>>> After checking the feature in MSO and comparing with your patch, I >>>>> found >>>>> that the "fill with background" cannot simply map to "no fill". Is >>>>> there >>>>> a >>>>> way to implement a real "fill with background" feature in AOO? Thanks. >>>>> >>>>> >>>>> On Thu, Oct 24, 2013 at 4:16 PM, Clarence GUO < >>>>> clarence.guo...@gmail.com >>>>> >>>>> wrote: >>>>>> Hi~ >>>>>> I submitted a path for 123515 >>>>>> https://issues.apache.org/ooo/show_bug.cgi?id=123515<https://issues.apache.org/ooo/**show_bug.cgi?id=123515> >>>>>> https://issues.apache.org/ooo/show_bug.cgi?id=123515> >>>>>> > >>>>>> >>>>>> . >>>>>> Root cause analysis and solution description please see my comment in >>>>>> >>>>>> above >>>>> >>>>> URL >>>>>> Please help to review. >>>>>> Thanks >>>>>> >>>>>> Clarence >>>>>> >>>>>> >>>>>> -- >>>>> Best Regards, >>>>> >>>>> Steve Yin >>>>> >>>>> >>>>> --** >>> --**- >>> To unsubscribe, e-mail: >>> dev-unsubscribe@openoffice.**a**pache.org<http://apache.org> >>> >>> > >>> >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >>> >>> > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: [Call for review]123515 - Import the sample PPTX(with one slide) to AOO, the shape in slide is applied a default color incorrectly ( should be transparent)
So Armin, as you said "We have currently no internal concept to do something like that, and no support neither in ODF nor in the UNO API nor in the core." and "with 'none' is better than to fill with solid color, but will destroy all that 'hole' effects.", do you think it is acceptable if we temporarily map it to 'no-fill" as a fix and waiting for ODF, UNO API, core can all support it then do a fully support? Sincerely Clarence 2013/10/24 Armin Le Grand > Hi Clarence, > > > On 24.10.2013 11:00, Clarence GUO wrote: > >> I read ODF 1.2 standard, and found for draw:fill it only defined 5 values: >> none, solid, gradient, hatch, bitmap. There is not a value for >> usebackgroundfill. So seems if we want to fully support this attribute, we >> must change ODF standard first. >> And finally I found the difference between "no fill" and "use slide >> background fill". If the shape is inside the slide area, there's no >> difference. But once move the shape outside of the slide area, if applied >> "use slide background fill", the shape can still fill the background from >> the slide just as it increase the size of canvas; but for shapes applied >> "no fill", the background will become empty. >> > > There will be more differences when objects overlap. This is indeed the > only useful usage of that FillType in MS; it allows to create the impresson > of 'holes' in any objects by forcing the page background to be painted at > that place. Thus, replacing with 'none' is better than to fill with solid > color, but will destroy all that 'hole' effects. > We have currently no internal concept to do something like that, and no > support neither in ODF nor in the UNO API nor in the core. > > Sincerely, > Armin > > > >> >> 2013/10/24 Steve Yin >> >> Hi Clarence, >>> >>> After checking the feature in MSO and comparing with your patch, I found >>> that the "fill with background" cannot simply map to "no fill". Is there >>> a >>> way to implement a real "fill with background" feature in AOO? Thanks. >>> >>> >>> On Thu, Oct 24, 2013 at 4:16 PM, Clarence GUO >> >>>> wrote: >>>> Hi~ >>>> I submitted a path for 123515 >>>> https://issues.apache.org/ooo/**show_bug.cgi?id=123515<https://issues.apache.org/ooo/show_bug.cgi?id=123515> >>>> . >>>> Root cause analysis and solution description please see my comment in >>>> >>> above >>> >>>> URL >>>> Please help to review. >>>> Thanks >>>> >>>> Clarence >>>> >>>> >>> >>> -- >>> Best Regards, >>> >>> Steve Yin >>> >>> > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: [Call for review]123515 - Import the sample PPTX(with one slide) to AOO, the shape in slide is applied a default color incorrectly ( should be transparent)
I read ODF 1.2 standard, and found for draw:fill it only defined 5 values: none, solid, gradient, hatch, bitmap. There is not a value for usebackgroundfill. So seems if we want to fully support this attribute, we must change ODF standard first. And finally I found the difference between "no fill" and "use slide background fill". If the shape is inside the slide area, there's no difference. But once move the shape outside of the slide area, if applied "use slide background fill", the shape can still fill the background from the slide just as it increase the size of canvas; but for shapes applied "no fill", the background will become empty. 2013/10/24 Steve Yin > Hi Clarence, > > After checking the feature in MSO and comparing with your patch, I found > that the "fill with background" cannot simply map to "no fill". Is there a > way to implement a real "fill with background" feature in AOO? Thanks. > > > On Thu, Oct 24, 2013 at 4:16 PM, Clarence GUO >wrote: > > > Hi~ > > I submitted a path for 123515 > > https://issues.apache.org/ooo/show_bug.cgi?id=123515. > > Root cause analysis and solution description please see my comment in > above > > URL > > Please help to review. > > Thanks > > > > Clarence > > > > > > -- > Best Regards, > > Steve Yin >
[Call for review]123515 - Import the sample PPTX(with one slide) to AOO, the shape in slide is applied a default color incorrectly ( should be transparent)
Hi~ I submitted a path for 123515 https://issues.apache.org/ooo/show_bug.cgi?id=123515. Root cause analysis and solution description please see my comment in above URL Please help to review. Thanks Clarence
Re: config error on Windows 7
Thanks Oliver, I reference this wiki ( http://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO/Step_by_step#Windows_7) for build, seems no much difference with yours. My configure is ./configure --with-cl-home="/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 9.0/VC" --with-mspdb-path="/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 9.0/Common7/IDE" --with-asm-home="/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 9.0/Bin" --with-csc-path="/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 9.0/SDK/v3.5" --with-frame-home="/cygdrive/c/Program Files/Microsoft SDKs/Windows/v6.1" --with-psdk-home="/cygdrive/c/Program Files/Microsoft SDKs/Windows/v6.1" --with-midl-path="/cygdrive/c/Program Files/Microsoft SDKs/Windows/v6.1/bin" --with-directx-home="C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)" --with-jdk-home="/cygdrive/d/jdk1.7.0_21" --with-ant-home="/cygdrive/d/apache-ant-1.8.4" --with-dmake-url=" http://dmake.apache-extras.org.codespot.com/files/dmake-4.12.tar.bz2"; --with-epm-url="http://www.msweet.org/files/project2/epm-3.7-source.tar.gz"; --enable-pch --disable-atl --disable-activex --disable-binfilter --without-junit Clarence 2013/9/17 Oliver-Rainer Wittmann > Hi Clarence, > > > On 13.09.2013 10:48, Clarence GUO wrote: > >> Hi~ >> When I set up build ENV on Window7, I met a error when configure, what >> does >> it mean? >> >> Can't find MS Visual Studio / VC++ at ./oowintool line 236. >> configure: error: oowintool failed to copy CRT >> >> Cannot find VC. But I already saw configure said "checking the Microsoft >> C/C++ Compiler... found " >> >> > Please, provide your complete 'configure' call. > Then I will be able to help you. > > BTW, did you follow the AOO Windows Building guide in our wiki [1] and [2] > to setup your environment? > > [1] > http://wiki.openoffice.org/**wiki/Documentation/Building_**Guide_AOO<http://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO> > [2] http://wiki.openoffice.org/**wiki/Documentation/Building_** > Guide_AOO/Building_on_Windows<http://wiki.openoffice.org/wiki/Documentation/Building_Guide_AOO/Building_on_Windows> > > > Best regards, Oliver. > > Thanks, >> Clarence >> >> > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: config error on Windows 7
John, Thanks for your information, I tried these two methods but they both don't work at my side. I'll check if there is some environment problem on my machine. Thanks & BRs Clarence 2013/9/16 John O'Sullivan > Clarence, > > The configure script uses flags and env vars to discover the root dir for > the VC install, which is why it's reporting it as found. ./oowintool is > relying on you path being set to pick up cl.exe. You can fix that by > changing your path in Control Panel/System/Environment Variables, or by > running vcvars32.bat from the VC dir tree before you launch the configure > script. > > Cheers > John > > > On Fri, Sep 13, 2013 at 9:48 AM, Clarence GUO >wrote: > > > Hi~ > > When I set up build ENV on Window7, I met a error when configure, what > does > > it mean? > > > > Can't find MS Visual Studio / VC++ at ./oowintool line 236. > > configure: error: oowintool failed to copy CRT > > > > Cannot find VC. But I already saw configure said "checking the Microsoft > > C/C++ Compiler... found " > > > > Thanks, > > Clarence > > >
config error on Windows 7
Hi~ When I set up build ENV on Window7, I met a error when configure, what does it mean? Can't find MS Visual Studio / VC++ at ./oowintool line 236. configure: error: oowintool failed to copy CRT Cannot find VC. But I already saw configure said "checking the Microsoft C/C++ Compiler... found " Thanks, Clarence
Re: [Request for review] - Solution for 122927 - =IF(AK3=" ";0;IF(AK3="Y";195;IF(AK3="N";125))) produces FALSE instead of $0.00
Regina, Sorry for my pen mistake, all statement of 12666 in my previous comment should be 121126. I also corrected it in the issue. About formula "=2>1", it is from the sample XLS in 121126. Once I rolled back fix code of 121126, I found it returned 1.0. I tested formula with "=2>1" which applied currency number format, it works. Thanks for you reminder, I will add checking "if (&rFormatter==NULL)" Clarence 2013/9/9 Regina Henschel > Hi Clarence, > > I do not understand some part of the description. Questions inline. > > Clarence GUO schrieb: > > Hi~ >> I'm working on >> https://issues.apache.org/ooo/**show_bug.cgi?id=122927<https://issues.apache.org/ooo/show_bug.cgi?id=122927> >> I delivered patch to the issue, please help to review. >> >> Root Cause: >> In 121126, although in description it only mentioned format code issue, >> actually the fix is not only for format code but also for output string >> for >> logic formula cell. The second one introduced this issue. >> I think the change for output string change for logic formulas is >> reasonable because before 12666 >> > > 12666 ? > > > , from 12666's sample file, a cell with > >> formula "=2>1" will return 1.0.It is very strange. It should return >> "TRUE" >> >> like that in MS Excel. >> > > In all my OOo versions (from 1.1.5 over 2.4.3 to 3.41 and AOO4.0) =2>1 > returns TRUE. In which version do you see result 1.0 ? > > > So my fix will based on 12666. The root cause is for logic formula cells, >> fix code of 12666 forcibly set output string to true or false. But many >> AOO >> users had manner already that set number format to logic formula cells. >> That's different with Excel. In Excel, no matter what number format you >> set >> to logic formula cells, the output strings are always true and false. >> In the sample of this issue, users set number format to currency, because >> of the forcibly setting, the string changed. >> >> Solution >> My solution is to add checking for logic formula cells, if their output >> number formats are certain category like number, currency, date, time, >> etc, >> we will not change the output string. but if no certain format categories >> were applied, for logic formula cells, will change output string to true >> and false. >> >> > I have applied your patch and build the source. The resulting AOO still > shows the error, that FALSE and TRUE cannot be formatted to currency. The > formatting to other number formats works. The error happens with IF with 1 > or 2 parameters and with simple comparisons as well. > > But it was not a clean build. I will try it with a clean build, but that > needs half a day on my PC. > > Your patch comes with DOS line ends to me. That might be a problem with my > browser. But it would be nice, if you verify, that your patch has UNIX line > ends. > > Kind regards > Regina > > > > > > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
[Request for review] - Solution for 122927 - =IF(AK3=" ";0;IF(AK3="Y";195;IF(AK3="N";125))) produces FALSE instead of $0.00
Hi~ I'm working on https://issues.apache.org/ooo/show_bug.cgi?id=122927 I delivered patch to the issue, please help to review. Root Cause: In 121126, although in description it only mentioned format code issue, actually the fix is not only for format code but also for output string for logic formula cell. The second one introduced this issue. I think the change for output string change for logic formulas is reasonable because before 12666, from 12666's sample file, a cell with formula "=2>1" will return 1.0. It is very strange. It should return "TRUE" like that in MS Excel. So my fix will based on 12666. The root cause is for logic formula cells, fix code of 12666 forcibly set output string to true or false. But many AOO users had manner already that set number format to logic formula cells. That's different with Excel. In Excel, no matter what number format you set to logic formula cells, the output strings are always true and false. In the sample of this issue, users set number format to currency, because of the forcibly setting, the string changed. Solution My solution is to add checking for logic formula cells, if their output number formats are certain category like number, currency, date, time, etc, we will not change the output string. but if no certain format categories were applied, for logic formula cells, will change output string to true and false.
Re: A question about StarBasic
Juergen,
Yes SAPGUI is not an AOO default object, it should be a SAP COMM object. Do
you mean OpenOffice Basic doesn't support non-default objects? If so, what
are the OpenOffice Basic default objects?
Clarence
2013/9/2 Jürgen Schmidt
> On 9/2/13 11:09 AM, Clarence GUO wrote:
> > Thanks Peter,
> > Yes Set SapGuiAuto = CreateObject("Excel.Sheet") works.
> > Why "SAPGUI" must be an ActiveXObject? Is it by design?
> >
>
> whatever it is in detail it is not part of AOO by default and probably
> comes from somewhere else.
>
> Juergen
>
>
> > Clarence
> >
> >
> > 2013/9/2 Peter Eberlein
> >
> >>
> >> Hi Clarence,
> >> Am 02.09.2013 08:47, schrieb Clarence GUO:
> >>
> >> Hi~
> >>> I'm totally green at StarBasic and VBA. Now I have a question about
> >>> CreateObject. I installed SAP and have below macros.
> >>>
> >>> Dim SapGuiAuto As Variant
> >>> Set SapGuiAuto = CreateObject("SAPGUI")
> >>>
> >>> "SAPGUI" must be an ActiveXObject.
> >>
> >> Does Set SapGuiAuto = CreateObject("Excel.Sheet") work?
> >>
> >> Regards Peter
> >>
> >>
> >>
> --**--**-
> >> To unsubscribe, e-mail: dev-unsubscribe@openoffice.**apache.org<
> dev-unsubscr...@openoffice.apache.org>
> >> For additional commands, e-mail: dev-h...@openoffice.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
>
Re: A question about StarBasic
Thanks Peter,
Yes Set SapGuiAuto = CreateObject("Excel.Sheet") works.
Why "SAPGUI" must be an ActiveXObject? Is it by design?
Clarence
2013/9/2 Peter Eberlein
>
> Hi Clarence,
> Am 02.09.2013 08:47, schrieb Clarence GUO:
>
> Hi~
>> I'm totally green at StarBasic and VBA. Now I have a question about
>> CreateObject. I installed SAP and have below macros.
>>
>> Dim SapGuiAuto As Variant
>> Set SapGuiAuto = CreateObject("SAPGUI")
>>
>> "SAPGUI" must be an ActiveXObject.
>
> Does Set SapGuiAuto = CreateObject("Excel.Sheet") work?
>
> Regards Peter
>
>
> --**--**-
> To unsubscribe, e-mail:
> dev-unsubscribe@openoffice.**apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
>
A question about StarBasic
Hi~
I'm totally green at StarBasic and VBA. Now I have a question about
CreateObject. I installed SAP and have below macros.
Dim SapGuiAuto As Variant
Set SapGuiAuto = CreateObject("SAPGUI")
But I got error "BASIC runtime error. '91' Module cannot be loaded; invalid
format" when executing CreateObject("SAPGUI")
Then I debugged code then found all SbxFactory instances creation failed. I
found below SbxFactory instances but don't know clearly what are they.
SbiFactory, seems it's for create pure StarBasic objects
SbTypeFactory, seems it's for create user defined objects
SbClassFactory, seems it's for create user defined classes
SbOLEFactory, seems it's for create OLE objects
SbFormFactory, is it for create form controls?
SbUnoFactory, seems it's for create UNO structs
In my scenario, which instance should work? Is that SbTypeFactory or
SbClassFactory? But why they don't work? Is that because StarBasic only
support some predefined objects? Or I lost something? How can I enable the
support for SAP objects?
Could anybody teach me?
Thanks
Clarence
A finding and a further question about 122840
HI~ I have a finding on 122840 and have a code can fix it. But I have a further question about technique detail on this issue. Don't know if anybody is familiar with. In 120478, zhaoshzh added support for scope of name range. MS Excel can define a same name to a range on different sheets. For example defines "MyRange" to "Sheet1.A1:A4" with scope in sheet1 and defines "MyRange" again to "Sheet2.A1:A4" with scope in sheet2. In order to add this support, he changed code in ScXMLImport::SetNamedRanges(), from xNamedRanges->addNewByName((*aItr)->sName, sTempContent, aCellAddress, GetRangeType((*aItr)->sRangeType)); to xNamedRanges->addNewByScopeName( sTabName, (*aItr)->sName, (*aItr)->sContent, aCellAddress, GetRangeType((*aItr)->sRangeType) ); addNewByScopeName is a new method, the difference with addNewByName is it added a new parameter sTabName in order to distinguish the scope. Others are same. But note he also changed the third parameter of the new method. In the old method, that parameter is sTempContent, it is string "0". However, in the new method he passed (*aItr)->sContent into, (*aItr)->sContent is the real content of the name. For example, for above illustration, "Sheet1.A1:A4" is the content of range name "MyRange". I'm not sure whether it is his pen mistake, but from logic, as he only add a new parameter for scope identification, the old parameters should not be changed. So I just change (*aItr)->sContent back to sTempContent, then it works. And there's no problem on 120478 sample file with the fix. I did some test, haven't find problem. But I don't know why we need to pass a "0" string as content into the method. Why not the real content? Does anybody know that? Thanks Clarence
Re: review requested: [Bug 122822] Correct viewing of XY-, Column- and Line-Charts limited to 10000 records + 1 Heading row : [Attachment 81367] Fix patch
Yes, Regina, Thank you for your suggestion. I agree with your suggestion on automatic adjust step. Thanks & BRs, Clarence 2013/8/22 Regina Henschel > Hi Clarence, > > my basis build has just finished and I need a little bit time to apply > your patch and test it. But a suggestion beforehand: You use > > sal_Int32 nStep = nEndIndex >= 2 ? 10 : 1; > > which produces a fix percent of dropped data points, e.g. from 24000 only > 2400 would be kept. Wouldn't it be better, to make this dependent on the > amount of data points? > > Something like > > sal_Int32 nStep = nEndIndex / 2 +1; > > ? > > Kind regards > Regina > > bugzi...@apache.org schrieb: > > Clarence GUO has asked for review: >> Bug 122822: Correct viewing of XY-, Column- and Line-Charts limited to >> 1 >> records + 1 Heading row >> https://issues.apache.org/ooo/**show_bug.cgi?id=122822<https://issues.apache.org/ooo/show_bug.cgi?id=122822> >> >> Attachment 81367: Fix patch >> https://issues.apache.org/ooo/**attachment.cgi?id=81367&**action=edit<https://issues.apache.org/ooo/attachment.cgi?id=81367&action=edit> >> >> >> --- Additional Comments from Clarence GUO >> The earlier fix patch has a problem. It cannot fix the problem of hover >> tip >> which is mentioned by Regina Henschel. >> It will always get drawing shape's name for hover tip. But drawing >> shape's name >> comes from the index when rendering these shapes. So if pick data points >> before >> rendering, the index will be always from 1 to the number it picked out. >> In order to solve this problem, picking must at view side, say rendering. >> As each chart type has it's own rendering, my fix is only in >> AreaChart.cxx. >> Area, line, XY and Radar chart share one implementation in this file. I >> tested >> sample file of 121058, it's a line chart, convert it to area, XY, radar >> charts, >> there are all performance problem. So my fix is only for these chart >> types. If >> there are performance problem for other chart types who have huge data, >> then it >> should be fixed separatedly. >> >> --**--**- >> To unsubscribe, e-mail: >> dev-unsubscribe@openoffice.**apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> >> > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: review requested: [Bug 122822] Correct viewing of XY-, Column- and Line-Charts limited to 10000 records + 1 Heading row : [Attachment 81359] Fix patch
Hi~ Regina, Sorry I misunderstood your comment in the defect about data label. You meant hover tip data label but I thought you meant data label on X axis. My old fix cannot solve the problem of hover tip. Seems we can only fix it at view side. So I changed my resolution to fix at view side, but it's only for specific chart types. Please get more details in the defect. Thanks, Clarence 2013/8/21 Clarence GUO > Hi~ Regina, > I understand your suggestion. But I think it has a limitation. We can > implement drawing shapes in each individual chart type. But drawing data > lables on X axis is common, not belongs to drawing shapes in chart type. So > when drawing axis, it doesn't know how did the implementation of draw data > points in one chart type, it can only draw from begining point in order. > About your question about Excel import, you mentioned delete the original > chart in Excel, then create a new one in AOO, it works. Did you use AOO4.0? > Then fix code of 121058 is already there, so it works. > About another question, my fix is only for spreadsheet. Yes, I only fixed > for spreadsheet because charts with too many data are mainly in > spreadsheet. It's hard to create chart with so many points in presentation > and word processor because they are using internal provider. Maybe we can > fix internal provider in a separate defect. > > Clarence > > > 2013/8/20 Regina Henschel > >> Hi Clarence, >> >> Clarence GUO schrieb: >> >> Hi~ Regina, >>> Do you mean the change should at view side? >>> >> >> Yes. >> >> >> But each chart type has it's >> >>> own implementation of view. >>> >> >> And each chart has its own performance problems. Drawing an XY-chart with >> only points might work, but showing data point labels will fail. Drawing a >> line in 2D might be fine, but drawing the same line in 3D will fail. >> Drawing only points might work, but drawing a regression line or smoothed >> curve in addition might fail. >> >> >> So if we want to change at view side, we have >> >>> to change code in each implementation. That code looks not very >>> effective. >>> My change doesn't change model because the data source range can be kept. >>> >> >> But is solves only Calc as data provider. >> >> Changing the view would also not change data source range but only the >> amount of generated shapes. >> >> Another problem is, that there must be something additional in Excel >> import, because using ods works with the same amount of data. Delete the >> chart in Excel, open the file in AOO and then make a new chart. It is slow, >> but works. >> >> Solving it inside chart has the opportunity to bring the threshold to UI, >> as suggested in comment 23. >> >> >> It only picked some points from model to prepare viewing for drawing >>> performance consideration. >>> >> >> But I'm not an expert here and you should wait, what our experienced >> developers think. >> >> A nitpick: the step should not be fix but depend on the amount of data >> relative to a threshold. >> >> Kind regards >> Regina >> >> >> 2013/8/20 Regina Henschel >>> >>> Hi, >>>> >>>> I think, that it is the wrong place for a correction. A chart is a >>>> document and the chart itself should take care, that it draws its data >>>> series in a reasonable time. >>>> >>>> Kind regards >>>> Regina >>>> >>>> bugzi...@apache.org schrieb: >>>> >>>> Clarence GUO has asked for review: >>>> >>>>> Bug 122822: Correct viewing of XY-, Column- and Line-Charts limited to >>>>> 1 >>>>> records + 1 Heading row >>>>> https://issues.apache.org/ooo/show_bug.cgi?id=122822<https://issues.apache.org/ooo/**show_bug.cgi?id=122822> >>>>> https://issues.apache.org/ooo/show_bug.cgi?id=122822> >>>>> > >>>>> >>>>> Attachment 81359: Fix patch >>>>> https://issues.apache.org/ooo/attachment.cgi?id=81359& >>>>> action=edit<https://issues.apache.org/ooo/**attachment.cgi?id=81359&**action=edit> >>>>> <https://issues.**apache.org/ooo/attachment.cgi?**id=81359&action=edit<https://issues.apache.org/ooo/attachment.cgi?id=81359&action=edit> >>>>> > >>>>> >>>>> >>>>> >>>>>
[Call-for-Review] issue 122827 - calc slow saving in xls
Hi~ I uploaded my fix patch of 122827, Please review. https://issues.apache.org/ooo/show_bug.cgi?id=122827 Thanks Clarence
Re: review requested: [Bug 122822] Correct viewing of XY-, Column- and Line-Charts limited to 10000 records + 1 Heading row : [Attachment 81359] Fix patch
Hi~ Regina, I understand your suggestion. But I think it has a limitation. We can implement drawing shapes in each individual chart type. But drawing data lables on X axis is common, not belongs to drawing shapes in chart type. So when drawing axis, it doesn't know how did the implementation of draw data points in one chart type, it can only draw from begining point in order. About your question about Excel import, you mentioned delete the original chart in Excel, then create a new one in AOO, it works. Did you use AOO4.0? Then fix code of 121058 is already there, so it works. About another question, my fix is only for spreadsheet. Yes, I only fixed for spreadsheet because charts with too many data are mainly in spreadsheet. It's hard to create chart with so many points in presentation and word processor because they are using internal provider. Maybe we can fix internal provider in a separate defect. Clarence 2013/8/20 Regina Henschel > Hi Clarence, > > Clarence GUO schrieb: > > Hi~ Regina, >> Do you mean the change should at view side? >> > > Yes. > > > But each chart type has it's > >> own implementation of view. >> > > And each chart has its own performance problems. Drawing an XY-chart with > only points might work, but showing data point labels will fail. Drawing a > line in 2D might be fine, but drawing the same line in 3D will fail. > Drawing only points might work, but drawing a regression line or smoothed > curve in addition might fail. > > > So if we want to change at view side, we have > >> to change code in each implementation. That code looks not very effective. >> My change doesn't change model because the data source range can be kept. >> > > But is solves only Calc as data provider. > > Changing the view would also not change data source range but only the > amount of generated shapes. > > Another problem is, that there must be something additional in Excel > import, because using ods works with the same amount of data. Delete the > chart in Excel, open the file in AOO and then make a new chart. It is slow, > but works. > > Solving it inside chart has the opportunity to bring the threshold to UI, > as suggested in comment 23. > > > It only picked some points from model to prepare viewing for drawing >> performance consideration. >> > > But I'm not an expert here and you should wait, what our experienced > developers think. > > A nitpick: the step should not be fix but depend on the amount of data > relative to a threshold. > > Kind regards > Regina > > > 2013/8/20 Regina Henschel >> >> Hi, >>> >>> I think, that it is the wrong place for a correction. A chart is a >>> document and the chart itself should take care, that it draws its data >>> series in a reasonable time. >>> >>> Kind regards >>> Regina >>> >>> bugzi...@apache.org schrieb: >>> >>> Clarence GUO has asked for review: >>> >>>> Bug 122822: Correct viewing of XY-, Column- and Line-Charts limited to >>>> 1 >>>> records + 1 Heading row >>>> https://issues.apache.org/ooo/show_bug.cgi?id=122822<https://issues.apache.org/ooo/**show_bug.cgi?id=122822> >>>> https://issues.apache.org/ooo/show_bug.cgi?id=122822> >>>> > >>>> >>>> Attachment 81359: Fix patch >>>> https://issues.apache.org/ooo/attachment.cgi?id=81359& >>>> action=edit<https://issues.apache.org/ooo/**attachment.cgi?id=81359&**action=edit> >>>> <https://issues.**apache.org/ooo/attachment.cgi?**id=81359&action=edit<https://issues.apache.org/ooo/attachment.cgi?id=81359&action=edit> >>>> > >>>> >>>> >>>> >>>> --- Additional Comments from Clarence GUO < >>>> clarence.guo...@gmail.com> >>>> The root cause of this defect is in fix of 121058, only some points were >>>> picked >>>> up in order to save loading time and memory for tens of thousands of >>>> data >>>> points. All data points were divided into many small groups and only >>>> picked min >>>> and max points from one group. The reason why only picked min and max >>>> points >>>> instead of using a regular distance is, for example, if there is a >>>> column >>>> or a >>>> line chart, most of data points are around max value 100 and min value >>>> 10, only >>>> if we pick max and min values from one group, the chart can keep it's &
Re: review requested: [Bug 122822] Correct viewing of XY-, Column- and Line-Charts limited to 10000 records + 1 Heading row : [Attachment 81359] Fix patch
Hi~ Regina, Do you mean the change should at view side? But each chart type has it's own implementation of view. So if we want to change at view side, we have to change code in each implementation. That code looks not very effective. My change doesn't change model because the data source range can be kept. It only picked some points from model to prepare viewing for drawing performance consideration. Thanks Clarence 2013/8/20 Regina Henschel > Hi, > > I think, that it is the wrong place for a correction. A chart is a > document and the chart itself should take care, that it draws its data > series in a reasonable time. > > Kind regards > Regina > > bugzi...@apache.org schrieb: > > Clarence GUO has asked for review: >> Bug 122822: Correct viewing of XY-, Column- and Line-Charts limited to >> 1 >> records + 1 Heading row >> https://issues.apache.org/ooo/**show_bug.cgi?id=122822<https://issues.apache.org/ooo/show_bug.cgi?id=122822> >> >> Attachment 81359: Fix patch >> https://issues.apache.org/ooo/**attachment.cgi?id=81359&**action=edit<https://issues.apache.org/ooo/attachment.cgi?id=81359&action=edit> >> >> >> --- Additional Comments from Clarence GUO >> The root cause of this defect is in fix of 121058, only some points were >> picked >> up in order to save loading time and memory for tens of thousands of data >> points. All data points were divided into many small groups and only >> picked min >> and max points from one group. The reason why only picked min and max >> points >> instead of using a regular distance is, for example, if there is a column >> or a >> line chart, most of data points are around max value 100 and min value >> 10, only >> if we pick max and min values from one group, the chart can keep it's >> original >> outline. But if we use a regular distance, we might only get some >> mid-value(for >> example 50) of the chart and will miss the chart outline. >> But the mechanism never consider scatter chart or bubble chart which have >> multiple data sequence in one series. For example, for scatter chart, one >> series has two sequence, x values and y values. A x value and a y value >> must be >> a pair. Then when pick x values, a min and a max values were picked. When >> pick >> y values, another min and max values were picked. However, the picked min >> and >> max x values probably are not in one pair of min and max y values. For >> example, >> index of min and max x values are 10 and 40. It should get No. 10 and No. >> 40 >> values from y values, but it might get No. 30 and No. 35. So in this >> case, the >> chart data are totally corrupt. That is the root cause. >> My fix will roll back code of 121058 in ScChart2DataSequence::** >> getNumericalData >> and add new fix code in ScChart2DataSequence::**BuildDataCache(), then >> wrong axes >> data label issue mentioned by Regina Henschel can be fixed. And new code >> will >> use regular distance to pick up points then problem for scatter chart and >> other >> charts which have multiple sequences in one series can be fixed. If the >> distance is small enough, fore-mentioned chart outline issue is no >> problem. So >> I use 5 as regular distance. >> >> --**--**- >> To unsubscribe, e-mail: >> dev-unsubscribe@openoffice.**apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> >> > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
[Call-for-Review] issue 122822 - Correct viewing of XY-, Column- and Line-Charts limited to 10000 records + 1 Heading row
Hi~ I uploaded my fix patch of 122822, also added root cause and resolution analysis. https://issues.apache.org/ooo/show_bug.cgi?id=122822 Please review Thanks Clarence
Re: For XLS, how does Excel represent a array data source of chart in the binary format?
I got the answer.
MS Excel uses cache mechanism for chart data source. In general, it uses
BRAI record to store the cell references or formulas which is used by chart
data source. At meanwhile, at the end of the chart sub-stream, the cached
data will be also stored by Dimensions record and a series of Number
records and SIIndex records.
For matrix chart data source, there's no valid data in BRAI records. But
the matrix data will be stored in Number records. Each record is a double
value of a chart data point. And Dimensions record is used to represent the
dimensions of the matrix.
2013/5/14 Donald Whytock
> Hi...Just a heads-up, the current mailing list is:
>
> dev@openoffice.apache.org
>
>
>
>
> On Tue, May 14, 2013 at 1:47 AM, Clarence GUO
> wrote:
>
>> For Excel chart data source, there are 3 kinds of data source.
>> 1) Reference a cell range directly
>> 2) Reference to a name which is a cell range or a formula which returns a
>> cell range reference or returns a matrix.
>> 3) Assign arrays to individual data series, for example a series was
>> assigned {1,2,3} as chart data.
>>
>> From MSDN, I know Excel 2003 uses BRAI record to specify data source of a
>> series. For case 1 and 2, it is that like the description. But for case 3,
>> I find many fields of BRAI record are empty but they are not in case 1 and
>> 2. These fields should be used to represent valid data series souce.
>> I'm trying to support case 3 in Symphony, but I don't know how Excel 2003
>> represents a array in data series. Could anybody who knows it tell me?
>>
>> Clarence
>>
>
>
For XLS, how does Excel represent a array data source of chart in the binary format?
For Excel chart data source, there are 3 kinds of data source.
1) Reference a cell range directly
2) Reference to a name which is a cell range or a formula which returns a
cell range reference or returns a matrix.
3) Assign arrays to individual data series, for example a series was
assigned {1,2,3} as chart data.
>From MSDN, I know Excel 2003 uses BRAI record to specify data source of a
series. For case 1 and 2, it is that like the description. But for case 3,
I find many fields of BRAI record are empty but they are not in case 1 and
2. These fields should be used to represent valid data series souce.
I'm trying to support case 3 in Symphony, but I don't know how Excel 2003
represents a array in data series. Could anybody who knows it tell me?
Clarence
