Re: Proposed changes to devtools/build-scripts on SVN
rigo, thanks for the great email.. I will be posting my comments/answers inline. > On Dec 8, 2020, at 4:13 PM, Arrigo Marchiori wrote: > > Dear List, > > while working on pull requests, I was wondering how to test the most > common build options for OpenOffice -- possibly the same used for > release builds. > > I must confess I got lost a couple of times while searching the wiki > for this information, but I eventually found out this SVN repository: > http://svn.apache.org/viewvc/openoffice/devtools/build-scripts/ > > I would like to propose some changes to those scripts. They do not > seem to be on GitHub, so a pull request is not possible. I am writing > to this list in the hope to reach the responsible people. I will be > happy to write to more direct email addresses, if anyone could point > them out to me. > For the most part, I do the Linux and macOS community builds. > 1- there seems to be a hidden bug. The configure script is called in > a subshell and its output is piped to tee(1). However, this discards > the return value of the configure script, and this does not seem to > be the intended behavior (the subshell invocation is followed by > "|| exit 1"). Solution: add "set -o pipefail" before invoking the > configure script. Great suggestion. > > 2- I would like to propose not to rely on dmake and epm to be > installed in /usr/local/bin, but to rather make them optional. If > they are found, they are used; otherwise, their URL's are passed to > the configure script so that the build system will take care of > building them. As I understand it, that would require the use of both configure options for EPM/dmake. One which sez "look for it locally" (basically, the one now where we specify a path) and the other that provides a download URL. Does that match your understanding? > > 3- I would like to propose build scripts for Ubuntu 18.04 and for > opeSUSE Leap 15 systems (they are what I have at hand at the moment) > Great! > 4- possibly other personalizations, such as the number of concurrent > jobs (8 is a bit too much for my computers :-) > Yes. In fact, I have been doing such things w/ the macOS build script where I allow for various command line options to change what is passed to configure. Of course, the question/issue arises that, after all, the main function of the build script is to pass options to configure, and it is easy to make the build script more complex that simply driving configure manually :) Please take a look at the macOS build scripts, esp for the 4.2.0-Dev code, and see if that match what you are thinking. > If the responsible people are interested in the above changes, then I > will be happy to send the changes in patch(1) format. Or, to open a > bug report. Alternatively, I am 100% open to discuss the above by > email. Cheers! - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Proposed changes to devtools/build-scripts on SVN
This is the correct list. Sent from my iPhone > On Dec 8, 2020, at 1:13 PM, Arrigo Marchiori wrote: > > Dear List, > > while working on pull requests, I was wondering how to test the most > common build options for OpenOffice -- possibly the same used for > release builds. > > I must confess I got lost a couple of times while searching the wiki > for this information, but I eventually found out this SVN repository: > http://svn.apache.org/viewvc/openoffice/devtools/build-scripts/ > > I would like to propose some changes to those scripts. They do not > seem to be on GitHub, so a pull request is not possible. I am writing > to this list in the hope to reach the responsible people. I will be > happy to write to more direct email addresses, if anyone could point > them out to me. > > 1- there seems to be a hidden bug. The configure script is called in > a subshell and its output is piped to tee(1). However, this discards > the return value of the configure script, and this does not seem to > be the intended behavior (the subshell invocation is followed by > "|| exit 1"). Solution: add "set -o pipefail" before invoking the > configure script. > > 2- I would like to propose not to rely on dmake and epm to be > installed in /usr/local/bin, but to rather make them optional. If > they are found, they are used; otherwise, their URL's are passed to > the configure script so that the build system will take care of > building them. > > 3- I would like to propose build scripts for Ubuntu 18.04 and for > opeSUSE Leap 15 systems (they are what I have at hand at the moment) > > 4- possibly other personalizations, such as the number of concurrent > jobs (8 is a bit too much for my computers :-) > > If the responsible people are interested in the above changes, then I > will be happy to send the changes in patch(1) format. Or, to open a > bug report. Alternatively, I am 100% open to discuss the above by > email. > > Regards, > -- > rigo > > http://rigo.altervista.org > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Proposed changes to devtools/build-scripts on SVN
Dear List, while working on pull requests, I was wondering how to test the most common build options for OpenOffice -- possibly the same used for release builds. I must confess I got lost a couple of times while searching the wiki for this information, but I eventually found out this SVN repository: http://svn.apache.org/viewvc/openoffice/devtools/build-scripts/ I would like to propose some changes to those scripts. They do not seem to be on GitHub, so a pull request is not possible. I am writing to this list in the hope to reach the responsible people. I will be happy to write to more direct email addresses, if anyone could point them out to me. 1- there seems to be a hidden bug. The configure script is called in a subshell and its output is piped to tee(1). However, this discards the return value of the configure script, and this does not seem to be the intended behavior (the subshell invocation is followed by "|| exit 1"). Solution: add "set -o pipefail" before invoking the configure script. 2- I would like to propose not to rely on dmake and epm to be installed in /usr/local/bin, but to rather make them optional. If they are found, they are used; otherwise, their URL's are passed to the configure script so that the build system will take care of building them. 3- I would like to propose build scripts for Ubuntu 18.04 and for opeSUSE Leap 15 systems (they are what I have at hand at the moment) 4- possibly other personalizations, such as the number of concurrent jobs (8 is a bit too much for my computers :-) If the responsible people are interested in the above changes, then I will be happy to send the changes in patch(1) format. Or, to open a bug report. Alternatively, I am 100% open to discuss the above by email. Regards, -- rigo http://rigo.altervista.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
