[ovs-dev] [PATCH] udpif: Add command to wait for revalidation.

2014-06-25 Thread Joe Stringer
This allows us to remove some of the sleeps from the testsuite. Signed-off-by: Joe Stringer joestrin...@nicira.com --- v2: Add udpif_run(), manage connection from main thread. v1: First post. --- ofproto/ofproto-dpif-upcall.c | 45 +

Re: [ovs-dev] [PATCH] revalidator: Add command to wait for revalidation.

2014-06-25 Thread Joe Stringer
Thanks for looking this over. I took a fresh look and realised that none of this is thread-safe. I sent a second version for review, which runs this logic all from the main thread: http://openvswitch.org/pipermail/dev/2014-June/042066.html On 24 June 2014 05:39, Ben Pfaff b...@nicira.com wrote:

Re: [ovs-dev] [PATCH] tests: Remove extraneous parenthesis from test name.

2014-06-25 Thread Joe Stringer
Thanks, I applied this to master. On 25 June 2014 06:22, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 23, 2014 at 09:33:56AM +1200, Joe Stringer wrote: This could cause configuration failure on earlier versions of autoconf. Reported-by: Lin Shaopeng slin0...@gmail.com Signed-off-by:

Re: [ovs-dev] [PATCH v3 02/41] connmgr: Support OFPFMF14_ONLY_OWN

2014-06-25 Thread Simon Horman
On Mon, Jun 23, 2014 at 03:16:59PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:22AM +0900, Simon Horman wrote: If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should skip sending updates to other controllers. This is in preparation for supporting OpenFlow1.4

Re: [ovs-dev] [PATCH] datapath: Rehash 16-bit skbuff hashes into 32 bits.

2014-06-25 Thread Thomas Graf
On 06/24/14 at 06:46pm, Jesse Gross wrote: Currently, if the network stack provides skb-rxhash then we use it, otherwise we compute our own. However, on at least some versions of RHEL/CentOS, the stack provides a hash but it is 16 bits rather than 32 bits. In cases where we use the upper most

Re: [ovs-dev] [PATCH] dpif: When executing actions needs help, use set action to set tunnel.

2014-06-25 Thread Thomas Graf
On 06/24/14 at 04:40pm, Ben Pfaff wrote: Open vSwitch userspace is able to implement some actions that the kernel doesn't support, such as modifying ARP fields. When it does this for a tunneled packet, it needs to supply the tunnel information with a set action, because the Linux kernel

Re: [ovs-dev] [PATCH v3 10/41] ofproto: Handle monitor and delete commands in flow monitor requests

2014-06-25 Thread Simon Horman
On Mon, Jun 23, 2014 at 05:14:52PM -0700, Ben Pfaff wrote: On Mon, Jun 16, 2014 at 11:29:30AM +0900, Simon Horman wrote: Handle modify and delete commands in OpenFlow1.4 flow monitor requests. These commands are not yet allowed by the decoder which will be updated by a subsequent patch.

Re: [ovs-dev] [PATCH V2 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-25 Thread Thomas Graf
On 06/24/14 at 06:40pm, Alex Wang wrote: Signed-off-by: Alex Wang al...@nicira.com --- PATCH - V2: - Use readdir_r() instead of readdir() for reentrency. - Address review comments from Thomas Graf. - Add dummy interface for WIN32 case. One minor comment below. index 85ecc5c..77b9b39

Re: [ovs-dev] [PATCH] netdev-dpdk: Count and delete every dropped packet

2014-06-25 Thread Thomas Graf
On 06/24/14 at 04:04pm, Daniele Di Proietto wrote: Commit f4fd623c4c25 introduced a bug in netdev_dpdk_send(): if multiple consecutive packets exceed MTU, only the first one is deleted and counted. This should fix the bug Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix coding style in TX/RX conf structs

2014-06-25 Thread Thomas Graf
On 06/24/14 at 04:05pm, Daniele Di Proietto wrote: Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com Acked-by: Thomas Graf tg...@noironetworks.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Disable NIC offloading and multiseg mbufs

2014-06-25 Thread Thomas Graf
On 06/24/14 at 04:05pm, Daniele Di Proietto wrote: We do not use any offloading (now) or multiple segments per packet, so we might as well disable those features while configuring the NIC. This could give performance improvements. For ixgbe, for example, this change allows the driver to use

Re: [ovs-dev] [PATCH V2 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-06-25 Thread Thomas Graf
On 06/24/14 at 06:40pm, Alex Wang wrote: Signed-off-by: Alex Wang al...@nicira.com --- PATCH - V2: - Rebase. LGTM, minor nitpick below. Acked-by: Thomas Graf tg...@noironetworks.com diff --git a/lib/netdev-dpdk.h b/lib/netdev-dpdk.h index f443a21..da507ce 100644 --- a/lib/netdev-dpdk.h

Re: [ovs-dev] [PATCH] netdev-dpdk / arbitrary port naming for vhost ports

2014-06-25 Thread Tahhan, Maryam
Hi Ben Thanks for the feedback, I will refactor and resubmit, just a question regarding the section that sets the MAC address for the logical vhost port, is the issue just the formatting you mention after the comment about it being wrong or was there an issue with setting the MAC to something

Re: [ovs-dev] [PATCH 4/8] lib/pvector: Non-intrusive RCU priority vector.

2014-06-25 Thread Jarno Rajahalme
Thanks for the review. I have addressed all the comments, there is quite a nice additional clean-up in classifier_lookup(). In addition to the lookahead, I also integrated the priority handling to an iterator. Will send v2 right away. Jarno On Jun 13, 2014, at 10:06 AM, Ben Pfaff

[ovs-dev] [PATCH v2] lib/pvector: Non-intrusive RCU priority vector.

2014-06-25 Thread Jarno Rajahalme
Factor out the priority vector code from the classifier. Making the classifier use RCU instead of locking requires parallel access to the priority vector, pointing to subtables in descending priority order. When a new subtable is added, a new copy of the priority vector is allocated, while the

Re: [ovs-dev] [PATCH 8/8] lib/classifier: Use cmap.

2014-06-25 Thread Jarno Rajahalme
Ben, Thanks for the reviews! I have addressed the (minor) comments on the series, will push once the vector v2 is ack’ed. I’ll keep this last patch as the first in the classifier RCU series. Jarno On Jun 13, 2014, at 10:37 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 09, 2014 at

Re: [ovs-dev] [PATCH] datapath: Rehash 16-bit skbuff hashes into 32 bits.

2014-06-25 Thread Jesse Gross
On Wed, Jun 25, 2014 at 1:30 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 06:46pm, Jesse Gross wrote: Currently, if the network stack provides skb-rxhash then we use it, otherwise we compute our own. However, on at least some versions of RHEL/CentOS, the stack provides a hash

Re: [ovs-dev] [PATCH V2 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-25 Thread Alex Wang
index 85ecc5c..77b9b39 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -76,6 +76,7 @@ m4_define([OVS_VSWITCHD_START], AT_CHECK([ovs-vswitchd --detach --no-chdir --pidfile --enable-dummy$3 --disable-system --log-file -vvconn -vofproto_dpif], [0], [], [stderr])

Re: [ovs-dev] [PATCH V2 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-06-25 Thread Alex Wang
On Wed, Jun 25, 2014 at 2:59 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 06:40pm, Alex Wang wrote: Signed-off-by: Alex Wang al...@nicira.com --- PATCH - V2: - Rebase. LGTM, minor nitpick below. Acked-by: Thomas Graf tg...@noironetworks.com diff --git

Re: [ovs-dev] [PATCH V2 1/5] ovs-numa: Add ovs-numa.{c, h} for extracting and storing cpu socket and cpu core info.

2014-06-25 Thread Thomas Graf
On 06/25/14 at 08:54am, Alex Wang wrote: index 85ecc5c..77b9b39 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -76,6 +76,7 @@ m4_define([OVS_VSWITCHD_START], AT_CHECK([ovs-vswitchd --detach --no-chdir --pidfile --enable-dummy$3 --disable-system

Re: [ovs-dev] [PATCH v3 3/3] datapath: add layer 3 flow/port support

2014-06-25 Thread Lori Jakab
On 6/25/14, 5:19 AM, Jesse Gross wrote: On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross je...@nicira.com wrote: On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab loja...@cisco.com wrote: Hi Jesse, On 5/23/14, 2:07 AM, Jesse Gross wrote: On Tue, May 20, 2014 at 9:27 PM, Lori Jakab loja...@cisco.com

Re: [ovs-dev] [PATCH] lib: Rename ofp to buf.

2014-06-25 Thread Pravin Shelar
On Tue, Jun 24, 2014 at 2:20 PM, Daniele Di Proietto ddiproie...@vmware.com wrote: On Jun 8, 2014, at 1:18 PM, Pravin B Shelar pshe...@nicira.com wrote: dpif-packet contains ofpbuf which points to packet data. Here buf is better name rather than ofp. Following patch renames all remaining

Re: [ovs-dev] [PATCH 8/8] lib/classifier: Use cmap.

2014-06-25 Thread Gurucharan Shetty
I had a quick comment. I noticed while running unit tests on Xenserver that the cuckoo hash unit test was very slow. It takes a little more than one minute to complete. I wonder whether using more cmap would hurt Xenserver's performance? On Wed, Jun 25, 2014 at 4:19 AM, Jarno Rajahalme

Re: [ovs-dev] [PATCH] dpif: When executing actions needs help, use set action to set tunnel.

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 11:05:56AM +0200, Thomas Graf wrote: On 06/24/14 at 04:40pm, Ben Pfaff wrote: Open vSwitch userspace is able to implement some actions that the kernel doesn't support, such as modifying ARP fields. When it does this for a tunneled packet, it needs to supply the

Re: [ovs-dev] [PATCH] netdev-dpdk / arbitrary port naming for vhost ports

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 10:48:41AM +, Tahhan, Maryam wrote: Thanks for the feedback, I will refactor and resubmit, just a question regarding the section that sets the MAC address for the logical vhost port, is the issue just the formatting you mention after the comment about it being wrong

Re: [ovs-dev] [PATCH] netdev-dpdk: Count and delete every dropped packet

2014-06-25 Thread Pravin Shelar
On Wed, Jun 25, 2014 at 2:49 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 04:04pm, Daniele Di Proietto wrote: Commit f4fd623c4c25 introduced a bug in netdev_dpdk_send(): if multiple consecutive packets exceed MTU, only the first one is deleted and counted. This should fix

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Disable NIC offloading and multiseg mbufs

2014-06-25 Thread Pravin Shelar
On Wed, Jun 25, 2014 at 2:55 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 04:05pm, Daniele Di Proietto wrote: We do not use any offloading (now) or multiple segments per packet, so we might as well disable those features while configuring the NIC. This could give performance

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix coding style in TX/RX conf structs

2014-06-25 Thread Pravin Shelar
On Wed, Jun 25, 2014 at 2:55 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 04:05pm, Daniele Di Proietto wrote: Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com Acked-by: Thomas Graf tg...@noironetworks.com I pushed it to master. Thanks.

Re: [ovs-dev] [PATCH] dpif-netdev: Delete packet if not able to do upcall

2014-06-25 Thread Pravin Shelar
On Tue, Jun 24, 2014 at 4:08 PM, Daniele Di Proietto ddiproie...@vmware.com wrote: In dp_netdev_input() we nevered fully covered the case where handler queues are not there. With this change we increment the stat counter and free the packet. Signed-off-by: Daniele Di Proietto

[ovs-dev] [PATCH] dpif-linux: Minor style fixes.

2014-06-25 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/dpif-linux.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index 66911c7..0eac3e7 100644 --- a/lib/dpif-linux.c +++ b/lib/dpif-linux.c @@ -1362,9 +1362,9 @@ dpif_linux_execute(struct

[ovs-dev] [PATCH 2/3] dpif: When executing an operation with help, log the sub-executes.

2014-06-25 Thread Ben Pfaff
This should make it easier to identify problems that result from bugs in the execution helper. Suggested-by: Jesse Gross je...@nicira.com Signed-off-by: Ben Pfaff b...@nicira.com --- lib/dpif.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/lib/dpif.c

[ovs-dev] [PATCH 1/3] dpif: Consistently help datapath to execute oversized actions.

2014-06-25 Thread Ben Pfaff
Only dpif_execute() was checking for oversized actions but dpif_operate() should do so also. This fixes the problem. Found by inspection. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/dpif.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/dpif.c

[ovs-dev] [PATCH 3/3] dpif: Explain a bug, why it isn't important, and why it's hard to fix.

2014-06-25 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/dpif.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/dpif.c b/lib/dpif.c index dcd60a5..2b6f36d 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -1554,6 +1554,23 @@ log_flow_del_message(struct dpif *dpif, const struct

Re: [ovs-dev] [PATCH] dpif: When executing actions needs help, use set action to set tunnel.

2014-06-25 Thread Ben Pfaff
On Tue, Jun 24, 2014 at 05:19:02PM -0700, Ben Pfaff wrote: Maybe we also need a log message lower down in the stack showing what is actually being sent to the kernel in these cases? I agree, I'm thinking about that too. I sent out a short series:

Re: [ovs-dev] [PATCH 4/8] lib/pvector: Non-intrusive RCU priority vector.

2014-06-25 Thread Ben Pfaff
Thanks! This series has dragged on a while so I'll try to expedite review. On Wed, Jun 25, 2014 at 03:58:00AM -0700, Jarno Rajahalme wrote: Thanks for the review. I have addressed all the comments, there is quite a nice additional clean-up in classifier_lookup(). In addition to the lookahead,

Re: [ovs-dev] [PATCH] json: Fix parsing of strings that end with a backslash.

2014-06-25 Thread Alex Wang
Looks good to me, Acked-by: Alex Wang al...@nicira.com Thx, On Tue, Jun 24, 2014 at 5:06 PM, Ben Pfaff b...@nicira.com wrote: json_string_unescape() flagged a backslash at the end of a string as an error, but of course \\ is a valid string. This fixes the problem. VMware-BZ: #1275208

Re: [ovs-dev] [PATCH 8/8] lib/classifier: Use cmap.

2014-06-25 Thread Ben Pfaff
Sounds good. I'll look at the pvector v2 now. On Wed, Jun 25, 2014 at 04:19:23AM -0700, Jarno Rajahalme wrote: Ben, Thanks for the reviews! I have addressed the (minor) comments on the series, will push once the vector v2 is ack?ed. I?ll keep this last patch as the first in the

Re: [ovs-dev] [PATCH 8/8] lib/classifier: Use cmap.

2014-06-25 Thread Ben Pfaff
I am really surprised to hear that it takes over a minute. On my workstation (which is a few years old), ovstest test-cmap check 1 only takes 6.5 seconds. Do you have any idea what's different on XenServer? It might be the GCC version, which version is it using? On Wed, Jun 25, 2014 at

Re: [ovs-dev] [PATCH] dpif-linux: Minor style fixes.

2014-06-25 Thread Pritesh Kothari (pritkoth)
Acked-by: Pritesh Kothari pritesh.koth...@cisco.com On Jun 25, 2014, at 10:59 AM, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/dpif-linux.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c

Re: [ovs-dev] [PATCH v2] lib/pvector: Non-intrusive RCU priority vector.

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 04:15:54AM -0700, Jarno Rajahalme wrote: Factor out the priority vector code from the classifier. Making the classifier use RCU instead of locking requires parallel access to the priority vector, pointing to subtables in descending priority order. When a new subtable

Re: [ovs-dev] [PATCH] ovs-ofctl: Document form of packet parameters to packet-out.

2014-06-25 Thread Justin Pettit
Acked-by: Justin Pettit jpet...@nicira.com --Justin On Jun 24, 2014, at 2:46 PM, Ben Pfaff b...@nicira.com wrote: The syntax is inconvenient but at least it's documented. Signed-off-by: Ben Pfaff b...@nicira.com --- utilities/ovs-ofctl.8.in |3 ++- 1 file changed, 2 insertions(+),

Re: [ovs-dev] [PATCH] json: Fix parsing of strings that end with a backslash.

2014-06-25 Thread Ben Pfaff
Thanks for the review. I applied this to master, branch-2.{0,1,2,3}, and branch-1.{4,9,11}. On Wed, Jun 25, 2014 at 11:05:56AM -0700, Alex Wang wrote: Looks good to me, Acked-by: Alex Wang al...@nicira.com Thx, On Tue, Jun 24, 2014 at 5:06 PM, Ben Pfaff b...@nicira.com wrote:

[ovs-dev] [PATCH] dpif-netdev: delete lost packets in dp_execute_cb()

2014-06-25 Thread Daniele Di Proietto
This commit fixes memory leaks in dp_execute_cb() in two cases: - when the output port cannot be found - when the recirculation depth is exceeded Reported-by: Pravin Shelar pshe...@nicira.com Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com --- lib/dpif-netdev.c | 11 ++-

Re: [ovs-dev] [PATCH 8/8] lib/classifier: Use cmap.

2014-06-25 Thread Gurucharan Shetty
On Wed, Jun 25, 2014 at 11:09 AM, Ben Pfaff b...@nicira.com wrote: I am really surprised to hear that it takes over a minute. On my workstation (which is a few years old), ovstest test-cmap check 1 only takes 6.5 seconds. Do you have any idea what's different on XenServer? It might be the

Re: [ovs-dev] [PATCH] ovs-ofctl: Document form of packet parameters to packet-out.

2014-06-25 Thread Ben Pfaff
Thanks, applied to master. On Wed, Jun 25, 2014 at 11:44:09AM -0700, Justin Pettit wrote: Acked-by: Justin Pettit jpet...@nicira.com --Justin On Jun 24, 2014, at 2:46 PM, Ben Pfaff b...@nicira.com wrote: The syntax is inconvenient but at least it's documented. Signed-off-by:

Re: [ovs-dev] [PATCH v4] dpif-netdev: Implement batched flow dumping.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 12:36:11PM -0700, Ryan Wilson wrote: Previously, flows were retrieved one by one when dumping flows for datapaths of type 'netdev'. This increased contention for the dump's mutex, negatively affecting revalidator performance. This patch retrieves batches of flows when

Re: [ovs-dev] [PATCH v4] dpif-netdev: Implement batched flow dumping.

2014-06-25 Thread Ryan Wilson
Thanks Ryan! I folded in this change to ensure that the caller could specify any 'max_flows' that it likes. It doesn't make sense for the caller to have to be aware of the implementation's limitations: I was debating between either using an assert or using the min of max_flows and

Re: [ovs-dev] [PATCH] netdev-dpdk: Count and delete every dropped packet

2014-06-25 Thread Daniele Di Proietto
Thanks On Jun 25, 2014, at 10:55 AM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Jun 25, 2014 at 2:49 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 04:04pm, Daniele Di Proietto wrote: Commit f4fd623c4c25 introduced a bug in netdev_dpdk_send(): if multiple consecutive

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Disable NIC offloading and multiseg mbufs

2014-06-25 Thread Daniele Di Proietto
Thanks On Jun 25, 2014, at 10:56 AM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Jun 25, 2014 at 2:55 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 04:05pm, Daniele Di Proietto wrote: We do not use any offloading (now) or multiple segments per packet, so we might as well

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix coding style in TX/RX conf structs

2014-06-25 Thread Daniele Di Proietto
Thanks On Jun 25, 2014, at 10:55 AM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Jun 25, 2014 at 2:55 AM, Thomas Graf tg...@noironetworks.com wrote: On 06/24/14 at 04:05pm, Daniele Di Proietto wrote: Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com Acked-by: Thomas Graf

[ovs-dev] [PATCH] dpif-netdev: Fix memory leak in dpif_netdev_flow_put()

2014-06-25 Thread Ryan Wilson
miniflow_destroy() needs to be called after using miniflow_init(). Otherwise, if the miniflow mallocs data, then a memory leak may occur. Found by inspection. Signed-off-by: Ryan Wilson wr...@nicira.com --- lib/dpif-netdev.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [ovs-dev] [PATCH 0/4] Support for OVS datapath on Windows platform.

2014-06-25 Thread Alessandro Pilotti
Hi Saurabh, Thanks for posting these patches! We looked at the code in the last two days, running various tests and did comparisons with our porting. We tried to be as unbiased as possible in the review, with the goal of making the best out of both codebases and not a “us” vs “them” match. :)

Re: [ovs-dev] [PATCH] datapath: fix sparse warning in function tbl_mask_array_delete_mask()

2014-06-25 Thread Pravin Shelar
On Mon, Jun 23, 2014 at 11:10 PM, Andy Zhou az...@nicira.com wrote: Sparse gives incompatible types in comparison expression (different address spaces) warning messages. Fix this by add rcu_dereference() wrappers. Reported-by: Ben Pfaff b...@nicira.com Signed-off-by: Andy Zhou

Re: [ovs-dev] [PATCH] dpif-netdev: Fix memory leak in dpif_netdev_flow_put()

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 01:05:17PM -0700, Ryan Wilson wrote: miniflow_destroy() needs to be called after using miniflow_init(). Otherwise, if the miniflow mallocs data, then a memory leak may occur. Found by inspection. Signed-off-by: Ryan Wilson wr...@nicira.com Thanks, applied to

[ovs-dev] [PATCH] CodingStyle: Functions in .c files should usually not be marked inline.

2014-06-25 Thread Ben Pfaff
I thought this was in here already, but I guess not. Signed-off-by: Ben Pfaff b...@nicira.com --- CodingStyle |5 + 1 file changed, 5 insertions(+) diff --git a/CodingStyle b/CodingStyle index 0ba0366..628f21f 100644 --- a/CodingStyle +++ b/CodingStyle @@ -162,6 +162,11 @@ such a

Re: [ovs-dev] [PATCH 1/1] PMD dpdk TX output SMP dpdk queue use and packet surge assoprtion.

2014-06-25 Thread Ben Pfaff
On Fri, Jun 20, 2014 at 10:24:33PM +, Polehn, Mike A wrote: Put in a DPDK queue to receive from multiple core SMP input from vSwitch for NIC TX output. Eliminated the inside polling loop SMP TX output lock (DPDK queue handles SMP). Added a SMP lock for non-polling operation to allow TX

Re: [ovs-dev] [netdev-dpdk 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 12:37:29PM -0700, Alex Wang wrote: diff --git a/lib/netdev-dpdk.h b/lib/netdev-dpdk.h index f443a21..da507ce 100644 --- a/lib/netdev-dpdk.h +++ b/lib/netdev-dpdk.h @@ -20,13 +20,18 @@ struct dpif_packet; #include rte_launch.h #include rte_malloc.h +struct

Re: [ovs-dev] [PATCH] CodingStyle: Functions in .c files should usually not be marked inline.

2014-06-25 Thread Alex Wang
Acked-by: Alex Wang al...@nicira.com On Wed, Jun 25, 2014 at 1:44 PM, Ben Pfaff b...@nicira.com wrote: I thought this was in here already, but I guess not. Signed-off-by: Ben Pfaff b...@nicira.com --- CodingStyle |5 + 1 file changed, 5 insertions(+) diff --git a/CodingStyle

Re: [ovs-dev] [netdev-dpdk 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-06-25 Thread Alex Wang
Yes, Thomas also pointed it out in V2, Will fix it. Also, remind me to clean up my patches in patchwork... Thanks, On Wed, Jun 25, 2014 at 1:51 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jun 23, 2014 at 12:37:29PM -0700, Alex Wang wrote: diff --git a/lib/netdev-dpdk.h

Re: [ovs-dev] [netdev-dpdk 2/5] netdev-dpdk: Add function for getting the socket_id of netdev-dpdk.

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 01:53:51PM -0700, Alex Wang wrote: Yes, Thomas also pointed it out in V2, Will fix it. Thanks. Also, remind me to clean up my patches in patchwork... It looked like this series needed a v2 so I marked all of them as Changes Requested (even though some of them may

Re: [ovs-dev] [PATCH] CodingStyle: Functions in .c files should usually not be marked inline.

2014-06-25 Thread Ben Pfaff
Thanks, applied to master. On Wed, Jun 25, 2014 at 01:52:32PM -0700, Alex Wang wrote: Acked-by: Alex Wang al...@nicira.com On Wed, Jun 25, 2014 at 1:44 PM, Ben Pfaff b...@nicira.com wrote: I thought this was in here already, but I guess not. Signed-off-by: Ben Pfaff b...@nicira.com

Re: [ovs-dev] [PATCH v8 0/3] Flow-Based Recirculation for MPLS

2014-06-25 Thread Ben Pfaff
On Tue, Jun 24, 2014 at 08:46:30AM +0900, Simon Horman wrote: The motivation of this series is to allow some sequences of actions that include MPLS actions to be performed using recirculation. Sequences of actions that could not previously be handled. For example pop_mpls:0x0800,dec_ttl.

Re: [ovs-dev] [PATCH] datapath: fix sparse warning in function tbl_mask_array_delete_mask()

2014-06-25 Thread Andy Zhou
Thanks, pushed with suggested changes. On Wed, Jun 25, 2014 at 1:21 PM, Pravin Shelar pshe...@nicira.com wrote: On Mon, Jun 23, 2014 at 11:10 PM, Andy Zhou az...@nicira.com wrote: Sparse gives incompatible types in comparison expression (different address spaces) warning messages. Fix this by

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Base code for developing the Hyper-V switch entension.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 05:34:56PM -0700, Saurabh Shah wrote: This is the Hyper-V Extensible Switch extension filter driver sample code available at: http://code.msdn.microsoft.com/windowshardware/Hyper-V-Extensible-Virtual-e4b31fbb The sample code is licensed under Microsoft Limited Public

Re: [ovs-dev] [PATCH] dpif-netdev: delete lost packets in dp_execute_cb()

2014-06-25 Thread Pravin Shelar
On Wed, Jun 25, 2014 at 11:39 AM, Daniele Di Proietto ddiproie...@vmware.com wrote: This commit fixes memory leaks in dp_execute_cb() in two cases: - when the output port cannot be found - when the recirculation depth is exceeded Reported-by: Pravin Shelar pshe...@nicira.com

Re: [ovs-dev] [PATCH 2/4] datapath-windows: Prepare base code for the forwarding extension.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 05:34:57PM -0700, Saurabh Shah wrote: These are some minimal changes required to get the base code to work with our forwarding extension. These changes are licensed under Apache License, Version 2.0. Co-Authored-By: Eitan Eliahu elia...@vmware.com Signed-off-by:

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Base code for developing the Hyper-V switch entension.

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 02:57:34PM -0700, Ben Pfaff wrote: On Mon, Jun 23, 2014 at 05:34:56PM -0700, Saurabh Shah wrote: This is the Hyper-V Extensible Switch extension filter driver sample code available at: http://code.msdn.microsoft.com/windowshardware/Hyper-V-Extensible-Virtual-e4b31fbb

Re: [ovs-dev] [PATCH] dpif-netdev: delete lost packets in dp_execute_cb()

2014-06-25 Thread Daniele Di Proietto
On Jun 25, 2014, at 3:02 PM, Pravin Shelar pshe...@nicira.com wrote: On Wed, Jun 25, 2014 at 11:39 AM, Daniele Di Proietto ddiproie...@vmware.com wrote: This commit fixes memory leaks in dp_execute_cb() in two cases: - when the output port cannot be found - when the recirculation

Re: [ovs-dev] Cloudbase - OVS Hyper-V porting availability

2014-06-25 Thread Alessandro Pilotti
On 24.06.2014, at 03:55, Justin Pettit jpet...@nicira.commailto:jpet...@nicira.com wrote: On Sun, Jun 22, 2014 at 5:42 PM, Alessandro Pilotti apilo...@cloudbasesolutions.commailto:apilo...@cloudbasesolutions.com wrote: In addition to the code repositories made previously available, here’s a

Re: [ovs-dev] [PATCH 1/3] dpif: Consistently help datapath to execute oversized actions.

2014-06-25 Thread Jesse Gross
On Wed, Jun 25, 2014 at 11:02 AM, Ben Pfaff b...@nicira.com wrote: Only dpif_execute() was checking for oversized actions but dpif_operate() should do so also. This fixes the problem. Found by inspection. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Jesse Gross je...@nicira.com

Re: [ovs-dev] [PATCH 2/3] dpif: When executing an operation with help, log the sub-executes.

2014-06-25 Thread Jesse Gross
On Wed, Jun 25, 2014 at 11:02 AM, Ben Pfaff b...@nicira.com wrote: This should make it easier to identify problems that result from bugs in the execution helper. Suggested-by: Jesse Gross je...@nicira.com Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Jesse Gross je...@nicira.com

Re: [ovs-dev] [PATCH 3/3] dpif: Explain a bug, why it isn't important, and why it's hard to fix.

2014-06-25 Thread Jesse Gross
On Wed, Jun 25, 2014 at 11:02 AM, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/dpif.c | 17 + 1 file changed, 17 insertions(+) Acked-by: Jesse Gross je...@nicira.com ___ dev mailing list

Re: [ovs-dev] PATCH [1/1] High speed PMD physical NIC queue size, resubmit

2014-06-25 Thread Pravin Shelar
On Thu, Jun 19, 2014 at 3:58 PM, Polehn, Mike A mike.a.pol...@intel.com wrote: Large TX and RX queues are needed for high speed 10 GbE physical NICS. Observed a 250% zero loss improvement over small NIC queue test for A port to port flow test. Signed-off-by: Mike A. Polehn

Re: [ovs-dev] [PATCH v8 0/3] Flow-Based Recirculation for MPLS

2014-06-25 Thread Simon Horman
On Wed, Jun 25, 2014 at 02:19:38PM -0700, Ben Pfaff wrote: On Tue, Jun 24, 2014 at 08:46:30AM +0900, Simon Horman wrote: The motivation of this series is to allow some sequences of actions that include MPLS actions to be performed using recirculation. Sequences of actions that could not

Re: [ovs-dev] [PATCH 3/4] dpif-windows: Implement datapath interface for windows.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 05:34:58PM -0700, Saurabh Shah wrote: Co-Authored-By: Eitan Eliahu elia...@vmware.com Signed-off-by: Eitan Eliahu elia...@vmware.com Co-Authored-By: Guolin Yang gy...@vmware.com Signed-off-by: Guolin Yang gy...@vmware.com Co-Authored-By: Linda Sun l...@vmware.com

Re: [ovs-dev] [PATCH 4/4] datapath-windows: Implement the virtual switch forwarding extension.

2014-06-25 Thread Ben Pfaff
On Mon, Jun 23, 2014 at 05:34:59PM -0700, Saurabh Shah wrote: With this implementation we support bridge backed forwarding (with VLAN tagging) tunneling over VXLAN. Co-Authored-By: Eitan Eliahu elia...@vmware.com Signed-off-by: Eitan Eliahu elia...@vmware.com Co-Authored-By: Guolin Yang

Re: [ovs-dev] Cloudbase - OVS Hyper-V porting availability

2014-06-25 Thread Ben Pfaff
On Tue, Jun 10, 2014 at 2:06 PM, Alessandro Pilotti apilo...@cloudbasesolutions.com wrote: https://github.com/cloudbase/openvswitch-hyperv https://github.com/cloudbase/openvswitch-hyperv-kernel Thanks a lot for sending this out. I've just now started taking a first look at it. I see that

Re: [ovs-dev] Cloudbase - OVS Hyper-V porting availability

2014-06-25 Thread Ben Pfaff
On Wed, Jun 25, 2014 at 5:04 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Jun 10, 2014 at 2:06 PM, Alessandro Pilotti apilo...@cloudbasesolutions.com wrote: https://github.com/cloudbase/openvswitch-hyperv https://github.com/cloudbase/openvswitch-hyperv-kernel Thanks a lot for sending this

[ovs-dev] Mail System Error - Returned Mail

2014-06-25 Thread The Post Office
The original message was received at Thu, 26 Jun 2014 09:46:13 +0700 from openvswitch.org [90.199.9.180] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH] datapath: Remove redundant tcp_flags code.

2014-06-25 Thread Joe Stringer
These two cases used to be treated differently for IPv4/IPv6, but they are now identical. Signed-off-by: Joe Stringer joestrin...@nicira.com --- datapath/flow_netlink.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/datapath/flow_netlink.c

Re: [ovs-dev] [PATCH] FAQ: add an entry for MAC learning + VLAN

2014-06-25 Thread Flavio Leitner
On Wed, Jun 25, 2014 at 11:07:31AM +0900, YAMAMOTO Takashi wrote: Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp --- FAQ | 6 ++ 1 file changed, 6 insertions(+) diff --git a/FAQ b/FAQ index 79d905d..c2520fc 100644 --- a/FAQ +++ b/FAQ @@ -1124,6 +1124,12 @@ A: Do you have a

Re: [ovs-dev] [PATCH] FAQ: add an entry for MAC learning + VLAN

2014-06-25 Thread YAMAMOTO Takashi
On Wed, Jun 25, 2014 at 11:07:31AM +0900, YAMAMOTO Takashi wrote: Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp --- FAQ | 6 ++ 1 file changed, 6 insertions(+) diff --git a/FAQ b/FAQ index 79d905d..c2520fc 100644 --- a/FAQ +++ b/FAQ @@ -1124,6 +1124,12 @@ A: Do you have a