[ovs-dev] [PATCH 1/2] ofp-msgs: Add support for ONF extension messages.

2016-01-27 Thread Ben Pfaff
ONF introduced a number of "standard extensions" that use its own vendor (experimenter) ID. This commit adds support for such extensions to ofp-msgs. These extensions were already half-supported, so there's barely any change to build-aux/extract-ofp-msgs. This isn't fully tested, since nothing

[ovs-dev] [PATCH 2/2] ofp-msgs: Move most OpenFlow header definitions here.

2016-01-27 Thread Ben Pfaff
This code was the only user for OpenFlow header definitions other than struct ofp_header itself. Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h | 9 - include/openflow/openflow-1.0.h | 20 include/openflow/openflow-1.1.h | 11 +--

Re: [ovs-dev] [PATCH 1/2] datapath: Provide this_cpu_{read, inc, dec} wrappers for v2.6.33

2016-01-27 Thread pravin shelar
On Thu, Nov 26, 2015 at 10:07 PM, Simon Horman wrote: > My understanding is that prior to linux kernel commit > dd17c8f72993 ("percpu: remove per_cpu__ prefix.") per_cpu_var(), > which was included in v2.6.34, was used to wrap per cpu variables > > In order to allow

Re: [ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

2016-01-27 Thread Russell Bryant
On Wednesday, January 27, 2016, Flavio Leitner wrote: > On Thu, 21 Jan 2016 17:09:42 -0500 > Russell Bryant > wrote: > > > On 01/20/2016 05:59 PM, Ansis Atteka wrote: > > > CentOS, RHEL and Fedora distributions ship with their own Open > > >

Re: [ovs-dev] [PATCH] datapath: Fix IPv6 fragment expiry crash.

2016-01-27 Thread pravin shelar
On Tue, Jan 26, 2016 at 5:57 PM, Joe Stringer wrote: > Fixes the following kernel oops on kernels < 3.17 when IPv6 fragments > are expired without reassembling the frame. > > BUG: unable to handle kernel paging request at 0006845d69a8 > IP: [] _raw_spin_lock+0xe/0x50 > ... >

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Reduce code duplication

2016-01-27 Thread Daniele Di Proietto
For the series: Acked-by: Daniele Di Proietto I didn't observe any performance regressions. Thanks! On 27/01/2016 13:31, "Andy Zhou" wrote: >Code clean up to reduce code duplication. > >Signed-off-by: Andy Zhou >--- > lib/dpif-netdev.c

[ovs-dev] [PATCH] README.ovs-vtep.md: Fix incorrect spacing

2016-01-27 Thread Kyle Mestery
This fixes a simple formatting issue with this file I noticed while reviewing the example of experimenting with the OVS HW-VTEP simulator. Signed-off-by: Kyle Mestery --- vtep/README.ovs-vtep.md | 1 + 1 file changed, 1 insertion(+) diff --git a/vtep/README.ovs-vtep.md

Re: [ovs-dev] [PATCH 1/4] Add MAINTAINERS file.

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 03:38:02PM -0500, Russell Bryant wrote: > Previously, the list of committers was not written down publicly. There > was no reason for this other than it not being trivial to expose the > commiter group membership via github. This MAINTAINERS file lists the > members of

Re: [ovs-dev] [PATCH 3/8] timeval: Factor out cycles_counter().

2016-01-27 Thread pravin shelar
On Mon, Jan 25, 2016 at 9:34 AM, Jesse Gross wrote: > On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >> index cd72e62..c746cc2 100644 >> --- a/lib/dpif-netdev.c >> +++ b/lib/dpif-netdev.c >>

Re: [ovs-dev] [PATCH] dpif-netdev: Avoid copying netdev_flow_key in emc_processing().

2016-01-27 Thread Daniele Di Proietto
On 26/01/2016 08:23, "Ben Pfaff" wrote: >On Tue, Jan 26, 2016 at 03:28:47AM +, Daniele Di Proietto wrote: >> >> >> On 25/01/2016 18:20, "Andy Zhou" wrote: >> >> >On Sun, Jan 24, 2016 at 8:32 AM, Ben Pfaff wrote: >> > >> >> Before this commit,

Re: [ovs-dev] dpif-netdev: Fix improper use of CMAP_FOR_EACH.

2016-01-27 Thread Daniele Di Proietto
On 27/01/2016 01:34, "Ilya Maximets" wrote: >Thanks for this patch. >I have seen this bug while testing my patches for rx queues, but I thought >that it was the problem in my specific testing system. > >It was easily reproducible. Now it's gone (with this patch

Re: [ovs-dev] [RFC] ovsdb-idl: improved error handling for non-existent db

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 04:20:39PM -0500, Lance Richardson wrote: > - Original Message - > > On Wed, Jan 27, 2016 at 02:46:07PM -0500, Lance Richardson wrote: > > > A common error scenario with OVN is to attempt to use ovn-nbctl when > > > the OVN databases have not been created: > > >

Re: [ovs-dev] [PATCH] README.ovs-vtep.md: Fix incorrect spacing

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 05:55:28PM -0600, Kyle Mestery wrote: > This fixes a simple formatting issue with this file I noticed while reviewing > the example of experimenting with the OVS HW-VTEP simulator. > > Signed-off-by: Kyle Mestery Thanks, applied to master,

Re: [ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

2016-01-27 Thread Russell Bryant
On 01/27/2016 06:56 PM, Ben Pfaff wrote: > On Wed, Jan 27, 2016 at 03:38:03PM -0500, Russell Bryant wrote: >> Adopt a subset of the syntax used in the Linux kernel MAINTAINERS file >> for expressing maintainership of subsets of the code base. To start, I >> added a catch-all section and a section

Re: [ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 03:38:03PM -0500, Russell Bryant wrote: > Adopt a subset of the syntax used in the Linux kernel MAINTAINERS file > for expressing maintainership of subsets of the code base. To start, I > added a catch-all section and a section for OVN. Other entries will > come in later

Re: [ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

2016-01-27 Thread Justin Pettit
> On Jan 27, 2016, at 4:45 PM, Russell Bryant wrote: > > I'm OK going either way here, but hopefully that helps explain my > motivation. I understand the motivation and agree with it in principal, but I share Ben's concern about it becoming territorial. Understanding the

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

2016-01-27 Thread Ben Pfaff
Thanks, I appreciate that. I tried to untie this knot this morning and ended up just getting more tangled. I applied this to master and branch-2.5. On Wed, Jan 27, 2016 at 04:16:00PM -0800, Jarno Rajahalme wrote: > I’ll propose more patches to make recirculation handling in > do_xlate_actions()

Re: [ovs-dev] [PATCH 3/8] timeval: Factor out cycles_counter().

2016-01-27 Thread Jesse Gross
On Wed, Jan 27, 2016 at 4:36 PM, pravin shelar wrote: > On Mon, Jan 25, 2016 at 9:34 AM, Jesse Gross wrote: >> I'm also not sure that it is really safe to use the raw TSC in all >> cases. It's possible that DPDK support is compiled in but we aren't >> using a

Re: [ovs-dev] [PATCH 11/14] ovn-controller: Add data structure for indexing lports, multicast groups.

2016-01-27 Thread Ben Pfaff
On Mon, Dec 21, 2015 at 09:01:00PM -0800, Justin Pettit wrote: > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > +struct lport { > > +struct hmap_node name_node; /* Index by name. */ > > +struct hmap_node key_node; /* Index by (dp->tunnel_key, tunnel_key). > >

Re: [ovs-dev] [PATCH 10/10] Implement "closures".

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 09:51:29AM -0800, Ben Pfaff wrote: > This RFC patch has a number of caveats: > > * No real tests yet. Ooops, that's old and incorrect. This patch includes adequate tests, in my opinion. I'll remove this from the commit message.

Re: [ovs-dev] dpif-netdev: Fix improper use of CMAP_FOR_EACH.

2016-01-27 Thread Ilya Maximets
On 28.01.2016 04:47, Daniele Di Proietto wrote: > > > On 27/01/2016 01:34, "Ilya Maximets" wrote: > >> Thanks for this patch. >> I have seen this bug while testing my patches for rx queues, but I thought >> that it was the problem in my specific testing system. >> >> It

Re: [ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

2016-01-27 Thread Russell Bryant
On Wednesday, January 27, 2016, Justin Pettit wrote: > > > On Jan 27, 2016, at 4:45 PM, Russell Bryant > wrote: > > > > I'm OK going either way here, but hopefully that helps explain my > > motivation. > > I understand the motivation and agree

Re: [ovs-dev] [PATCH 11/14] ovn-controller: Add data structure for indexing lports, multicast groups.

2016-01-27 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 11:44:20PM +0530, Numan Siddique wrote: > On 12/09/2015 06:38 AM, Ben Pfaff wrote: > > This was more or less implemented inside lflow.c until now, but some > > upcoming code that shouldn't be in that file needs to use it too. > > > > This also adds a second index on lports,

[ovs-dev] You have the education now get the Degree to match

2016-01-27 Thread Daphne
Get a Degree in 5 weeks with our program! ~ Our program will let ANYONE with professional experience gain a Degree: ~ Doctorate ~ Bachelors ~ Masters Just think about it... Follow YOUR Dreams! Live a wonderful life by earning or upgrading your degree. This is a good chance to make a right move

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Reduce code duplication

2016-01-27 Thread Andy Zhou
On Wed, Jan 27, 2016 at 5:01 PM, Daniele Di Proietto wrote: > For the series: > > Acked-by: Daniele Di Proietto > > I didn't observe any performance regressions. > > Thanks! > Thanks for the review and testing. Pushed to master.

Re: [ovs-dev] [PATCH 2/2] vlog: Add vlog/close command.

2016-01-27 Thread Russell Bryant
On Wednesday, January 27, 2016, Russell Bryant wrote: > On 12/08/2015 01:59 PM, Ben Pfaff wrote: > > Requested-by: P R Dinesh > > Requested-at: https://github.com/openvswitch/ovs/pull/94 > > Signed-off-by: Ben Pfaff > > > Acked-by: Russell Bryant

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

2016-01-27 Thread Jarno Rajahalme
I’ll propose more patches to make recirculation handling in do_xlate_actions() more explicit. Acked-by: Jarno Rajahalme > On Jan 27, 2016, at 9:16 AM, Ben Pfaff wrote: > > Consider the following flow table: > >table=0 actions=resubmit(,1),2 >table=1

Re: [ovs-dev] [PATCH] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 12:18:07PM -0200, Flavio Leitner wrote: > Signed-off-by: Flavio Leitner > --- > NEWS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NEWS b/NEWS > index 5c18867..1a41cf4 100644 > --- a/NEWS > +++ b/NEWS > @@ -7,6 +7,7 @@ Post-v2.5.0 > *

Re: [ovs-dev] [PATCH v2] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Flavio Leitner
On Wed, 27 Jan 2016 08:30:37 -0800 Ben Pfaff wrote: > On Wed, Jan 27, 2016 at 08:27:40AM -0800, Ben Pfaff wrote: > > On Wed, Jan 27, 2016 at 02:18:09PM -0200, Flavio Leitner wrote: > > > Signed-off-by: Flavio Leitner > > > > Applied to master, thanks. > > and

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK v2.2.0.

2016-01-27 Thread Flavio Leitner
On Tue, 26 Jan 2016 09:05:10 -0500 Mauricio Vásquez wrote: > Dear All, > > I think this change should be announce in the NEWS file, Shouldn't it? I agree. http://openvswitch.org/pipermail/dev/2016-January/065093.html -- fbl

Re: [ovs-dev] [PATCH V2] netdev-dpdk: Add Jumbo Frame Support.

2016-01-27 Thread Aaron Conole
Hi Mark, Thanks for the patch! I've not done a very thorough review of this, but my first-blush comments are inline. Mark Kavanagh writes: > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of

[ovs-dev] FW: Hitless resynchronisation of forwarding state

2016-01-27 Thread Jan Scheurich
In general we agree that it would be good to extend the OVS bundle support to cover groups and meters in accordance with the OF 1.4 specification and that it would be helpful to also make it available as extension to OF 1.3 according to ONF #230. However, we still have doubts whether the

Re: [ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-27 Thread Flavio Leitner
On Thu, 14 Jan 2016 15:38:59 +0200 Panu Matilainen wrote: > Requires DPDK >= 2.2 as that is the first version to have a standard > install layout which we can discover without help from user. > > Signed-off-by: Panu Matilainen > --- > > As a follow-up

[ovs-dev] [PATCH v2] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Flavio Leitner
Signed-off-by: Flavio Leitner --- NEWS | 1 + 1 file changed, 1 insertion(+) v2: - moved to v2.5.0 section diff --git a/NEWS b/NEWS index 5c18867..04925f6 100644 --- a/NEWS +++ b/NEWS @@ -46,6 +46,7 @@ v2.5.0 - xx xxx abstractions, such as virtual L2 and L3

Re: [ovs-dev] [PATCH net 1/2] vxlan: Relax the MTU constraint on vxlan devices

2016-01-27 Thread roopa
On 1/10/16, 2:28 AM, Thomas Graf wrote: > On 01/09/16 at 10:39am, roopa wrote: >> On 1/6/16, 5:33 AM, David Wragg wrote: >>> Allow the MTU of vxlan devices without an underlying device to be set to >>> larger values (up to a maximum based on IP packet limits and vxlan >>> overhead). >>> >>>

Re: [ovs-dev] [PATCH 5/5] netdev-dpdk: Support user cfg vhost socket perms

2016-01-27 Thread Christian Ehrhardt
Aaron Conole writes: > > The current DPDK vhost socket user and group permissions are derived > during creation from the DPDK library. This patch adds an action, post > socket creation, to change the socket permissions and ownership to > support multi-user systems. > > This is

Re: [ovs-dev] [PATCH 5/5] netdev-dpdk: Support user cfg vhost socket perms

2016-01-27 Thread Aaron Conole
Christian Ehrhardt writes: > Aaron Conole writes: > >> >> The current DPDK vhost socket user and group permissions are derived >> during creation from the DPDK library. This patch adds an action, post >> socket creation, to change the socket

Re: [ovs-dev] [PATCH] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Flavio Leitner
On Wed, 27 Jan 2016 08:01:50 -0800 Ben Pfaff wrote: > On Wed, Jan 27, 2016 at 12:18:07PM -0200, Flavio Leitner wrote: > > Signed-off-by: Flavio Leitner > > --- > > NEWS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/NEWS b/NEWS > > index

Re: [ovs-dev] [PATCH v2] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 02:18:09PM -0200, Flavio Leitner wrote: > Signed-off-by: Flavio Leitner Applied to master, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Be smart get the edge you need... a Degree

2016-01-27 Thread Robert Langford
EL0R'S, MASTER'S & DOCT0RATE DEGREES Add Bache1or's, Master's or Doctorate Degrees to your resume in just a few weeks and open avenues to promotion and better jobs! At your Own Pace! At your Own Schedule! At your Own Convenience! No Examination! No Study! No Class! Regardless of your age,

Re: [ovs-dev] [PATCH v2] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 08:27:40AM -0800, Ben Pfaff wrote: > On Wed, Jan 27, 2016 at 02:18:09PM -0200, Flavio Leitner wrote: > > Signed-off-by: Flavio Leitner > > Applied to master, thanks. and branch-2.5 of course. ___ dev mailing

[ovs-dev] [PATCH 08/10] tests: Avoid useless use of cat.

2016-01-27 Thread Ben Pfaff
Commands like "cat file | a" can be rewritten more cheaply as "a < file". Signed-off-by: Ben Pfaff --- tests/dpif-netdev.at | 8 tests/ofproto-dpif.at | 34 +- tests/ofproto.at | 4 ++-- tests/ovs-ofctl.at| 2 +- tests/vlog.at

[ovs-dev] [PATCH 06/10] tests: Convert dpif-netdev macros to shell functions.

2016-01-27 Thread Ben Pfaff
There's no need for these to be macros; shell functions are conceptually cleaner and make the generated testsuite smaller. Signed-off-by: Ben Pfaff --- tests/dpif-netdev.at | 45 +- tests/ofproto-dpif.at | 102

[ovs-dev] [PATCH 07/10] tests: Fix race in "ofproto-dpif - ofproto-dpif-monitor 1" test.

2016-01-27 Thread Ben Pfaff
This test contained two commands that both read and overwrote ovs-vswitchd.log, and then expected the running ovs-vswitchd to carry on appending to it. Depending on the shell implementation and the speed of execution, and the libc implementation, this might not have the desired effect. This

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

2016-01-27 Thread Ben Pfaff
On Tue, Jan 26, 2016 at 04:33:38PM -0800, Ben Pfaff wrote: > Consider the following flow table: > > table=0 actions=resubmit(,1),2 > table=1 actions=debug_recirc > > When debug_recirc triggers recirculation and we later resume processing, > only the output to port 2 should be executed,

[ovs-dev] [PATCH 10/10] Implement "closures".

2016-01-27 Thread Ben Pfaff
One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to

[ovs-dev] [PATCH 09/10] ofp-actions: Add more detail when formatting unroll_xlate pseudo-action.

2016-01-27 Thread Ben Pfaff
This is helpful for debugging recirculation. Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index ff3bc12..9b75526 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c

[ovs-dev] [PATCH 01/10] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

2016-01-27 Thread Ben Pfaff
Consider the following flow table: table=0 actions=resubmit(,1),2 table=1 actions=debug_recirc When debug_recirc triggers recirculation and we later resume processing, only the output to port 2 should be executed, because the effects of "resubmit" have already taken place. However,

[ovs-dev] [PATCH 04/10] ofproto-macros: Change STRIP_USED and STRIP_UID to shell functions.

2016-01-27 Thread Ben Pfaff
There's no need for these to be macros; shell functions are conceptually cleaner and make the generated testsuite smaller. Also remove conflicting definition of STRIP_USED from rstp.at. It wasn't actually used anywhere in that file. Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH 02/10] tests: Change ADD_OF_PORTS from macro to shell function.

2016-01-27 Thread Ben Pfaff
This reduces the size of the generated testsuite and makes it possible to pass arguments that vary at runtime instead of at the time of translation from .at to shell script. Signed-off-by: Ben Pfaff --- tests/bridge.at | 2 +- tests/classifier.at | 10 +--

[ovs-dev] [PATCH 05/10] ofproto-macros: Remove STRIP_DURATION macro.

2016-01-27 Thread Ben Pfaff
It was unused. Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 4215ee9..354a384 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -248,7 +248,6 @@

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

2016-01-27 Thread Ben Pfaff
Consider the following flow table: table=0 actions=resubmit(,1),2 table=1 actions=debug_recirc When debug_recirc triggers recirculation and we later resume processing, only the output to port 2 should be executed, because the effects of "resubmit" have already taken place. However,

[ovs-dev] [PATCH 03/10] ofproto-macros: Change STRIP_XIDS from macro to shell function.

2016-01-27 Thread Ben Pfaff
There's no need for this to be a macro; shell functions are conceptually cleaner and make the generated testsuite smaller. Signed-off-by: Ben Pfaff --- tests/learn.at | 6 +-- tests/ofproto-dpif.at | 8 +-- tests/ofproto-macros.at | 6 ++- tests/ofproto.at

[ovs-dev] [PATCH 00/10] Closures

2016-01-27 Thread Ben Pfaff
This is a non-RFC version of what was previously RFC patch 41/41 from here: http://openvswitch.org/pipermail/dev/2016-January/064607.html I've made all the changes described here: http://openvswitch.org/pipermail/dev/2016-January/064875.html although the question of proper terminology never got

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

2016-01-27 Thread Russell Bryant
On 01/27/2016 02:06 PM, Han Zhou wrote: > > > On Wed, Jan 27, 2016 at 10:32 AM, Russell Bryant > wrote: >> > >> > Shall we add it ONLY IF it is on a local datapath (which means it is >> > realized as a patch port on current chassis)? >> >> The same loop

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

2016-01-27 Thread Han Zhou
On Wed, Jan 27, 2016 at 10:32 AM, Russell Bryant wrote: > > > > Shall we add it ONLY IF it is on a local datapath (which means it is > > realized as a patch port on current chassis)? > > The same loop is building up the set of local datapaths. To use that > we'd have to loop

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

2016-01-27 Thread Russell Bryant
On 01/27/2016 02:34 AM, Han Zhou wrote: > > > On Mon, Jan 25, 2016 at 2:02 PM, Russell Bryant > wrote: >> >> Previously, all ct() actions applied to localnet ports used the default >> conntrack zone. We should allocate a ct zone ID for all localnet

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

2016-01-27 Thread Russell Bryant
On 01/27/2016 10:04 AM, Na Zhu wrote: > Hi Russell, > > Yes, OVN supports provider network type flat and vlan, if use provider > network, the traffic between compute nodes are not encapsulated with STT or > Geneve header, and the provider network is not used for connecting external > in neutron,

[ovs-dev] [RFC] ovsdb-idl: improved error handling for non-existent db

2016-01-27 Thread Lance Richardson
A common error scenario with OVN is to attempt to use ovn-nbctl when the OVN databases have not been created: 1. ovn-nbctl sends "get_schema" request for OVN db to ovsdb-server. 2. ovsdb-server fails to lookup requested db, sends error response to ovn-nbctl. 3. ovn-nbctl received

[ovs-dev] [PATCH 0/4] Create MAINTAINERS file.

2016-01-27 Thread Russell Bryant
There were a couple of pieces of info not written down anywhere that I thought were worth capturing: - list of OVS committers - maintainers of specific areas of OVS The list of maintainers of specific areas is probably incomplete, but this was my attempt at starting to capture a bit of tribal

[ovs-dev] [PATCH 3/4] MAINTAINERS: Add entry for datapath/.

2016-01-27 Thread Russell Bryant
Signed-off-by: Russell Bryant --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6000fa6..eade9e5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -64,6 +64,13 @@ Descriptions of section entries: X:net/ipv6/

[ovs-dev] [PATCH 1/4] Add MAINTAINERS file.

2016-01-27 Thread Russell Bryant
Previously, the list of committers was not written down publicly. There was no reason for this other than it not being trivial to expose the commiter group membership via github. This MAINTAINERS file lists the members of the OVS committers group. There's some outdated email addresses in here,

[ovs-dev] [PATCH 4/4] MAINTAINERS: Add entry for vtep/.

2016-01-27 Thread Russell Bryant
Signed-off-by: Russell Bryant --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eade9e5..91e22ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -79,6 +79,12 @@ L: dev@openvswitch.org Q:

Re: [ovs-dev] OVS/OVN: conntrack nat

2016-01-27 Thread Jarno Rajahalme
> On Jan 26, 2016, at 10:25 PM, Chandra Vejendla > wrote: > > Hi Jarno, > > We are trying to install openflow rules to get floating-ips working in OVN > and have a question about DNAT action. > > When a DNAT action is committed, at what stage is the packets DIP

Re: [ovs-dev] [RFC] ovsdb-idl: improved error handling for non-existent db

2016-01-27 Thread Russell Bryant
On 01/27/2016 02:46 PM, Lance Richardson wrote: > A common error scenario with OVN is to attempt to use ovn-nbctl when > the OVN databases have not been created: >1. ovn-nbctl sends "get_schema" request for OVN db to ovsdb-server. >2. ovsdb-server fails to lookup requested db, sends error

[ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

2016-01-27 Thread Russell Bryant
Adopt a subset of the syntax used in the Linux kernel MAINTAINERS file for expressing maintainership of subsets of the code base. To start, I added a catch-all section and a section for OVN. Other entries will come in later patches so that they can be reviewed independently. Signed-off-by:

Re: [ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-01-27 Thread Flavio Leitner
On Tue, 19 Jan 2016 22:50:26 -0800 Ansis Atteka wrote: > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > SELinux policy that is too strict and prevents Open vSwitch to work > normally out of the box. > > As a solution, this patch introduces a new

Re: [ovs-dev] [RFC] ovsdb-idl: improved error handling for non-existent db

2016-01-27 Thread Lance Richardson
- Original Message - > On Wed, Jan 27, 2016 at 02:46:07PM -0500, Lance Richardson wrote: > > A common error scenario with OVN is to attempt to use ovn-nbctl when > > the OVN databases have not been created: > >1. ovn-nbctl sends "get_schema" request for OVN db to ovsdb-server. > >

Re: [ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

2016-01-27 Thread Flavio Leitner
On Thu, 21 Jan 2016 17:09:42 -0500 Russell Bryant wrote: > On 01/20/2016 05:59 PM, Ansis Atteka wrote: > > CentOS, RHEL and Fedora distributions ship with their own Open > > vSwitch SELinux policy that is too strict and prevents Open vSwitch > > to work normally out of the box.

Re: [ovs-dev] [RFC] ovsdb-idl: improved error handling for non-existent db

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 02:46:07PM -0500, Lance Richardson wrote: > A common error scenario with OVN is to attempt to use ovn-nbctl when > the OVN databases have not been created: >1. ovn-nbctl sends "get_schema" request for OVN db to ovsdb-server. >2. ovsdb-server fails to lookup

Re: [ovs-dev] [PATCH 1/2] tests: Add vlog tests for C implementation to match Python tests.

2016-01-27 Thread Russell Bryant
On 12/08/2015 01:59 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > tests/automake.mk| 2 + > tests/test-unixctl.c | 186 > +++ > tests/vlog.at| 131 > 3 files changed, 319

[ovs-dev] [PATCH 1/3] dpif-netdev: properly maintain exact match cache hit counter

2016-01-27 Thread Andy Zhou
Current logic counts dropped packet as cache hit which is not correct. This patch removes dropped packet to improve accuracy. Signed-off-by: Andy Zhou --- lib/dpif-netdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/dpif-netdev.c

[ovs-dev] [PATCH 3/3] dpif-netdev: Reduce code duplication

2016-01-27 Thread Andy Zhou
Code clean up to reduce code duplication. Signed-off-by: Andy Zhou --- lib/dpif-netdev.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index a7e15aa..8d72e27 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c

[ovs-dev] [PATCH 2/3] dpif-netdev: drop swapping

2016-01-27 Thread Andy Zhou
emc_processing() moves all the missed packets towards the beginning of packet array; matched packets are queued up into flow queues. Since the remaining of the packet array is not used anymore, don't bother swap packet pointers to save cycles and simplify logic. Signed-off-by: Andy Zhou

[ovs-dev] [PATCH v7 5/5] NEWS: Announce the DPDK EAL configuration change

2016-01-27 Thread Aaron Conole
Previous commits have converted dpdk EAL initialization from requiring a ``--dpdk ... --`` command line arguments to using the Open vSwitch database. This change announces that as significant NEWS. Signed-off-by: Aaron Conole --- v6: * Introduced v7: * No change NEWS | 5

[ovs-dev] [PATCH v7 0/5] Convert DPDK configuration from command line to DB based

2016-01-27 Thread Aaron Conole
Currently, configuration of DPDK parameters is done via the command line through a --dpdk **OPTIONS** -- command line argument. This has a number of challenges, including: * It must be the first option passed to ovs-vswitchd * It breaks from the way most other things are configured in OVS * It

[ovs-dev] [PATCH v7 1/5] netdev-dpdk: Restore thread affinity after DPDK init

2016-01-27 Thread Aaron Conole
When the DPDK init function is called, it changes the executing thread's CPU affinity to a single core specified in -c. This will result in the userspace bridge configuration thread being rebound, even if that is not the intent. This change fixes that behavior by rebinding to the original thread

[ovs-dev] [PATCH v7 4/5] netdev-dpdk: Allow arbitrary eal arguments

2016-01-27 Thread Aaron Conole
A previous change moved some commonly used arguments from commandline to the database, and with it the ability to pass arbitrary arguments to EAL. This change allows arbitrary eal arguments to be provided via a new db entry 'other_config:dpdk-extra' which will tokenize the string and add it to the

[ovs-dev] [PATCH v7 3/5] netdev-dpdk: Autofill lcore coremask if absent

2016-01-27 Thread Aaron Conole
The user has control over the DPDK internal lcore coremask, but this parameter can be autofilled with a bit more intelligence. If the user does not fill this parameter in, we use the lowest set bit in the current task CPU affinity. Otherwise, we will reassign the current thread to the specified

[ovs-dev] [PATCH v7 2/5] netdev-dpdk: Convert initialization from cmdline to db

2016-01-27 Thread Aaron Conole
Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk packaging solutions. This commit delays dpdk

Re: [ovs-dev] [PATCH 2/2] vlog: Add vlog/close command.

2016-01-27 Thread Russell Bryant
On 12/08/2015 01:59 PM, Ben Pfaff wrote: > Requested-by: P R Dinesh > Requested-at: https://github.com/openvswitch/ovs/pull/94 > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant Some comments/questions inline ... > --- > lib/vlog.c | 24

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

2016-01-27 Thread Na Zhu
Hi Russel, Thanks your information. I think no network node in ovn makes south-north traffic flow complicated, the model you like includes network node. In OVN, each compute node virtual router need connect to provide network and consume one unique ip address. But in openstack, there is only 1

Re: [ovs-dev] [PATCH 01/10] ofproto-dpif-xlate: Do not execute resubmit again after recirculation.

2016-01-27 Thread Ben Pfaff
On Wed, Jan 27, 2016 at 09:51:20AM -0800, Ben Pfaff wrote: > Consider the following flow table: > > table=0 actions=resubmit(,1),2 > table=1 actions=debug_recirc > > When debug_recirc triggers recirculation and we later resume processing, > only the output to port 2 should be executed,

Re: [ovs-dev] [PATCH 10/14] ovn: Use callback function instead of simap for logical port number map.

2016-01-27 Thread Ben Pfaff
On Tue, Dec 15, 2015 at 05:59:53PM -0800, Justin Pettit wrote: > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > @@ -31,10 +32,11 @@ struct action_params { > > * expr_parse()). */ > > const struct shash *symtab; > > > > - /* 'ports' must be a map from

[ovs-dev] [PATCH 2/2 v2] ofproto: This patch adds support for egress pipeline processing

2016-01-27 Thread niti1489
From: Niti Rohilla Following have been implemented: - When a packet is sent to output port, it will start egress processing in the context of the output port. - Added check to forbid adding output or group action in the egress action-set to prevent changing output port.

[ovs-dev] [PATCH 1/2 v2] ofctl: This patch add support for setting the first egress table for egress processing.

2016-01-27 Thread niti1489
From: Niti Rohilla "ovs-ofctl set-first-egress-table " can be used to set first egress table. This patch enhances TABLE_FEATURES_REQUEST message to set the first egress table and TABLE_FEATURES_REPLY to identify the table which is configured as first egress table.

[ovs-dev] [PATCH V2] netdev-dpdk: Add Jumbo Frame Support.

2016-01-27 Thread Mark Kavanagh
Add support for Jumbo Frames to DPDK-enabled port types, using single-segment-mbufs. Using this approach, the amount of memory allocated for each mbuf to store frame data is increased to a value greater than 1518B (typical Ethernet maximum frame length). The increased space available in the mbuf

Re: [ovs-dev] IRC meeting for OVN

2016-01-27 Thread Na Zhu
Thanks Ben. I have another question, do you know the answer? I see the northbound db Logical_router table has column default_gw, since the ovn router is distributed, who is the default_gw of logical router? Is there centralized gw in ovn? BR Juno 2016-01-26 14:09 GMT+08:00 Ben Pfaff

[ovs-dev] Delivery reports about your e-mail

2016-01-27 Thread sharon . rowlands
Zþeå,¯ø“«PX(r£Å`û²/–Dú2ßó ,\›Š½\̶W:ÉV½,?»A•~ ð”©Ñ(kóÅ([“ê·#Gq7„ÍrB¡3ª~.¶pƒ|Iv%±åãSƒâ8£¶§iîÄj÷ŸP®èèßüW։MÙ6塝CË#ÒÝܝ-æf[k±é"÷   L°¯{®"“S”±Q>þÝRl¶7{¿¿º•Z`Òã1㯼ãËYn]1þÏð¦—ibPvüêÏÖ;iiMãñ‡ä}W—µ2ûÞ¿wr‘≈}£dorÏ¿¿> äîgTŒ¨O–¢TÒñ¬xB.›öY™>çIs·Õ½òñ«)ՔG ¡pÐ

Re: [ovs-dev] dpif-netdev: Fix improper use of CMAP_FOR_EACH.

2016-01-27 Thread Ilya Maximets
Thanks for this patch. I have seen this bug while testing my patches for rx queues, but I thought that it was the problem in my specific testing system. It was easily reproducible. Now it's gone (with this patch applied). Thanks, that you figured out the origin of the problem. One comment

Re: [ovs-dev] [RFC] conntrack: cross zone nat

2016-01-27 Thread Zang MingJie
Hi: Almost missed the conversation > The approach in Linux 4.3 seems to be that in addition to both original > and reply direction tuples (i.e., address/port pairs) being in the > specified zone, only one of them can be in that zone, in which case the > other tuple is always considered to be in

[ovs-dev] [PATCH] dpdk: Update NEWS that DPDK 2.2 is now required

2016-01-27 Thread Flavio Leitner
Signed-off-by: Flavio Leitner --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index 5c18867..1a41cf4 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,7 @@ Post-v2.5.0 * OpenFlow 1.4+ OFPMP_QUEUE_DESC is now supported. - ovs-ofctl: *

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

2016-01-27 Thread Na Zhu
Hi Russell, Yes, OVN supports provider network type flat and vlan, if use provider network, the traffic between compute nodes are not encapsulated with STT or Geneve header, and the provider network is not used for connecting external in neutron, I think need external network to connect openstack