On Sat, Aug 06, 2016 at 05:46:30PM -0500, Ryan Moats wrote:
> Allow the python IDL to use mutate operations more freely
> by mimicing the partial map and partial set operations now
> available in the C IDL.
>
> Unit tests for both of these types of operations are included.
> They are not carbon co
On Sun, Aug 14, 2016 at 06:43:06PM -0500, Ryan Moats wrote:
> Commit f1ab6e06 ("Add/user partial set updates.) incorrectly
> did not include HPE attribution for derived files
> lib/ovsdb-set-op.[ch]. Add the attribution to correct this.
>
> Signed-off-by: Ryan Moats
Wow, that was fast.
Applied
On Sat, Aug 06, 2016 at 05:46:29PM -0500, Ryan Moats wrote:
> This patchset mimics the changes introduced in
>
> f199df26 (ovsdb-idl: Add partial map updates functionality.)
> 010fe7ae (ovsdb-idlc.in: Autogenerate partial map updates functions.)
> 7251075c (tests: Add test for partial map up
that test the logical network
implementation (using tracing) and ones that test physical/logical
translation.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
include/openvswitch/meta-flow.h |8 +
include/ovn/actions.h |8 +
lib/automake.mk |1 +
lib/daem
On Sat, Aug 13, 2016 at 09:30:22AM -0700, Ben Pfaff wrote:
> The exciting part is the final commit. I recommend reading the
> documentation for the new program.
>
> Also available at https://github.com/blp/ovs-reviews/tree/ovnacts
>
> v1->v2: First 9 commits applied. Reb
An upcoming commit will need to evaluate individual expressions outside the
context of a classifier. test-ovn already had a function to do this but it
wasn't general-purpose, so this commit makes a general-purpose version and
adopts it for use in test-ovn as well.
Signed-off-by: Ben Pfaff
This allows "ovstest test-ovn evaluate-expr" work with arbitrary
microflows rather than just a few restricted variables, but the main point
is to enable the upcoming "ovn-trace" utility to accept arbitrary
microflows in a format that seems reasonable for OVN.
Signed-off-by:
This makes it easier to debug based on the southbound database without
looking at the northbound representation. This commit adds the name
to "ovn-sbctl dump-flows" output and it will be even more useful in
an upcoming commit.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
ovn/
The actions and expr modules had each developed their own error handling
code that were very similar. Upcoming code needs similar error handling,
so rather than duplicating it again, integrate it into the lexer itself.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
include/ovn/actions.h
v4: First commit applied. Rebased.
v4->v5: Rebased (nontrivial because of new action put_dhcpv6_opts).
Ben Pfaff (8):
ovn: Rewrite logical action parsing and encoding library.
ovn-util: Add common functions for the default NB and SB databases.
lex: Integrate error handling into struct lexer.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
ovn/controller-vtep/ovn-controller-vtep.c | 5 +++--
ovn/lib/ovn-util.c| 27 +
ovn/lib/ovn-util.h| 4
ovn/northd/ovn-northd.c | 27
flaw, and updates the callers. An upcoming commit will introduce a
new user of the function.
This commit also introduces a related function mf_subfield_swap() to swap
the contents of subfields. An upcoming commit will introduce the first
user.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
On Fri, Aug 05, 2016 at 09:36:39AM +0530, Numan Siddique wrote:
> OVN implements native DHCPv6. DHCPv6 options are stored
> in the 'DHCP_Options' NB table and logical ports refer to this
> table to configure the DHCPv6 options.
>
> For each logical port configured with DHCPv6 Options following flo
On Fri, Aug 05, 2016 at 09:36:07AM +0530, Numan Siddique wrote:
> This patch adds a new OVN action 'put_dhcpv6_opts' to support native
> DHCPv6 in OVN.
>
> ovn-controller parses this action and adds a NXT_PACKET_IN2
> OF flow with 'pause' flag set and the DHCPv6 options stored in
> 'userdata' fiel
Until now, this code did not strip "" or '' from variable assignments in
os-release. This fixes the problem.
CC: Matt Mulsow
Fixes: c60d6b096436 ("ovs-ctl: support populating system info from
/etc/os-release")
Signed-off-by: Ben Pfaff
---
I have not tested th
On Sat, Aug 13, 2016 at 11:12:18PM -0700, Jesse Gross wrote:
> I think the code is reasonably robust at this point and certainly it
> fixes a number of existing bugs. However, the truth is that I wasn't
> really all that happy about it. It took a fairly long time to work
> through the various corne
On Sun, Aug 14, 2016 at 12:49:00PM +0300, Ori Shoshan wrote:
> Added a few examples and clarifications to the man page to explain points I
> had difficulty figuring out without reading code/tests.
>
> Signed-off-by: Ori Shoshan
Thanks a lot, applied to master.
__
the number of
flows.
"Linear in the number of unique wildcard patterns" is quite different
from "linear in the number of flows".
> 2016. 8. 14. 13:09에 "Ben Pfaff" 님이 작성:
>
> > On Sun, Aug 14, 2016 at 08:58:31AM +0900, Nam Bong Ha wrote:
> >
On Thu, Aug 04, 2016 at 05:55:34PM +, Ryan Moats wrote:
> ovs-dpctl and ovs-ofctl lack a dry-run option. Add it
> and the necessary scaffolding to each.
>
> Signed-off-by: Ryan Moats
The point behind a --dry-run option is supposed to be that it does
everything up to but not actually includi
On Sat, Aug 06, 2016 at 04:44:13PM -0500, Ryan Moats wrote:
> "dev" wrote on 08/04/2016 06:50:03 AM:
>
> > From: nickcooper-zhangtonghao
> > To: dev@openvswitch.org
> > Cc: nickcooper-zhangtonghao
> > Date: 08/04/2016 06:50 AM
> > Subject: [ovs-dev] [PATCH] ovn-controller:improve the ofctrl_run
On Thu, Aug 04, 2016 at 04:50:03AM -0700, nickcooper-zhangtonghao wrote:
> Before calling the function "ofctrl_run" and "pinctrl_run",
> the "br-int"" has been checked. Remove the conditional statements in
> the function may make the code clearer.
>
> Signed-off-by: nickcooper-zhangtonghao
>
Ap
ialized in this
function [-Werror=maybe-uninitialized]
error = ovsdb_error("not allowed",
^
cc1: all warnings being treated as errors
If you fix those things then:
Acked-by: Ben Pfaff
Thanks!
Ben
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Aug 03, 2016 at 04:57:04PM -0700, Andy Zhou wrote:
> Found by inspection
>
> Signed-off-by: Andy Zhou
It's not obvious from the context that this can cause a problem, but I
think it's safe in any case.
Acked-by: Ben Pfaff
On Wed, Aug 03, 2016 at 04:57:03PM -0700, Andy Zhou wrote:
> Pollblock requires the run() function to be paired with a wait()
poll_block(), I guess.
> function. Add one for replication.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
t should be servicing the client, backup
> server is the server that boots with the --sync-from option.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Aug 03, 2016 at 07:07:38PM +, Ryan Moats wrote:
> When setting a where clause, if the timeout is set to a value of 0,
> the clause is tested once and if it fails, a message of '"wait" timed
> out' is returned. This can be misleading because there wasn't any
> real time, so change the m
On Fri, Jul 29, 2016 at 05:28:26PM +, Mickey Spiegel wrote:
> Could you expand on why priorities in a single stage aren't enough to
> satisfy the use case?
>
>
> If two features are configured independently with a mix of
> prioritized allow and drop rules, then with a single stage, a
> new se
On Tue, Aug 09, 2016 at 09:14:15AM +0300, Liran Schour wrote:
> Do we plan to include the ovn conditional monitoring usage in 2.6.0?
> Performance evaluation shows up to 75% reduction of computation at the
> ovn-controller and also a reduction of computation at the server side,
> depending at the
.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl-provider.h | 7 ++-
lib/ovsdb-idl.c | 112 ---
lib/ovsdb-idl.h | 26 +--
3 files changed, 94 insertions(+), 51 deletions(-)
diff --git a/lib/ovsdb-idl-provider.h b/lib/ovsdb-idl
On Tue, Aug 02, 2016 at 04:38:00PM +0300, Liran Schour wrote:
> Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group
> MAC_Binding tables. As a result ovn-controller will be notified only about
> records belongs to a datapath that is being served by this hypervisor.
>
> Performance
On Sun, Aug 14, 2016 at 08:58:31AM +0900, Nam Bong Ha wrote:
> Has the tuple space search been used from the early version?
Yes.
> In several thesis I read, it says they do linear search.
>
> Isn't there any openswitch version that uses linear search?
No.
What theses are you reading?
_
Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call
ovs_list_remove() on the clause's 'node' member, but it should only be
called once.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.
The function always allocated a clause but didn't use it if it was
going to be a duplicate.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index ad0d1e1..7d3d328 100644
--- a/lib/ovsdb-
On Tue, Aug 02, 2016 at 04:37:59PM +0300, Liran Schour wrote:
> Call for poll_immediate_wake() when condition is changed.
>
> Signed-off-by: Liran Schour
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/
ested that should act to make some of the OVN tests
more reliable. Maybe one of them will have some positive effect. This
one in particular comes to mind.
commit 207d29e13d103cdae911ecf3863c7493d89a5a48
Author: Ben Pfaff
Date: Tue Jul 26 23:55:25 2016 -0700
ovsdb-idl: Wake up ovsdb_idl_l
On Fri, Aug 12, 2016 at 12:21:28PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam
>
> ovn-northd sets 'ip.dscp' to the DSCP value
>
> Signed-off-by: Babu Shanmugam
Thanks for the revision (and for adding a test)!
This comment in ovn-northd seems like an incomplete thought (and what'
On Fri, Aug 12, 2016 at 12:21:27PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam
>
> ovn-northd processes the list of Port_Bindings and hashes the list of
> queues per chassis. When it finds a port with qos_parameters and without
> a queue_id, it allocates a free queue for the chassis
The actions and expr modules had each developed their own error handling
code that were very similar. Upcoming code needs similar error handling,
so rather than duplicating it again, integrate it into the lexer itself.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
include/ovn/actions.h
that test the logical network
implementation (using tracing) and ones that test physical/logical
translation.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
include/openvswitch/meta-flow.h |8 +
include/ovn/actions.h |8 +
lib/automake.mk |1 +
lib/daem
This allows "ovstest test-ovn evaluate-expr" work with arbitrary
microflows rather than just a few restricted variables, but the main point
is to enable the upcoming "ovn-trace" utility to accept arbitrary
microflows in a format that seems reasonable for OVN.
Signed-off-by:
An upcoming commit will need to evaluate individual expressions outside the
context of a classifier. test-ovn already had a function to do this but it
wasn't general-purpose, so this commit makes a general-purpose version and
adopts it for use in test-ovn as well.
Signed-off-by: Ben Pfaff
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
ovn/controller-vtep/ovn-controller-vtep.c | 5 +++--
ovn/lib/ovn-util.c| 27 +
ovn/lib/ovn-util.h| 4
ovn/northd/ovn-northd.c | 27
This makes it easier to debug based on the southbound database without
looking at the northbound representation. This commit adds the name
to "ovn-sbctl dump-flows" output and it will be even more useful in
an upcoming commit.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
---
ovn/
v4: First commit applied. Rebased.
Ben Pfaff (8):
ovn: Rewrite logical action parsing and encoding library.
ovn-util: Add common functions for the default NB and SB databases.
lex: Integrate error handling into struct lexer.
meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().
o
flaw, and updates the callers. An upcoming commit will introduce a
new user of the function.
This commit also introduces a related function mf_subfield_swap() to swap
the contents of subfields. An upcoming commit will introduce the first
user.
Signed-off-by: Ben Pfaff
Acked-by: Ryan Moats
On Fri, Aug 12, 2016 at 04:30:01PM -0700, Justin Pettit wrote:
>
> > On Aug 8, 2016, at 11:21 AM, Ben Pfaff wrote:
> >
> > This makes it more convenient to access a 128-bit value stored in an
> > mf_subvalue.
> >
> > Signed-off-by: Ben Pfaff
>
>
No problem, stuff happens.
On Fri, Aug 12, 2016 at 05:58:51PM -0700, Daniele Di Proietto wrote:
> I just applied the same fix, sorry for breaking it
>
> Daniele
>
> 2016-08-12 17:52 GMT-07:00 Ben Pfaff :
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/dpif
On Sat, Jul 30, 2016 at 03:32:01PM +0530, Numan Siddique wrote:
> This patch reads the 'Bridge.datapath_type' column value of the integration
> bridge and 'Open_vSwitch.iface_types' column value and sets these in the
> external_ids:datapath-type and external_ids:iface-types of Chassis table.
>
> T
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index c1564bd..96504f5 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4911,7 +4911,7 @@ dpcls_create_subtable(struct dpcls *cls
irectory removal.
>
> I didn't want to really change this logic, as I'm not sure if there something
> else can be stored in this directory, but it was very tempting to remove
> everything just by:
> rm -rf "$(DESTDIR)$(bugtoolpluginsdir)/*"
>
> Br,
&
On Fri, Aug 12, 2016 at 02:47:09PM -0700, Ben Pfaff wrote:
> On Thu, Jul 28, 2016 at 05:12:04PM -0500, Ryan Moats wrote:
> >
> > Ben Pfaff wrote on 07/28/2016 04:23:57 PM:
> >
> > > From: Ben Pfaff
> > > To: Ryan Moats/Omaha/IBM@IBMUS
> > > Cc:
On Thu, Jul 28, 2016 at 05:12:04PM -0500, Ryan Moats wrote:
>
> Ben Pfaff wrote on 07/28/2016 04:23:57 PM:
>
> > From: Ben Pfaff
> > To: Ryan Moats/Omaha/IBM@IBMUS
> > Cc: dev@openvswitch.org
> > Date: 07/28/2016 04:24 PM
> > Subject: Re: [ovs-dev] [PATC
On Tue, Jul 26, 2016 at 02:51:08PM -0300, Flavio Leitner wrote:
> The current ifcfg file lacks support for OVS DPDK Bond.
>
> Reviewed-by: Aaron Conole
> Signed-off-by: Flavio Leitner
I have a feeling that no one was really comfortable with applying this.
It's not really a DPDK patch per se, so
On Thu, Jul 28, 2016 at 10:34:12AM +0800, nickcooper-zhangtonghao wrote:
>
> > On Jul 28, 2016, at 5:01 AM, Ben Pfaff wrote:
> >
> > On Mon, Jul 25, 2016 at 09:19:00AM -0700, nickcooper-zhangtonghao wrote:
> >> Deletion of a logical router port, which may be an oth
this.
The rationale about software versus hardware defaults might go into the
documentation or code somewhere, otherwise it'll probably be forgotten
over time.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
le hard
to follow encaps_run(). I had to study it. I'm still not entirely sure
I understand all of it.
Usually, your code is super-robust, so some of this is on faith:
Acked-by: Ben Pfaff
I'm appending some suggestions.
diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c
inde
On Fri, Aug 12, 2016 at 08:40:12PM +0900, Nam Bong Ha wrote:
> Is linear search a searching method for vswitchd flow table?
No. Read the NSDI paper:
http://openvswitch.org/support/papers/nsdi2015.pdf
___
dev mailing list
dev@openvswitch.org
http
1d45d5a9 ("ovn-controller: Change encaps_run to work incrementally.")
> Signed-off-by: Jesse Gross
Weird. Good catch.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Aug 11, 2016 at 09:53:50PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On Thu, Aug 11, 2016 at 01:00:21PM -0400, Aaron Conole wrote:
> >> Ben Pfaff writes:
> >> > Neither of those is a simple "return server->listen_fd;" function.
> to this translation error.
>
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Aug 04, 2016 at 02:58:38PM -0700, Joe Stringer wrote:
> To assist debugging pipelines when resubmit resource checks fail, print
> the base_flow from the translation context. This base flow can then be
> used from ofproto/trace to figure out which parts of the pipeline lead
> to this transla
On Thu, Aug 11, 2016 at 10:12:13AM -0500, Conner Herriges wrote:
> Ben Pfaff wrote on 08/10/2016 11:22:49 AM:
>
> > From: Ben Pfaff
> > To: Conner Herriges/US/IBM@IBM
> > Cc: dev@openvswitch.org
> > Date: 08/10/2016 11:23 AM
> > Subject: Re: [ovs-dev
On Thu, Aug 11, 2016 at 11:33:17AM -0500, Conner Herriges wrote:
> Monitoring is a valid option on POSIX based platforms. The monitor
> creates an additional process to monitor the ovsdb-server daemon. If
> the daemon dies due to a programming error, then the monitor process
> starts a new copy of
On Thu, Aug 11, 2016 at 10:08:12AM -0700, Ben Pfaff wrote:
> On Fri, Aug 05, 2016 at 03:25:47PM +0200, Christian Ehrhardt wrote:
> > Hi,
> > while checking latest master we found that there were several tests that
> > failed sometimes.
> > 15: bfd - bfd decay
> &
On Fri, Aug 05, 2016 at 03:25:47PM +0200, Christian Ehrhardt wrote:
> Hi,
> while checking latest master we found that there were several tests that
> failed sometimes.
> 15: bfd - bfd decay
> 1149: ofproto-dpif - in place modification (vlan)
> But one of them seems to reliably fail in i686 mode
On Thu, Aug 11, 2016 at 01:00:21PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
> > Neither of those is a simple "return server->listen_fd;" function. Any
> > chance that would be accepted? It would solve the problem just fine.
>
> I don't know, but
On Thu, Aug 11, 2016 at 07:59:10AM -0500, Ryan Moats wrote:
>
>
> "dev" wrote on 08/10/2016 11:14:27 PM:
>
> > From: Ben Pfaff
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff
> > Date: 08/10/2016 11:14 PM
> > Subject: [ovs-dev] [PATCH] ovs-bu
On Thu, Aug 11, 2016 at 11:33:59AM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On Mon, Aug 01, 2016 at 08:24:40AM -0400, Aaron Conole wrote:
> >> Aaron Conole writes:
> >>
> >> > Currently, when using Open vSwitch with DPDK and qemu guests
ot
do it? That's why I think that this is a reasonable change.
VMware-BZ: #1708786
Signed-off-by: Ben Pfaff
---
utilities/bugtool/ovs-bugtool.in | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtoo
On Mon, Aug 01, 2016 at 08:24:40AM -0400, Aaron Conole wrote:
> Aaron Conole writes:
>
> > Currently, when using Open vSwitch with DPDK and qemu guests, the
> > recommended
> > method for joining the guests is via the dpdkvhostuser interface. This
> > interface uses Unix Domain sockets to commun
On Wed, Aug 10, 2016 at 10:26:15PM +0200, Christian Svensson wrote:
> Hi,
>
> On Wed, Aug 10, 2016 at 6:15 PM, Ben Pfaff wrote:
>
> > This is how OVS works.
> >
>
> Only when specifically launched with --detach. It's not the binary default,
> which I feel
On Thu, Jul 28, 2016 at 10:17:41PM +, Ryan Moats wrote:
> With incremental processing of logical flows desired conntrack groups
> are not being persisted. This patch adds this capability, with the
> side effect of adding a ds_clone method that this capability leverages.
>
> Signed-off-by: Rya
On Sat, Aug 06, 2016 at 04:55:14AM +0800, Binbin Xu wrote:
> The function netdev_vport_get_dpif_port_strdup is not
> used anymore. So we can remove it now.
>
> Signed-off-by: Binbin Xu
Thanks, applied.
I don't plan to review patch 2.
___
dev mailing l
Why do all of these patches have the same title? It makes it difficult
to distinguish them. Please give them unique titles.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 09, 2016 at 12:50:31PM -0700, Andy Zhou wrote:
> Use ds_get_line() instead of hand rolling it. Rearrange the logic
> to removes some duplication.
>
> Signed-off-by: Andy Zhou
>
> ---
> v1->v2: rebase to current mast
On Wed, Aug 10, 2016 at 02:16:14PM +0300, Panu Matilainen wrote:
> On systemd-era hosts, OS name and version are available in sanitized
> format from /etc/os-release(5) without resorting to calling (and thus
> requiring) lsb_release. Support populating system-type and system-version
> from /etc/os-
On Wed, Aug 10, 2016 at 11:10:25AM -0500, Conner Herriges wrote:
> Monitoring is a valid option on POSIX based platforms. The monitor
> creates an additional process to monitor the ovsdb-server daemon. If
> the daemon dies due to a programming error, then the monitor process
> starts a new copy of
On Wed, Aug 10, 2016 at 05:27:09PM +0200, Christian Svensson wrote:
> Hi,
>
> As far as I understand, right now the daemonizing flow for an OVS process
> is:
>
> 1. Process calls daemonize_start to fork into a child if running in
> detached mode
> Parent waits until daemonize_complete is called
>
On Thu, Aug 11, 2016 at 12:25:58AM +0900, Nam Bong Ha wrote:
> Where does the flow table size of datapath defined in?
>
> I supposed it is related to MC_HASH_ENTRIES which is defined at 54th line
> in datapath/flow_table.c.
>
> Does the source defined in 271th line represents flow table size?
> (
On Tue, Aug 09, 2016 at 08:08:20AM +0800, nickcooper-zhangtonghao wrote:
> > +/* --detailed: Show a detailed, table-by-table trace. */
> > +static bool detailed;
> > +
> > +/* --summary: Show a trace that omits table information. */
> > +static bool summary;
> > +
> > +/* --minimal: Show a trace wi
On Mon, Aug 08, 2016 at 09:33:54PM -0500, Ryan Moats wrote:
> "dev" wrote on 08/08/2016 01:21:52 PM:
>
> > From: Ben Pfaff
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff
> > Date: 08/08/2016 01:23 PM
> > Subject: [ovs-dev] [PATCH v3 9/9] ovn-trace:
On Mon, Aug 08, 2016 at 10:05:03PM +0200, Christian Svensson wrote:
> On Mon, Aug 8, 2016 at 7:59 PM, Ben Pfaff wrote:
>
> > OK, let's add that then.
>
> While it's an alternative, I feel like going down that path is hasty and
> for my use case I will probab
On Mon, Aug 08, 2016 at 12:29:42PM -0500, Ryan Moats wrote:
> "dev" wrote on 08/08/2016 11:14:28 AM:
>
> > From: Ben Pfaff
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff
> > Date: 08/08/2016 11:17 AM
> > Subject: [ovs-dev] [PATCH v2 17/21] meta-
that test the logical network
implementation (using tracing) and ones that test physical/logical
translation.
Signed-off-by: Ben Pfaff
---
include/openvswitch/meta-flow.h |8 +
include/ovn/actions.h |8 +
lib/automake.mk |1 +
lib/daemon.xml
An upcoming commit will need to evaluate individual expressions outside the
context of a classifier. test-ovn already had a function to do this but it
wasn't general-purpose, so this commit makes a general-purpose version and
adopts it for use in test-ovn as well.
Signed-off-by: Ben
This allows "ovstest test-ovn evaluate-expr" work with arbitrary
microflows rather than just a few restricted variables, but the main point
is to enable the upcoming "ovn-trace" utility to accept arbitrary
microflows in a format that seems reasonable for OVN.
Sign
This makes it easier to debug based on the southbound database without
looking at the northbound representation. This commit adds the name
to "ovn-sbctl dump-flows" output and it will be even more useful in
an upcoming commit.
Signed-off-by: Ben Pfaff
---
ovn/northd/ovn-north
The actions and expr modules had each developed their own error handling
code that were very similar. Upcoming code needs similar error handling,
so rather than duplicating it again, integrate it into the lexer itself.
Signed-off-by: Ben Pfaff
---
include/ovn/actions.h | 5 +-
include/ovn
Signed-off-by: Ben Pfaff
---
ovn/controller-vtep/ovn-controller-vtep.c | 5 +++--
ovn/lib/ovn-util.c| 27 +
ovn/lib/ovn-util.h| 4
ovn/northd/ovn-northd.c | 27 -
ovn
flaw, and updates the callers. An upcoming commit will introduce a
new user of the function.
This commit also introduces a related function mf_subfield_swap() to swap
the contents of subfields. An upcoming commit will introduce the first
user.
Signed-off-by: Ben Pfaff
---
include/openvswitch
The exciting part is the final commit. I recommend reading the
documentation for the new program.
Also available at https://github.com/blp/ovs-reviews/tree/ovnacts
v1->v2: First 9 commits applied. Rebased.
v2->v3: First 12 commits applied. Fixed bad %-specifier in patch 2.
Ben Pf
This makes it more convenient to access a 128-bit value stored in an
mf_subvalue.
Signed-off-by: Ben Pfaff
---
include/openvswitch/meta-flow.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h
index aaf7da1..76d915c 100644
ernatives specific to vxlan.
>
> Thanks for confirming. Will there be any overhead in using 1 group for each
> tunnel in a scaled environment.
>
> Regards
> Kapil
>
> Thanks
> Kapil
>
> On 08-Aug-2016 9:54 PM, "Ben Pfaff" wrote:
>
> On Mon, Aug 08, 2016
On Mon, Aug 08, 2016 at 12:21:18PM -0500, Ryan Moats wrote:
> "dev" wrote on 08/08/2016 11:14:23 AM:
>
> > From: Ben Pfaff
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff
> > Date: 08/08/2016 11:16 AM
> > Subject: [ovs-dev] [PATCH v2 12/21] logi
On Mon, Aug 08, 2016 at 07:32:12PM +0200, Christian Svensson wrote:
> The alternative I'm looking for would be something like
> --unixctl=/run/openvswitch/my-daemon.ctl but that does not exist.
OK, let's add that then.
___
dev mailing list
dev@openvswitc
On Mon, Aug 08, 2016 at 12:12:53PM -0500, Ryan Moats wrote:
> "dev" wrote on 08/08/2016 11:14:21 AM:
>
> > From: Ben Pfaff
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff
> > Date: 08/08/2016 11:16 AM
> > Subject: [ovs-dev] [PATCH v2 10/21]
On Mon, Aug 08, 2016 at 10:49:21AM +0200, Christian Svensson wrote:
> As handling software via cgroups is more and more common, PID files are
> not always needed. This change adds --disable-pid-socket-path to
> ./configure to build OpenvSwitch without this PID section of the socket
> path. This off
On Mon, Aug 08, 2016 at 04:49:49PM +0530, Kapil Adhikesavalu wrote:
> Want to check if there is an alternate way to append a output port to the
> existing flow.
>
>
>
> For example,
>
>
>
> Existing flow:
>
> cookie=0x0, duration=14279.412s, table=0, n_packets=0, n_bytes=0,
> idle_age=14316,
On Mon, Aug 08, 2016 at 03:29:11PM +, Bodireddy, Bhanuprakash wrote:
> >It seems to me that it’s unnecessary to change the codes. If the “timeout” is
> >empty, the “atoi” function will convert it to 0,
>
> Got a signal when I passed empty timeout accidentally during my test runs and
> so I s
On Sun, Aug 07, 2016 at 10:06:05PM +0100, Bhanuprakash Bodireddy wrote:
> ovs-appctl can crash with missing timeout argument.
> # ovs-appctl --timeout= dpif-netdev/pmd-stats-show
I don't see the crash when I run this. How is it caused?
___
dev mailing
501 - 600 of 18975 matches
Mail list logo
