Re: [ovs-dev] [PATCH net-next 03/10] genetlink: remove userhdr from struct genl_info

2023-08-10 Thread Jiri Pirko
d >for a family pointer in later patches. > >Signed-off-by: Jakub Kicinski Reviewed-by: Jiri Pirko I'm fine with the existing message, but what Johannes suggests is also ok. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next v3 3/3] openvswitch: Use string_is_terminated() helper

2023-02-08 Thread Jiri Pirko
Wed, Feb 08, 2023 at 02:31:53PM CET, andriy.shevche...@linux.intel.com wrote: >Use string_is_terminated() helper instead of cpecific memchr() call. >This shows better the intention of the call. > >Signed-off-by: Andy Shevchenko >Reviewed-by: Simon Horman Reviewed

Re: [ovs-dev] [PATCH net-next v3 2/3] genetlink: Use string_is_terminated() helper

2023-02-08 Thread Jiri Pirko
Wed, Feb 08, 2023 at 02:31:52PM CET, andriy.shevche...@linux.intel.com wrote: >Use string_is_terminated() helper instead of cpecific memchr() call. >This shows better the intention of the call. > >Signed-off-by: Andy Shevchenko >Reviewed-by: Simon Horman Reviewed

Re: [ovs-dev] [PATCH net-next v3 1/3] string_helpers: Move string_is_valid() to the header

2023-02-08 Thread Jiri Pirko
r() directly. With or without it: Reviewed-by: Jiri Pirko ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] 回复: [PATCH net-next v7 1/1] net:openvswitch:reduce cpu_used_mask memory

2023-02-03 Thread Jiri Pirko
Fri, Feb 03, 2023 at 04:50:31PM CET, taoyuan_e...@hotmail.com wrote: >Change between V7 and V6: >move initialization of cpu_used_mask up to follow stats_last_writer Okay, please stop sending stuff and begin to read. > >thanks >eddy ___ dev mailing

Re: [ovs-dev] [PATCH net-next v6 1/1] net:openvswitch:reduce cpu_used_mask memory

2023-02-03 Thread Jiri Pirko
ver access >bits beyond cpu count, cpumask_size() bytes of memory is enough > >Signed-off-by: Eddy Tao Reviewed-by: Jiri Pirko Sigh, I hope this is the last V, at least until I send this email... ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] 回复: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory

2023-02-03 Thread Jiri Pirko
Fri, Feb 03, 2023 at 10:03:28AM CET, taoyuan_e...@hotmail.com wrote: >sorry, Jiri, my bad, will hold on before the next submission/hope it is the >final one Don't top-post please. So what is the change comparing to v4? > >eddy >____ >发件人: Jiri Pir

Re: [ovs-dev] [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory

2023-02-03 Thread Jiri Pirko
Fri, Feb 03, 2023 at 09:52:56AM CET, taoyuan_e...@hotmail.com wrote: >Use actual CPU number instead of hardcoded value to decide the size >of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason. > >'struct cpumask cpu_used_mask' is embedded in struct sw_flow. >Its size is hardcoded to

Re: [ovs-dev] [PATCH net-next v4 1/1] net:openvswitch:reduce cpu_used_mask memory

2023-02-03 Thread Jiri Pirko
ver access >bits beyond cpu count, cpumask_size() bytes of memory is enough > >Signed-off-by: Eddy Tao Reviewed-by: Jiri Pirko ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory

2023-02-01 Thread Jiri Pirko
Wed, Feb 01, 2023 at 02:24:39PM CET, taoyuan_e...@hotmail.com wrote: >From: Eddy Tao > >'struct cpumask cpu_used_mask' is embedded in struct sw_flow. >However, its size is hardcoded to CONFIG_NR_CPUS bits, which can be >8192 by default, it costs memory and slows down ovs_flow_alloc. >This fix

Re: [ovs-dev] [PATCH] net: openvswitch: reduce cpu_used_mask memory consumption

2023-02-01 Thread Jiri Pirko
Tue, Jan 31, 2023 at 02:58:22PM CET, taoyuan_e...@hotmail.com wrote: >From: eddytaoyuan > >struct cpumask cpu_used_mask is directly embedded in struct sw_flow >however, its size is hardcoded to CONFIG_NR_CPUS bits, which >can be as large as 8192 by default, it cost memory and slows down

Re: [ovs-dev] [PATCH] [PATCH v8 net-next] net: openvswitch: Add support to count upcall packets

2022-12-06 Thread Jiri Pirko
Tue, Dec 06, 2022 at 10:29:05AM CET, wangchuan...@inspur.com wrote: >Add support to count upall packets, when kmod of openvswitch >upcall to userspace , here count the number of packets for s/userspace , here/userspace, here/ >upcall succeed and failed, which is a better way to see how >many

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-08 Thread Jiri Pirko
Wed, Jun 08, 2022 at 04:58:27PM CEST, k...@kernel.org wrote: >On Wed, 8 Jun 2022 10:27:15 +0200 Jiri Pirko wrote: >> Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote: >> >Netdev reference helpers have a dev_ prefix for historic >> >reasons. Renaming the ol

Re: [ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-08 Thread Jiri Pirko
Wed, Jun 08, 2022 at 06:39:55AM CEST, k...@kernel.org wrote: >Netdev reference helpers have a dev_ prefix for historic >reasons. Renaming the old helpers would be too much churn Hmm, I think it would be great to eventually rename the rest too in order to maintain unique prefix for netdev things.

Re: [ovs-dev] [PATCH net-next V3 1/1] net: sched: act_csum: Fix csum calc for tagged packets

2019-02-26 Thread Jiri Pirko
Mon, Feb 25, 2019 at 11:00:36PM CET, el...@mellanox.com wrote: >The csum calculation is different for IPv4/6. For VLAN packets, >tc_skb_protocol returns the VLAN protocol rather than the packet's one >(e.g. IPv4/6), so csum is not calculated. Furthermore, VLAN may not be >stripped so csum is not

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-11-13 Thread Jiri Pirko
w that causing ip link to load this module? >> >Why can't we do the same thing when a vlan interface is created from ovs? >> > >> >Jiri, >> >Any other idea how we can solve this issue? >> >> Could you please test following patch? I will send i

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-11-13 Thread Jiri Pirko
terface is created from ovs? > >Jiri, >Any other idea how we can solve this issue? Could you please test following patch? I will send it upstream once you confirm it helps your case. Thanks! From: Jiri Pirko Subject: [patch net-next RFC] net: 8021q: move vlan offload registrations into v

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-10-28 Thread Jiri Pirko
Sun, Oct 28, 2018 at 03:03:42PM CET, michaels...@gmail.com wrote: >Jiri, >I am not sure it would be simple to move the add_offload to vlan_Core.c as >the add_offload should happen once. Just call it from net_dev_init() >in vlan.c it's done as part of module init but in vlan_core.c we are not

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-10-25 Thread Jiri Pirko
Thu, Oct 25, 2018 at 01:34:04PM CEST, michaels...@gmail.com wrote: >I'v used ftrace to see which paths we take in the kernel. >I remind you that the packet (in my scenario) looks like the following: >ETH | IP | UDP | VXLAN | L2 | VLAN | IP | TCP | payload > >When 8021q is not loaded:

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-10-25 Thread Jiri Pirko
Wed, Oct 24, 2018 at 10:12:54PM CEST, michaels...@gmail.com wrote: >Hi, >I noticed that there is a performance issue when running traffic on a vlan >interface that was created by OVS. >If we create a bridge with a vlan interface, the 8021q module is not loaded. >Then when packets with a 8021q tag

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

2017-08-11 Thread Jiri Pirko
Fri, Aug 11, 2017 at 12:09:36PM CEST, jan.scheur...@ericsson.com wrote: >> -Original Message- >> From: Jiri Benc [mailto:jb...@redhat.com] >> Sent: Friday, 11 August, 2017 11:45 >> >> The context field does not apply to MD type 2. It looks wrong for the >> context field to be included in

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

2017-03-23 Thread Jiri Pirko
Thu, Mar 23, 2017 at 08:01:35AM CET, j...@ovn.org wrote: >On 22 March 2017 at 04:10, Roi Dayan wrote: >> This patch series introduces rule offload functionality to dpif-netlink >> via netdev ports new flow offloading API. The user can specify whether to >> enable rule

Re: [ovs-dev] [patch net-next 00/13] introduce rocker switch driver with openvswitch hardware accelerated datapath

2015-06-28 Thread Jiri Pirko
Mon, Jun 29, 2015 at 07:44:38AM CEST, neelugad...@gmail.com wrote: Hi All, Shall we expect these changes to be available in the upcoming 2.4 release? or is it still in development? Still in devel. On Tue, Sep 16, 2014 at 9:28 PM, Jiri Pirko j...@resnulli.us wrote: Mon, Sep 08, 2014

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-22 Thread Jiri Pirko
Sat, Sep 20, 2014 at 01:32:30PM CEST, j...@mojatatu.com wrote: On 09/20/14 07:01, Thomas Graf wrote: Nothing speaks against having such a tc classifier. In fact, having the interface consist of only an embedded Netlink attribute structure would allow for such a classifier in a very straight

Re: [ovs-dev] [patch net-next v2 6/9] switchdev: add basic support for flow matching and actions

2014-09-20 Thread Jiri Pirko
Sat, Sep 20, 2014 at 07:32:08AM CEST, f.faine...@gmail.com wrote: On 09/19/14 06:49, Jiri Pirko wrote: This patch adds basic support for flows. The infrastructure is prepared to easily add another flow matching types. So far, only the key one is implemented. Signed-off-by: Jiri Pirko j

Re: [ovs-dev] [patch net-next v2 5/9] net: introduce dummy switch

2014-09-20 Thread Jiri Pirko
Sat, Sep 20, 2014 at 07:21:00AM CEST, f.faine...@gmail.com wrote: On 09/19/14 06:49, Jiri Pirko wrote: Dummy switch implementation using switchdev interface This really looks like a DSA driver that has 0 ports, and is not attached to an useful network interface, and which is registering its own

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-20 Thread Jiri Pirko
Sat, Sep 20, 2014 at 05:41:16AM CEST, ro...@cumulusnetworks.com wrote: On 9/19/14, 8:49 AM, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: On 09/19/14 09:49, Jiri Pirko wrote: This patch exposes switchdev API using generic Netlink. Example userspace utility

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-20 Thread Jiri Pirko
Sat, Sep 20, 2014 at 12:12:12AM CEST, john.r.fastab...@intel.com wrote: On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: Is this just a temporary test tool? Otherwise i dont see reason for its

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-20 Thread Jiri Pirko
Sat, Sep 20, 2014 at 12:18:02AM CEST, j...@mojatatu.com wrote: On 09/19/14 18:12, John Fastabend wrote: On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: Is this just a temporary test tool? Otherwise

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-20 Thread Jiri Pirko
Sat, Sep 20, 2014 at 07:39:51AM CEST, f.faine...@gmail.com wrote: On 09/19/14 15:18, Jamal Hadi Salim wrote: On 09/19/14 18:12, John Fastabend wrote: On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-20 Thread Jiri Pirko
, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: On 09/19/14 09:49, Jiri Pirko wrote: This patch exposes switchdev API using generic Netlink. Example userspace utility is here: https://github.com/jpirko/switchdev Is this just a temporary test tool

[ovs-dev] [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api

2014-09-19 Thread Jiri Pirko
.* - drivers/net/ethernet/rocker/ - fixed couple of little bugs and typos - in dsa the switch id is generated randomly - fixed rocker schedule in atomic context bug in rocker_port_set_rx_mode - added switchdev Netlink API Jiri Pirko (9): net: rename netdev_phys_port_id to more generic name net: introduce

[ovs-dev] [patch net-next v2 2/9] net: introduce generic switch devices support

2014-09-19 Thread Jiri Pirko
a/MAINTAINERS b/MAINTAINERS index 5e3709e..f1f26db 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8826,6 +8826,13 @@ F: lib/swiotlb.c F: arch/*/kernel/pci-swiotlb.c F: include/linux/swiotlb.h +SWITCHDEV +M: Jiri Pirko j...@resnulli.us +L: net...@vger.kernel.org +S: Supported +F

[ovs-dev] [patch net-next v2 3/9] rtnl: expose physical switch id for particular device

2014-09-19 Thread Jiri Pirko
The netdevice represents a port in a switch, it will expose IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value belong to one physical switch. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/uapi/linux/if_link.h | 1 + net/core/rtnetlink.c | 26

[ovs-dev] [patch net-next v2 6/9] switchdev: add basic support for flow matching and actions

2014-09-19 Thread Jiri Pirko
This patch adds basic support for flows. The infrastructure is prepared to easily add another flow matching types. So far, only the key one is implemented. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 16 ++ include/net/switchdev.h | 113

[ovs-dev] [patch net-next v2 5/9] net: introduce dummy switch

2014-09-19 Thread Jiri Pirko
Dummy switch implementation using switchdev interface Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/Kconfig | 7 +++ drivers/net/Makefile | 1 + drivers/net/dummyswitch.c| 130 +++ include/uapi/linux/if_link.h | 9

[ovs-dev] [patch net-next v2 4/9] net-sysfs: expose physical switch id for particular device

2014-09-19 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/core/net-sysfs.c | 24 1 file changed, 24 insertions(+) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 55dc4da..87b97bc 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -12,6 +12,7

[ovs-dev] [patch net-next v2 7/9] switchdev: add swdev features

2014-09-19 Thread Jiri Pirko
Driver should define ndo_swdev_festures_get and indicate which switch features it supports. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 5 + include/net/switchdev.h | 18 ++ net/switchdev/switchdev.c | 33 + 3

[ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Jiri Pirko
This patch exposes switchdev API using generic Netlink. Example userspace utility is here: https://github.com/jpirko/switchdev Signed-off-by: Jiri Pirko j...@resnulli.us --- MAINTAINERS | 1 + include/uapi/linux/switchdev.h| 113 ++ net/switchdev/Kconfig

[ovs-dev] [patch net-next v2 9/9] rocker: introduce rocker switch driver

2014-09-19 Thread Jiri Pirko
. Signed-off-by: Scott Feldman sfel...@cumulusnetworks.com Signed-off-by: Jiri Pirko j...@resnulli.us --- MAINTAINERS |6 + drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile|1 + drivers/net/ethernet/rocker/Kconfig | 29 + drivers/net

Re: [ovs-dev] [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api

2014-09-19 Thread Jiri Pirko
Fri, Sep 19, 2014 at 04:15:32PM CEST, david.lai...@aculab.com wrote: From: Jiri Pirko This patchset can be divided into 3 main sections: - introduce switchdev api for implementing switch drivers - introduce switchdev generic netlink api for userspace manipulation - introduce rocker switch

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Jiri Pirko
Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: On 09/19/14 09:49, Jiri Pirko wrote: This patch exposes switchdev API using generic Netlink. Example userspace utility is here: https://github.com/jpirko/switchdev Is this just a temporary test tool? Otherwise i dont see reason

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-17 Thread Jiri Pirko
Thu, Sep 04, 2014 at 10:46:28PM CEST, pshe...@nicira.com wrote: On Thu, Sep 4, 2014 at 5:33 AM, Jiri Pirko j...@resnulli.us wrote: Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote: On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko j...@resnulli.us wrote: After this, flow related

Re: [ovs-dev] [patch net-next 00/13] introduce rocker switch driver with openvswitch hardware accelerated datapath

2014-09-16 Thread Jiri Pirko
Mon, Sep 08, 2014 at 03:54:13PM CEST, tg...@suug.ch wrote: On 09/03/14 at 11:24am, Jiri Pirko wrote: This patchset can be divided into 3 main sections: - introduce switchdev api for implementing switch drivers - add hardware acceleration bits into openvswitch datapath, This uses previously

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-04 Thread Jiri Pirko
Thu, Sep 04, 2014 at 11:03:46AM CEST, simon.hor...@netronome.com wrote: On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote: On 08/23/2014 07:51 AM, Thomas Graf wrote: On 08/23/14 at 11:24am, Jiri Pirko wrote: Sat, Aug 23, 2014 at 12:53:34AM CEST, sfel...@cumulusnetworks.com wrote

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-04 Thread Jiri Pirko
Thu, Sep 04, 2014 at 11:04:49AM CEST, simon.hor...@netronome.com wrote: Hi Jiri, sorry for coming a little late to the party. I'm very happy to see work in this area. On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pirko wrote: Benefit from the possibility to work with flows in switch devices

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-04 Thread Jiri Pirko
Thu, Sep 04, 2014 at 11:23:35AM CEST, simon.hor...@netronome.com wrote: On Thu, Sep 04, 2014 at 11:09:26AM +0200, Jiri Pirko wrote: Thu, Sep 04, 2014 at 11:03:46AM CEST, simon.hor...@netronome.com wrote: On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote: On 08/23/2014 07:51 AM

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 05:20:25PM CEST, john.fastab...@gmail.com wrote: On 09/03/2014 02:24 AM, Jiri Pirko wrote: After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko j...@resnulli.us --- Hi Jiri, As I indicated before I'm looking into integrating

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 08:42:18PM CEST, pshe...@nicira.com wrote: On Wed, Sep 3, 2014 at 8:20 AM, John Fastabend john.fastab...@gmail.com wrote: On 09/03/2014 02:24 AM, Jiri Pirko wrote: After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko j...@resnulli.us

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote: On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko j...@resnulli.us wrote: After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/net/sw_flow.h | 99

Re: [ovs-dev] [patch net-next 07/13] dsa: implement ndo_swdev_get_id

2014-09-04 Thread Jiri Pirko
Thu, Sep 04, 2014 at 01:20:58AM CEST, f.faine...@gmail.com wrote: On 09/03/2014 02:24 AM, Jiri Pirko wrote: Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 3 ++- include/net/dsa.h | 1 + net/dsa/Kconfig | 2 +- net/dsa/dsa.c | 3

Re: [ovs-dev] [patch net-next 03/13] net: introduce generic switch devices support

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 05:46:23PM CEST, john.fastab...@gmail.com wrote: On 09/03/2014 02:24 AM, Jiri Pirko wrote: The goal of this is to provide a possibility to suport various switch chips. Drivers should implement relevant ndos to do so. Now there is a couple of ndos defines: - for getting

Re: [ovs-dev] [patch net-next 07/13] dsa: implement ndo_swdev_get_id

2014-09-04 Thread Jiri Pirko
Fri, Sep 05, 2014 at 06:43:23AM CEST, n...@openwrt.org wrote: On 2014-09-04 14:47, Jiri Pirko wrote: Thu, Sep 04, 2014 at 01:20:58AM CEST, f.faine...@gmail.com wrote: On 09/03/2014 02:24 AM, Jiri Pirko wrote: Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 3

[ovs-dev] [patch net-next 03/13] net: introduce generic switch devices support

2014-09-03 Thread Jiri Pirko
the switch. Signed-off-by: Jiri Pirko j...@resnulli.us --- Documentation/networking/switchdev.txt | 53 ++ MAINTAINERS| 7 ++ include/linux/netdevice.h | 28 ++ include/net/sw_flow.h | 14 +++ include/net/switchdev.h

[ovs-dev] [patch net-next 10/13] openvswitch: add support for datapath hardware offload

2014-09-03 Thread Jiri Pirko
Benefit from the possibility to work with flows in switch devices and use the swdev api to offload flow datapath. Signed-off-by: Jiri Pirko j...@resnulli.us --- net/openvswitch/Makefile | 3 +- net/openvswitch/datapath.c | 33 ++ net/openvswitch/datapath.h | 3 + net

[ovs-dev] [patch net-next 05/13] net-sysfs: expose physical switch id for particular device

2014-09-03 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/core/net-sysfs.c | 24 1 file changed, 24 insertions(+) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 55dc4da..51cd5ab 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -12,6 +12,7

[ovs-dev] [patch net-next 06/13] net: introduce dummy switch

2014-09-03 Thread Jiri Pirko
Dummy switch implementation using switchdev interface Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/Kconfig | 7 +++ drivers/net/Makefile | 1 + drivers/net/dummyswitch.c| 130 +++ include/uapi/linux/if_link.h | 9

[ovs-dev] [patch net-next 04/13] rtnl: expose physical switch id for particular device

2014-09-03 Thread Jiri Pirko
The netdevice represents a port in a switch, it will expose IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value belong to one physical switch. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/uapi/linux/if_link.h | 1 + net/core/rtnetlink.c | 26

[ovs-dev] [patch net-next 11/13] sw_flow: add misc section to key with in_port_ifindex field

2014-09-03 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- include/net/sw_flow.h| 3 +++ net/openvswitch/hw_offload.c | 22 ++ net/switchdev/switchdev.c| 2 ++ 3 files changed, 27 insertions(+) diff --git a/include/net/sw_flow.h b/include/net/sw_flow.h index 3af7758

[ovs-dev] [patch net-next 07/13] dsa: implement ndo_swdev_get_id

2014-09-03 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 3 ++- include/net/dsa.h | 1 + net/dsa/Kconfig | 2 +- net/dsa/dsa.c | 3 +++ net/dsa/slave.c | 10 ++ 5 files changed, 17 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [patch net-next 08/13] net: introduce netdev_phys_item_ids_match helper

2014-09-03 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us Acked-by: Scott Feldman sfel...@cumulusnetworks.com --- include/linux/netdevice.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7ee070f..b2c3ff0 100644 --- a/include/linux

[ovs-dev] [patch net-next 12/13] rocker: introduce rocker switch driver

2014-09-03 Thread Jiri Pirko
. Signed-off-by: Scott Feldman sfel...@cumulusnetworks.com Signed-off-by: Jiri Pirko j...@resnulli.us --- MAINTAINERS |6 + drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile|1 + drivers/net/ethernet/rocker/Kconfig | 29 + drivers/net

[ovs-dev] [patch net-next 13/13] switchdev: introduce Netlink API

2014-09-03 Thread Jiri Pirko
This patch exposes switchdev API using generic Netlink. Example userspace utility is here: https://github.com/jpirko/switchdev Signed-off-by: Jiri Pirko j...@resnulli.us --- MAINTAINERS | 1 + include/uapi/linux/switchdev.h| 119 + net/switchdev/Kconfig

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-09-01 Thread Jiri Pirko
Mon, Sep 01, 2014 at 06:37:05PM CEST, j...@mojatatu.com wrote: On 09/01/14 04:13, Simon Horman wrote: On Fri, Aug 29, 2014 at 10:20:55AM -0400, Jamal Hadi Salim wrote: I actually have no issues with whatever classifier someone decides to use. To each their poison. But I do take issue mandating

Re: [ovs-dev] [patch net-next RFC 06/12] net: introduce dummy switch

2014-08-29 Thread Jiri Pirko
Tue, Aug 26, 2014 at 09:14:20PM CEST, go...@cumulusnetworks.com wrote: On Thu, Aug 21, 2014 at 06:18:59PM +0200, Jiri Pirko wrote: Dummy switch implementation using switchdev interface [...] +if (!data || !data[IFLA_DYMMYSWPORT_PHYS_SWITCH_ID]) [...] +dsp-psid.id_len = nla_len(data

Re: [ovs-dev] [patch net-next RFC 12/12] rocker: introduce rocker switch driver

2014-08-29 Thread Jiri Pirko
Sat, Aug 23, 2014 at 04:04:50PM CEST, tg...@suug.ch wrote: On 08/21/14 at 06:19pm, Jiri Pirko wrote: This patch introduces the first driver to benefit from the switchdev infrastructure and to implement newly introduced switch ndos. This is a driver for emulated switch chip implemented in qemu

Re: [ovs-dev] [patch net-next RFC 04/12] rtnl: expose physical switch id for particular device

2014-08-26 Thread Jiri Pirko
Fri, Aug 22, 2014 at 09:08:39PM CEST, john.fastab...@gmail.com wrote: On 08/21/2014 09:18 AM, Jiri Pirko wrote: The netdevice represents a port in a switch, it will expose IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value belong to one physical switch. Signed-off-by: Jiri

Re: [ovs-dev] [patch net-next RFC 03/12] net: introduce generic switch devices support

2014-08-26 Thread Jiri Pirko
Sun, Aug 24, 2014 at 01:46:05PM CEST, tg...@suug.ch wrote: On 08/21/14 at 06:18pm, Jiri Pirko wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 39294b9..8b5d14c 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -49,6 +49,8 @@ #include

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-08-26 Thread Jiri Pirko
Tue, Aug 26, 2014 at 03:50:21PM CEST, ro...@cumulusnetworks.com wrote: On 8/25/14, 3:50 PM, Thomas Graf wrote: On 08/25/14 at 12:15pm, Jamal Hadi Salim wrote: On 08/25/14 10:17, Thomas Graf wrote: On 08/25/14 at 09:53am, Jamal Hadi Salim wrote: fdb_add() *is* flow based. At least in my

Re: [ovs-dev] [patch net-next RFC 02/12] net: rename netdev_phys_port_id to more generic name

2014-08-26 Thread Jiri Pirko
Tue, Aug 26, 2014 at 02:23:24PM CEST, ogerl...@mellanox.com wrote: On 21/08/2014 19:18, Jiri Pirko wrote: --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -868,7 +868,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev, + rtnl_port_size(dev, ext_filter_mask

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-08-26 Thread Jiri Pirko
Tue, Aug 26, 2014 at 04:58:54PM CEST, j...@mojatatu.com wrote: On 08/26/14 10:06, Jiri Pirko wrote: Yes. Flows are phase one. The api will be extended in for whatever is needed for l2/l3 as you said. Also I see a possibility to implement the l2/l3 use case with flows as well. And as a note

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-08-26 Thread Jiri Pirko
Tue, Aug 26, 2014 at 05:29:10PM CEST, j...@mojatatu.com wrote: On 08/26/14 11:22, Jiri Pirko wrote: I do not think that really matters. Phase one is flows. After that we can focus on l2/l3. If we would be able to fit in in flows (some drivers may), then ok. If not, we extend the api with couple

Re: [ovs-dev] [patch net-next RFC 03/12] net: introduce generic switch devices support

2014-08-23 Thread Jiri Pirko
Sat, Aug 23, 2014 at 03:02:10AM CEST, f.faine...@gmail.com wrote: 2014-08-22 5:56 GMT-07:00 Jiri Pirko j...@resnulli.us: Fri, Aug 22, 2014 at 02:42:04PM CEST, j...@mojatatu.com wrote: On 08/21/14 13:05, Florian Fainelli wrote: 2014-08-21 9:18 GMT-07:00 Jiri Pirko j...@resnulli.us: The goal

Re: [ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-08-23 Thread Jiri Pirko
Sat, Aug 23, 2014 at 12:53:34AM CEST, sfel...@cumulusnetworks.com wrote: On Aug 22, 2014, at 12:39 PM, John Fastabend john.fastab...@gmail.com wrote: On 08/21/2014 09:19 AM, Jiri Pirko wrote: Benefit from the possibility to work with flows in switch devices and use the swdev api to offload

Re: [ovs-dev] [patch net-next RFC 03/12] net: introduce generic switch devices support

2014-08-22 Thread Jiri Pirko
Fri, Aug 22, 2014 at 02:42:04PM CEST, j...@mojatatu.com wrote: On 08/21/14 13:05, Florian Fainelli wrote: 2014-08-21 9:18 GMT-07:00 Jiri Pirko j...@resnulli.us: The goal of this is to provide a possibility to suport various switch chips. Drivers should implement relevant ndos to do so. Now

[ovs-dev] [patch net-next RFC 00/12] introduce rocker switch driver with openvswitch hardware accelerated datapath

2014-08-21 Thread Jiri Pirko
in separate patches. So now there is possible out of the box to create ovs bridge over rocker switch ports and the flows will be offloaded into hardware. Jiri Pirko (12): openvswitch: split flow structures into ovs specific and generic ones net: rename netdev_phys_port_id to more generic name net

[ovs-dev] [patch net-next RFC 01/12] openvswitch: split flow structures into ovs specific and generic ones

2014-08-21 Thread Jiri Pirko
After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/sw_flow.h| 98 ++ net/openvswitch/actions.c | 3 +- net/openvswitch/datapath.c | 74 +- net

[ovs-dev] [patch net-next RFC 07/12] dsa: implement ndo_swdev_get_id

2014-08-21 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/dsa/Kconfig | 2 +- net/dsa/slave.c | 16 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index f5eede1..66c445a 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,6 +1,6

[ovs-dev] [patch net-next RFC 05/12] net-sysfs: expose physical switch id for particular device

2014-08-21 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/core/net-sysfs.c | 24 1 file changed, 24 insertions(+) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 55dc4da..69e3d64 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -12,6 +12,7

[ovs-dev] [patch net-next RFC 08/12] net: introduce netdev_phys_item_ids_match helper

2014-08-21 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us Acked-by: Scott Feldman sfel...@cumulusnetworks.com --- include/linux/netdevice.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 8b5d14c..b48028d 100644 --- a/include/linux

[ovs-dev] [patch net-next RFC 06/12] net: introduce dummy switch

2014-08-21 Thread Jiri Pirko
Dummy switch implementation using switchdev interface Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/Kconfig | 7 +++ drivers/net/Makefile | 1 + drivers/net/dummyswitch.c| 131 +++ include/uapi/linux/if_link.h | 9

[ovs-dev] [patch net-next RFC 11/12] sw_flow: add misc section to key with in_port_ifindex field

2014-08-21 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/sw_flow.h | 3 +++ net/core/switchdev.c | 10 ++ net/openvswitch/hw_offload.c | 23 +++ 3 files changed, 36 insertions(+) diff --git a/include/linux/sw_flow.h b/include/linux/sw_flow.h index

[ovs-dev] [patch net-next RFC 09/12] openvswitch: introduce vport_op get_netdev

2014-08-21 Thread Jiri Pirko
This will allow to query easily if the vport has netdev. Also it allows to unexpose netdev_vport_priv and struct netdev_vport. Signed-off-by: Jiri Pirko j...@resnulli.us --- net/openvswitch/datapath.c | 2 +- net/openvswitch/dp_notify.c | 7 ++--- net/openvswitch/vport

[ovs-dev] [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

2014-08-21 Thread Jiri Pirko
Benefit from the possibility to work with flows in switch devices and use the swdev api to offload flow datapath. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/sw_flow.h| 14 +++ net/openvswitch/Makefile | 3 +- net/openvswitch/datapath.c | 33 ++ net

[ovs-dev] [patch net-next RFC 12/12] rocker: introduce rocker switch driver

2014-08-21 Thread Jiri Pirko
. Signed-off-by: Scott Feldman sfel...@cumulusnetworks.com Signed-off-by: Jiri Pirko j...@resnulli.us --- MAINTAINERS |6 + drivers/net/Kconfig |8 + drivers/net/Makefile |2 + drivers/net/rocker.c | 3446 ++ drivers/net/rocker.h | 465

Re: [ovs-dev] [patch net-next RFC 03/12] net: introduce generic switch devices support

2014-08-21 Thread Jiri Pirko
Thu, Aug 21, 2014 at 06:41:23PM CEST, b...@decadent.org.uk wrote: On Thu, 2014-08-21 at 18:18 +0200, Jiri Pirko wrote: The goal of this is to provide a possibility to suport various switch chips. Drivers should implement relevant ndos to do so. Now there is a couple of ndos defines

Re: [ovs-dev] [patch net-next RFC 07/12] dsa: implement ndo_swdev_get_id

2014-08-21 Thread Jiri Pirko
Thu, Aug 21, 2014 at 06:56:13PM CEST, f.faine...@gmail.com wrote: 2014-08-21 9:19 GMT-07:00 Jiri Pirko j...@resnulli.us: Signed-off-by: Jiri Pirko j...@resnulli.us --- net/dsa/Kconfig | 2 +- net/dsa/slave.c | 16 2 files changed, 17 insertions(+), 1 deletion(-) diff

Re: [ovs-dev] [patch net-next RFC v3 10/10] openvswitch: add support for datapath hardware offload

2014-04-24 Thread Jiri Pirko
Thu, Apr 24, 2014 at 04:54:19PM CEST, john.fastab...@gmail.com wrote: On 04/17/2014 05:15 AM, Jiri Pirko wrote: Benefit from the possibility to work with flows in switch devices and use the swdev api to offload flow datapath. Signed-off-by: Jiri Pirko j...@resnulli.us --- [...] @@ -840,13

[ovs-dev] [patch net-next RFC v3 01/10] openvswitch: split flow structures into ovs specific and generic ones

2014-04-17 Thread Jiri Pirko
After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/sw_flow.h| 108 net/openvswitch/datapath.c | 45 +++ net/openvswitch/datapath.h | 4 +- net/openvswitch

[ovs-dev] [patch net-next RFC v3 03/10] net: introduce generic switch devices support

2014-04-17 Thread Jiri Pirko
The goal of this is to provide a possibility to suport various switch chips. Drivers should implement relevant ndos to do so. So far, only one ndo for getting physical switch id is in place. Signed-off-by: Jiri Pirko j...@resnulli.us --- Documentation/networking/switchdev.txt | 53

[ovs-dev] [patch net-next RFC v3 00/10] introduce infrastructure for support of switch chip datapath

2014-04-17 Thread Jiri Pirko
which would call sw*dev_ndos to setup the switch according to what the user wants. This would allow a usecase then a user configures bridges, bonds, etc and the switch chip underneath gets configured by that. Any suggestions, feedbacks welcome. Jiri Pirko (10): openvswitch: split flow structures

[ovs-dev] [patch net-next RFC v3 04/10] rtnl: expose physical switch id for particular device

2014-04-17 Thread Jiri Pirko
The the netdevice represents a port in a switch, it will expose IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with a same value belong to one physical switch. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/uapi/linux/if_link.h | 1 + net/core/rtnetlink.c | 26

[ovs-dev] [patch net-next RFC v3 05/10] switchdev: introduce basic support for flows

2014-04-17 Thread Jiri Pirko
This patch adds a couple of ndos which can be used to work with flows. Note that user can use random port netdevice to access the switch. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 30 include/linux/switchdev.h | 25

[ovs-dev] [patch net-next RFC v3 07/10] dsa: implement ndo_swdev_get_id

2014-04-17 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- net/dsa/slave.c | 16 1 file changed, 16 insertions(+) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 02c0e17..22855f3 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -171,6 +171,19 @@ static int dsa_slave_ioctl(struct

[ovs-dev] [patch net-next RFC v3 10/10] openvswitch: add support for datapath hardware offload

2014-04-17 Thread Jiri Pirko
Benefit from the possibility to work with flows in switch devices and use the swdev api to offload flow datapath. Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/sw_flow.h | 16 +++- net/openvswitch/Makefile | 3 +- net/openvswitch/datapath.c | 16 +++- net

[ovs-dev] [patch net-next RFC v3 08/10] net: add netdev_for_each_all_lower_dev_rcu helper

2014-04-17 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- include/linux/netdevice.h | 18 +- net/core/dev.c| 26 ++ 2 files changed, 27 insertions(+), 17 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 14bd8b3

[ovs-dev] [patch net-next RFC v3 09/10] openvswitch: introduce vport_op get_netdev

2014-04-17 Thread Jiri Pirko
This will allow to query easily if the vport has netdev. Also it allows to unexpose netdev_vport_priv and struct netdev_vport. Signed-off-by: Jiri Pirko j...@resnulli.us --- net/openvswitch/datapath.c | 2 +- net/openvswitch/dp_notify.c | 7 ++--- net/openvswitch/vport

[ovs-dev] [patch net-next RFC v3 06/10] net: introduce dummy switch

2014-04-17 Thread Jiri Pirko
Dummy switch implementation using switchdev interface Signed-off-by: Jiri Pirko j...@resnulli.us --- drivers/net/Kconfig | 7 +++ drivers/net/Makefile | 1 + drivers/net/dummyswitch.c| 126 +++ include/uapi/linux/if_link.h | 9

[ovs-dev] [patch net-next RFC v3 0/5] iproute2: support switch chip infrastructure

2014-04-17 Thread Jiri Pirko
Jiri Pirko (5): iproute2: arpd: use ll_addr_a2n and ll_addr_n2a iproute2: utils: change hexstring_n2a and hexstring_a2n to do not work with : iproute2: ipa: show switch id iproute2: add support for dummyswport iproute2: ipa: show port id include/linux/if_link.h | 11 ++ ip

[ovs-dev] [patch iproute2 RFC v3 2/5] iproute2: utils: change hexstring_n2a and hexstring_a2n to do not work with :

2014-04-17 Thread Jiri Pirko
Signed-off-by: Jiri Pirko j...@resnulli.us --- lib/utils.c | 46 +- 1 file changed, 13 insertions(+), 33 deletions(-) diff --git a/lib/utils.c b/lib/utils.c index 4e9c719..e9e1040 100644 --- a/lib/utils.c +++ b/lib/utils.c @@ -743,10 +743,6 @@ char

  1   2   >