[ovs-dev] Understanding the contribution model of OVS with GIT

2014-09-30 Thread Rishi Bamba
Hi All, I just need to mention and get a confirmation on the process we are following for contribution to the OpenvSwitch i.e in line with contributing document of the Dev forum.This is mainly how we are using GIT for the same. 1. Fork the repository from the main OVS official

[ovs-dev] Bug#763428: openvswitch-switch: openvswitch doesn't work anymore since kernel 3.16 update

2014-09-30 Thread Mehdi Abaakouk
Package: openvswitch-switch Version: 2.3.0+git20140819-2 Severity: important Dear Maintainer, Since the update of kernel in jessie to 3.16, my openvswitch setups won't work anymore, I have to keep the kernel 3.14 to have openvswitch working. I guess the 3.16 kernel is offically supported only

[ovs-dev] Gentile utente

2014-09-30 Thread ADMIN
Gentile utente La tua email è superato 2 GB creati dal webmaster, è attualmente in esecuzione a 2.30GB, che non può inviare o ricevere nuovi messaggi entro i prossimi 24 ore prima di averne verificato email account. Inserisci i tuoi dati qui sotto per verificare il tuo account: (1)

[ovs-dev] [PATCH] pstream-unix: add listen count to 64 in punix_open

2014-09-30 Thread jerry.lilijun
From: Lilijun jerry.lili...@huawei.com In my test with openstack setup, ovs-ofctl executes failed when there are many flow rules to be added by multiple threads. The error like this: ovs-ofctl: /var/run/openvswitch/br1.mgmt: failed to open socket (Protocol error) In the function listen(fd, 10)

[ovs-dev] Call for paper- International Conference on Economics, Energy, Environment and Agricultural Sciences

2014-09-30 Thread touqeer ahmad
Dear Colleagues, *Call for papers* International Conference on Economics, Energy, Environment and Agricultural Sciences * (ICEEEAS)* *(**1-2 November, 2014**– Kuala Lumpur, Malaysia)* *Pearl International Hotel**, Kuala Lumpur, Malaysia* http://www.pakrdw.com/?ic=detailsid=7 The aim

[ovs-dev] [PATCH 00/14] datapath-windows: Implement the rest of the netlink vport commands

2014-09-30 Thread Samuel Ghinet
Hello guys, This patch number 00 is an introduction to the patch series. I am sorry we could not provide the design behind this much faster. This series of patches is based on that design. I have tested these vport commands with both VMs and vxlan, with both VMs connecting and reconnecting

[ovs-dev] [PATCH 01/14] datapath-windows: Remove the old IOCTL vport functions.

2014-09-30 Thread Samuel Ghinet
The old IOCTL vport functions (using the non-netlink device) are no longer needed. They should be removed. Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com --- datapath-windows/ovsext/Vport.c | 403 datapath-windows/ovsext/Vport.h | 15 -- 2

[ovs-dev] [PATCH 02/14] datapath-windows: Rename hyper-v switch port and nic handlers

2014-09-30 Thread Samuel Ghinet
Functions such as OvsCreatePort are vague in regard to who creates it or when. It wasn't a problem thus far, since the vports were created, updated and destroyed from one place only (hyper-v switch part). But now, with the netlink implementation of the vport commands, a part of the vport is

[ovs-dev] [PATCH 03/14] datapath-windows: We don't need to keep validation ports in ovs

2014-09-30 Thread Samuel Ghinet
Validation ports are used internally by the hyper-v switch to validate and verify settings for the real hyper-v switch ports that will be connected to the VNic. The validation ports are of no use to us - we must skip handling them, and return STATUS_SUCCESS as the OID result. Signed-off-by:

[ovs-dev] [PATCH 04/14] datapath-windows: Update OVS_SWITCH_CONTEXT: external and internal port

2014-09-30 Thread Samuel Ghinet
The fields externalVport and internalVport of the OVS_SWITCH_CONTEXT struct are currently defined as PVOID. However, all over the code they are used as POVS_VPORT_ENTRY. In order to improve clarity and reduce the need for useless casts to POVS_VPORT_ENTRY, this patch changes the type from PVOID to

[ovs-dev] [PATCH 05/14] datapath-windows: Define OVS_DPPORT_NUMBER_INVALID

2014-09-30 Thread Samuel Ghinet
This value represents the invalid number of the ovs (datapath) part of the vport. It is currently 0, but when vport numbers will be constraint to less than MAXUINT16, it will become MAXUINT16. Reason for adding this symbol: a symbol is more clear of the intent than a magic number. Also, it allows

[ovs-dev] [PATCH 06/14] datapath-windows: Rename OvsGetVportNo into OvsComputeVportNo and make public

2014-09-30 Thread Samuel Ghinet
OvsGetVportNo computes a new port number. Therefore, OvsComputeVportNo is a more clear name for what the function does. Reading OvsGetVportNo may give the false impression that it returns the port number of an existing vport. Also, since the responsibility of assigning dp port numbers no longer

[ovs-dev] [PATCH 07/14] datapath-windows: Rename switch context's nameHashArray and vport's nameLink

2014-09-30 Thread Samuel Ghinet
The field nameLink of the OVS_VPORT_ENTRY is the link within the OVS_SWITCH_CONTEXT's hash array of vports nameHashArray, hashed by the ovsName field of the OVS_VPORT_ENTRY. Later on, the friendly name of the hyper-v switch port will need to be set from userspace using WMI. This will require that

[ovs-dev] [PATCH 08/14] datapath-windows: Rename switch context's portHashArray and vport's portLink

2014-09-30 Thread Samuel Ghinet
The field portLink of the OVS_VPORT_ENTRY is the link within the OVS_SWITCH_CONTEXT's hash array of vports portHashArray, hashed by the portId field of the OVS_VPORT_ENTRY. Later on, we will need to modify the OVS_VPORT_ENTRY so that its port numbers are set to maximum MAXUINT16. This will

[ovs-dev] [PATCH 09/14] datapath-wuindows: Make VPORT ovs number values smaller than MAXUINT16

2014-09-30 Thread Samuel Ghinet
For this, the old method of finding vports based on the ovs port numbers is removed. Now, the lookup of a vport by ovs port number is done the same way as the lookup by hyper-v switch port id. This is done so that the kernel is able to interact with the userspace correctly when using vport

[ovs-dev] [PATCH 11/14] datapath-windows: Add netlink command: vport new

2014-09-30 Thread Samuel Ghinet
Does the following: a. before creating the vport, makes sure there is no existing vport with the same ovs (datapath) port name. If this is not so, it means that the specified port already exists: it returns NL_ERROR_EXIST. b. looks up the vport: o) if the vport type is internal, then the

[ovs-dev] [PATCH 12/14] datapath-windows: Add netlink command vport delete

2014-09-30 Thread Samuel Ghinet
Deletion of a vport is now handled both by the netlink command vport delete and the hyper-v switch port delete handler. If a netlink command vport delete is requested on a vport that has no hyper-v switch port counterpart (i.e., it is a tunnel port, or or the hyper-v switch virtual nic is

[ovs-dev] [PATCH 13/14] datapath-windows: Add netlink command vport set

2014-09-30 Thread Samuel Ghinet
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com --- datapath-windows/ovsext/Datapath.c | 128 - 1 file changed, 127 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index

[ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Samuel Ghinet
If the hyper-v switch port type is external, then the function OvsInitConfiguredSwitchNics allocates a vport, and if allocation succeeds, it procedes with the initialization. However, at this point, virtPort may happen to be null, but check against virtPort was not made - this means that if

[ovs-dev] [PATCH 10/14] datapath-windows: Add port friendly name to OVS_VPORT_ENTRY

2014-09-30 Thread Samuel Ghinet
The port friendly name will be set by WMI / powershell script. It will be used from within the netlink command vport new to identify the hyper-v switch port it represents. This patch also adds a function to lookup a vport by the port friendly name. Signed-off-by: Samuel Ghinet

Re: [ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Nithin Raju
On Sep 30, 2014, at 8:03 AM, Samuel Ghinet sghi...@cloudbasesolutions.com wrote: If the hyper-v switch port type is external, then the function OvsInitConfiguredSwitchNics allocates a vport, and if allocation succeeds, it procedes with the initialization. However, at this point, virtPort

Re: [ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Alin Serdean
Hi Nithin, We used a modified version of netdev-windows. Alin. -Mesaj original- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Tuesday, September 30, 2014 6:09 PM Către: Samuel Ghinet Cc: dev@openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma Subiect: Re: [PATCH 14/14]

Re: [ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-30 Thread Samuel Ghinet
Eitan, I see the code is already merged :) In a future patch, could you rename rc into something more intuitive, such as ret or retVal? It's just a suggestion :) Regards, Sam From: Eitan Eliahu [elia...@vmware.com] Sent: Friday, September 26, 2014 7:17

Re: [ovs-dev] [PATCH] pstream-unix: add listen count to 64 in punix_open

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 04:55:25PM +0800, jerry.lili...@huawei.com wrote: From: Lilijun jerry.lili...@huawei.com In my test with openstack setup, ovs-ofctl executes failed when there are many flow rules to be added by multiple threads. The error like this: ovs-ofctl:

Re: [ovs-dev] Understanding the contribution model of OVS with GIT

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 01:44:49PM +0530, Rishi Bamba wrote: I just need to mention and get a confirmation on the process we are following for contribution to the OpenvSwitch i.e in line with contributing document of the Dev forum.This is mainly how we are using GIT for the same.

Re: [ovs-dev] [PATCH v1 08/10] datapath-windows/Flow.c: FLOW_SET command handler.

2014-09-30 Thread Samuel Ghinet
Sorry Ankur, My bad, I was not clear enough on my suggestion. I wanted to reply later, but did not find the time. Thinking about the diversity of situations and scenarios (both for flow set and flow delete), I see the current implementation, with one handler to deal with all netlink flow

Re: [ovs-dev] [PATCH] datapath-windows: NUL character should be left out during VPORT hash lookup

2014-09-30 Thread Samuel Ghinet
From: Samuel Ghinet Sent: Tuesday, September 30, 2014 6:24 PM To: Nithin Raju Subject: RE: [PATCH] datapath-windows: NUL character should be left out during VPORT hash lookup The vport names given by the userspace using netlink command vport add are

Re: [ovs-dev] [PATCH] CodingStyle: Mention our assumption about conversions to bool

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 08:07:58AM +0900, YAMAMOTO Takashi wrote: Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp Can't hurt to clarify this. Acked-by: Ben Pfaff b...@nicira.com ___ dev mailing list dev@openvswitch.org

[ovs-dev] Sketch implementation in OVS

2014-09-30 Thread Aditya Kamath
Hi everyone, I am a research student working on a project of implementing count-min sketches in OpenVSwitch. I have had some success with modifying the kernel module to intercept packets and add required fields to the sketch. As the next step I want to add a flow action to divert traffic to

Re: [ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-30 Thread Eitan Eliahu
No problem Sam. Perhaps, we could do it across all the driver code at once. Thanks, Eitan -Original Message- From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] Sent: Tuesday, September 30, 2014 8:29 AM To: Eitan Eliahu; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2]

Re: [ovs-dev] [PATCH v1 08/10] datapath-windows/Flow.c: FLOW_SET command handler.

2014-09-30 Thread Ankur Sharma
Hi Samuel, My intention was to remove code duplication. But i have no strong preferences. I think your point makes sense, in long term having separate handler would make code easy to understand (even if it leads to code duplication). I have a bunch of TODOs for netlink , i have noted this

Re: [ovs-dev] dpdk options in ovs-vswitchd

2014-09-30 Thread Daniele Di Proietto
The options you are using should be correct. It looks like you didn't really enable DPDK support while compiling. Make sure to pass the appropriate option to ./configure On 9/30/14, 8:35 AM, Vinod, Chegu chegu_vi...@hp.com wrote: Hello, 'had git cloned the OVS tree and was trying out the

Re: [ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Eitan Eliahu
Hi Alin, I'm wondering if you could send a patch with your modified netdev code. Is this something that we could leverage? Thanks, Eitan -Original Message- From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] Sent: Tuesday, September 30, 2014 8:23 AM To: Nithin Raju; Samuel

Re: [ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Samuel Ghinet
Nithin, basically, any userspace code that used flows was commented out. And code that was trying to set qos to the netdev was commented out (because it was retrying forever). And netlink functions that used rtnetlink (were used for qos and netdev, if I am not mistaken) were commented out, so

Re: [ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Eitan Eliahu
Let's discuss it during the IRC. Since your netdev enabled to Vport commands I think it would be a good starting point. Thanks Alin. Eitan -Original Message- From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] Sent: Tuesday, September 30, 2014 9:21 AM To: Eitan Eliahu; Nithin

Re: [ovs-dev] [PATCH 14/14] datapath-windows: Fix potential crash in OvsInitConfiguredSwitchNics: virtPort

2014-09-30 Thread Nithin Raju
On Sep 30, 2014, at 9:16 AM, Samuel Ghinet sghi...@cloudbasesolutions.com wrote: Nithin, basically, any userspace code that used flows was commented out. And code that was trying to set qos to the netdev was commented out (because it was retrying forever). And netlink functions that

Re: [ovs-dev] [PATCH] datapath-windows: NUL character should be left out during VPORT hash lookup

2014-09-30 Thread Nithin Raju
From: Samuel Ghinet Sent: Tuesday, September 30, 2014 6:24 PM To: Nithin Raju Subject: RE: [PATCH] datapath-windows: NUL character should be left out during VPORT hash lookup The vport names given by the userspace using netlink command vport add are null-terminated. I personally see

[ovs-dev] 100% CPU in ovs-vswitchd (again)

2014-09-30 Thread Ben Pfaff
There's still a 100% CPU bug in ovs-vswitchd. Run make sandbox, then run a second ovs-vswitchd inside the subshell (just run a bare ovs-vswitchd without any parameters). You get output like this: 2014-09-30T16:33:45Z|1|ovs_numa|INFO|Discovered 8 CPU cores on NUMA node 0

Re: [ovs-dev] [PATCH] datapath-windows: NUL character should be left out during VPORT hash lookup

2014-09-30 Thread Samuel Ghinet
Oh, that was a bug. Well, in my netlink command vport add I used the full name (including the null terminator) for the hash. And in the OvsFindVportByOvsName I use length = strlen(name) + 1. When I pulled the latest modifs from the repo, I noticed I was doing some kind of revert to this patch.

[ovs-dev] [PATCH] ovs-vswitchd: Better diagnose errors in DPDK command-line options.

2014-09-30 Thread Ben Pfaff
With DPDK compiled in, when the --dpdk option was given other than as the first command-line argument, ovs-vswitchd silently ignored it. Without DPDK compiled in, when the --dpdk option was given anywhere, ovs-vswitchd silently ignored it. However, in each case any options following --dpdk were

[ovs-dev] dev Be your own boss

2014-09-30 Thread Todays Franchises

Re: [ovs-dev] [patch V2] INSTALL.DPDK: Update DPDK related documentation.

2014-09-30 Thread Daniele Di Proietto
On 9/29/14, 3:29 PM, Alex Wang al...@nicira.com wrote: This commit updates the DPDK related documentation to reflect the pmd thread multi-threading work. Signed-off-by: Alex Wang al...@nicira.com Acked-by: Daniele Di Proietto ddiproie...@vmware.com

Re: [ovs-dev] [PATCH] ovs-vswitchd: Better diagnose errors in DPDK command-line options.

2014-09-30 Thread Daniele Di Proietto
On 9/30/14, 9:57 AM, Ben Pfaff b...@nicira.com wrote: With DPDK compiled in, when the --dpdk option was given other than as the first command-line argument, ovs-vswitchd silently ignored it. Without DPDK compiled in, when the --dpdk option was given anywhere, ovs-vswitchd silently ignored it.

Re: [ovs-dev] 100% CPU in ovs-vswitchd (again)

2014-09-30 Thread Alex Wang
I can reproduce it, working on a fix, Thx for reporting~ On Tue, Sep 30, 2014 at 9:37 AM, Ben Pfaff b...@nicira.com wrote: There's still a 100% CPU bug in ovs-vswitchd. Run make sandbox, then run a second ovs-vswitchd inside the subshell (just run a bare ovs-vswitchd without any

Re: [ovs-dev] [PATCH] datapath-windows: NUL character should be left out during VPORT hash lookup

2014-09-30 Thread Nithin Raju
On Sep 30, 2014, at 9:48 AM, Samuel Ghinet sghi...@cloudbasesolutions.com wrote: Oh, that was a bug. Well, in my netlink command vport add I used the full name (including the null terminator) for the hash. And in the OvsFindVportByOvsName I use length = strlen(name) + 1. When I pulled

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-30 Thread Pravin Shelar
On Mon, Sep 29, 2014 at 3:59 PM, Joe Stringer joestrin...@nicira.com wrote: On 30 September 2014 10:10, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:15PM +1200, Joe Stringer wrote: If a datapath is created with the flag OVS_DP_F_INDEX_BY_UID, then an additional

Re: [ovs-dev] [PATCH] ovs-vswitchd: Better diagnose errors in DPDK command-line options.

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 05:11:10PM +, Daniele Di Proietto wrote: On 9/30/14, 9:57 AM, Ben Pfaff b...@nicira.com wrote: With DPDK compiled in, when the --dpdk option was given other than as the first command-line argument, ovs-vswitchd silently ignored it. Without DPDK compiled in, when

Re: [ovs-dev] 100% CPU in ovs-vswitchd (again)

2014-09-30 Thread Ben Pfaff
It's not the first time we've had this kind of bug. Last time, I tried to think of a good unit test, but did not succeed. On Tue, Sep 30, 2014 at 10:32:15AM -0700, Alex Wang wrote: I can reproduce it, working on a fix, Thx for reporting~ On Tue, Sep 30, 2014 at 9:37 AM, Ben Pfaff

Re: [ovs-dev] [PATCH] ovs-vswitchd: Better diagnose errors in DPDK command-line options.

2014-09-30 Thread Daniele Di Proietto
Yes, I tested with and without DPDK. It didn't cause any problem for me Thanks, Daniele On 9/30/14, 11:10 AM, Ben Pfaff b...@nicira.com wrote: On Tue, Sep 30, 2014 at 05:11:10PM +, Daniele Di Proietto wrote: On 9/30/14, 9:57 AM, Ben Pfaff b...@nicira.com wrote: With DPDK compiled in,

Re: [ovs-dev] [PATCH] ovs-vswitchd: Better diagnose errors in DPDK command-line options.

2014-09-30 Thread Ben Pfaff
Thanks a lot. Applied to master. On Tue, Sep 30, 2014 at 06:14:21PM +, Daniele Di Proietto wrote: Yes, I tested with and without DPDK. It didn't cause any problem for me Thanks, Daniele On 9/30/14, 11:10 AM, Ben Pfaff b...@nicira.com wrote: On Tue, Sep 30, 2014 at 05:11:10PM

Re: [ovs-dev] 100% CPU in ovs-vswitchd (again)

2014-09-30 Thread Alex Wang
Found the issue, I have idea of unit testing it, will experiment on it, On Tue, Sep 30, 2014 at 11:11 AM, Ben Pfaff b...@nicira.com wrote: It's not the first time we've had this kind of bug. Last time, I tried to think of a good unit test, but did not succeed. On Tue, Sep 30, 2014 at

Re: [ovs-dev] [patch V2] INSTALL.DPDK: Update DPDK related documentation.

2014-09-30 Thread Alex Wang
Thx, applied to master, On Tue, Sep 30, 2014 at 10:10 AM, Daniele Di Proietto ddiproie...@vmware.com wrote: On 9/29/14, 3:29 PM, Alex Wang al...@nicira.com wrote: This commit updates the DPDK related documentation to reflect the pmd thread multi-threading work. Signed-off-by: Alex Wang

[ovs-dev] [PATCH] dpif-netdev: Fix Double free in recirc action.

2014-09-30 Thread Pravin B Shelar
Incase of action execution dpif-netdev set may-steal for a packet depending on whether it is last action or not. But this does not work if it is last action inside a recirc action. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- lib/dpif-netdev.c | 9 ++--- 1 file changed, 6

Re: [ovs-dev] [PATCH 14/17] util: Make hexits_value() support 64-bit integers too.

2014-09-30 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 10:50:04AM +0900, YAMAMOTO Takashi wrote: diff --git a/lib/nx-match.c b/lib/nx-match.c index df39b4e..5970e44 100644 --- a/lib/nx-match.c +++ b/lib/nx-match.c @@ -1093,8 +1093,11 @@ parse_nxm_field_name(const char *name, int name_len) /* Check whether it's

[ovs-dev] [PATCH v1] User mode event read for Windows

2014-09-30 Thread Eitan Eliahu
User mode sends down three distinct Read ioctl commands for Events, Packet Reads and Dumps. In case the Packet Read socket can not be distinguished a Set function will be provided. Signed-off-by: Eitan Eliahu elia...@vmware.com Acked-by: Nithin Raju nit...@vmware.com --- lib/netlink-socket.c |

Re: [ovs-dev] Spurious CI failures

2014-09-30 Thread Ben Pfaff
On Mon, Sep 29, 2014 at 08:51:27PM +0200, Thomas Graf wrote: We are hitting spurious CI failures. I assume it's due to the VM running relatively slow and thus the current ovs-appctl time/warp not being sufficient. I'm not familiar with all the tests cases, can we just +50% on the current

[ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Alex Wang
When there are more than one ovs-vswitchd processes started, only one process is enabled. The disabled processes should just sleep. However, a bug in ovs makes the disabled processes keep waking up on global connectivity sequence number which is never sync'ed. Consequently, those processes use

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-30 Thread Joe Stringer
On 1 October 2014 06:56, Pravin Shelar pshe...@nicira.com wrote: On Mon, Sep 29, 2014 at 3:59 PM, Joe Stringer joestrin...@nicira.com wrote: On 30 September 2014 10:10, Ben Pfaff b...@nicira.com wrote: On Fri, Sep 26, 2014 at 09:28:15PM +1200, Joe Stringer wrote: If a datapath is

Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Joe Stringer
Awesome, thanks for the fix. On 1 October 2014 10:01, Alex Wang al...@nicira.com wrote: +dnl -- +AT_SETUP([ovs-vswitchd -- start additional ovs-vswitchd process]) +OVS_VSWITCHD_START + +# start another ovs-vswitchd process.

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-30 Thread Pravin Shelar
On Tue, Sep 30, 2014 at 3:15 PM, Joe Stringer joestrin...@nicira.com wrote: On 1 October 2014 06:56, Pravin Shelar pshe...@nicira.com wrote: On Mon, Sep 29, 2014 at 3:59 PM, Joe Stringer joestrin...@nicira.com wrote: On 30 September 2014 10:10, Ben Pfaff b...@nicira.com wrote: On

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-30 Thread Joe Stringer
On 1 October 2014 11:55, Pravin Shelar pshe...@nicira.com wrote: On Tue, Sep 30, 2014 at 3:15 PM, Joe Stringer joestrin...@nicira.com wrote: On 1 October 2014 06:56, Pravin Shelar pshe...@nicira.com wrote: On Mon, Sep 29, 2014 at 3:59 PM, Joe Stringer joestrin...@nicira.com wrote:

Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Alex Wang
Thx for the review~ 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Yeah, also to maybe cumulate more logs, if there is something. How about changing it to 2 s? Acked-by: Joe Stringer joestrin...@nicira.com

Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Joe Stringer
I had a play around and could only reproduce the bug with mininum 3 seconds. On 1 October 2014 12:11, Alex Wang al...@nicira.com wrote: Thx for the review~ 5 seems high, is this just to make sure that vswitchd gets a chance to fully initialize and go through the wait block once? Yeah,

[ovs-dev] [PATCH] README: Adding github markup and travis-ci build status to github readme page.

2014-09-30 Thread Pritesh Kothari
Signed-off-by: Pritesh Kothari pritesh.koth...@cisco.com --- README| 116 -- README.md | 114 2 files changed, 114 insertions(+), 116 deletions(-) delete mode 100644

[ovs-dev] [PATCH] configure: Disable strict aliasing.

2014-09-30 Thread Ben Pfaff
The C standard allows compilers to do type-based alias analysis, which means that the compiler is allowed to assume that pointers to objects of different types are pointers to different objects. For example, a compiler may assume that uint16_t *a and uint32_t *b point to different and

Re: [ovs-dev] [PATCH] README: Adding github markup and travis-ci build status to github readme page.

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 04:15:20PM -0700, Pritesh Kothari wrote: Signed-off-by: Pritesh Kothari pritesh.koth...@cisco.com Needs to also fix up references to README in various places throughout the tree, and especially to add one in Makefile.am (Automake automatically distributes README but not

Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Alex Wang
Yeah, so should we use 5 seconds? or use ovs_wait() to wait on the number of lines which could wait up to 10 seconds...? On Tue, Sep 30, 2014 at 4:14 PM, Joe Stringer joestrin...@nicira.com wrote: I had a play around and could only reproduce the bug with mininum 3 seconds. On 1 October

Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Joe Stringer
Maybe just stick with 5. On 1 October 2014 13:10, Alex Wang al...@nicira.com wrote: Yeah, so should we use 5 seconds? or use ovs_wait() to wait on the number of lines which could wait up to 10 seconds...? On Tue, Sep 30, 2014 at 4:14 PM, Joe Stringer joestrin...@nicira.com wrote: I had a

Re: [ovs-dev] [PATCH] README: Adding github markup and travis-ci build status to github readme page.

2014-09-30 Thread Joe Stringer
On 1 October 2014 12:15, Pritesh Kothari pritesh.koth...@cisco.com wrote: diff --git a/README.md b/README.md new file mode 100644 index 000..318f0e6 --- /dev/null +++ b/README.md @@ -0,0 +1,114 @@ +h1 +a href=http://openvswitch.org;Open vSwitch/a +/h1 + Markdown has syntax for

Re: [ovs-dev] [PATCH 06/17] meta-flow: Autogenerate mf_field data structures.

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 08:32:34AM +0900, YAMAMOTO Takashi wrote: On Wed, Sep 24, 2014 at 10:24:11AM +0900, YAMAMOTO Takashi wrote: This is a first step toward improving the abstraction of OXM and NXM in the tree. As an immediate improvement, this commit removes all of the

Re: [ovs-dev] [PATCH 12/17] nx-match: Use nx_put_header() internally for encoding flow matches.

2014-09-30 Thread Ben Pfaff
On Tue, Sep 30, 2014 at 09:04:26AM +0900, YAMAMOTO Takashi wrote: This will make it easier to support 64-bit OXM experimenter fields. Signed-off-by: Ben Pfaff b...@nicira.com static void -nxm_put_ipv6(struct ofpbuf *b, uint32_t header, +nxm_put_ipv6(struct ofpbuf *b, +

Re: [ovs-dev] [PATCH] CodingStyle: Mention our assumption about conversions to bool

2014-09-30 Thread YAMAMOTO Takashi
On Tue, Sep 30, 2014 at 08:07:58AM +0900, YAMAMOTO Takashi wrote: Signed-off-by: YAMAMOTO Takashi yamam...@valinux.co.jp Can't hurt to clarify this. Acked-by: Ben Pfaff b...@nicira.com applied. thank you. YAMAMOTO Takashi ___ dev mailing list

Re: [ovs-dev] [PATCH] bridge: Fix high cpu utilization.

2014-09-30 Thread Alex Wang
On Tue, Sep 30, 2014 at 5:13 PM, Joe Stringer joestrin...@nicira.com wrote: Maybe just stick with 5. 5 it is, also fold in the following check, applied to master~ diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at index 9be3078..2c72a7f 100644 --- a/tests/ovs-vswitchd.at +++

Re: [ovs-dev] [PATCH 15/17] nx-match: Add support for experimenter OXM.

2014-09-30 Thread Ben Pfaff
On Wed, Sep 24, 2014 at 10:57:08AM +0900, YAMAMOTO Takashi wrote: Testing experimenter OXM is tricky because I do not know of any in widespread use. Two ONF proposals use experimenter OXMs: EXT-256 and EXT-233. EXT-256 is not suitable to implement for testing because its use of

[ovs-dev] [PATCH v2 00/12] Better abstract OXM/NXM; EXT-314; EXT-233

2014-09-30 Thread Ben Pfaff
This series refactors how information about fields is managed at compile time, making it more flexible via a new extract-ofp-fields program. It uses that flexibility to centralize all knowledge of how OXM and NXM works in nx-match (from being split across nx-match, meta-flow, ofp-util, and

[ovs-dev] [PATCH v2 01/12] meta-flow: Autogenerate mf_field data structures.

2014-09-30 Thread Ben Pfaff
This is a first step toward improving the abstraction of OXM and NXM in the tree. As an immediate improvement, this commit removes all of the definitions of the OXM and NXM constants from the top-level header files, because they are no longer used anywhere. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH v2 02/12] util: New function bitwise_scan().

2014-09-30 Thread Ben Pfaff
This will acquire its first user in an upcoming commit. This implementation is not optimized at all but it doesn't matter for the purpose for which I intend to initially use it. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: YAMAMOTO Takashi yamam...@valinux.co.jp --- lib/util.c | 29

[ovs-dev] [PATCH v2 03/12] ovs-ofctl: Encode cookies in OXM-compliant manner.

2014-09-30 Thread Ben Pfaff
NXM/OXM are only supposed to put 1-bits in a value if the corresponding bit in the mask is a 1-bit, but in the case of cookie matching, e.g. ovs-ofctl del-flows br0 cookie=0x3/0x1 ovs-ofctl would encode a bad OXM. This fixes the problem. (The test ofproto - del flows based on cookie mask in

[ovs-dev] [PATCH v2 04/12] nx-match: Move all knowledge of OXM/NXM here.

2014-09-30 Thread Ben Pfaff
This improves the general abstraction of OXM/NXM by eliminating direct knowledge of it from the meta-flow code and other places. Some function renaming might be called for; for example, mf_oxm_header() may not be the best name now that the function is implemented within nx-match. However, these

[ovs-dev] [PATCH v2 05/12] ofp-actions: Better support OXM in Copy-Field action.

2014-09-30 Thread Ben Pfaff
The OpenFlow 1.5 (draft) Copy-Field action has two OXM headers, one after the other. Until now, Open vSwitch has implemented these as a pair of ovs_be32 members, which meant that only 32-bit OXM could be supported. This commit changes the implementation to use nx_pull_header(), which means that

[ovs-dev] [PATCH v2 06/12] ofp-actions: Support OF1.5 (draft) masked Set-Field, merge with reg_load.

2014-09-30 Thread Ben Pfaff
OpenFlow 1.5 (draft) extends the OFPAT_SET_FIELD action originally introduced in OpenFlow 1.2 so that it can set not just entire fields but any subset of bits within a field as well. This commit adds support for that feature when OpenFlow 1.5 is used. With this feature, OFPAT_SET_FIELD becomes a

[ovs-dev] [PATCH v2 11/12] ofp-actions: Support experimenter OXMs in Nicira extensions.

2014-09-30 Thread Ben Pfaff
Some of the Nicira extension actions include fixed-size 32-bit members that designate NXM fields. These actions can't accommodate 64-bit experimenter OXMs, so we need to figure out some kind of solution. This commit does that, in different ways for different actions. For some actions, I did not

[ovs-dev] [PATCH v2 08/12] nx-match: Speak of 'class' instead of 'vendor' for OXM/NXM.

2014-09-30 Thread Ben Pfaff
OXM renamed the 'vendor' field from NXM to the 'class', and uses the term experimenter, which OVS usually renders as vendor for historical reasons, as part of the extended 64-bit OXMs. To reduce confusion, this commit adopts the OXM terminology for class. Signed-off-by: Ben Pfaff b...@nicira.com

[ovs-dev] [PATCH v2 09/12] util: Make hexits_value() support 64-bit integers too.

2014-09-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- v1-v2: Fix inverted check in parse_nxm_field_name(). --- lib/json.c |5 +++-- lib/nx-match.c |7 +-- lib/util.c | 20 lib/util.h |2 +- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git

[ovs-dev] [PATCH v2 12/12] [RFC] flow: Support OF1.5+ (draft) actset_output field.

2014-09-30 Thread Ben Pfaff
This field allows a flow table to match on the output port currently in the action set. As-is, this patch has a number of deficiencies. I will fix them; I am posting for now because I feel like I have sat on this patch series for long enough. Known problems: * When the action set contains

Re: [ovs-dev] [PATCH] configure: Disable strict aliasing.

2014-09-30 Thread Jarno Rajahalme
I buy that, Acked-by: Jarno Rajahalme jrajaha...@nicira.com On Sep 30, 2014, at 5:03 PM, Ben Pfaff b...@nicira.com wrote: The C standard allows compilers to do type-based alias analysis, which means that the compiler is allowed to assume that pointers to objects of different types are

[ovs-dev] [PATCH 3/7] add lib/netdev-windows.c

2014-09-30 Thread Nithin Raju
In this patch, we add a lib/netdev-windows.c which mostly contains stub code and in subsequent patches, would use the netlink interface to query netdev information for a vport. The code implements netdev functionality for internal and system types of vports. Signed-off-by: Nithin Raju

[ovs-dev] [PATCH 5/7] datapath-windows: Add stub handlers for netdev commands

2014-09-30 Thread Nithin Raju
In this patch, we add stub handlers for the netdev commands. Signed-off-by: Nithin Raju nit...@vmware.com --- datapath-windows/ovsext/Datapath.c | 27 +-- datapath-windows/ovsext/Vport.c| 14 ++ 2 files changed, 39 insertions(+), 2 deletions(-) diff

[ovs-dev] [PATCH 7/7] datapath-windows: implementation of netdev commands

2014-09-30 Thread Nithin Raju
validation: - Vport dump works now without printing any errors. I didn't go so far as to test if vport add works. Signed-off-by: Nithin Raju nit...@vmware.com --- datapath-windows/ovsext/Vport.c | 242 +-- datapath-windows/ovsext/Vport.h |3 - 2 files

[ovs-dev] [PATCH 2/7] lib/netlink-socket.c: add support for OVS_WIN_NETDEV_FAMILY

2014-09-30 Thread Nithin Raju
In this patch, we add support for family ID lookup of OVS_WIN_NETDEV_FAMILY. Signed-off-by: Nithin Raju nit...@vmware.com --- lib/netlink-socket.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c index 1717ab8..d5e5728

Re: [ovs-dev] [PATCH 15/17] nx-match: Add support for experimenter OXM.

2014-09-30 Thread YAMAMOTO Takashi
On Wed, Sep 24, 2014 at 10:57:08AM +0900, YAMAMOTO Takashi wrote: Testing experimenter OXM is tricky because I do not know of any in widespread use. Two ONF proposals use experimenter OXMs: EXT-256 and EXT-233. EXT-256 is not suitable to implement for testing because its use of

[ovs-dev] OVS on Hyper-V: Items to discuss for 10/1 IRC meeting

2014-09-30 Thread Nithin Raju
hi Alin/Sorin, There were the items we had to discuss: 1. Netlink task status: vport, flow, events, packet. 2. Discussion on the vport addition workflow (and the document Alin sent out). I'll have some initial comments on the patches and document by tomorrow. 3. Discussion on packet receive

Re: [ovs-dev] [PATCH] README: Adding github markup and travis-ci build status to github readme page.

2014-09-30 Thread Pritesh Kothari (pritkoth)
On Sep 30, 2014, at 5:19 PM, Joe Stringer joestrin...@nicira.commailto:joestrin...@nicira.com wrote: On 1 October 2014 12:15, Pritesh Kothari pritesh.koth...@cisco.commailto:pritesh.koth...@cisco.com wrote: diff --git a/README.md b/README.md new file mode 100644 index 000..318f0e6 ---

Re: [ovs-dev] [PATCHv6 11/14] datapath: Add support for unique flow identifiers.

2014-09-30 Thread Joe Stringer
On 1 October 2014 11:59, Joe Stringer joestrin...@nicira.com wrote: On 1 October 2014 11:55, Pravin Shelar pshe...@nicira.com wrote: On Tue, Sep 30, 2014 at 3:15 PM, Joe Stringer joestrin...@nicira.com wrote: On 1 October 2014 06:56, Pravin Shelar pshe...@nicira.com wrote: On Mon,

[ovs-dev] [PATCH] ovs-vswitchd.at: Fix start additional ovs-vswitchd process test

2014-09-30 Thread YAMAMOTO Takashi
NetBSD implementation of wc command outputs extra whitespaces like the following. Tweak the test to success on such environments. % echo hoge|wc -l|hexdump -C 20 20 20 20 20 20 20 31 0a | 1.| 0009 % The failing test was introduced by

[ovs-dev] [PATCH] ofproto: flush groups and meters in ofproto_flush__

2014-09-30 Thread Gur Stavi
In fail-open mode on disconnect from controller rules are flushed. It makes sense to flush groups and meters as well. Signed-off-by: Gur Stavi gst...@mrv.commailto:gst...@mrv.com --- Original issue was discussed here: https://www.mail-archive.com/discuss@openvswitch.org/msg10930.html Index:

[ovs-dev] Delivery reports about your e-mail

2014-09-30 Thread The Post Office
Dear user of openvswitch.org, We have found that your account was used to send a huge amount of spam during this week. Most likely your computer had been compromised and now runs a trojan proxy server. Please follow the instruction in order to keep your computer safe. Have a nice day,

[ovs-dev] Mail System Error - Returned Mail

2014-09-30 Thread wbm
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-vswitchd.at: Fix start additional ovs-vswitchd process test

2014-09-30 Thread Joe Stringer
Thanks for fixing this. Acked-by: Joe Stringer joestrin...@nicira.com On 1 October 2014 18:10, YAMAMOTO Takashi yamam...@valinux.co.jp wrote: NetBSD implementation of wc command outputs extra whitespaces like the following. Tweak the test to success on such environments. % echo hoge|wc