Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

On Tue, Sep 20, 2016 at 3:40 PM, Aaron Conole wrote: > > `other_config:dpdk-extra' Thank you a lot, but even with my immediate issue being ok by that I'd still like the change to be integrated in OVS. -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix memory leak in execute_controller_action.

On Tue, Sep 20, 2016 at 10:35:46AM -0500, Ryan Moats wrote: > commit df70a7731 ("ofproto-dpif-xlate: Allow translating > without side-effects.") created a memory leak by removing the > dp_packet_delete statement in execute_controller_action that > freed the earlier cloned packet. This commit

Re: [ovs-dev] [PATCH] ovn-controller: Fix possible null pointer dereference.

> On Sep 20, 2016, at 10:00 AM, Ben Pfaff wrote: > > On Mon, Sep 19, 2016 at 06:01:15PM -0700, Justin Pettit wrote: >> The code dereferences "chassis", which could be null if chassis_run() >> returns null. "chassis" will always be null if "chassis_id" is null, so >> checking

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix memory leak in execute_controller_action.

commit df70a7731 ("ofproto-dpif-xlate: Allow translating without side-effects.") created a memory leak by removing the dp_packet_delete statement in execute_controller_action that freed the earlier cloned packet. This commit restores this statement to the end of the method. This issue is only

Re: [ovs-dev] [PATCH 1/3] ofproto: Do not signal revalidation for group mods twice.

On Fri, Sep 16, 2016 at 04:10:49PM -0700, Jarno Rajahalme wrote: > The new group mod implementation signals revalidation through > '->set_tables_version()', so the separate '->group_modify()' is no > longer needed. The ofproto-provider API is changed to allow > 'group_modify' to be NULL. > >

Re: [ovs-dev] [PATCH] datapath: avoid deferred execution of recirc actions

On Tue, Sep 20, 2016 at 5:55 AM, Lance Richardson wrote: > Port upstream fix to datapath module. The only notable difference > between this patch and the upstream version is that the value of > ovs_recursion_limit (5 for upstream kernel, 4 for out-of-tree > module) is

Re: [ovs-dev] [PATCH 2/2] ofp-actions: remove unused macro and function

On Wed, Sep 21, 2016 at 03:54:06AM +0800, Binbin Xu wrote: > The macro "OFPACT_FOR_EACH_TYPE" should be instead of > macro "OFPACT_FOR_EACH_TYPE_FLATTENED". The macro and > function with reference to "OFPACT_FOR_EACH_TYPE" can > be removed now. > > Signed-off-by: Binbin Xu

Re: [ovs-dev] [PATCH] ovn-controller: Fix possible null pointer dereference.

On Mon, Sep 19, 2016 at 06:01:15PM -0700, Justin Pettit wrote: > The code dereferences "chassis", which could be null if chassis_run() > returns null. "chassis" will always be null if "chassis_id" is null, so > checking "chassis" is sufficient to check both. > > Found by inspection. > >

Re: [ovs-dev] [PATCH 1/2] ofproto: fix the crash of process ovs-vswitchd

On Wed, Sep 21, 2016 at 03:54:05AM +0800, Binbin Xu wrote: > topology: > ++ > +>| SDN Controller |<--+ > | ++ | > || >

Re: [ovs-dev] [CudaMailTagged] [PATCH] bond: Fix the issue of negative number of "next rebalance"

On Tue, Sep 13, 2016 at 07:23:41AM +0800, Binbin Xu wrote: > The command "ovs-appctl bond/show" is used for display information > of bond ports. > > When bond mode is "balance_slb" or "balance_tcp", we can find that > the value followed behind "next rebalance" is negative somtimes. > >

[ovs-dev] sxzyfpbkppuni

The original message was included as attachment ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/2] ofproto: fix the crash of process ovs-vswitchd

topology: ++ +>| SDN Controller |<--+ | ++ | | | +---|-++---|-+ | +-+ |

[ovs-dev] [PATCH v2] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

The other_config:dpdk-rxq-size and dpdk-txq-size fields allow for an integer between 1 and 4096 that reflects the number of rx/tx descriptors to initialise 'dpdk' devices with. If no value is specified, they default to 2048. 'dpdk-*xq-size' fields must be set before launching the daemon as

Re: [ovs-dev] [PATCH] netdev-dpdk: Configure flow control only when necessary.

Hi Ilya, Thank you for sending out the patch. I verified that the patch is working fine. Please find some comments below. Regards _Sugesh > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, September 19, 2016 2:34 PM > To: dev@openvswitch.org;

[ovs-dev] [PATCH 2/2] ofp-actions: remove unused macro and function

The macro "OFPACT_FOR_EACH_TYPE" should be instead of macro "OFPACT_FOR_EACH_TYPE_FLATTENED". The macro and function with reference to "OFPACT_FOR_EACH_TYPE" can be removed now. Signed-off-by: Binbin Xu --- include/openvswitch/ofp-actions.h | 23 --- 1

Re: [ovs-dev] [PATCH] netdev-dpdk: Configure flow control only when necessary.

Hi, Sugesh, Thanks for review. My comments inline. Bets regards, Ilya Maximets. On 20.09.2016 11:41, Chandran, Sugesh wrote: > Hi Ilya, > Thank you for sending out the patch. > I verified that the patch is working fine. > Please find some comments below. > > Regards > _Sugesh > > >>

Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

On Sun, Sep 4, 2016 at 4:33 PM, Aaron Conole wrote: > Sorry for the top-post and don't want to be a pest - ping? You are not a pest at all Aaron. I already thank you for driving this all the time since we started looking at it about a year ago. Just as of now I face the

Re: [ovs-dev] NSH Option 2 implementation

> From: Jesse Gross [mailto:je...@kernel.org] > Sent: Friday, 16 September, 2016 01:38 > > I think the main issue is that when packets are being tunneled and NSH is in > use, the encapsulation format (and therefore OVS port > type) is not NSH - it's typically VXLAN-GPE. This is conceptually

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

> > Hi, Ciara. > I also wanted to do something like this. But, IMHO, this configuration > should be per port because different HW behaves differently and has > different capabilities. > > What do you think? > > For the implementation: I think, we should check that value is a power of 2 >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

Hi, Ciara. I also wanted to do something like this. But, IMHO, this configuration should be per port because different HW behaves differently and has different capabilities. What do you think? For the implementation: I think, we should check that value is a power of 2 because its required at

[ovs-dev] [PATCH] datapath: avoid deferred execution of recirc actions

Port upstream fix to datapath module. The only notable difference between this patch and the upstream version is that the value of ovs_recursion_limit (5 for upstream kernel, 4 for out-of-tree module) is maintained in this patch. Upstream commit: commit

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix memory leak in execute_controller_action.

> On Sep 20, 2016, at 8:35 AM, Ryan Moats wrote: > > commit df70a7731 ("ofproto-dpif-xlate: Allow translating > without side-effects.") created a memory leak by removing the > dp_packet_delete statement in execute_controller_action that > freed the earlier cloned packet.

Re: [ovs-dev] [PATCH 3/3] seq: Add support for initial delay before waking up.

Thanks for the review. I sent a v2 with an implementation that just does the right thing (I hope) in the revalidator thread itself. Jarno > On Sep 19, 2016, at 10:32 PM, Ben Pfaff wrote: > > On Fri, Sep 16, 2016 at 04:10:51PM -0700, Jarno Rajahalme wrote: >> The execution time

Re: [ovs-dev] [PATCH 1/3] ofproto: Do not signal revalidation for group mods twice.

> On Sep 20, 2016, at 8:20 AM, Ben Pfaff wrote: > > On Fri, Sep 16, 2016 at 04:10:49PM -0700, Jarno Rajahalme wrote: >> The new group mod implementation signals revalidation through >> '->set_tables_version()', so the separate '->group_modify()' is no >> longer needed. The

Re: [ovs-dev] [PATCH 2/3] token-bucket: Add token_bucket_wait_at().

> On Sep 19, 2016, at 5:19 PM, Ben Pfaff wrote: > > On Fri, Sep 16, 2016 at 04:10:50PM -0700, Jarno Rajahalme wrote: >> Having the caller of token_bucket_wait() indicated in the log messages >> makes debugging easier. >> >> Signed-off-by: Jarno Rajahalme > >

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

On Tue, 20 Sep 2016 15:13:38 +0100 Ciara Loftus wrote: > The 'options:n_rxq_desc' and 'n_txq_desc' fields allow the number of > rx and tx descriptors for dpdk ports to be modified. By default the > values are set to 2048, but can be modified to an integer between 1 > and

[ovs-dev] [PATCH v2] upcall: Don't start new revalidation round too soon after the last one.

The execution time of 'ovs-ofctl add-flows' with a large number of flows can be more than halved if revalidators are not running after each flow mod separately. This was first suspected when it was found that 'ovs-ofctl --bundle add-flows' is about 10 times faster than the same command without

Re: [ovs-dev] [PATCH] ovn-vtep: fix arping from vtep-gw physical port

On Tue, Sep 20, 2016 at 2:38 PM, Ramu Ramamurthy wrote: > > > > Does the following diff work on your system? > > > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 7797417..4f1cd89 100644 > > --- a/ovn/northd/ovn-northd.8.xml > >

[ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

OVS IPsec tunnel support has issues: 1. It only works for GRE. 2. only works on Debian. 3. It does not allow user to match on packet-mark on packet received on tunnel ports. Therefore following patch provide alternative to completely disable ipsec-tunnel support by vswitchd command line

[ovs-dev] [PATCH 1/5] datapath-windows: read overrun in vxlan.c

Fix possible read overrun. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Vxlan.c b/datapath-windows/ovsext/Vxlan.c index ddd8d8e..8a681a9 100644

[ovs-dev] [PATCH 5/5] datapath-windows: fix return value in conntrack

'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type bool. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Conntrack.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[ovs-dev] [PATCH 4/5] datapath-windows: read overrun in geneve.c

Fix possible read overrun. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ovsext/Geneve.c index 5712e4d..65e547f

[ovs-dev] [PATCH 3/5] datapath-windows: read overrun in gre.c

Fix possible read overrun. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c index 1976b08..a0c953b 100644 ---

[ovs-dev] [PATCH 2/5] datapath-windows: read overrun in stt.c

Fix possible read overrun. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Stt.c b/datapath-windows/ovsext/Stt.c index ad322d2..cc0f912 100644 ---

Re: [ovs-dev] Setting pmd-cpu-mask in cluster-on-die mode

On 09/19/2016 10:28 AM, Jeremias Blendin wrote: Hello Mauricio, thank you for the pointer to the bin-to-hex conversion, I knew it looked strange but I could not see why m) In any case, it was just an example, the actual configuration for testing is correct. 2016-09-18 18:25 GMT+02:00

Re: [ovs-dev] [PATCH] ovn-vtep: fix arping from vtep-gw physical port

> > Does the following diff work on your system? > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > index 7797417..4f1cd89 100644 > --- a/ovn/northd/ovn-northd.8.xml > +++ b/ovn/northd/ovn-northd.8.xml > @@ -421,8 +421,8 @@ > > > > -Priority-100

[ovs-dev] [PATCH] Windows: Disable python3 tests

Until the effort of the python series is integrated, disable the python3 tests under Windows. Signed-off-by: Alin Gabriel Serdean --- tests/atlocal.in | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/atlocal.in b/tests/atlocal.in index 55070d8..f518cda

[ovs-dev] [PATCH] OVSDB: Fix segfalut during replication.

The newly added replication logic makes it possible for a monitor to receive delete and insertion of the same row back to back, which was not possible before. Add logic (and comment) to handle this case to avoid follow crash reported by Valgrind: #0 0x00453edd in

Re: [ovs-dev] [PATCH] Windows: Disable python3 tests

On 20 September 2016 at 12:09, Alin Serdean wrote: > Until the effort of the python series is integrated, disable the python3 > tests under Windows. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks! > --- >

Re: [ovs-dev] [CudaMailTagged] [PATCH] bond: Fix the issue of negative number of "next rebalance"

I just think the negative number may puzzle someone. The positive number may be better, it shows us the left time to next rebalance. Ben Pfaff 写于 2016/09/20 23:15:22: > 发件人: Ben Pfaff > 收件人: Binbin Xu , > 抄送: dev@openvswitch.org > 日期:

Re: [ovs-dev] [PATCH] OVSDB: Fix segfalut during replication.

On 20 September 2016 at 13:27, Andy Zhou wrote: > The newly added replication logic makes it possible for a monitor to > receive delete and insertion of the same row back to back, which > was not possible before. Add logic (and comment) to handle this > case to avoid follow crash

Re: [ovs-dev] [PATCH 2/5] datapath-windows: read overrun in stt.c

Please disregard this patch I'll post a new series. > -Original Message- > From: Alin Serdean > Sent: Wednesday, September 21, 2016 12:08 AM > To: dev@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH 2/5] datapath-windows: read overrun in stt.c > >

[ovs-dev] [PATCH 1/6] revalidator: Refactor ukey->xout translation.

This patch shifts the code that directly calls xlate into a separate function, xlate_ukey(). Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 110 -- 1 file changed, 73 insertions(+), 37 deletions(-) diff --git

Re: [ovs-dev] [RFC v2 5/5] ofproto-dpif-upcall: Add instant revalidation.

On 30 August 2016 at 18:47, Daniele Di Proietto wrote: > Sometimes the ofproto layer creates a flow which is not liked by the > revalidation for various reasons. This behavior, while not critical > might impact the performance. This commit adds a facility to detect >

Re: [ovs-dev] [PATCH 1/5] datapath-windows: read overrun in vxlan.c

Please disregard this patch I'll post a new series. > -Original Message- > From: Alin Serdean > Sent: Wednesday, September 21, 2016 12:07 AM > To: dev@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH 1/5] datapath-windows: read overrun in vxlan.c > >

Re: [ovs-dev] [PATCH 3/5] datapath-windows: read overrun in gre.c

Please disregard this patch I'll post a new series. > -Original Message- > From: Alin Serdean > Sent: Wednesday, September 21, 2016 12:08 AM > To: dev@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH 3/5] datapath-windows: read overrun in gre.c > >

Re: [ovs-dev] [PATCH 4/5] datapath-windows: read overrun in geneve.c

Please disregard this patch I'll post a new series. > -Original Message- > From: Alin Serdean > Sent: Wednesday, September 21, 2016 12:08 AM > To: dev@openvswitch.org > Cc: Alin Serdean > Subject: [PATCH 4/5] datapath-windows: read overrun in geneve.c >

Re: [ovs-dev] [PATCH] OVSDB: Fix segfalut during replication.

On Tue, Sep 20, 2016 at 4:39 PM, Joe Stringer wrote: > On 20 September 2016 at 13:27, Andy Zhou wrote: > > The newly added replication logic makes it possible for a monitor to > > receive delete and insertion of the same row back to back, which > > was not possible

[ovs-dev] Receipt 4062361 from The Music Zoo

Thank you for your order!  Please find your final sales receipt attached to this email. Your USPS Tracking Number is: 0072652323136379606377 This order will ship tomorrow and you should be able to begin tracking tomorrow evening after it is picked up. If you have any questions or experience any

[ovs-dev] [PATCH] openvswitch: deprecates support for IPsec tunnel port.

OVS IPsec tunnel support has issues: 1. It only works for GRE. 2. only works on Debian. 3. It does not allow user to match on packet-mark on packet received on tunnel ports. This patch deprecates support for IPsec tunnel port. Signed-off-by: Pravin B Shelar --- After

[ovs-dev] [PATCH] ovsdb: Fix memory leak when disposing 'replication_dbs'

Found by inspection. The 'replication_dbs' structure was not freed after use. Fix by adding a new function replication_dbs_destroy(). Also remove unnecessary global pointer variables initializer. Signed-off-by: Andy Zhou --- ovsdb/replication.c | 21 ++--- 1

[ovs-dev] [PATCH 3/6] revalidator: Refactor revalidation early exit.

Shift the early-exit conditions for revalidation into a separate function. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 136 -- 1 file changed, 78 insertions(+), 58 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c

[ovs-dev] [PATCH 2/6] revalidator: Don't modify ukey from xlate_ukey().

Refactor the newly introduced xlate_ukey() function to just perform the translation, not modify the ukey. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git

[ovs-dev] [PATCH 0/6] Refactor revalidate_ukey().

The function revalidate_ukey() has bothered me for some time. It's long enough with enough local variables that it's easy to forget to properly cleanup after a function call. Error conditions are interspersed with optimizations to shortcut revalidation so it's easy to forget how changes are

[ovs-dev] [PATCH 5/6] revalidator: Defer stats push to end of validation.

To make more of the core revalidate() functions do just one thing and not modify state on the way, refactor them to prepare the xcache then defer the ukey modification and stats/side effects execution to the end of successful revalidation. If revalidation causes deletion, then the xcache will be

[ovs-dev] [PATCH 4/6] revalidator: Reuse xlate_ukey from deletion.

This code was already very similar to the actual revalidation code, but previously it wasn't structured quite closely enough to share it. Do so. xlate_actions_for_side_effects() is now unused, so remove it. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 48

[ovs-dev] [PATCH 6/6] revalidator: Simplify full-revalidation code.

Simplify the remaining bits of the original revalidation codepath to only handle the "full-revalidation" case. Make the 'ukey' parameter purely const by pushing the only piece that gets changed into a separate argument. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c

Re: [ovs-dev] [PATCH v4 0/3] vhost-user: Add the ability to control ownership/permissions

Christian Ehrhardt writes: ... > But now even worse than having to have a delta for such a long time it seems > we have to add > openvswitch delta as well. > This is due to the EAL commandline no more being "reachable" via > "ovs-vswitchd [...] --dpdk >

[ovs-dev] Emailing: _1303_33759

Your message is ready to be sent with the following file or link attachments: _1303_33759 Note: To protect against computer viruses, e-mail programs may prevent sending or receiving certain types of file attachments. Check your e-mail security settings to determine how attachments are

[ovs-dev] error while applying the patch for GTP-U

Dear Developers, I applied the attached patch and tried to run the command make and got some errors. From the error I realised that the patch was written for OVS 2.5 by looking at the error. Now for installing OVS 2.5 on ubuntu, we need a linux kernel not later than 4.3. But now if we download

[ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

In order to use rtnetlink to create new tunnel vports, the backported tunnels require some code that was removed from their upstream version, mainly the necessary code for newlink and for start_xmit. This patch adds back the necessary code for VXLAN, GRE and Geneve tunnels. Signed-off-by: Eric

Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number

On 19 September 2016 at 16:16, Shashank Ram wrote: > Adds a define for the last defined module number. > > Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c > Signed-off-by: Shashank Ram > I removed the Change-Id, added you to AUTHORS and applied this to

Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number

-Original Message- From: dev on behalf of Guru Shetty Date: Tuesday, September 20, 2016 at 7:40 AM To: Shashank Ram Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last

[ovs-dev] documents

-- Deana belcher Office Manager Box Rentals LLC Sanibel Executive Suites Crestwood Apts. Cleveland Apts. rayatboxrent...@cableone.net www.sanibelsuites.com 2230 East 8th St / Office Joplin, Mo.64801 Cell- 417-312-3661 Office- 417-624-7900 Fax- 417-624-7971

[ovs-dev] [PATCH v3] netdev-dpdk: Allow configurable queue sizes for 'dpdk' ports

The 'options:n_rxq_desc' and 'n_txq_desc' fields allow the number of rx and tx descriptors for dpdk ports to be modified. By default the values are set to 2048, but can be modified to an integer between 1 and 4096 that is a power of two. The values can be modified at runtime, however require the