Re: [ovs-dev] [PATCH] tests: Get rid of overly specific --pidfile and --unixctl options.

On Wed, Oct 12, 2016 at 12:00:00AM -0700, Andy Zhou wrote: > On Wed, Oct 5, 2016 at 8:11 PM, Ben Pfaff wrote: > > > At an early point in OVS development, OVS was built with fixed default > > directories for pidfiles and sockets. This meant that it was necessary to > > use lots of

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash in dpif_netdev_execute().

On Tue, Oct 04, 2016 at 04:25:35PM -0700, Daniele Di Proietto wrote: > dp_netdev_get_pmd() is allowed to return NULL (even if we call it with > NON_PMD_CORE_ID) for different reasons: > > * Since we use RCU to protect pmd threads, it is possible that > ovs_refcount_try_ref_rcu() has failed. > *

Re: [ovs-dev] [PATCH 01/13] netdev-dpdk.h: Add missing copyright.

On Tue, Oct 04, 2016 at 06:22:12PM -0700, Daniele Di Proietto wrote: > Looks like we forgot to add the copyright headers to netdev-dpdk.h. > Looking at the contribution history of the file, this commit adds the > header with Nicira copyright. > > Signed-off-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH 03/13] netdev-dpdk: Refactor dpdk_mp_get().

On Tue, Oct 04, 2016 at 06:22:14PM -0700, Daniele Di Proietto wrote: > The error handling path in dpdk_mp_get() is getting complicated, it > even requires a boolean variable. > > Simplify it by extracting the function dpdk_mp_create(). > > CC: Ilya Maximets >

Re: [ovs-dev] [PATCH] tests: Fix double-rebuild of testsuite for "check-valgrind".

On Wed, Oct 12, 2016 at 10:42:36AM -0700, Ben Pfaff wrote: > On Tue, Oct 11, 2016 at 04:58:26PM -0700, Andy Zhou wrote: > > On Wed, Oct 5, 2016 at 6:28 PM, Ben Pfaff wrote: > > > > > When I ran "make check-valgrind -j10" and the testsuite needed to be > > > rebuilt, two copies of

Re: [ovs-dev] [PATCH 02/13] netdev-nodpdk.c: Add missing copyright.

On Tue, Oct 04, 2016 at 06:22:13PM -0700, Daniele Di Proietto wrote: > Looks like we forgot to add the copyright headers to netdev-dpdk.h. > Looking at the contribution history of the file, this commit adds the > header with Red Hat copyright. > > CC: Aaron Conole >

Re: [ovs-dev] [PATCH 01/12] dpcls: Use 32 packet batches for lookups.

On Tue, Oct 11, 2016 at 8:33 AM, Fischetti, Antonio wrote: > Comments inline. > > Thanks, > Antonio > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno >> Rajahalme >> Sent: Friday, October 7, 2016 10:08 PM >> To:

Re: [ovs-dev] [PATCH ovs RFC 0/9] Introducing HW offload support for openvswitch

Sorry for jumping in a bit late. I have couple of high level comments below. On Thu, Oct 6, 2016 at 10:10 AM, Rony Efraim wrote: > From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, October 06, 2016 > 5:06 AM >> >> Subject: Re: [ovs-dev] [PATCH ovs RFC 0/9]

Re: [ovs-dev] [PATCH 12/13] dpdk: New module with some code from netdev-dpdk.

Daniele Di Proietto writes: > There's a lot of code in netdev-dpdk which is not at all related to the > netdev interface, mostly the library initialization code. > > This commit moves it to a new 'dpdk' module, to simplify 'netdev-dpdk'. > > Also a new module 'dpdk-stub'

[ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

This commit returns the updated column value when getattr is done after a mutate operation is performed (but before the commit). Signed-off-by: Amitabha Biswas Reported-by: Richard Theis Reported-at:

Re: [ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

Thanks! I reposted the patch with the update to the commit message. Amitabha > On Oct 12, 2016, at 1:16 PM, Russell Bryant wrote: > > > > On Wed, Oct 12, 2016 at 10:32 AM, Amitabha Biswas > wrote: > This commit returns the

[ovs-dev] [PATCH] netdev: Initialize netdev's features before getting them

When OVS is used, DPDK doesn't support features 'advertised', 'supported' and 'peer'. If a physical port added to bridge, features descirbed above can't be assigned, and the values are random. Signed-off-by: Binbin Xu --- lib/netdev.c | 6 +++--- 1 file changed, 3

Re: [ovs-dev] [PATCH] netdev-dpdk: Optimise the initialization of "port_conf"

> >"port_conf" is a global const variables, and in function >dpdk_eth_dev_queue_setup >it is asigned to the local variables "conf". The jumbo_frame bit is set in the >local varables, previous configuration shouldn't influence on the other port. > >Thanks Yes, you're right. In one of my earlier

[ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

This commit returns the updated column value when getattr is done after a mutate operation is performed (but before the commit). It addresses the bug reported in http://openvswitch.org/pipermail/dev/2016-September/080120.html Signed-off-by: Amitabha Biswas Reported-by:

Re: [ovs-dev] Why not implement netdev datapath in a separated process

Huanle Han writes: > Hi, Hi Huanle, > I'm thinking about this quesion, after experience the dpdk feature in ovs. > Could you give me some answer? I'll take a stab at it. > Currently, netdev datapath(or called dpdk) is implemented inside daemon > process "ovs-vswitchd". >

[ovs-dev] Always generate port status on port config change (EXT-338) in OpenFlow 1.5.

Hi All, It's my great pleasure to participate in the OpenVSwitch Community. I would like to work on "Always generate port status on port config change (EXT-338)" and contribute for the same. If anybody has already started and working on this do please let me know, to avoid duplication of work.

Re: [ovs-dev] [PATCH] netdev: Initialize netdev's features before getting them

Hi Binbin, Binbin Xu writes: > When OVS is used, DPDK doesn't support features 'advertised', > 'supported' and 'peer'. If a physical port added to bridge, features > descirbed above can't be assigned, and the values are random. > > Signed-off-by: Binbin Xu

[ovs-dev] Why not implement netdev datapath in a separated process

Hi, I'm thinking about this quesion, after experience the dpdk feature in ovs. Could you give me some answer? Currently, netdev datapath(or called dpdk) is implemented inside daemon process "ovs-vswitchd". It makes ovs-vswitchd not that stable as before: 1. some ovsbd config for dpdk requires

Re: [ovs-dev] [PATCH 04/13] netdev-dpdk: Use RCU for egress QoS.

On Tue, Oct 04, 2016 at 06:22:15PM -0700, Daniele Di Proietto wrote: > I think it's clearer to use RCU than to check for a pointer twice in the > fast path (before and after taking the spinlock). Now the spinlock is > integrated into 'qos_conf'. > > 'qos_conf' objects cannot be modified, so,

Re: [ovs-dev] [PATCH 05/13] netdev-dpdk: Acquire dev->stats_lock only once.

On Tue, Oct 04, 2016 at 06:22:16PM -0700, Daniele Di Proietto wrote: > Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 06/13] netdev-dpdk: Do not abort if out of hugepage memory.

On Tue, Oct 04, 2016 at 06:22:17PM -0700, Daniele Di Proietto wrote: > We can run out of hugepage memory coming from rte_*alloc() more easily > than heap coming from malloc(). > > Therefore: > > * We should use hugepage memory if we're going to access it only in > the slowpath. > * We

Re: [ovs-dev] [PATCH 07/13] netdev-dpdk: Use xasprintf() when possible.

On Tue, Oct 04, 2016 at 06:22:18PM -0700, Daniele Di Proietto wrote: > We're in the slowpath. I find it easier to allocate and free memory, > than to handle snprintf() error condition. > > Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH] vagrant: add CentOS 7.2 support

On Tue, Sep 27, 2016 at 04:13:11PM -0300, Thadeu Lima de Souza Cascardo wrote: > Signed-off-by: Thadeu Lima de Souza Cascardo Applied to master, thanks! ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 08/13] netdev-dpdk: Remove useless nonpmd_mempool_mutex.

On Tue, Oct 04, 2016 at 06:22:19PM -0700, Daniele Di Proietto wrote: > Since DPDK commit 30e639989227("mempool: support non-EAL thread"), > non-EAL threads can use the mempool API safely. Plus, nonpmd threads > access to netdev is already serialized with 'non_pmd_mutex' in > dpif-netdev. > >

Re: [ovs-dev] [PATCH v1] Python-IDL: getattr after mutate fix

On Wed, Oct 12, 2016 at 10:32 AM, Amitabha Biswas wrote: > This commit returns the updated column value when getattr is done > after a mutate operation is performed (but before the commit). It > addresses the bug reported in >

Re: [ovs-dev] [ovs-dev, 09/13] netdev-dpdk: Remove useless 'rte_eal_init_ret'.

On Tue, Oct 04, 2016 at 06:22:20PM -0700, Daniele Di Proietto wrote: > If rte_eal_init() fails, we do not register the DPDK netdev classes, > therefore it's impossible to reach the classes construct functions. > > Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 0/9 md->rst] Convert most INSTALL guides

On Sat, Oct 8, 2016 at 12:30 PM, Stephen Finucane wrote: > I'm going to dripfeed the conversion patches to avoid overloading > peoples (there are ~25 of them so far). This is the first batch. > > Stephen Finucane (9): > dist-docs: Add support for rST > doc: Convert INSTALL

[ovs-dev] Ich brauche Ihre Unterstützung zu investieren !!

Sehr geehrte Damen und Herren, Ich brauche Ihre Unterstützung in Ihrem Land zu verlagern und zu investieren. Ich bitte Sie um Hilfe, weil ich nicht das Wissen über Geschäft und die Regeln, die ihr Land für eine sichere Investition führen. Werden Sie versprechen, mit mir aufrichtig zu sein?

Re: [ovs-dev] [ovs-dev, 10/13] netdev-dpdk: Use init() function to initialize classes.

On Tue, Oct 04, 2016 at 06:22:21PM -0700, Daniele Di Proietto wrote: > It's better to use the classes init() functions to perform > initialization required for classes. > > This will make it easier to move dpdk_init__() to a separate module in a > future commit. > > No functional change. > >

Re: [ovs-dev] [PATCH 11/13] netdev-dpdk: Change vlog module name to 'netdev_dpdk'.

On Tue, Oct 04, 2016 at 06:22:22PM -0700, Daniele Di Proietto wrote: > It is customary to have the vlog module name similar to the filename. > Plus a following commit will introduce a 'dpdk' module. > > Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH] tests: Get rid of overly specific --pidfile and --unixctl options.

On Wed, Oct 5, 2016 at 8:11 PM, Ben Pfaff wrote: > At an early point in OVS development, OVS was built with fixed default > directories for pidfiles and sockets. This meant that it was necessary to > use lots of --pidfile and --unixctl options in the testsuite, to point the >

Re: [ovs-dev] [PATCH 06/13] netdev-dpdk: Do not abort if out of hugepage memory.

> On Oct 4, 2016, at 6:22 PM, Daniele Di Proietto > wrote: > > We can run out of hugepage memory coming from rte_*alloc() more easily > than heap coming from malloc(). > > Therefore: > > * We should use hugepage memory if we're going to access it only in > the slow

Re: [ovs-dev] [PATCH 12/13] dpdk: New module with some code from netdev-dpdk.

On 12/10/2016 13:59, "Aaron Conole" wrote: >Daniele Di Proietto writes: > >> There's a lot of code in netdev-dpdk which is not at all related to the >> netdev interface, mostly the library initialization code. >> >> This commit moves it to a new

[ovs-dev] [PATCH] ofproto: Return the OFPC_BUNDLES bit in switch features reply.

Add definitions for the OpenFlow 1.5 specific capabilities bits OFPC15_BUNDLES and OFPC15_FLOW_MONITORING. Return the bundles capability bit in switch features reply. Reported-by: Andrej Leitner Signed-off-by: Jarno Rajahalme ---

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash in dpif_netdev_execute().

On 12/10/2016 12:37, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 04:25:35PM -0700, Daniele Di Proietto wrote: >> dp_netdev_get_pmd() is allowed to return NULL (even if we call it with >> NON_PMD_CORE_ID) for different reasons: >> >> * Since we use RCU to protect pmd threads,

Re: [ovs-dev] [PATCH 11/13] netdev-dpdk: Change vlog module name to 'netdev_dpdk'.

On 12/10/2016 13:27, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 06:22:22PM -0700, Daniele Di Proietto wrote: >> It is customary to have the vlog module name similar to the filename. >> Plus a following commit will introduce a 'dpdk' module. >> >> Signed-off-by: Daniele Di

Re: [ovs-dev] [PATCH 03/13] netdev-dpdk: Refactor dpdk_mp_get().

On 12/10/2016 12:45, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 06:22:14PM -0700, Daniele Di Proietto wrote: >> The error handling path in dpdk_mp_get() is getting complicated, it >> even requires a boolean variable. >> >> Simplify it by extracting the function

Re: [ovs-dev] [PATCH 06/13] netdev-dpdk: Do not abort if out of hugepage memory.

On 12/10/2016 16:23, "Jarno Rajahalme" wrote: > >> On Oct 4, 2016, at 6:22 PM, Daniele Di Proietto >> wrote: >> >> We can run out of hugepage memory coming from rte_*alloc() more easily >> than heap coming from malloc(). >> >> Therefore: >> >> *

Re: [ovs-dev] [PATCH 04/13] netdev-dpdk: Use RCU for egress QoS.

On 12/10/2016 13:04, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 06:22:15PM -0700, Daniele Di Proietto wrote: >> I think it's clearer to use RCU than to check for a pointer twice in the >> fast path (before and after taking the spinlock). Now the spinlock is >> integrated into

Re: [ovs-dev] [PATCH 02/13] netdev-nodpdk.c: Add missing copyright.

On 12/10/2016 12:43, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 06:22:13PM -0700, Daniele Di Proietto wrote: >> Looks like we forgot to add the copyright headers to netdev-dpdk.h. >> Looking at the contribution history of the file, this commit adds the >> header with Red Hat

Re: [ovs-dev] [PATCH 01/13] netdev-dpdk.h: Add missing copyright.

On 12/10/2016 12:42, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 06:22:12PM -0700, Daniele Di Proietto wrote: >> Looks like we forgot to add the copyright headers to netdev-dpdk.h. >> Looking at the contribution history of the file, this commit adds the >> header with Nicira

Re: [ovs-dev] [PATCH] tests: Fix double-rebuild of testsuite for "check-valgrind".

On Tue, Oct 11, 2016 at 04:58:26PM -0700, Andy Zhou wrote: > On Wed, Oct 5, 2016 at 6:28 PM, Ben Pfaff wrote: > > > When I ran "make check-valgrind -j10" and the testsuite needed to be > > rebuilt, two copies of it were rebuilt in parallel and sometimes they > > raced with each

[ovs-dev] ovn: Improving southbound database security

Hello, I'm back to looking at southbound database security concerns in OVN. A previous thread discussing approaches was here: http://openvswitch.org/pipermail/dev/2016-August/078106.html I'm now working with a few others on implementing a proposed solution. The overview is that we'd like

Re: [ovs-dev] [PATCH] rhel-systemd: Delay shutting down the services

On Fri, Oct 7, 2016 at 1:36 PM, Aaron Conole wrote: > During testing it was found that systemd would consider the openvswitch > service as a part of networking component, but the dependent services of > ovs-vswitchd and ovsdb-server were not likewise considered. This leads >

Re: [ovs-dev] Always generate port status on port config change (EXT-338) in OpenFlow 1.5.

On Wed, Oct 12, 2016 at 05:52:13PM +0530, varsha agarwal wrote: > It's my great pleasure to participate in the OpenVSwitch Community. > > I would like to work on "Always generate port status on port config > change (EXT-338)" and contribute for the same. > > If anybody has already started and

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

On Fri, Oct 7, 2016 at 1:48 PM, Flavio Leitner wrote: > On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote: > > On 09/08/2016 05:50 PM, Aaron Conole wrote: > > > > > >> It sounds like new feature territory, but you do make a case for it > being considered a set of

Re: [ovs-dev] [PATCH 1/6] checkpatch: Fix up the co-authors check

Aaron Conole writes: > The signed-off and co-authors check that was committed is just plain > wrong. The test should be more than 1 'Signed-off-by'. > > Signed-off-by: Aaron Conole > --- > utilities/checkpatch.py | 6 +++--- > 1 file changed, 3

Re: [ovs-dev] [PATCH 05/12] dpif-netdev: Clear flow batches inside packet_batch_execute.

Looks good to me, could you send this in the next version of the series? Thanks, Daniele 2016-10-11 9:14 GMT-07:00 Fischetti, Antonio : > Thanks Daniele for all your explanations. > Instead of the proposed changes, is it worth to add a comment to the code > just to

[ovs-dev] [PATCH] netdev-dpdk: Assign value '0' to unsupported netdev features

When OVS is used, DPDK doesn't support features 'advertised', 'supported' and 'peer'. If a physical port added to bridge, features descirbed above can't be assigned, and the values are random. Signed-off-by: Binbin Xu --- lib/netdev-dpdk.c | 8 +--- 1 file changed, 5

[ovs-dev] 答复: Re: [PATCH] netdev: Initialize netdev's features before getting them

Hi Aaron, Thanks for your suggestion, I'll resubmit a patch for DPDK, and take a look at lib/netdev-bsd.c to confirm that the additional patch is needed or not. Thanks, Aaron Conole 写于 2016/10/12 21:26:14: > 发件人: Aaron Conole > 收件人: Binbin Xu

Re: [ovs-dev] [PATCH v3 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Sun, Oct 9, 2016 at 12:02 AM, Babu Shanmugam wrote: > > > On Friday 07 October 2016 05:33 AM, Andy Zhou wrote: > >> Babu, Thank you for working on this. At a high level, it is not clear >> to me the boundary between ocf scripts and the ovn-ctl script -- i.e. which >>

Re: [ovs-dev] [PATCH v3 1/4] ovn: ovn-ctl support for HA ovn DB servers

On Thursday 13 October 2016 07:26 AM, Andy Zhou wrote: On Sun, Oct 9, 2016 at 12:02 AM, Babu Shanmugam > wrote: On Friday 07 October 2016 05:33 AM, Andy Zhou wrote: Babu, Thank you for working on this. At a high level, it is