in nl_sock_transact_multiple__() has not been touched
since it is not needed yet.
Main motive for this change is to be able to unblock the DP Dump workflow.
Signed-off-by: Nithin Raju nit...@vmware.com
---
lib/netlink-socket.c | 46 ++
1 files changed, 26
agreed that pending patches need to be reviewed soon, esp. the multiple
NB patch.
thanks,
Nithin
On Aug 26, 2014, at 10:20 AM, Nithin Raju
nit...@vmware.commailto:nit...@vmware.com wrote:
hi Alin/Sam,
These were the items we wanted to discuss:
1. Netlink implementation:
* status
* work
On Aug 27, 2014, at 11:19 AM, Eitan Eliahu elia...@vmware.com wrote:
+if (!DeviceIoControl(sock-handle, OVS_IOCTL_READ,
+ NULL, 0, tail, sizeof tail, bytes, NULL))
...
+memcpy(ofpbuf_data(buf), tail, retval);
+
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.h | 54 ++--
1 files changed, 45 insertions(+), 9 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.h
b/datapath-windows/ovsext/Datapath.h
index 6d8a6db..0b303a2 100644
:
- With a hacked up dpif-linux.c to work on Windows,
dpif_linux_enumerate() successfully enumerated the datapaths in the
kernel.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c | 220 ++--
1 files changed, 186 insertions(+), 34
I didn't realize earlier that version in a netlink message was a
UINT8. So, fixing that here.
Also, some of the commands don't pass a valid DP value. Hence adding
a field to identify such commands.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c | 74
keeps the code clean, IMO.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c | 72 ++-
datapath-windows/ovsext/Datapath.h | 37 ++
2 files changed, 58 insertions(+), 51 deletions(-)
diff --git a/datapath
On Aug 28, 2014, at 4:16 PM, Ankur Sharma ankursha...@vmware.com
wrote:
Hi NIthin,
Changes are fine.
One very minor comment would be that we should improve the formatting of
InitUserDumpState function. But this can be handled later, we are good for
checkin.
hi Ankur,
Thanks for the
On Aug 28, 2014, at 4:17 PM, Ankur Sharma ankursha...@vmware.com
wrote:
Add a description for each member of OVS_USER_PARAMS_CONTEXT
Done. I'll be sending out a patch for this.
thanks,
Nithin
___
dev mailing list
dev@openvswitch.org
On Aug 28, 2014, at 4:19 PM, Ankur Sharma ankursha...@vmware.com
wrote:
One minor comment:
1. In function OvsGetDpCmdHandler, we should check for devOp at line 830
rather than dump_state.
Done. I'll incorporate in the patch I'll send out.
thanks for the review.
-- Nithin
On Aug 28, 2014, at 6:40 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hello Nithin,
I have a few notes regarding the patch:
struct {
POVS_MESSAGE ovsMsg;/* OVS message passed during dump start. */
UINT32 index[8];/* markers to continue dump from.
On Aug 28, 2014, at 6:52 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hello Nithin,
BOOLEAN validateDp; /* Does command require a valid DP argument. */
} NETLINK_CMD, *PNETLINK_CMD;
Perhaps a better name would be validateDpIfIndex? Or, is there going to be
On Aug 28, 2014, at 7:22 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hello Nithin,
/* Netlink datapath family. */
NETLINK_CMD nlDatapathFamilyCmdOps[] = {
{ OVS_DP_CMD_GET, OvsGetDpCmdHandler,
OVS_WRITE_DEV_OP | OVS_READ_DEV_OP, FALSE }
};
Could you make the
I didn't realize earlier that version in a netlink message was a
UINT8. So, fixing that here.
Also, some of the commands don't pass a valid DP value. Hence adding
a field to identify such commands.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.h | 54 ++--
1 files changed, 45 insertions(+), 9 deletions(-)
diff --git
Also renamed the validateDp boolean to a more meaningful name.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c |6 +++---
1 files changed, 3 insertions
refactor that too.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c | 66 ++--
1 files changed, 40 insertions(+), 26 deletions
A review comment was that we should check for device operation
rather than whether the dump context while deciding if the operation
is a dump start or a dump continue.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi
keeps the code clean, IMO.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c | 72 ++-
datapath-windows/ovsext/Datapath.h | 37
:
- With a hacked up dpif-linux.c to work on Windows,
dpif_linux_enumerate() successfully enumerated the datapaths in the
kernel.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.h | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.h | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/datapath-windows/ovsext
hi Sam/Alin,
Thanks for working on this.
In general, it would have been better if the two changes:
1. handle NBL with multiple NBs
2. Optimizing the parsing code to handle NBs rather than NBLs.
could have been split into different review. I was not a big fan of split up
changes into multiple
hi Sam/Alin,
Thanks for working on this.
In general, it would have been better if the two changes:
1. handle NBL with multiple NBs
2. Optimizing the parsing code to handle NBs rather than NBLs.
could have been split into different review. I was not a big fan of split up
changes into multiple
hi Sam,
Pls. find my answers inlined. Pls. feel free to repost the patches for the two
different functionalities.
On Sep 6, 2014, at 2:39 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Yes, you were right with the TSO. I'll send a new version of the patch,
though I am not sure how
During a review, it seemed that some of the conventions were not clear.
Fixing them in this patch.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/CodingStyle | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/CodingStyle b
During a review, it seemed that some of the conventions were not clear.
Fixing them in this patch.
Signed-off-by: Nithin Raju nit...@vmware.com
Reported-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/CodingStyle | 13 +
1 files changed, 13 insertions(+), 0
On Aug 29, 2014, at 1:20 PM, Saurabh Shah ssaur...@vmware.com wrote:
Generally, we have not used '_' prefix for function parameter names. We
use them for macros etc, but not for functions. Do you prefer it this way? I
am not against it, but I don't think it is necessary. For a macro, it is
[ankursha...@vmware.com]
Sent: Saturday, August 30, 2014 2:04 AM
To: Ben Pfaff
Cc: Eitan Eliahu; Samuel Ghinet; dev@openvswitch.org; Nithin Raju
Subject: RE: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to
setup dump start state
Hi,
I have sent a v4 for review.
All the code
by dump functions in the
future. I have not refactored the code that continues the dump
operation primarily since it is not final yet. Once the netlink set
APIs are in place, we can refactor that too.
Signed-off-by: Nithin Raju nit...@vmware.com
Signed-off-by: Ankur Sharma ankursha
refactor that too.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Datapath.c | 66 ++--
1 files changed, 40 insertions(+), 26 deletions
On Sep 9, 2014, at 1:09 PM, Gurucharan Shetty shet...@nicira.com
wrote:
Gives an uninitialized local variable 'sock' used. Can you take care
of it in an upcoming patch?
Sure. Thanks for point this out.
-- Nithin
___
dev mailing list
'sock' is not initialized and hence should not be un-initialized
as well in the failure path.
Signed-off-by: Nithin Raju nit...@vmware.com
Reported-by: Gurucharan Shetty shet...@nicira.com
---
lib/netlink-socket.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib
,
Samuel
From: Nithin Raju [nit...@vmware.com]
Sent: Tuesday, September 09, 2014 6:36 PM
To: Samuel Ghinet
Cc: Alin Serdean; Saurabh Shah; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Create a NBL for each NB when required
hi Sam,
Pls. find my
This is already committed, but LG to me as well. Will look forward to the
kernel implementation.
Only comment I had was w.r.t alignment in the following code:
+int ovs_msg_size = sizeof (struct nlmsghdr) + sizeof (struct genlmsghdr)
+
+ sizeof (struct
Eitan,
Thanks for doing this.
I had some minor comments. LG otherwise.
Acked-by: Nithin Raju nit...@vmware.com
+OVS_NL_ATTR_MCAST_JOIN, /*1/0 - Join/Unjoin */
minor: need a space before '1/0'.
+nl_msg_put_genlmsghdr(request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0
On Sep 10, 2014, at 12:40 PM, Eitan Eliahu elia...@vmware.com
wrote:
Nithin, I can't align it since if aligned this line will go over the 80
character limit.
You could do one of these two options. Either way is fine:
a)
+nl_msg_put_genlmsghdr(request, 0, OVS_WIN_NL_CTRL_FAMILY_ID, 0,
+
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index c145d00..d1f4b9d 100644
--- a/datapath-windows/ovsext
hi Ankur,
I had minor comments, but LG otherwise.
Acked-by: Nithin Raju nit...@vmware.com
+VOID
+NlMsgPutNested(PNL_BUFFER buf, UINT16 type,
+ const PVOID data, UINT32 size)
+{
+UINT32 offset = NlMsgStartNested(buf, type);
+
+UNREFERENCED_PARAMETER(data
Added an inline function to return used size in the buffer.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
hi Sam/Alin,
This is a followup to the discussion we had over IRC this morning about adding
vports.
The question was about what should happen in the kernel if userspace tries to
add a VIF port that is not existent on the hyper-v switch. Should we support it?
In general, you cannot add a vport
hi Sam,
Thanks for the updating the patch to make it specific to handle NBLs with
multiple NBs.
In general it looks good. There are a few bugs w.r.t NBL completion that I have
highlighted.
More than that I was a little concerned about the changes in OvsTunnelTx to
split a TSOed NBL (with
for event notifications and for packet read.
I hope I answered your question.
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Samuel Ghinet
Sent: Wednesday, September 10, 2014 4:15 PM
To: dev@openvswitch.org; Nithin Raju
Subject: Re: [ovs-dev
In this change:
1. we refactor the code that fills up information about the DP into
a seprate function.
2. use the netlink set APIs to fill up the netlink attributes.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Datapath.c | 123
On Sep 14, 2014, at 8:36 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hello Nithin,
Overall, it looks ok.
Very minor things, though:
(OvsDpFillInfo)
o) could you please rename nlWrite into something more boolean-like, like
ok or whatever you prefer?
When I first read that
On Sep 14, 2014, at 8:18 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
At first on reading this code, I was wondering why?
Now I think I understand: the function zeroes memory, and must return the ptr
to 'next' item to be filled (which is called tail). Am I correct?
Yes, that is
On Sep 14, 2014, at 7:34 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
This netdev check on windows, I understand, would translate to a km-um /
netlink communication by which it will be checked if the hyper-v switch does
have a port with friendly name X.
The only thing that
On Sep 14, 2014, at 7:38 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
I meant in the sense, if it is necessary. AFAIK, the IO pending can only
happen in non-dump operations (and here, non-dump netlink pids).
Therefore, I don't know if it is really useful to FreeDumpState in a
On Sep 14, 2014, at 8:03 PM, Samuel Ghinet
sghi...@cloudbasesolutions.commailto:sghi...@cloudbasesolutions.com wrote:
I have a question here,
is a file HANDLE normally used by only one userspace thread at a time (so that
if you have multiple threads, each thread will have its own unique file
We should be returning value of tail before the increment
and not after.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
---
datapath-windows/ovsext/Netlink/NetlinkBuf.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git
-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/include/OvsDpInterfaceExt.h |2 +
datapath-windows/ovsext/Datapath.c | 124 ++
2 files changed, 68 insertions(+), 58 deletions(-)
diff --git a/datapath-windows/include/OvsDpInterfaceExt.h
b/datapath
. In the absence of netlink set API, I had put in an ASSERT earlier
that the output buffer should be limited to 512 bytes. This is not
true anymore. The netlink set API checks for bounds of the buffer.
Hence removed the ASSERT.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/include
We should be returning value of tail before the increment
and not after.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Ankur Sharma ankursha...@vmware.com
---
datapath-windows/ovsext/Netlink/NetlinkBuf.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git
On Sep 15, 2014, at 5:51 PM, Ankur Sharma ankursha...@vmware.com
wrote:
Added minor fix for allowing support for variable lenghth attributes in
parsing policy.
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
On Sep 15, 2014, at 5:51 PM, Ankur Sharma ankursha...@vmware.com
wrote:
Added the optional flag in policy structure. This would allow
caller to avoid checks for mandatory attributes if parsing
succeeds.
Missing Signed-off-by, and also I don't see the 2/3 patch.
Thanks,
-- Nithin
ankursha...@vmware.com
Thanks for sending this mail directly to me. Assuming this was seen on the ML:
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Netlink/Netlink.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Netlink/Netlink.c
b/datapath-windows/ovsext/Netlink/Netlink.c
index 5faf07f..f6ee4c4 100644
--- a/datapath
The Windows kernel datapath needs the definition of 'IFNAMSIZ' for
specifying attribute sizes in netlink policies. Adding the definition
of 'IFNAMSIZ' to be part of OvsDpInterface.h similar to ETH_ADDR_LEN.
Signed-off-by: Nithin Raju nit...@vmware.com
---
build-aux/extract-odp-netlink-windows-dp
Turns out that there's no convenient equivalent of strncmp()
in the Windows kernel. RtlEqualString() works on STRING *
pointers which are different from the CHAR * pointers.
In this patch, we add support for such a function for comparing
strings.
Signed-off-by: Nithin Raju nit...@vmware.com
- I got so far as to hit the PORT_DUMP command which is currently not
implemented.
Signed-off-by: Nithin Raju nit...@vmware.com
Tested-by: Nithin Raju nit...@vmware.com
Reported-at: https://github.com/openvswitch/ovs-issues/issues/38
---
datapath-windows/ovsext/Datapath.c | 151
cases and error coditions similar to Linux. Some of it is not
applicable yet. Eg. the Windows kernel does not send embed an error
in the netlink message itself. There's userspace code nevertheless
for this.
Signed-off-by: Nithin Raju nit...@vmware.com
---
lib/netlink-socket.c | 95
hi Sam/Alin,
These were the items we wanted to bring up from our side:
1. statuses: DP commands, VPORT commands, Flow commands, Event commands
2. dpif-linux.c porting to Windows
3. netdev for windows
4. Pending reviews
Pls. feel free to add any new items.
Thanks,
-- Nithin
On Sep 17, 2014, at 6:16 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
I don't think there's a need to implement such a function.
You can use memcmp, which behaves quite like strncmp.
hi Samuel,
Thanks for the pointer. I was trying to use Rtl* functions, but if memcmp()
works, that
We can do the file re-naming after this checkin. I'm reviewing the change. Let
me get back in a few minutes.
thanks,
Nithin
On Sep 17, 2014, at 1:38 PM, Ben Pfaff b...@nicira.com
wrote:
I'm happy to do that. I don't care whether it happens before or after
or simultaneously with the change
is good to go.
Acked-by: Nithin Raju nit...@vmware.com
thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Just wanted to summarize the meeting for future reference:
Attendees: Samuel Ghinet, Alin Serdean, Ankur Sharma, Eitan Eliahu, Nithin Raju
1. statuses: DP commands, VPORT commands, Flow commands, Event commands
- Review for DP commands SET_DP and GET_DP along with transaction semantics has
...@vmware.com
LG. Thanks for doing this.
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Alin,
Thanks for incorporating all the comments.
Does it get any better if you don't do the renaming in this patch?
I looked at the patch and there's only deleted code in dpif-linux.c and new
code in dpif-netlink.c. It is hard to do any comparison about what was changed.
I am OK with this
On Sep 18, 2014, at 4:35 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hi Nithin,
Good catch!
I would normally prefer the validation in a function to be done like:
ret = TRUE;
if (fail_cond_1) {
log();
ret = FALSE;
goto done;
}
if (fail_cond_2) {
log();
ret =
into the OVS_VPORT_INTERNAL since it
is a port that is connected to OVS as well as has a presence on the host.
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi Samuel,
Thanks for sending out the changes.
Some high level comments are:
1. You might have to rebase your change when Eitan's change gets checked in. He
has coalesced the declarations of the command handlers.
2. We'll have to get rid of the OvsDumpVportIoctl() sometime. We need not do it
in
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
This didn't apply for me:
Applying: datapath-windows: fix OVS_VPORT_TYPE
error: patch failed: datapath-windows/include/OvsDpInterfaceExt.h:80
error: datapath-windows/include/OvsDpInterfaceExt.h: patch does not apply
hi Sam,
Pls. find my replies inline.
On Sep 14, 2014, at 9:12 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hello Nithin,
Thanks a lot again for the review!
Welcome. As you said, the code is intricate. It is fine though. Thanks for
working on this one.
On Sep 19, 2014, at 6:39 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
Hi Nithin,
Thanks for the clarifications on the Tcp segmentation and NBs sharing info. I
had missed that detail :)
I will use the flow from the first NBL for all the NBLs that resulted from
tcp
for vport add/delete.
So, feel free to address some of the comments later.
thanks,
Nithin
On Sep 18, 2014, at 4:21 PM, Nithin Raju nit...@vmware.com
wrote:
hi Samuel,
Thanks for sending out the changes.
Some high level comments are:
1. You might have to rebase your change when Eitan's change
On Sep 17, 2014, at 9:13 AM, Eitan Eliahu elia...@vmware.com wrote:
How about using RtlEqualString() ?
Str1.MaximumLength = 16;
Str1.Buffer = AnsiString;
if (!RtlEqualString( str1, str2, TRUE ){
}
Eitan,
I considered using RtlEqualString(), but backed
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext/Netlink/Netlink.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Netlink/Netlink.c
b/datapath-windows/ovsext
In this patch we implement a utility function to compare ANSI
strings using the Rtl* functions. As much as possible, in an
NDIS driver, we stick to Rtl* functions for memory/string
manipulation.
Signed-off-by: Nithin Raju nit...@vmware.com
---
datapath-windows/ovsext/Util.c | 14
as to hit the PORT_DUMP command which is currently not
implemented.
Signed-off-by: Nithin Raju nit...@vmware.com
Tested-by: Nithin Raju nit...@vmware.com
Reported-at: https://github.com/openvswitch/ovs-issues/issues/38
Acked-by: Samuel Ghinet sghi...@cloudbasesolutions.com
---
datapath-windows/ovsext
The Windows kernel datapath needs the definition of 'IFNAMSIZ' for
specifying attribute sizes in netlink policies. Adding the definition
of 'IFNAMSIZ' to be part of OvsDpInterface.h similar to ETH_ADDR_LEN.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Samuel Ghinet sghi
cases and error coditions similar to Linux. Some of it is not
applicable yet. Eg. the Windows kernel does not embed an error
in the netlink message itself. There's userspace code nevertheless
for this.
Signed-off-by: Nithin Raju nit...@vmware.com
Acked-by: Samuel Ghinet sghi
In the flow related functions, there's a stack variable called
'linux_flow'. Since this code is not specific to Linux anymore,
in this patch, we rename the variable to 'datpath_flow'.
Signed-off-by: Nithin Raju nit...@vmware.com
---
lib/dpif-netlink.c | 32
1
hi Folks,
Following are my findings (not many) from looking at netdev and how to go about
implementing it for Windows. I'm posting this as followup to the discussion we
had during IRC meeting. Pls. feel free to comment.
For reference, I looked at the code in the VMware repo (prior to
hi Samuel,
Thanks for the re-spin. I'm afraid, there'll have to be another iteration. I
see a refCounting issue when origNbl-FirstNetBuffer-Next != NULL. I have
noted that down in the code.
Other comments are very minor.
Thanks again for working on this. I'll be on IRC if you want to chat.
in vport,
isExternal
Signed-off-by: Samuel Ghinet sghi...@cloudbasesolutions.com
Acked-by: Nithin Raju nit...@vmware.com
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Tuesday, September 23, 2014 1:58 PM
To: Samuel Ghinet
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: fix OVS_VPORT_TYPE
On Sep 23, 2014, at 5:45 AM, Samuel
-Original Message-
From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
Sent: Wednesday, September 24, 2014 7:01 AM
To: dev@openvswitch.org
Cc: Alin Serdean; Nithin Raju; Saurabh Shah; Eitan Eliahu; Ankur Sharma;
Kaushik Guha
Subject: [PATCH v3] datapath-windows: Netlink
...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
genlCmd, UINT8 genlVer, UINT32 dpNo)
We don't need msgOut and nlBuf both as parameters. One of them will suffice.
You can declare a local variable msgOut = NlBufAt(nlBuf, 0, sizeof *msgOut);
LG otherwise.
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sep 24, 2014, at 11:57 PM, Ankur Sharma ankursha...@vmware.com wrote:
Signed-off-by: Ankur Sharma ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
ankursha...@vmware.com
Acked-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
LG. Only thing is, I'd add a command saying some of the actions/key fields
related to recirc and MPLS are not supported yet.
Acked-by: Nithin Raju nit...@vmware.com
Thanks,
-- Nithin
___
dev
-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Acked-by: Eitan Eliahu elia...@vmware.com
Acked-by: Nithin Raju nit...@vmware.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
,
+ .handler = OvsFlowNlNewCmdHandler,
+ .supportedDevOp = OVS_TRANSACTION_DEV_OP,
+ .validateDpIndex = FALSE
}
};
validateDpIndex should be TRUE for both the commands. But, LG otherwise.
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
On Sep 24, 2014, at 11:58 PM, Ankur Sharma ankursha...@vmware.com wrote:
Registered FLOW_DEL command handler. The same command
handler as FLOW_ADD is good enough to handle FLOW_DEL
case as well with minor changes for checking to action
attribute.
Signed-off-by: Ankur Sharma
. Thanks for the feature.
Acked-by: Nithin Raju nit...@vmware.com
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
LG. Maybe we should call the function as OvsFlowNlCmdHandler, and get rid of
the 'New'.
.validateDpindex should be TRUE.
Acked-by: Nithin Raju nit...@vmware.com
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
hi Samuel,
I had some minor comments. Looks good otherwise.
Acked-by: Nithin Raju nit...@vmware.com
On Sep 24, 2014, at 8:42 AM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
The transactional get vport command.
This command uses the netlink transactional errors.
Signed-off
hi Sam,
Thanks for incorporating the comments in the latest patch.
On Sep 25, 2014, at 2:44 PM, Samuel Ghinet sghi...@cloudbasesolutions.com
wrote:
All of the vport commands are implemented in Vport.c. Pls. move this to that
file. Perhaps even the Vport dump. You can move all of them at once
1 - 100 of 906 matches
Mail list logo
