Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-20 Thread Kevin Lo
On Fri, Apr 17, 2015 at 08:02:28AM -0700, Gurucharan Shetty wrote: I know some of you are concerned about it will break build on Windows. The diff below fixes pthread linking on FreeBSD. Tested on Linux, NetBSD, and FreeBSD. You can also check whether it builds successfully on Windows

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-18 Thread Kevin Lo
On Fri, Apr 17, 2015 at 09:41:19PM -0700, Ben Pfaff wrote: On Sat, Apr 18, 2015 at 01:28:21AM +0800, Kevin Lo wrote: On Fri, Apr 17, 2015 at 09:17:46AM -0700, Ben Pfaff wrote: On Fri, Apr 17, 2015 at 02:45:32PM +0800, Kevin Lo wrote: On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-17 Thread Kevin Lo
On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben Pfaff wrote: On Wed, Apr 15, 2015 at 07:52:24AM -0700, Gurucharan Shetty wrote: I am also concerned that it this will break the Windows build. Currently Windows uses some Windows-only code in m4/openvswitch.m4, which requires Win32

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-17 Thread Gurucharan Shetty
I know some of you are concerned about it will break build on Windows. The diff below fixes pthread linking on FreeBSD. Tested on Linux, NetBSD, and FreeBSD. You can also check whether it builds successfully on Windows by adding your proposed commit to your fork of OVS in Github and then

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-17 Thread Kevin Lo
On Fri, Apr 17, 2015 at 09:17:46AM -0700, Ben Pfaff wrote: On Fri, Apr 17, 2015 at 02:45:32PM +0800, Kevin Lo wrote: On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben Pfaff wrote: On Wed, Apr 15, 2015 at 07:52:24AM -0700, Gurucharan Shetty wrote: I am also concerned that it this

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-17 Thread Ben Pfaff
On Fri, Apr 17, 2015 at 02:45:32PM +0800, Kevin Lo wrote: On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben Pfaff wrote: On Wed, Apr 15, 2015 at 07:52:24AM -0700, Gurucharan Shetty wrote: I am also concerned that it this will break the Windows build. Currently Windows uses some

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-17 Thread Ben Pfaff
On Sat, Apr 18, 2015 at 01:28:21AM +0800, Kevin Lo wrote: On Fri, Apr 17, 2015 at 09:17:46AM -0700, Ben Pfaff wrote: On Fri, Apr 17, 2015 at 02:45:32PM +0800, Kevin Lo wrote: On Wed, Apr 15, 2015 at 05:50:42PM -0700, Ben Pfaff wrote: On Wed, Apr 15, 2015 at 07:52:24AM -0700,

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-15 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 07:52:24AM -0700, Gurucharan Shetty wrote: I am also concerned that it this will break the Windows build. Currently Windows uses some Windows-only code in m4/openvswitch.m4, which requires Win32 builders to specify --with-pthread=dir on the configure command line.

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-15 Thread Kevin Lo
On Tue, Apr 14, 2015 at 08:43:42PM -0700, Ben Pfaff wrote: [Guru: please see final paragraph] On Tue, Apr 07, 2015 at 03:54:30PM +0800, Kevin Lo wrote: On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-15 Thread Kevin Lo
On Tue, Apr 14, 2015 at 09:06:28PM -0700, Ben Pfaff wrote: On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread Ben Pfaff
[Guru: please see final paragraph] On Tue, Apr 07, 2015 at 03:54:30PM +0800, Kevin Lo wrote: On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf macro archive and use macro AX_PTHREAD.

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf macro archive and use macro AX_PTHREAD. Signed-off-by: Kevin

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread YAMAMOTO Takashi
On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf macro archive and use macro AX_PTHREAD. Signed-off-by: Kevin Lo kevlo at FreeBSD.org --- diff --git a/configure.ac b/configure.ac

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread YAMAMOTO Takashi
On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf macro archive and use macro AX_PTHREAD. Signed-off-by: Kevin

[ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-07 Thread Kevin Lo
On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the linker flags for linking with a pthread library. Add macro ax_pthread.m4 from GNU autoconf macro archive and use macro AX_PTHREAD. Signed-off-by: Kevin Lo kevlo at FreeBSD.org --- diff --git a/configure.ac b/configure.ac index