Re: Eclipse/Checkstyle errors

2012-09-15 Thread Joseph Bergmark
es because the won't be checked by maven. > For example -> AbstractUnitTest#addExtension > > 2012/9/15 Joseph Bergmark > >> Which test classes are you getting check style errors in? When I >> build on the command line I don't see any check style errors: >

Re: [VOTE] [take-2] release Apache OpenWebBeans 1.1.6

2012-09-27 Thread Joseph Bergmark
+1 On Tue, Sep 25, 2012 at 6:22 PM, Mark Struberg wrote: > > > Hi! > > I'd again like to call a VOTE on releasing Apache OpenWebBeans-1.1.6 . I > fixed the issues which stopped our first attempt > > This > is a bugfix release of OpenWebBeans-1.1.x, thus no branch has been > created. It mainly c

Re: Method in OpenWebBeansEjbPlugin

2012-11-08 Thread Joseph Bergmark
I believe this method is used to take the actual method annotated and find which method that corresponds to in an EJB interface. The one place I see it used in the code is DefinitionUtil when its trying to determine the producer/disposer methods. I believe the concern is the proxy that is built b

Re: CDI-1.1 module handling

2012-11-27 Thread Joseph Bergmark
It doesn't sound incredibly dissimilar from the behavior that can be enabled by turning on the by the use bda beans.xml scanner flag. I think currently that flag only controls interceptors, decorators & alternatives based on what bean is being injected, but it could feasibly also be aware of relat

Re: [VOTE] release OpenWebBeans-1.1.6

2012-12-06 Thread Joseph Bergmark
+1 On Thu, Dec 6, 2012 at 9:16 AM, Jean-Louis MONTEIRO wrote: > +1 > > Thanks again Mark. > > JLouis > > > 2012/12/6 Romain Manni-Bucau > >> otherwise it seems fine for me and all TCK passed (even in tomee/openejb) >> >> +1 >> >> Romain Manni-Bucau >> Twitter: @rmannibucau >> Blog: http://rmanni

Re: The pittfalls of ClassLoaders for proxies

2013-01-27 Thread Joseph Bergmark
Sorry for the late response, but I don't think you have to worry about the hierarchical class loader scenario you described below. At least in the server I'm aware of, the modules classloaders all delegate up to the shared classloader. If they didn't then each module classloader would be loading

Re: interface, generics and interceptors

2013-04-03 Thread Joseph Bergmark
This looks like it might be the same as: https://issues.apache.org/jira/browse/OWB-706 If so, the quick fix for Javassist based proxies is to add an exclusion for bridge methods in our methodFilter. I haven't looked at this for our alternative proxy code. On Wed, Apr 3, 2013 at 4:37 AM, Romain

Re: classloader resolution

2013-04-04 Thread Joseph Bergmark
I like the idea of a flexible ClassLoaderResolverService, as long as can obtain the information about the bean class (if any) and interfaces. I'm not sure if just knowing the WebBeansContext is enough. For the old javassist proxies, one trick was using the bean class as long as that classloader a

Re: classloader resolution

2013-04-04 Thread Joseph Bergmark
au>* > *Blog: **http://rmannibucau.wordpress.com/*< > http://rmannibucau.wordpress.com/> > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* > *Github: https://github.com/rmannibucau* > > > > 2013/4/4 Joseph Bergmark > > > I like the idea of a flexible ClassLoaderResolverSer

Re: svn commit: r1481253 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/portable/AnnotatedTypeImpl.java test/java/org/apache/webbeans/portable/AnnotatedTypeImplTest.java

2013-05-11 Thread Joseph Bergmark
On a side note, if you are creating "fake beans" by using BeanManager.createInjectionTarget, at one point it had a side affect of registering ObserMethodImpls with the NotificantManager. Joe On Sat, May 11, 2013 at 5:05 AM, Romain Manni-Bucau wrote: > To explain a bit for people not having the d

Re: [VOTE] Release Apache OpenWebBeans build-tools 1.3

2013-05-16 Thread Joseph Bergmark
+1 On Thu, May 16, 2013 at 5:05 AM, Gerhard Petracek < gerhard.petra...@gmail.com> wrote: > +1 > > regards, > gerhard > > > > 2013/5/14 Mark Struberg > > > Hi! > > > > This is now a split VOTE for owb-build-tools-1.3 > > > > The stating repo is up here: > > > > > https://repository.apache.org/co

Re: [VOTE] take 3: Release Apache OpenWebBeans-1.2.0

2013-05-21 Thread Joseph Bergmark
+1 On Sun, May 19, 2013 at 1:49 AM, Mark Struberg wrote: > I'd like to call a 3rd take to VOTE on releasing Apache OpenWebBeans-1.2.0 > . > > This is the first release of the OpenWebBeans-1.2.x branch. > This release changed many internal mechanics but still targets > the CDI-1.0 specification.

Re: OWB and generics

2013-07-06 Thread Joseph Bergmark
For some reason I believe the spec specifically says that Object should not be in the list of types, which I believe is why your plain old java example isn't valid. Joe On Sat, Jul 6, 2013 at 6:57 AM, Arne Limburg wrote: > Hi Romain, > > > In plain old java the assignment does not work either: >

Re: OWB and generics

2013-07-06 Thread Joseph Bergmark
47 AM, Romain Manni-Bucau wrote: > Didnt get your answer, there is no link with Object. A produced generic > type modelizes all possible subtypes IMO (otherwise it should be forbidden > cause it doesnt match original java meaning then) + all beans match Object > in the spec > Le 6 juil

Re: svn commit: r1552050 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/component/creation/BeanAttributesBuilder.java test/java/org/apache/webbeans/newtests/specalization/mu

2013-12-18 Thread Joseph Bergmark
I'll be the first to admit I'm not very familiar with this code area, but is it possible that this change could mean that we miss @Specializes added to the AnnotatedType classes in the super class hierarchy, as you are walking up the class objects themselves looking for the annotation? On Wed, Dec

Re: svn commit: r1552050 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/component/creation/BeanAttributesBuilder.java test/java/org/apache/webbeans/newtests/specalization/mu

2013-12-18 Thread Joseph Bergmark
> > e.g. > > @Named BeanA > @Specializes BeanB extends BeanA > @Specializes BeanC extends BeanC > > It tried to extract the name for BeanC from BeanB but actually it must look > for @Named on BeanA. > > > 2013/12/18 Joseph Bergmark > > > I'll be the

Re: svn commit: r1552050 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/component/creation/BeanAttributesBuilder.java test/java/org/apache/webbeans/newtests/specalization/mu

2013-12-19 Thread Joseph Bergmark
sUtil.getManagedBeanDefaultName(annotatedToSpecialize.getJavaClass().getSimpleName())); > > and its working fine too. > All unit tests passing. > > Should i commit it? > > > > 2013/12/18 Joseph Bergmark > > > Sorry, I'll try to be more clear. Again, I'm not

Re: [VOTE] Release Apache OpenWebBeans-1.2.2

2014-02-20 Thread Joseph Bergmark
+1 On Wed, Feb 19, 2014 at 4:09 AM, Mark Struberg wrote: > > > I'd like to call a VOTE on releasing Apache OpenWebBeans-1.2.2 . > > This is a maintenance release of the owb_1.2.x branch and targets the > CDI-1.0 specification. > > The ReleaseNotes are available in the README and online: > > > h

Re: [VOTE] Release Apache OpenWebBeans-1.2.3

2014-04-24 Thread Joseph Bergmark
+1 On Wed, Apr 23, 2014 at 2:36 AM, Mark Struberg wrote: > I'd like to call a VOTE on releasing Apache OpenWebBeans-1.2.2 . > > This is a maintenance release of the owb_1.2.x branch and targets the > CDI-1.0 specification. > > The ReleaseNotes are available online: > > https://issues.apache.org/

Re: [VOTE] Release Apache OpenWebBeans 1.2.5

2014-05-24 Thread Joseph Bergmark
I set up my build environment on a new machine, so its possible I'm fighting a configuration problem, but after a successful build from the 1.2.5 source zip, I'm having trouble with the guess sample app which is my normal go-to for quick testing. It looks like an EL or bean discovery problem, as l

Re: [VOTE] Release Apache OpenWebBeans 1.2.5

2014-05-24 Thread Joseph Bergmark
gt; > https://git-wip-us.apache.org/repos/asf/deltaspike/repo?p=deltaspike.git;a=summary > > > > 2014-05-24 20:24 GMT+02:00 Joseph Bergmark : > > > I set up my build environment on a new machine, so its possible I'm > > fighting a configuration problem, but after a

Re: [VOTE] Release Apache OpenWebBeans 1.2.5

2014-05-24 Thread Joseph Bergmark
an reproduce it. > > txs and LieGrue, > strub > > > > On Saturday, 24 May 2014, 21:22, Joseph Bergmark > wrote: > > > I walked though the code in debug, and from what I can tell it appears > to > > be an issue with the way the URLs are b

Re: [VOTE] Release Apache OpenWebBeans 1.2.5

2014-05-25 Thread Joseph Bergmark
; > > >> > > > >> txs and LieGrue, > > > >> strub > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >>> On Sunday, 25 May

Re: [VOTE] Release Apache OpenWebBeans-1.2.6

2014-06-21 Thread Joseph Bergmark
+1 On Thu, Jun 19, 2014 at 4:57 PM, Mark Struberg wrote: > I'd like to call a VOTE on releasing Apache OpenWebBeans-1.2.6 . > > This is a maintenance release of the owb_1.2.x branch and targets the > CDI-1.0 specification. > > The ReleaseNotes are available online: > > https://issues.apache.org

Re: svn commit: r1658730 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/util/ test/java/org/apache/webbeans/test/interceptors/factory/ test/java/org/apache/webbeans/test/int

2015-02-12 Thread Joseph Bergmark
I need to write a quick unit test to verify, but I think this may still be missing non-public inherited methods. Previously it only used getDeclaredMethods, which would return all all private, protected, default and public methods for the class, but did not contain any inherited methods. If I'm r

Re: [DRAFT] OpenWebBeans board report 2015-03

2015-03-15 Thread Joseph Bergmark
If you haven't already sent it, I would make two trivial changes: 1) Fix the accidental typo of "teh" into "the" in the development section 2) In the community section, I might have chosen to used "received" instead of "got", as in "we received quite a few bug reports and patches". Very small thi

Re: [VOTE] Release Apache OpenWebBeans-1.2.8

2015-04-22 Thread Joseph Bergmark
I'm seeing some errors with mvn rat:check: [ERROR] Failed to execute goal org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:ch eck (default-cli) on project openwebbeans: Too many unapproved licenses: 21 -> [ Help 1] >From my quick glance at rat.txt, they appear to mostly be the readme/* files which

Re: [VOTE] Release Apache OpenWebBeans-1.2.8

2015-04-22 Thread Joseph Bergmark
Never mind, I'm seeing similar problems with the last release (1.5.0) when I re-run it. Not sure what I might have done differently before. On Wed, Apr 22, 2015 at 7:36 PM, Joseph Bergmark wrote: > I'm seeing some errors with mvn rat:check: > > [ERROR] Fai

Re: [VOTE] Release Apache OpenWebBeans-1.2.8

2015-04-24 Thread Joseph Bergmark
Forgot to add my +1 I'll open up a JIRA issue to take care of the README files and to ignore the generated DEPENDENCIES file. On Wed, Apr 22, 2015 at 9:37 AM, Mark Struberg wrote: > I’d like to call a VOTE for releasing Apache OpenWebBeans-1.2.8 > > This is a maintenance release of our 1.2.x br

Re: adding a web-fragment.xml to openwebbeans-web?

2015-04-25 Thread Joseph Bergmark
It should be well supported on any servlet 3.0 compliant container as its part of the specification. I suppose it could be inconvenient for application servers that already have OWB integration, but in that case I wouldn't expect the user to be including OWB in their application at all. As long a

Re: do we like to drop servlet-2.5 support?

2015-04-26 Thread Joseph Bergmark
Perhaps I'm being dense, but tomcat 6 is at spec level servlet 2.5 and tomcat 7 is at spec level servlet 3.0 right? Requiring Servlet 3.0 lets us leverage ServletContainerInitializers. On Sun, Apr 26, 2015 at 10:55 AM, Romain Manni-Bucau wrote: > We can/should drop t6 but not servlet 2.5 > > No

Re: [VOTE] for Apache OpenWebBeans 1.6.1

2015-06-16 Thread Joseph Bergmark
+1 On Tue, Jun 16, 2015 at 3:10 AM, Romain Manni-Bucau wrote: > +1 > > > Romain Manni-Bucau > @rmannibucau | Blog > | Github < > https://github.com/rmannibucau> | > LinkedIn | Tomitrib

Re: [DISCUSS] moving OpenWebBeans to GIT?

2016-01-23 Thread Joseph Bergmark
+0 I really like DVCSs. working in feature branches, and the git workflow in general, but haven't been active at all in CDI-2.0 work so it makes more sense to stick with the opinion of those that are. On Sat, Jan 23, 2016 at 7:44 AM, Thomas Andraschko < andraschko.tho...@gmail.com> wrote: > +0 -

Re: [VOTE] Release Apache OpenWebBeans-1.7.0

2016-08-30 Thread Joseph Bergmark
+1 built, mvn apache-rat:check, and ran a couple of the sample applications. Looked good to me On Tue, Aug 30, 2016 at 4:40 AM, Mark Struberg wrote: > Good morning! > > I'd like to call a VOTE on releasing Apache OpenWebBeans-1.7.0. > > > The staging repo is: > > https://repository.apache.org/c

Re: [VOTE] Release Apache OpenWebBeans-1.7.0 - take 2

2016-09-02 Thread Joseph Bergmark
+1 On Wed, Aug 31, 2016 at 4:50 PM, Mark Struberg wrote: > New take for OWB-1.7.0 > > Repo is > https://repository.apache.org/content/repositories/ > orgapacheopenwebbeans-1018/ > > Source release is > https://repository.apache.org/content/repositories/ > orgapacheopenwebbeans-1018/org/apache/op

Re: [VOTE] Release Apache OpenWebBeans-1.7.3

2017-04-16 Thread Joseph Bergmark
+1 On Sat, Apr 15, 2017 at 6:56 PM, Mark Struberg wrote: > Hi folks! > > I've run the tasks to ship OWB 1.7.3. > > The following bugs got fixed > > Bug > > • [OWB-1172] - getResources doesn't work in OWB Arquillian > container for WebArchives > • [OWB-1173] - InjectionPoint with

Re: [VOTE] Release Apache OpenWebBeans-1.7.4

2017-07-07 Thread Joseph Bergmark
+1 built, mvn apache-rat:check, and ran a couple sample apps On Fri, Jul 7, 2017 at 6:05 PM, Mark Struberg wrote: > Dear lords and ladies! > > It's my pleasure to call a VOTE on releasing Apache OpenWebBeans-1.7.4. > This is a maintenance release of our CDI-1.2 branch and a drop in > replacemen

Fwd: [VOTE] Release Apache OpenWebBeans-2.0.0

2017-07-11 Thread Joseph Bergmark
Sorry for sending to the wrong list! -- Forwarded message -- From: Joseph Bergmark Date: Tue, Jul 11, 2017 at 9:14 AM Subject: Re: [VOTE] Release Apache OpenWebBeans-2.0.0 To: u...@openwebbeans.apache.org +1 On Mon, Jul 10, 2017 at 7:21 AM, Mark Struberg wrote: > G

Re: [VOTE] Release Apache OpenWebBeans-2.0.2

2017-10-11 Thread Joseph Bergmark
+1 On Tue, Oct 10, 2017 at 7:58 PM, Romain Manni-Bucau wrote: > +1 and thanks a lot for it! > > Side question: why CDI-SE? the controller is for EE as well I think > > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Blog >

Re: [VOTE] Release Apache OpenWebBeans-1.7.5

2018-04-28 Thread Joseph Bergmark
+1 On Sat, Apr 28, 2018 at 8:10 AM, Mark Struberg wrote: > Hi folks! > > I did run all required tasks for shipping an OWB-1.7.5 release. > This version targets CDI-1.2 / EE7 and would fit for the TomEE-7.x line. > > The following tickets got resolved > > Bug > > • [OWB-1197] - OwbSWClass

Re: [VOTE] Apache OpenWebBeans-2.0.5

2018-04-28 Thread Joseph Bergmark
+1 On Sat, Apr 28, 2018 at 4:52 PM, Mark Struberg wrote: > good evening! > > I'd like to call a VOTE to release Apache OpenWebBeans-2.0.5. > > The following tickets got resolved > > Bug > • [OWB-1233] - WrappedValueExpression.equals(Object arg0) always > false if arg0 is an instance of W

Re: [VOTE] Release Apache OpenWebBeans-2.0.7

2018-08-30 Thread Joseph Bergmark
+1 On Tue, Aug 28, 2018 at 4:56 AM Mark Struberg wrote: > Good morning ladies and gents! > > I'd like to call a VOTE on releasing Apache OpenWebBeans-2.0.7 > > The following tickets got resolved: > > Bug > > [OWB-1247] - Update to XBean Asm 6 Shaded 4.9 > [OWB-1248] - defineClass used wh

<    1   2