[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread yuruiz
Github user yuruiz commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191995987 --- Diff: c++/src/RLE.hh --- @@ -68,7 +76,24 @@ namespace orc { * record current position * @param recorder use the recorder to record

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread yuruiz
Github user yuruiz commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191995946 --- Diff: c++/src/Writer.cc --- @@ -122,9 +127,17 @@ namespace orc { } WriterOptions& WriterOptions::setFileVersion(const FileVersion&

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread yuruiz
Github user yuruiz commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191973999 --- Diff: c++/src/Writer.cc --- @@ -38,9 +38,10 @@ namespace orc { FileVersion fileVersion; double dictionaryKeySizeThreshold; bool

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread jamesclampffer
Github user jamesclampffer commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191935614 --- Diff: c++/src/RLE.hh --- @@ -68,7 +76,24 @@ namespace orc { * record current position * @param recorder use the recorder to

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread jamesclampffer
Github user jamesclampffer commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191932328 --- Diff: c++/include/orc/Writer.hh --- @@ -38,6 +38,11 @@ namespace orc { CompressionStrategy_COMPRESSION }; + enum

[GitHub] orc pull request #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SAS...

2018-05-30 Thread majetideepak
GitHub user majetideepak opened a pull request: https://github.com/apache/orc/pull/275 ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is not found You can merge this pull request into a Git repository by running: $ git pull https://github.com/majetideepak/orc ORC-371

[jira] [Created] (ORC-371) [C++] Disable Libhdfspp build when Cyrus SASL is not found

2018-05-30 Thread Deepak Majeti (JIRA)
Deepak Majeti created ORC-371: - Summary: [C++] Disable Libhdfspp build when Cyrus SASL is not found Key: ORC-371 URL: https://issues.apache.org/jira/browse/ORC-371 Project: ORC Issue Type: Bug

[jira] [Created] (ORC-370) ORC PPD evaluation for date should use DateWritable

2018-05-30 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created ORC-370: - Summary: ORC PPD evaluation for date should use DateWritable Key: ORC-370 URL: https://issues.apache.org/jira/browse/ORC-370 Project: ORC Issue

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191832950 --- Diff: c++/src/Writer.cc --- @@ -122,9 +127,17 @@ namespace orc { } WriterOptions& WriterOptions::setFileVersion(const FileVersion&

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191830703 --- Diff: c++/src/Writer.cc --- @@ -38,9 +38,10 @@ namespace orc { FileVersion fileVersion; double dictionaryKeySizeThreshold;

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191829402 --- Diff: c++/src/Writer.cc --- @@ -38,9 +38,10 @@ namespace orc { FileVersion fileVersion; double dictionaryKeySizeThreshold;

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191816749 --- Diff: c++/test/TestWriter.cc --- @@ -47,7 +47,6 @@ namespace orc { const Type& type,

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191816344 --- Diff: c++/test/TestWriter.cc --- @@ -139,7 +136,6 @@ namespace orc { *type,

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread majetideepak
Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191815756 --- Diff: c++/test/TestWriter.cc --- @@ -1174,5 +1170,5 @@ namespace orc { } } - INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest,

[GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2

2018-05-30 Thread yuruiz
Github user yuruiz commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191672633 --- Diff: c++/src/RleEncoderV2.cc --- @@ -0,0 +1,768 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor