Re: Usage of ORC_UNIQUE_PTR

2018-10-30 Thread Gang Wu
Hi Fang, ORC_UNIQUE_PTR was intended to support platforms which does not support c++11. You can also find that std::unique_ptr is translated into std::auto_ptr as well. Current and future versions of ORC will not support those obsolete platforms; therefore I think it is ok to use std::unique_ptr

Usage of ORC_UNIQUE_PTR

2018-10-30 Thread Fang Zheng
Hi, I have a question about the usage of ORC_UNIQUE_PTR in C++ code: The ORC_UNIQUE_PTR macro is used intensively in the public header files in c++/include/. On the other hand, among those files in c++/src/ directory, std::unique_ptr appears much more frequently than ORC_UNIQUE_PTR (356 vs. 16

[jira] [Created] (ORC-428) Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer

2018-10-30 Thread Fang Zheng (JIRA)
Fang Zheng created ORC-428: -- Summary: Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer Key: ORC-428 URL: https://issues.apache.org/jira/browse/ORC-428 Project: ORC Issue Type:

[jira] [Created] (ORC-427) Fix errors in ORC C++ public API Doxygen documentation

2018-10-30 Thread Fang Zheng (JIRA)
Fang Zheng created ORC-427: -- Summary: Fix errors in ORC C++ public API Doxygen documentation Key: ORC-427 URL: https://issues.apache.org/jira/browse/ORC-427 Project: ORC Issue Type: Bug

Re: Fixing the docker builds

2018-10-30 Thread Deepak Majeti
+1 On Tue, Oct 30, 2018 at 3:22 AM Sandeep Moré wrote: > I did not know about the docker builds :( sounds like a fantastic idea ! > > On Mon, Oct 29, 2018 at 2:20 PM Owen O'Malley > wrote: > > > All, > >We've let the docker build scripts decay badly. I'm fixing them, but > > along the way,