Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-08 Thread Owen O'Malley
With five +1's (3 binding) and no -1's the release passes. Thanks everyone! Owen On Fri, May 5, 2017 at 4:56 PM, Prasanth Jayachandran < j.prasant...@gmail.com> wrote: > There are rat failures in java/bench as well.. > orc-1.4.0/java/bench/fetch-data.sh >

Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-05 Thread Prasanth Jayachandran
There are rat failures in java/bench as well.. orc-1.4.0/java/bench/fetch-data.sh orc-1.4.0/java/bench/src/main/resources/github.schema orc-1.4.0/java/bench/src/main/resources/log4j.properties orc-1.4.0/java/bench/src/main/resources/sales.schema orc-1.4.0/java/bench/src/main/resources/taxi.schema

Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-05 Thread Alan Gates
+1. I did a build on centos and ran the unit tests.  Checked the signatures (why is the file called .sig instead of .asc?  that screwed up my release test script; grumble, grumble). Rat build failed.  I don't think this is an issue since all of the unapproved files look like test results, but

Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-05 Thread Owen O'Malley
I should also point out that I ran the C++ and Java build and tests on the whole list of supported OSes. Including: - CentOS 6 and 7 - Debian 7 and 8 - Ubuntu 12, 14, and 16 - MacOS 10.12 .. Owen On Fri, May 5, 2017 at 12:51 AM, Prasanth Jayachandran < j.prasant...@gmail.com> wrote:

Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-05 Thread Prasanth Jayachandran
+1 - verified checksum and signature - ran tests in Mac OS X Thanks and Regards, Prasanth Jayachandran On Thu, May 4, 2017 at 11:36 AM, Deepak Majeti wrote: > +1 (non-binding) > > - verfied checksum and signature > - built Release and Debug versions on Ubuntu

Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-04 Thread Deepak Majeti
+1 (non-binding) - verfied checksum and signature - built Release and Debug versions on Ubuntu 16.04 with gcc 4.9.4 - ran C++ and Java tests On Thu, May 4, 2017 at 4:26 AM, Dongjoon Hyun wrote: > +1 (non-binding) > > I checked the followings with RC1. > - checksum

Re: [VOTE] Should we release ORC 1.4.0rc1?

2017-05-04 Thread Dongjoon Hyun
+1 (non-binding) I checked the followings with RC1. - checksum / signature - building and install with 1.4.0 correctly. - unit testing for Java module on Mac/JDK 1.8.0_131 - some integration tests with new `nohive` jar for both record/RowBatch reader Everything looks good to me. Thank

[VOTE] Should we release ORC 1.4.0rc1?

2017-05-03 Thread Owen O'Malley
Ok, I made two mistakes: 1. I didn't update the version in the build to say 1.4.0 instead of 1.4.0-SNAPSHOT. 2. I didn't include the ORC-181 fix. I've rolled a new release candidate. Tag: https://github.com/apache/orc/releases/tag/release-1.4.0rc1 Tar ball: