Re: Usage of ORC_UNIQUE_PTR

2018-10-31 Thread Owen O'Malley
Ok, we should have done a better job at documenting these. For most of the features like ORC_UNIQUE_PTR and ORC_NOEXCEPT, we take two different approaches depending on the context: In external header files, we always use the ORC_*, because the users have to be able to include our header files

Re: Usage of ORC_UNIQUE_PTR

2018-10-30 Thread Gang Wu
Hi Fang, ORC_UNIQUE_PTR was intended to support platforms which does not support c++11. You can also find that std::unique_ptr is translated into std::auto_ptr as well. Current and future versions of ORC will not support those obsolete platforms; therefore I think it is ok to use std::unique_ptr