Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/301#discussion_r215486726
--- Diff: c++/src/Compression.cc ---
@@ -899,6 +907,166 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ /**
+ * Block
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/301#discussion_r215486619
--- Diff: c++/src/Compression.cc ---
@@ -899,6 +907,166 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ /**
+ * Block
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/268
Hi all, I'd like to bring this up again. It's almost another three months,
and we haven't seen the zstd java library yet. I would suggest we move forward
to add zstd support in C++ reader/writer
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/300
Looks good. Thanks for adding this.
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/293
LGTM
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/273
@majetideepak this is RLEv2 change that was promised.
@yuruiz Could you also include some perf data obtained from offline testing?
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/268
The current solution is not perfect. But at least it gives us some ability
to read zstd Orc files, which I believe is important from the compatibility
perspective - our in-house system has zstd Orc
GitHub user xndai opened a pull request:
https://github.com/apache/orc/pull/268
ORC-363 Enable zstd decompression in ORC Java reader
1. Upgrade aircompressor lib to 0.11
2. Enable Zstd decompression in Java reader
3. Zstd compression is still not availiable. Will throw
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/245
+1 for Gang's proposal.
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/247#discussion_r181530787
--- Diff: site/specification/ORCv2.md ---
@@ -0,0 +1,1032 @@
+---
+layout: page
+title: Evolving Draft for ORC Specification v2
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/245#discussion_r181149073
--- Diff: site/_docs/encodings.md ---
@@ -123,6 +127,41 @@ DIRECT_V2 | PRESENT | Yes | Boolean
RLE
| DATA
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/243
LGTM. Thanks for putting together a document.
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/241
LGTM
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/240
We should also add an MSVC build in travis. Otherwise there's no way to
verify it.
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r176909659
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,9 +1194,8 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues;
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r176910052
--- Diff: c++/src/ColumnReader.cc ---
@@ -336,8 +336,7 @@ namespace orc {
}
}
int64_t writerTime = secsBuffer[i
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/233
IMO the ideal approach of achieving the timestamp semantics is to have the
caller pass in session timezone, and the reader return timestamp batch based on
that. That would be similar to what we do
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/233
Sorry, I am confused after reading the discussions above. The key question
I have is - do we implement ORC TIMESTAMP as SQL "TIMESTAMP with Timezone" or
"TIMESTAMP without Timezone&q
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/214
LGTM.
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/212
+1
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r163463896
--- Diff: c++/include/orc/Common.hh ---
@@ -69,7 +69,7 @@ namespace orc {
UNKNOWN_WRITER = INT32_MAX
};
- enum CompressionKind
GitHub user xndai opened a pull request:
https://github.com/apache/orc/pull/211
ORC-290 [C++] Update Readme to include C++ writer info
Change-Id: Ic419427b7441c96f63221ba650f9965e5342680e
You can merge this pull request into a Git repository by running:
$ git pull https
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/199
Hi @majetideepak , Gang is on vacation and will look into your feedback
after he's back next week. Thx.
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r155623157
--- Diff: java/core/src/test/org/apache/orc/impl/mask/TestUnmaskRange.java
---
@@ -0,0 +1,165 @@
+package org.apache.orc.impl.mask
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r154761512
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -245,8 +271,8 @@ public void maskData(ColumnVector original,
ColumnVector
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/184#discussion_r154762146
--- Diff:
java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
@@ -619,7 +646,7 @@ public double maskDouble(double value) {
} else
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/198
LGTM
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/199#discussion_r155596136
--- Diff: tools/src/CSVFileImport.cc ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/199#discussion_r155593796
--- Diff: tools/src/CSVFileImport.cc ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/199#discussion_r155594426
--- Diff: tools/src/CSVFileImport.cc ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/169
@dain if the concern is the performance, should we also limit the string
length when generate stats in writer path, which in my opinion is more costly?
I think if we keep the string compare up to 1024
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/169
I don't understand why you need to trim the strings. Protobuf doesn't
support strings over 1024 characters?
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/151
Squash commit. Thanks @ajayyadava @majetideepak
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/151
@majetideepak how do I do that? :)
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/151
@majetideepak pls take another look. Thx!
---
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/134
LGTM
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r138531251
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -0,0 +1,172 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r138235902
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,18 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r138018152
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -0,0 +1,172 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r138019713
--- Diff: c++/include/orc/OrcFile.hh ---
@@ -103,12 +103,18 @@ namespace orc {
};
/**
- * Create a stream to a local file
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/159
@iamhumanbeing did you compare it with zstd? Based on my experience, zstd
is way better than igzip. I would expect a similar result with ISA-L. It
doesn't seem to be adding a lot of value if we plan
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/151
@omalley please take another look. thanks.
---
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r136697977
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r134897076
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r10343
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r133008869
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r132589551
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132531200
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132522783
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/128
@omalley Update change again, please take a look. I also reduce the initial
stream memory capacity from 4M to 1M, and greatly reduce the pre-allocated
memory for footers and ps. This should alleviate
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131780372
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/142#discussion_r130473949
--- Diff: c++/src/CMakeLists.txt ---
@@ -125,6 +125,83 @@ include_directories (
${LZ4_INCLUDE_DIRS}
)
+# To avoid reading the Timezone
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r128647874
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r128392669
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/128
Hi @omalley , please see my replies and the new commit. Let me know if you
have further questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r125729396
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -34,15 +34,13 @@
#include "common/hdfs_configuration.h"
#include "common/configu
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r125728966
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -123,17 +123,21 @@ namespace orc {
uint64_t length,
uint64_t offset) override
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r125728350
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -66,22 +64,22 @@ namespace orc {
options = config->GetOptions();
}
hdfs::IoServ
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124720147
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124720134
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718827
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718523
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124718336
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124715175
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r123852932
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -121,39 +116,24 @@ namespace orc {
}
uint64_t getNaturalReadSize() const override
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r123853053
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -66,22 +64,22 @@ namespace orc {
options = config->GetOptions();
}
hdfs::IoServ
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r123853204
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -34,15 +34,13 @@
#include "common/hdfs_configuration.h"
#include "common/configu
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/134#discussion_r123646956
--- Diff: c++/src/OrcHdfsFile.cc ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/132
That makes sense. I add the writer code in c++ writer. We might need a
similar change for c++ reader. Will do it in a separate PR.
---
If your project is set up for it, you can reply to this email
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120799267
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120751420
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120739743
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120708078
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120706989
--- Diff: c++/src/Writer.cc ---
@@ -0,0 +1,659 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120704852
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120701079
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r120699358
--- Diff: c++/include/orc/OrcFile.hh ---
@@ -119,6 +120,17 @@ namespace orc {
* @param path the name of the file in the local file system
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/128
@majetideepak have you got a chance to take a look? Sorry for the big diff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user xndai opened a pull request:
https://github.com/apache/orc/pull/128
ORC-178 Implement Basic C++ Writer and Writer Option
1. Add basic Writer and WriterOption
2. Add StructColumnWriter and IntegerColumnWriter. With them, we will be
able to write a complete ORC
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/126
Thanks @majetideepak for reviewing. @prasanthj @omalley please help review
and/or accept the PR. Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118057983
--- Diff: c++/test/TestByteRLEEncoder.cc ---
@@ -0,0 +1,231 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118057495
--- Diff: c++/test/TestByteRLEEncoder.cc ---
@@ -0,0 +1,231 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118048655
--- Diff: c++/src/RLEv1.hh ---
@@ -26,6 +26,59 @@
namespace orc {
+class RleEncoderV1 : public RleEncoder {
+public
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118048627
--- Diff: c++/src/RLEv1.cc ---
@@ -26,8 +26,173 @@
namespace orc {
const uint64_t MINIMUM_REPEAT = 3;
+const uint64_t MAXIMUM_REPEAT = 127
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118048556
--- Diff: c++/src/ByteRLE.cc ---
@@ -27,6 +27,272 @@
namespace orc {
const size_t MINIMUM_REPEAT = 3;
+ const size_t MAXIMUM_REPEAT = 127
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118048038
--- Diff: c++/src/ByteRLE.cc ---
@@ -27,6 +27,272 @@
namespace orc {
const size_t MINIMUM_REPEAT = 3;
+ const size_t MAXIMUM_REPEAT = 127
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118048019
--- Diff: c++/src/ByteRLE.cc ---
@@ -27,6 +27,272 @@
namespace orc {
const size_t MINIMUM_REPEAT = 3;
+ const size_t MAXIMUM_REPEAT = 127
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118046740
--- Diff: c++/src/ByteRLE.cc ---
@@ -27,6 +27,272 @@
namespace orc {
const size_t MINIMUM_REPEAT = 3;
+ const size_t MAXIMUM_REPEAT = 127
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/126#discussion_r118044090
--- Diff: c++/src/ByteRLE.cc ---
@@ -27,6 +27,272 @@
namespace orc {
const size_t MINIMUM_REPEAT = 3;
+ const size_t MAXIMUM_REPEAT = 127
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/122
Hi @majetideepak , what happens next after you approved? are you able to
accept this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117822601
--- Diff: c++/src/Compression.cc ---
@@ -636,6 +884,33 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ std::unique_ptr
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117622782
--- Diff: c++/src/Compression.cc ---
@@ -636,6 +884,33 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ std::unique_ptr
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/126
@omalley @majetideepak Can you also take a look at this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/122
@majetideepak @omalley please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117381049
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117380313
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117379895
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117378369
--- Diff: c++/src/Compression.cc ---
@@ -33,6 +33,254 @@
namespace orc {
+ class CompressionStreamBase: public BufferedOutputStream
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/122#discussion_r117363862
--- Diff: c++/src/Compression.cc ---
@@ -636,6 +884,33 @@ DIAGNOSTIC_POP
return static_cast(result);
}
+ std::unique_ptr
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/122
@omalley can you please take a look at this? Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 105 matches
Mail list logo
