[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857176353 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -379,4 +432,117 @@ public void remove() { second.remove(); }

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857176203 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -248,13 +295,17 @@ public int read() throws IOException { throw new

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857176083 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -203,11 +217,22 @@ public List remainingBuffers() { return

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857175991 ## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ## @@ -174,4 +248,63 @@ public boolean markSupported() { public int

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857175853 ## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ## @@ -88,6 +132,15 @@ public long skip(long n) { return bytesToSkip; }

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857175617 ## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ## @@ -46,12 +74,19 @@ public long position() { return buffer.position() -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-24 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r857175587 ## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ## @@ -46,12 +74,19 @@ public long position() { return buffer.position() -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #953: Performance optimizations: Merged all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-04-18 Thread GitBox
rdblue commented on code in PR #953: URL: https://github.com/apache/parquet-mr/pull/953#discussion_r852492474 ## parquet-column/src/main/java/org/apache/parquet/column/values/bitpacking/ByteBitPackingValuesReader.java: ## @@ -1,14 +1,14 @@ -/* +/* * Licensed to the Apache