[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-06-20 Thread GitBox
steveloughran commented on code in PR #951: URL: https://github.com/apache/parquet-mr/pull/951#discussion_r901856428 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -50,51 +46,45 @@ public class HadoopStreams { */ public static See

[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-06-06 Thread GitBox
steveloughran commented on code in PR #951: URL: https://github.com/apache/parquet-mr/pull/951#discussion_r890391185 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -66,6 +67,19 @@ public static SeekableInputStream wrap(FSDataInputStream

[GitHub] [parquet-mr] steveloughran commented on a diff in pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

2022-06-06 Thread GitBox
steveloughran commented on code in PR #951: URL: https://github.com/apache/parquet-mr/pull/951#discussion_r890388928 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/HadoopStreams.java: ## @@ -51,7 +52,7 @@ public class HadoopStreams { public static SeekableInpu