[jira] [Commented] (PARQUET-1229) parquet-mr code changes for encryption support

2020-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103615#comment-17103615 ] ASF GitHub Bot commented on PARQUET-1229: - shangxinli commented on pull request

[GitHub] [parquet-mr] shangxinli commented on pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#issuecomment-626266715 @ggershinsky Do you have time to review the code? This is an automated message from the Apache Git Service

[jira] [Commented] (PARQUET-1229) parquet-mr code changes for encryption support

2020-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103614#comment-17103614 ] ASF GitHub Bot commented on PARQUET-1229: - shangxinli commented on a change in

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422577368 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -463,14 +486,29 @@ ConvertedType

[jira] [Commented] (PARQUET-1229) parquet-mr code changes for encryption support

2020-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103604#comment-17103604 ] ASF GitHub Bot commented on PARQUET-1229: - shangxinli commented on a change in

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #776: PARQUET-1229: Parquet MR encryption

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #776: URL: https://github.com/apache/parquet-mr/pull/776#discussion_r422575326 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java ## @@ -1185,70 +1275,189 @@ static long

[jira] [Commented] (PARQUET-1827) UUID type currently not supported by parquet-mr

2020-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103555#comment-17103555 ] ASF GitHub Bot commented on PARQUET-1827: - shangxinli commented on a change in

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r422564200 ## File path: parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveStringifier.java ## @@ -309,6 +308,35 @@ public void testDecimalStr

[jira] [Commented] (PARQUET-1827) UUID type currently not supported by parquet-mr

2020-05-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103548#comment-17103548 ] ASF GitHub Bot commented on PARQUET-1827: - shangxinli commented on a change in

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-09 Thread GitBox
shangxinli commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r422563108 ## File path: parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java ## @@ -766,6 +768,33 @@ public void testReuseNameInNest

Re: [Python][Documentation] Add column limit recommendations Parquet page

2020-05-09 Thread Wes McKinney
hi Maarten, I added dev@parquet.apache.org to this (if you are not subscribed to this list you may want to) I made a quick notebook to help illustrate: https://gist.github.com/wesm/cabf684db3ce8fdd6df27cf782f7226e Summary: * Files with 1000+ columns can see the metadata-to-data ratio exceed 10

[GitHub] [parquet-mr] lssatvik commented on pull request #791: Parquet-1860: Add missing Builder Class to ProtoParquetWriter Class

2020-05-09 Thread GitBox
lssatvik commented on pull request #791: URL: https://github.com/apache/parquet-mr/pull/791#issuecomment-626145884 > Would be great if you could create a test under https://github.com/forcedotcom/incubator-parquet-mr/tree/master/parquet-protobuf/src/test/java/parquet/proto Is there a

[GitHub] [parquet-mr] Fokko commented on pull request #791: Parquet-1860: Add missing Builder Class to ProtoParquetWriter Class

2020-05-09 Thread GitBox
Fokko commented on pull request #791: URL: https://github.com/apache/parquet-mr/pull/791#issuecomment-626122482 Would be great if you could create a test under https://github.com/forcedotcom/incubator-parquet-mr/tree/master/parquet-protobuf/src/test/java/parquet/proto