[jira] [Commented] (PARQUET-1997) [C++] AesEncryptor and AesDecryptor primitives are unsafe

2021-03-10 Thread Gidon Gershinsky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299054#comment-17299054 ] Gidon Gershinsky commented on PARQUET-1997: --- I recall we talked about that with Tham, but I

[jira] [Commented] (PARQUET-1997) [C++] AesEncryptor and AesDecryptor primitives are unsafe

2021-03-10 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299049#comment-17299049 ] Antoine Pitrou commented on PARQUET-1997: - Hmm, you're right, I had overlooked that. But what

[jira] [Commented] (PARQUET-1997) [C++] AesEncryptor and AesDecryptor primitives are unsafe

2021-03-10 Thread Gidon Gershinsky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299041#comment-17299041 ] Gidon Gershinsky commented on PARQUET-1997: --- [~apitrou] This point is addressed by the _int 

[GitHub] [parquet-format] pitrou commented on pull request #168: PARQUET-1996: [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread GitBox
pitrou commented on pull request #168: URL: https://github.com/apache/parquet-format/pull/168#issuecomment-795853899 Thanks for the reference. I'll wait a bit in case I get some feedback from the LZ4 mailing-list. In any case, what is the procedure for merging an update in the

[jira] [Commented] (PARQUET-1996) [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299038#comment-17299038 ] ASF GitHub Bot commented on PARQUET-1996: - pitrou commented on pull request #168: URL:

[jira] [Commented] (PARQUET-1997) [C++] AesEncryptor and AesDecryptor primitives are unsafe

2021-03-10 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298998#comment-17298998 ] Antoine Pitrou commented on PARQUET-1997: - [~gershinsky] > [C++] AesEncryptor and AesDecryptor

[jira] [Created] (PARQUET-1997) [C++] AesEncryptor and AesDecryptor primitives are unsafe

2021-03-10 Thread Antoine Pitrou (Jira)
Antoine Pitrou created PARQUET-1997: --- Summary: [C++] AesEncryptor and AesDecryptor primitives are unsafe Key: PARQUET-1997 URL: https://issues.apache.org/jira/browse/PARQUET-1997 Project: Parquet

[jira] [Resolved] (PARQUET-1993) [C++] Expose when prefetching completes

2021-03-10 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou resolved PARQUET-1993. - Fix Version/s: cpp-1.6.0 Resolution: Fixed Issue resolved by pull request 9613

[jira] [Commented] (PARQUET-1996) [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298817#comment-17298817 ] ASF GitHub Bot commented on PARQUET-1996: - pitrou commented on pull request #168: URL:

[GitHub] [parquet-format] pitrou commented on pull request #168: PARQUET-1996: [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread GitBox
pitrou commented on pull request #168: URL: https://github.com/apache/parquet-format/pull/168#issuecomment-795390108 I've also sent [a message](https://groups.google.com/g/lz4c/c/d6V12JKr5Fw) to the LZ4 mailing-list to gather their feedback on this proposal.

[jira] [Commented] (PARQUET-1992) Cannot build from tarball because of git submodules

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298694#comment-17298694 ] ASF GitHub Bot commented on PARQUET-1992: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test p

2021-03-10 Thread GitBox
gszadovszky commented on a change in pull request #878: URL: https://github.com/apache/parquet-mr/pull/878#discussion_r591264845 ## File path: .gitignore ## @@ -19,3 +19,4 @@ target/ .cache *~ mvn_install.log +parquet-hadoop/parquet-testing Review comment: Since you

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #878: PARQUET-1992: Manually download interop files inside the test and move encryption interop test to maven integration-test p

2021-03-10 Thread GitBox
gszadovszky commented on a change in pull request #878: URL: https://github.com/apache/parquet-mr/pull/878#discussion_r591264380 ## File path: .gitignore ## @@ -19,3 +19,4 @@ target/ .cache *~ mvn_install.log +parquet-hadoop/parquet-testing Review comment: Since you

[jira] [Commented] (PARQUET-1996) [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298685#comment-17298685 ] ASF GitHub Bot commented on PARQUET-1996: - pitrou commented on pull request #168: URL:

[GitHub] [parquet-format] pitrou commented on pull request #168: PARQUET-1996: [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread GitBox
pitrou commented on pull request #168: URL: https://github.com/apache/parquet-format/pull/168#issuecomment-795136194 > What do you think about adding links to the codec specifications directly instead of to the C/C++ implementations? I was not aware that those even existed. I'll add

[jira] [Commented] (PARQUET-1996) [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298681#comment-17298681 ] ASF GitHub Bot commented on PARQUET-1996: - pitrou commented on a change in pull request #168:

[GitHub] [parquet-format] pitrou commented on a change in pull request #168: PARQUET-1996: [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread GitBox
pitrou commented on a change in pull request #168: URL: https://github.com/apache/parquet-format/pull/168#discussion_r591254094 ## File path: Compression.md ## @@ -0,0 +1,86 @@ + + +# Parquet compression definitions + +This document contains the specification of all supported

[jira] [Commented] (PARQUET-1950) Define core features / compliance level

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298674#comment-17298674 ] ASF GitHub Bot commented on PARQUET-1950: - gszadovszky commented on a change in pull request

[GitHub] [parquet-format] gszadovszky commented on a change in pull request #164: PARQUET-1950: Define core features

2021-03-10 Thread GitBox
gszadovszky commented on a change in pull request #164: URL: https://github.com/apache/parquet-format/pull/164#discussion_r591252577 ## File path: CoreFeatures.md ## @@ -0,0 +1,181 @@ + + +# Parquet Core Features + +This document lists the core features for each parquet-format

[jira] [Commented] (PARQUET-1996) [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298661#comment-17298661 ] ASF GitHub Bot commented on PARQUET-1996: - gszadovszky commented on a change in pull request

[GitHub] [parquet-format] gszadovszky commented on a change in pull request #168: PARQUET-1996: [Format] Add interoperable LZ4 codec, deprecate existing LZ4 codec

2021-03-10 Thread GitBox
gszadovszky commented on a change in pull request #168: URL: https://github.com/apache/parquet-format/pull/168#discussion_r591231620 ## File path: src/main/thrift/parquet.thrift ## @@ -481,9 +481,10 @@ enum CompressionCodec { SNAPPY = 1; GZIP = 2; LZO = 3; - BROTLI =