[
https://issues.apache.org/jira/browse/PARQUET-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298694#comment-17298694
]
ASF GitHub Bot commented on PARQUET-1992:
-----------------------------------------
gszadovszky commented on a change in pull request #878:
URL: https://github.com/apache/parquet-mr/pull/878#discussion_r591264845
##########
File path: .gitignore
##########
@@ -19,3 +19,4 @@ target/
.cache
*~
mvn_install.log
+parquet-hadoop/parquet-testing
Review comment:
Since you are using `target` now this change is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cannot build from tarball because of git submodules
> ---------------------------------------------------
>
> Key: PARQUET-1992
> URL: https://issues.apache.org/jira/browse/PARQUET-1992
> Project: Parquet
> Issue Type: Bug
> Reporter: Gabor Szadovszky
> Priority: Blocker
>
> Because we use git submodules (to get test parquet files) a simple "mvn clean
> install" fails from the unpacked tarball due to "not a git repository".
> I think we would have 2 options to solve this situation:
> * Include all the required files (even only for testing) in the tarball and
> somehow avoid the git submodule update in case of executed in a non-git
> envrionment
> * Make the downloading of the parquet files and the related tests optional so
> it won't fail the build from the tarball
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
