[GitHub] [parquet-mr] shangxinli commented on pull request #901: PARQUET-2037: Write INT96 with parquet-avro

2021-05-04 Thread GitBox
shangxinli commented on pull request #901: URL: https://github.com/apache/parquet-mr/pull/901#issuecomment-832398022 In the ticket, you mentioned there are two ways to solve this issue. I see you implemented it using the 2nd way. I wonder what is the reason behind it? I am not in favor

[GitHub] [parquet-mr] shangxinli commented on pull request #902: PARQUET-1633 Fix integer overflow

2021-05-04 Thread GitBox
shangxinli commented on pull request #902: URL: https://github.com/apache/parquet-mr/pull/902#issuecomment-832290027 Can you come up with a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PARQUET-1798) [C++] Review logic around automatic assignment of field_id's

2021-05-04 Thread Weston Pace (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339290#comment-17339290 ] Weston Pace commented on PARQUET-1798: -- Is there something wrong with the generation algorithm? 

[jira] [Commented] (PARQUET-1633) Integer overflow in ParquetFileReader.ConsecutiveChunkList

2021-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338998#comment-17338998 ] ASF GitHub Bot commented on PARQUET-1633: - eadwright commented on a change in pull request

[GitHub] [parquet-mr] eadwright commented on a change in pull request #902: PARQUET-1633 Fix integer overflow

2021-05-04 Thread GitBox
eadwright commented on a change in pull request #902: URL: https://github.com/apache/parquet-mr/pull/902#discussion_r625792180 ## File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java ## @@ -1464,7 +1464,7 @@ protected PageHeader

[jira] [Commented] (PARQUET-1633) Integer overflow in ParquetFileReader.ConsecutiveChunkList

2021-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338988#comment-17338988 ] ASF GitHub Bot commented on PARQUET-1633: - eadwright opened a new pull request #902: URL:

[GitHub] [parquet-mr] eadwright opened a new pull request #902: PARQUET-1633 Fix integer overflow

2021-05-04 Thread GitBox
eadwright opened a new pull request #902: URL: https://github.com/apache/parquet-mr/pull/902 This PR addresses this issue: https://issues.apache.org/jira/browse/PARQUET-1633 I have not added unit tests, as to check overflow conditions I would need test data over 2GB in size (on

Re: [parquet-mr] Support writing INT96 type by parquet-avro

2021-05-04 Thread Gabor Szadovszky
I've created PARQUET-2037 about this topic. Also created a potential implementation: #901 Any reviews/comments are welcomed. On Tue, Apr 20, 2021 at 4:48 PM Gabor Szadovszky wrote: > Hi

[jira] [Commented] (PARQUET-2037) Write INT96 with parquet-avro

2021-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338958#comment-17338958 ] ASF GitHub Bot commented on PARQUET-2037: - gszadovszky opened a new pull request #901: URL:

[GitHub] [parquet-mr] gszadovszky opened a new pull request #901: PARQUET-2037: Write INT96 with parquet-avro

2021-05-04 Thread GitBox
gszadovszky opened a new pull request #901: URL: https://github.com/apache/parquet-mr/pull/901 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them

[jira] [Commented] (PARQUET-2038) Upgrade Jackson version used in parquet encryption

2021-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338954#comment-17338954 ] ASF GitHub Bot commented on PARQUET-2038: - gszadovszky merged pull request #898: URL:

[jira] [Resolved] (PARQUET-2038) Upgrade Jackson version used in parquet encryption

2021-05-04 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-2038. --- Resolution: Fixed > Upgrade Jackson version used in parquet encryption >

[GitHub] [parquet-mr] gszadovszky merged pull request #898: PARQUET-2038: Upgrade Jackson version used in parquet encryption.

2021-05-04 Thread GitBox
gszadovszky merged pull request #898: URL: https://github.com/apache/parquet-mr/pull/898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (PARQUET-2043) Fail build for used but not declared direct dependencies

2021-05-04 Thread Gabor Szadovszky (Jira)
Gabor Szadovszky created PARQUET-2043: - Summary: Fail build for used but not declared direct dependencies Key: PARQUET-2043 URL: https://issues.apache.org/jira/browse/PARQUET-2043 Project: Parquet

[jira] [Updated] (PARQUET-1230) CLI tools for encrypted files

2021-05-04 Thread Gidon Gershinsky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gidon Gershinsky updated PARQUET-1230: -- Component/s: parquet-mr Affects Version/s: 1.12.0 > CLI tools for

[jira] [Updated] (PARQUET-1230) CLI tools for encrypted files

2021-05-04 Thread Gidon Gershinsky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gidon Gershinsky updated PARQUET-1230: -- Parent: (was: PARQUET-1178) Issue Type: New Feature (was: Sub-task) >

[jira] [Commented] (PARQUET-2038) Upgrade Jackson version used in parquet encryption

2021-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338803#comment-17338803 ] ASF GitHub Bot commented on PARQUET-2038: - andersonm-ibm commented on pull request #898: URL:

[GitHub] [parquet-mr] andersonm-ibm commented on pull request #898: PARQUET-2038: Upgrade Jackson version used in parquet encryption.

2021-05-04 Thread GitBox
andersonm-ibm commented on pull request #898: URL: https://github.com/apache/parquet-mr/pull/898#issuecomment-831731317 Hi @gszadovszky , could you please take a look at this? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please