[jira] [Commented] (PARQUET-2107) Travis failures
[ https://issues.apache.org/jira/browse/PARQUET-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454848#comment-17454848 ] ASF GitHub Bot commented on PARQUET-2107: - shangxinli merged pull request #941: URL: https://github.com/apache/parquet-mr/pull/941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Travis failures > --- > > Key: PARQUET-2107 > URL: https://issues.apache.org/jira/browse/PARQUET-2107 > Project: Parquet > Issue Type: Bug >Reporter: Gabor Szadovszky >Assignee: Gabor Szadovszky >Priority: Major > > There are Travis failures since a while in our PRs. See e.g. > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] shangxinli merged pull request #941: PARQUET-2107: Fix Travis failures
shangxinli merged pull request #941: URL: https://github.com/apache/parquet-mr/pull/941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2107) Travis failures
[ https://issues.apache.org/jira/browse/PARQUET-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454846#comment-17454846 ] ASF GitHub Bot commented on PARQUET-2107: - shangxinli commented on pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#issuecomment-988262215 This great help @gszadovszky @martin-g! Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Travis failures > --- > > Key: PARQUET-2107 > URL: https://issues.apache.org/jira/browse/PARQUET-2107 > Project: Parquet > Issue Type: Bug >Reporter: Gabor Szadovszky >Assignee: Gabor Szadovszky >Priority: Major > > There are Travis failures since a while in our PRs. See e.g. > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] shangxinli commented on pull request #941: PARQUET-2107: Fix Travis failures
shangxinli commented on pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#issuecomment-988262215 This great help @gszadovszky @martin-g! Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2106) BinaryComparator should avoid doing ByteBuffer.wrap in the hot-path
[ https://issues.apache.org/jira/browse/PARQUET-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454805#comment-17454805 ] ASF GitHub Bot commented on PARQUET-2106: - alexeykudinkin commented on pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#issuecomment-988196165 @gszadovszky good points, will address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > BinaryComparator should avoid doing ByteBuffer.wrap in the hot-path > --- > > Key: PARQUET-2106 > URL: https://issues.apache.org/jira/browse/PARQUET-2106 > Project: Parquet > Issue Type: Task > Components: parquet-mr >Affects Versions: 1.12.2 >Reporter: Alexey Kudinkin >Priority: Major > Attachments: Screen Shot 2021-12-03 at 3.26.31 PM.png, > profile_48449_alloc_1638494450_sort_by.html > > > *Background* > While writing out large Parquet tables using Spark, we've noticed that > BinaryComparator is the source of substantial churn of extremely short-lived > `HeapByteBuffer` objects – It's taking up to *16%* of total amount of > allocations in our benchmarks, putting substantial pressure on a Garbage > Collector: > !Screen Shot 2021-12-03 at 3.26.31 PM.png|width=828,height=521! > [^profile_48449_alloc_1638494450_sort_by.html] > > *Proposal* > We're proposing to adjust lexicographical comparison (at least) to avoid > doing any allocations, since this code lies on the hot-path of every Parquet > write, therefore causing substantial churn amplification. > > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] alexeykudinkin commented on pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path
alexeykudinkin commented on pull request #940: URL: https://github.com/apache/parquet-mr/pull/940#issuecomment-988196165 @gszadovszky good points, will address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2107) Travis failures
[ https://issues.apache.org/jira/browse/PARQUET-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454686#comment-17454686 ] ASF GitHub Bot commented on PARQUET-2107: - gszadovszky commented on pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#issuecomment-987987814 It seems it solved the issues. @shangxinli, could you please check it out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Travis failures > --- > > Key: PARQUET-2107 > URL: https://issues.apache.org/jira/browse/PARQUET-2107 > Project: Parquet > Issue Type: Bug >Reporter: Gabor Szadovszky >Assignee: Gabor Szadovszky >Priority: Major > > There are Travis failures since a while in our PRs. See e.g. > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] gszadovszky commented on pull request #941: PARQUET-2107: Fix Travis failures
gszadovszky commented on pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#issuecomment-987987814 It seems it solved the issues. @shangxinli, could you please check it out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #941: PARQUET-2107: Fix Travis failures
gszadovszky commented on a change in pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#discussion_r763839330 ## File path: .travis.yml ## @@ -18,6 +18,7 @@ # TravisCI is being used as an alternative to GitHub Actions until # the latter provides support for ARM64 CPU architecture (PARQUET-1980) +dist: focal distro: bionic Review comment: Thanks, @martin-g. I didn't realize that `dist` is for distro. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2107) Travis failures
[ https://issues.apache.org/jira/browse/PARQUET-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454529#comment-17454529 ] ASF GitHub Bot commented on PARQUET-2107: - martin-g commented on a change in pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#discussion_r763834170 ## File path: .travis.yml ## @@ -18,6 +18,7 @@ # TravisCI is being used as an alternative to GitHub Actions until # the latter provides support for ARM64 CPU architecture (PARQUET-1980) +dist: focal distro: bionic Review comment: Sorry, I didn't notice it earlier - you need to remove `distro: bionic`. `distro` is a typo anyway, so it was falling back to the default (`bionic`) until now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Travis failures > --- > > Key: PARQUET-2107 > URL: https://issues.apache.org/jira/browse/PARQUET-2107 > Project: Parquet > Issue Type: Bug >Reporter: Gabor Szadovszky >Assignee: Gabor Szadovszky >Priority: Major > > There are Travis failures since a while in our PRs. See e.g. > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or > https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] martin-g commented on a change in pull request #941: PARQUET-2107: Fix Travis failures
martin-g commented on a change in pull request #941: URL: https://github.com/apache/parquet-mr/pull/941#discussion_r763834170 ## File path: .travis.yml ## @@ -18,6 +18,7 @@ # TravisCI is being used as an alternative to GitHub Actions until # the latter provides support for ARM64 CPU architecture (PARQUET-1980) +dist: focal distro: bionic Review comment: Sorry, I didn't notice it earlier - you need to remove `distro: bionic`. `distro` is a typo anyway, so it was falling back to the default (`bionic`) until now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PARQUET-2107) Travis failures
[
https://issues.apache.org/jira/browse/PARQUET-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454522#comment-17454522
]
ASF GitHub Bot commented on PARQUET-2107:
-
gszadovszky opened a new pull request #941:
URL: https://github.com/apache/parquet-mr/pull/941
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Travis failures
> ---
>
> Key: PARQUET-2107
> URL: https://issues.apache.org/jira/browse/PARQUET-2107
> Project: Parquet
> Issue Type: Bug
>Reporter: Gabor Szadovszky
>Assignee: Gabor Szadovszky
>Priority: Major
>
> There are Travis failures since a while in our PRs. See e.g.
> https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or
> https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (PARQUET-2107) Travis failures
Gabor Szadovszky created PARQUET-2107: - Summary: Travis failures Key: PARQUET-2107 URL: https://issues.apache.org/jira/browse/PARQUET-2107 Project: Parquet Issue Type: Bug Reporter: Gabor Szadovszky Assignee: Gabor Szadovszky There are Travis failures since a while in our PRs. See e.g. https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598285 or https://app.travis-ci.com/github/apache/parquet-mr/jobs/550598286 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #940: [PARQUET-2106] Refactoring lexicographic `BinaryComparator` to avoid `ByteBuffer.wrap` in the hot-path
gszadovszky commented on a change in pull request #940:
URL: https://github.com/apache/parquet-mr/pull/940#discussion_r763814302
##
File path: parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
##
@@ -542,6 +606,10 @@ public static Binary fromCharSequence(CharSequence value) {
return new FromCharSequenceBinary(value);
}
+ public static int compareToLexicographic(Binary one, Binary other) {
Review comment:
`compareTo` is usually used when `this` is to be compared to the
argument. In case of a method comparing the two arguments to each other
`compare` is preferred.
I think, either `lexicographicCompare` or `compareLexicographically` would
be better than the current one.
The naming of the package private methods that really compares `this` to the
argument is less important to me but still, something like
`lexicographicCompareTo` or `compareToLexicographically` would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
