maccamlc commented on pull request #798:
URL: https://github.com/apache/parquet-mr/pull/798#issuecomment-651009716
> @maccamlc,
>
> The main problem I think is that the spec does not say anything about how
the thrift objects shall be used. The specification is about the semantics of
maccamlc commented on pull request #798:
URL: https://github.com/apache/parquet-mr/pull/798#issuecomment-650527774
@gszadovszky before this gets merged, I just wanted to clarify something
myself after looking more into the format spec, that might tidy this issue up
further.
* Is MAP
maccamlc commented on pull request #798:
URL: https://github.com/apache/parquet-mr/pull/798#issuecomment-649482253
> Thank you for creating the backward compatibility test for Map. It should
have been existed already.
> Unfortunately, this way you do not properly test backward compatibil
maccamlc commented on pull request #798:
URL: https://github.com/apache/parquet-mr/pull/798#issuecomment-649202469
> Thanks for working on this.
>
> You have changed every naming from `"map"` to `"key_value"` in the tests.
This is good for the expected data but we should keep testing
