[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351679#comment-16351679 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823076 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823076 ] PDFBOX-3709: remove deprecated methods > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351682#comment-16351682 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823077 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823077 ] PDFBOX-3709: remove deprecated methods > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351683#comment-16351683 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823078 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823078 ] PDFBOX-3709: remove deprecated method > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351684#comment-16351684 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823079 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823079 ] PDFBOX-3709: remove deprecated method > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351685#comment-16351685 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823080 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823080 ] PDFBOX-3709: remove deprecated method > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351686#comment-16351686 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823081 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823081 ] PDFBOX-3709: remove deprecated method > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351687#comment-16351687 ] ASF subversion and git services commented on PDFBOX-3709: - Commit 1823082 from [~tilman] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823082 ] PDFBOX-3709: remove deprecated methods > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[
https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351688#comment-16351688
]
Maruan Sahyoun commented on PDFBOX-3709:
[~tilman] can we keep the deprecated methods in {{PDPageContentStream}} for now
until we are done with the appearance generation?
> delete deprecated API
> -
>
> Key: PDFBOX-3709
> URL: https://issues.apache.org/jira/browse/PDFBOX-3709
> Project: PDFBox
> Issue Type: Task
>Reporter: Tilman Hausherr
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> As a reminder, these are the API parts to delete for 3.0
> - COSNumber ZERO, ONE
> - methods with RandomAccess in CCITTFactory
> - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html
> - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if
> there are left overs we didn't do
> - remove throws declarations where not necessary (see PDFBOX-3365)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3709) delete deprecated API
[ https://issues.apache.org/jira/browse/PDFBOX-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351690#comment-16351690 ] Tilman Hausherr commented on PDFBOX-3709: - Sure! > delete deprecated API > - > > Key: PDFBOX-3709 > URL: https://issues.apache.org/jira/browse/PDFBOX-3709 > Project: PDFBox > Issue Type: Task >Reporter: Tilman Hausherr >Priority: Major > Fix For: 3.0.0 PDFBox > > > As a reminder, these are the API parts to delete for 3.0 > - COSNumber ZERO, ONE > - methods with RandomAccess in CCITTFactory > - https://pdfbox.apache.org/docs/2.0.7/javadocs/deprecated-list.html > - https://pdfbox.apache.org/docs/1.8.13/javadocs/deprecated-list.html if > there are left overs we didn't do > - remove throws declarations where not necessary (see PDFBOX-3365) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4068) Create ContentStream for XObject forms
[
https://issues.apache.org/jira/browse/PDFBOX-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351706#comment-16351706
]
Maruan Sahyoun commented on PDFBOX-4068:
[~tilman] if we keep {{PDPageContentStream.appendRawCommands}} we can remove
{{PDAbstractContentStream.getOutput}} and {{PDAbstractContentStream.setOutput}}
removing the risk associated with allowing direct access to the {{OuputStream}}
e.g. calling {{close()}}
WDYT?
> Create ContentStream for XObject forms
> --
>
> Key: PDFBOX-4068
> URL: https://issues.apache.org/jira/browse/PDFBOX-4068
> Project: PDFBox
> Issue Type: Task
> Components: PDModel
>Reporter: Tilman Hausherr
>Priority: Major
>
> We have a {{PDAppearanceContentStream}} for appearances but nothing for
> XObject forms.
> What we need should extend {{PDAbstractContentStream}} and should have a
> constructor like
> {code:java}
> public PDFormContentStream(PDFormXObject form) throws IOException
> {code}
> Alternatively, why not replace {{PDAppearanceContentStream}} ? Its parameter
> {{PDAppearanceStream}} is extended from {{PDFormXObject}} so we could just
> use the base class.
> We need this both for 2.0 and 3.* - we have users who have a really hard time
> fiddling with low level operators instead of using the methods.
> In 2.0 we could replace the parameter of {{PDPageContentStream}} that is
> currently {{PDAppearanceStream}}. This would be a non breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
Re: Removing methods deprectaed in 2.0.x in trunk
> Am 03.02.2018 um 20:54 schrieb Maruan Sahyoun : > > >> Am 03.02.2018 um 20:52 schrieb Tilman Hausherr : >> >> Am 03.02.2018 um 20:42 schrieb Maruan Sahyoun: Am 03.02.2018 um 20:28 schrieb Tilman Hausherr : Yes with some exceptions: - keep the "raw" methods from the contentstream classes because some people may use them anyway >>> I'd like to keep them too as it allows people who know what they do to use >>> them. Why not remove the deprecation notice in 2.0? >> >> I'd prefer to keep the deprecation so that "new" people don't start using >> them. It's like smoking. It is warned against that it shouldn't be done, but >> people do it anyway, but at least they've been warned that they'll have a >> terrible death. > > OK > >> >> >>> - keep the "height" methods that are mentioned in the builds because these are still being used by ourselves (I think). >>> that's getHeight in some of the font classes - correct? >> >> Yes what about replacing the deprecated call with the new method? >> >>> >>> Shall I add a ticket or do we handle that with PDFBOX-4071? >> >> There's PDFBOX-3709 for that :-) > > thanks - too many tickets :-) > >> >> Tilman >> >> >>> BR >>> Maruan >>> >>> Tilman Am 03.02.2018 um 19:56 schrieb Maruan Sahyoun: > Hi, > > there are a number of deprecated constructors, methods and fields in > trunk which we deprecated in 2.0.x. > > What about starting to remove these while we are working on some of the > affected classes? > > BR > Maruan > > > - > To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org > For additional commands, e-mail: dev-h...@pdfbox.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org >>> For additional commands, e-mail: dev-h...@pdfbox.apache.org >>> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org >> For additional commands, e-mail: dev-h...@pdfbox.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org > For additional commands, e-mail: dev-h...@pdfbox.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4068) Create ContentStream for XObject forms
[
https://issues.apache.org/jira/browse/PDFBOX-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351709#comment-16351709
]
Tilman Hausherr commented on PDFBOX-4068:
-
If you remove the setter then the no-args constructor doesn't have any value.
So I'd say yes remove both but remove the no-args constructor as well.
The risk is still there - one can call close() on the class itself... I
accidentally did this several times.
> Create ContentStream for XObject forms
> --
>
> Key: PDFBOX-4068
> URL: https://issues.apache.org/jira/browse/PDFBOX-4068
> Project: PDFBox
> Issue Type: Task
> Components: PDModel
>Reporter: Tilman Hausherr
>Priority: Major
>
> We have a {{PDAppearanceContentStream}} for appearances but nothing for
> XObject forms.
> What we need should extend {{PDAbstractContentStream}} and should have a
> constructor like
> {code:java}
> public PDFormContentStream(PDFormXObject form) throws IOException
> {code}
> Alternatively, why not replace {{PDAppearanceContentStream}} ? Its parameter
> {{PDAppearanceStream}} is extended from {{PDFormXObject}} so we could just
> use the base class.
> We need this both for 2.0 and 3.* - we have users who have a really hard time
> fiddling with low level operators instead of using the methods.
> In 2.0 we could replace the parameter of {{PDPageContentStream}} that is
> currently {{PDAppearanceStream}}. This would be a non breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
Re: Removing methods deprectaed in 2.0.x in trunk
Am 04.02.2018 um 10:31 schrieb Maruan Sahyoun: - keep the "height" methods that are mentioned in the builds because these are still being used by ourselves (I think). that's getHeight in some of the font classes - correct? Yes what about replacing the deprecated call with the new method? I suspect that text extraction would no longer work. Tilman
[jira] [Comment Edited] (PDFBOX-4068) Create ContentStream for XObject forms
[
https://issues.apache.org/jira/browse/PDFBOX-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351729#comment-16351729
]
Maruan Sahyoun edited comment on PDFBOX-4068 at 2/4/18 10:30 AM:
-
Sorry - I'll keep it as {{setOutput}} / {{getOutput}} s used within
{{PDPageContentStream}} after deciding on the {{AppendMode}} so there needs to
be a possibility to set the {{OutputStream}} after the constructor. I'll rename
the method to {{setOutputStream}} {{getOutputStream}} to make the method name
clearer.
was (Author: msahyoun):
Sorry - I'll keep it as {{set/Output}} / {{getOutput}} s used within
{{PDPageContentStream}} after deciding on the {{AppendMode}} so there needs to
be a possibility to set the {{OutputStream}} after the constructor. I'll rename
the method to {{setOutputStream}} {{getOutputStream}} to make the method name
clearer.
> Create ContentStream for XObject forms
> --
>
> Key: PDFBOX-4068
> URL: https://issues.apache.org/jira/browse/PDFBOX-4068
> Project: PDFBox
> Issue Type: Task
> Components: PDModel
>Reporter: Tilman Hausherr
>Priority: Major
>
> We have a {{PDAppearanceContentStream}} for appearances but nothing for
> XObject forms.
> What we need should extend {{PDAbstractContentStream}} and should have a
> constructor like
> {code:java}
> public PDFormContentStream(PDFormXObject form) throws IOException
> {code}
> Alternatively, why not replace {{PDAppearanceContentStream}} ? Its parameter
> {{PDAppearanceStream}} is extended from {{PDFormXObject}} so we could just
> use the base class.
> We need this both for 2.0 and 3.* - we have users who have a really hard time
> fiddling with low level operators instead of using the methods.
> In 2.0 we could replace the parameter of {{PDPageContentStream}} that is
> currently {{PDAppearanceStream}}. This would be a non breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4068) Create ContentStream for XObject forms
[
https://issues.apache.org/jira/browse/PDFBOX-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351729#comment-16351729
]
Maruan Sahyoun commented on PDFBOX-4068:
Sorry - I'll keep it as {{set/Output}} / {{getOutput}} s used within
{{PDPageContentStream}} after deciding on the {{AppendMode}} so there needs to
be a possibility to set the {{OutputStream}} after the constructor. I'll rename
the method to {{setOutputStream}} {{getOutputStream}} to make the method name
clearer.
> Create ContentStream for XObject forms
> --
>
> Key: PDFBOX-4068
> URL: https://issues.apache.org/jira/browse/PDFBOX-4068
> Project: PDFBox
> Issue Type: Task
> Components: PDModel
>Reporter: Tilman Hausherr
>Priority: Major
>
> We have a {{PDAppearanceContentStream}} for appearances but nothing for
> XObject forms.
> What we need should extend {{PDAbstractContentStream}} and should have a
> constructor like
> {code:java}
> public PDFormContentStream(PDFormXObject form) throws IOException
> {code}
> Alternatively, why not replace {{PDAppearanceContentStream}} ? Its parameter
> {{PDAppearanceStream}} is extended from {{PDFormXObject}} so we could just
> use the base class.
> We need this both for 2.0 and 3.* - we have users who have a really hard time
> fiddling with low level operators instead of using the methods.
> In 2.0 we could replace the parameter of {{PDPageContentStream}} that is
> currently {{PDAppearanceStream}}. This would be a non breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4068) Create ContentStream for XObject forms
[
https://issues.apache.org/jira/browse/PDFBOX-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351733#comment-16351733
]
ASF subversion and git services commented on PDFBOX-4068:
-
Commit 1823085 from [~msahyoun] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1823085 ]
PDFBOX-4068: rename methods and member to better match intented parameter
> Create ContentStream for XObject forms
> --
>
> Key: PDFBOX-4068
> URL: https://issues.apache.org/jira/browse/PDFBOX-4068
> Project: PDFBox
> Issue Type: Task
> Components: PDModel
>Reporter: Tilman Hausherr
>Priority: Major
>
> We have a {{PDAppearanceContentStream}} for appearances but nothing for
> XObject forms.
> What we need should extend {{PDAbstractContentStream}} and should have a
> constructor like
> {code:java}
> public PDFormContentStream(PDFormXObject form) throws IOException
> {code}
> Alternatively, why not replace {{PDAppearanceContentStream}} ? Its parameter
> {{PDAppearanceStream}} is extended from {{PDFormXObject}} so we could just
> use the base class.
> We need this both for 2.0 and 3.* - we have users who have a really hard time
> fiddling with low level operators instead of using the methods.
> In 2.0 we could replace the parameter of {{PDPageContentStream}} that is
> currently {{PDAppearanceStream}}. This would be a non breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
Re: Removing methods deprectaed in 2.0.x in trunk
> Am 04.02.2018 um 10:39 schrieb Tilman Hausherr : > > Am 04.02.2018 um 10:31 schrieb Maruan Sahyoun: >> - keep the "height" methods that are mentioned in the builds because >> these are still being used by ourselves (I think). > that's getHeight in some of the font classes - correct? Yes >> what about replacing the deprecated call with the new method? >> > > I suspect that text extraction would no longer work. From the comments in the source it shouldn't matter but I suspect that's not the case. And replacing with the height of the GeneralPath is IMHO a very costly although likely more accurate operation. > > > Tilman > - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4071) Improve code quality (3)
[ https://issues.apache.org/jira/browse/PDFBOX-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351746#comment-16351746 ] ASF subversion and git services commented on PDFBOX-4071: - Commit 1823086 from [~msahyoun] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1823086 ] PDFBOX-4071: fix javadoc warnings > Improve code quality (3) > > > Key: PDFBOX-4071 > URL: https://issues.apache.org/jira/browse/PDFBOX-4071 > Project: PDFBox > Issue Type: Task >Affects Versions: 2.0.8 >Reporter: Tilman Hausherr >Priority: Major > > This is a longterm issue for the task to improve code quality, by using the > [SonarQube > report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], > hints in different IDEs, the FindBugs tool and other code quality tools. > This is a follow-up of PDFBOX-2852, which was getting too long. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-4091) Cannot analyze signatures : Wrong type of referenced length object COSObject
[
https://issues.apache.org/jira/browse/PDFBOX-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351769#comment-16351769
]
Andreas Lehmkühler commented on PDFBOX-4091:
{quote}It fails on 2.0.8, but succeeds in the trunk, which is surprising for
now.
{quote}
It works on 2.0.9 SNAPSHOT, I guess due to some of the improvements/fixes for
the parser
> Cannot analyze signatures : Wrong type of referenced length object COSObject
>
>
> Key: PDFBOX-4091
> URL: https://issues.apache.org/jira/browse/PDFBOX-4091
> Project: PDFBox
> Issue Type: Bug
> Components: Parsing
>Affects Versions: 2.0.7, 2.0.8
>Reporter: Endre Pető
>Priority: Critical
> Attachments: E-SZ00104418_20180111_040700.pdf
>
>
> Dear Colleagues,
> From one of our customer, we have got a pdf. According them and the adobe
> there is a PKCS7 signature but according the DSS 5.2 there is no. I attached
> this voucher.
> What do you think?
> One of DSS developer quickly checked their log and we got:
> e.e.e.d.p.pdfbox.PdfBoxSignatureService : Cannot analyze signatures : Wrong
> type of referenced length object COSObject
> Unknown macro: \{8, 0}
> : COSDictionary
> java.io.IOException: Wrong type of referenced length object COSObject
> : COSDictionary
> at org.apache.pdfbox.pdfparser.COSParser.getLength(COSParser.java:908)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseCOSStream(COSParser.java:950)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseFileObject(COSParser.java:781)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:742)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:673)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseDictObjects(COSParser.java:633)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.PDFParser.initialParse(PDFParser.java:241)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.PDFParser.parse(PDFParser.java:276)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1224)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1201)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1182)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1165)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> eu.europa.esig.dss.pdf.pdfbox.PdfBoxSignatureService.getSignatures(PdfBoxSignatureService.java:321)
> [dss-pades-5.2.jar!/:na]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Assigned] (PDFBOX-4091) Cannot analyze signatures : Wrong type of referenced length object COSObject
[
https://issues.apache.org/jira/browse/PDFBOX-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Lehmkühler reassigned PDFBOX-4091:
--
Assignee: Andreas Lehmkühler
> Cannot analyze signatures : Wrong type of referenced length object COSObject
>
>
> Key: PDFBOX-4091
> URL: https://issues.apache.org/jira/browse/PDFBOX-4091
> Project: PDFBox
> Issue Type: Bug
> Components: Parsing
>Affects Versions: 2.0.7, 2.0.8
>Reporter: Endre Pető
>Assignee: Andreas Lehmkühler
>Priority: Critical
> Fix For: 2.0.9, 3.0.0 PDFBox
>
> Attachments: E-SZ00104418_20180111_040700.pdf
>
>
> Dear Colleagues,
> From one of our customer, we have got a pdf. According them and the adobe
> there is a PKCS7 signature but according the DSS 5.2 there is no. I attached
> this voucher.
> What do you think?
> One of DSS developer quickly checked their log and we got:
> e.e.e.d.p.pdfbox.PdfBoxSignatureService : Cannot analyze signatures : Wrong
> type of referenced length object COSObject
> Unknown macro: \{8, 0}
> : COSDictionary
> java.io.IOException: Wrong type of referenced length object COSObject
> : COSDictionary
> at org.apache.pdfbox.pdfparser.COSParser.getLength(COSParser.java:908)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseCOSStream(COSParser.java:950)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseFileObject(COSParser.java:781)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:742)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:673)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseDictObjects(COSParser.java:633)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.PDFParser.initialParse(PDFParser.java:241)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.PDFParser.parse(PDFParser.java:276)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1224)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1201)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1182)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1165)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> eu.europa.esig.dss.pdf.pdfbox.PdfBoxSignatureService.getSignatures(PdfBoxSignatureService.java:321)
> [dss-pades-5.2.jar!/:na]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Resolved] (PDFBOX-4091) Cannot analyze signatures : Wrong type of referenced length object COSObject
[
https://issues.apache.org/jira/browse/PDFBOX-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Lehmkühler resolved PDFBOX-4091.
Resolution: Fixed
Fix Version/s: 3.0.0 PDFBox
2.0.9
> Cannot analyze signatures : Wrong type of referenced length object COSObject
>
>
> Key: PDFBOX-4091
> URL: https://issues.apache.org/jira/browse/PDFBOX-4091
> Project: PDFBox
> Issue Type: Bug
> Components: Parsing
>Affects Versions: 2.0.7, 2.0.8
>Reporter: Endre Pető
>Assignee: Andreas Lehmkühler
>Priority: Critical
> Fix For: 2.0.9, 3.0.0 PDFBox
>
> Attachments: E-SZ00104418_20180111_040700.pdf
>
>
> Dear Colleagues,
> From one of our customer, we have got a pdf. According them and the adobe
> there is a PKCS7 signature but according the DSS 5.2 there is no. I attached
> this voucher.
> What do you think?
> One of DSS developer quickly checked their log and we got:
> e.e.e.d.p.pdfbox.PdfBoxSignatureService : Cannot analyze signatures : Wrong
> type of referenced length object COSObject
> Unknown macro: \{8, 0}
> : COSDictionary
> java.io.IOException: Wrong type of referenced length object COSObject
> : COSDictionary
> at org.apache.pdfbox.pdfparser.COSParser.getLength(COSParser.java:908)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseCOSStream(COSParser.java:950)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseFileObject(COSParser.java:781)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:742)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:673)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.COSParser.parseDictObjects(COSParser.java:633)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.PDFParser.initialParse(PDFParser.java:241)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdfparser.PDFParser.parse(PDFParser.java:276)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1224)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1201)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1182)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1165)
> ~[pdfbox-2.0.7.jar!/:2.0.7]
> at
> eu.europa.esig.dss.pdf.pdfbox.PdfBoxSignatureService.getSignatures(PdfBoxSignatureService.java:321)
> [dss-pades-5.2.jar!/:na]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Assigned] (PDFBOX-4084) Can't draw PDFs while ANNOTS is COSStream instead of COSArray
[
https://issues.apache.org/jira/browse/PDFBOX-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Lehmkühler reassigned PDFBOX-4084:
--
Assignee: Andreas Lehmkühler
> Can't draw PDFs while ANNOTS is COSStream instead of COSArray
> -
>
> Key: PDFBOX-4084
> URL: https://issues.apache.org/jira/browse/PDFBOX-4084
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
>Affects Versions: 2.0.8
>Reporter: Cheng Zhong
>Assignee: Andreas Lehmkühler
>Priority: Major
> Attachments: Benelux Equity Daily-20110321.pdf, TELECOM EQUIPMENT
> DAILY - 12 AUG 2009.pdf
>
>
> PDFBox would failed to draw the attached document , error logs are below:
> {code:java}
> java.lang.ClassCastException: org.apache.pdfbox.cos.COSStream cannot be cast
> to org.apache.pdfbox.cos.COSArray
> at org.apache.pdfbox.pdmodel.PDPage.getAnnotations(PDPage.java:661)
> ~[classes/:?]
> at org.apache.pdfbox.rendering.PageDrawer.drawPage(PageDrawer.java:202)
> ~[classes/:?]{code}
> This PDF put COSStream as the page's ANNOTS object, and caused the failure.
> Simply do type checks in PDPage.getAnnotations might avoid this issue, but
> the annotations would lost.
>
> This PDF show correctly (I mean annotation works) in:
> * Chrome 63.0.3239.132
> * Adobe Reader 11.0.23
> This PDF doesn't work perfectly in:
> * Microsoft Edge
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
