Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Doug MacEachern
On Tue, 16 Apr 2002, Stas Bekman wrote: > yup. or at least to give the C code line number/filename if the debug > info is available. you'd still need a callstack, to go up one and get that info. > Hmm, would it be feasible to have something like Carp::c_croak (which > will work only if the

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Stas Bekman
Doug MacEachern wrote: > On Tue, 16 Apr 2002, Stas Bekman wrote: > > >>Carp::confess was called alright. I was just saying that it didn't give >>the trace into the C code. It never does. I was asking if you had an >>idea how to improve it on the perl core side, not modperl. > > > you mean p

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Doug MacEachern
On Tue, 16 Apr 2002, Stas Bekman wrote: > Carp::confess was called alright. I was just saying that it didn't give > the trace into the C code. It never does. I was asking if you had an > idea how to improve it on the perl core side, not modperl. you mean printing the C callstack from Perl_cro

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Stas Bekman
Doug MacEachern wrote: > On Tue, 16 Apr 2002, Stas Bekman wrote: > > >>I see that you've solved it, Doug. But before we move on, can we please >>make it easier in the future to spot such a thing in the C code? What >>should be changed to get the C code trace ala Carp::confess? Can the >>taint

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Doug MacEachern
On Tue, 16 Apr 2002, Stas Bekman wrote: > I see that you've solved it, Doug. But before we move on, can we please > make it easier in the future to spot such a thing in the C code? What > should be changed to get the C code trace ala Carp::confess? Can the > taint checker figure out that the p

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Stas Bekman
I see that you've solved it, Doug. But before we move on, can we please make it easier in the future to spot such a thing in the C code? What should be changed to get the C code trace ala Carp::confess? Can the taint checker figure out that the problem happens in the C code and not Perl and ca

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Doug MacEachern
On Tue, 16 Apr 2002, Stas Bekman wrote: > Doug MacEachern wrote: > > have you tried $SIG{__DIE__} = \&Carp::confess ? > > Of course, with no success. there is always 'b Perl_croak' in gdb, and then the curinfo macro. tho i didn't try either in this case.

Re: the include flip/flop issue in mod_perl.h 1.x is back with perl5.7.3+ithreads

2002-04-15 Thread Stas Bekman
Doug MacEachern wrote: > On Mon, 15 Apr 2002, Stas Bekman wrote: > > >>Needs to be revived at least for 5.7.3+ithreads. > > > that really sucks. i would like to see if it is possible to fix perl so > we don't have todo this. does modperl-2.0 have a similar issue with > bleedperl? Haven't

Re: cvs commit: modperl/File File.pm

2002-04-15 Thread Doug MacEachern
On Tue, 16 Apr 2002, Stas Bekman wrote: > > +($tmpfile) = $tmpfile =~ /^([^<>|;*]+)$/; #untaint > > Doug, will this do the right thing on all platform? I'm simply looking for > a similar solution to a bug in Cwd.pm to generically untaint a path. > Shouldn't '?\[\]' be in the forbidden

Re: cvs commit: modperl/File File.pm

2002-04-15 Thread Stas Bekman
> +($tmpfile) = $tmpfile =~ /^([^<>|;*]+)$/; #untaint Doug, will this do the right thing on all platform? I'm simply looking for a similar solution to a bug in Cwd.pm to generically untaint a path. Shouldn't '?\[\]' be in the forbidden set? These are all parts of the wild chars set (at

Re: Apach2.pm hoses 2.0's make test with perl 5.6.1

2002-04-15 Thread Stas Bekman
Doug MacEachern wrote: > On Mon, 15 Apr 2002, Stas Bekman wrote: > > >>1. it tests against wrong libraries, as it pushes the tobe installed >>libraries first in @INC, but some people will have the older versions >>installed in exactly the same locations. > > > that'll be an issue regardless

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Stas Bekman
Doug MacEachern wrote: > have you tried $SIG{__DIE__} = \&Carp::confess ? Of course, with no success. __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apa

Re: Porblem building mod_perl on Win2000

2002-04-15 Thread Doug MacEachern
chuck, based on your cpp output (modperl_filter.i), it looks like a namespace issue. i made a change in cvs that should fix the problem. though it is strange it hasn't bitten anybody else on win32. if you aren't setup with cvs, snapshots are dropped here every 6 hours: http://cvs.apache.org/snap

Re: Apach2.pm hoses 2.0's make test with perl 5.6.1

2002-04-15 Thread Doug MacEachern
On Mon, 15 Apr 2002, Stas Bekman wrote: > 1. it tests against wrong libraries, as it pushes the tobe installed > libraries first in @INC, but some people will have the older versions > installed in exactly the same locations. that'll be an issue regardless of Apache2 being used or not. the b

Re: the include flip/flop issue in mod_perl.h 1.x is back with perl5.7.3+ithreads

2002-04-15 Thread Doug MacEachern
On Mon, 15 Apr 2002, Stas Bekman wrote: > Needs to be revived at least for 5.7.3+ithreads. that really sucks. i would like to see if it is possible to fix perl so we don't have todo this. does modperl-2.0 have a similar issue with bleedperl? --

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Doug MacEachern
have you tried $SIG{__DIE__} = \&Carp::confess ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Several problems for mod_perl2 in compatibility mode (Win32)

2002-04-15 Thread Doug MacEachern
On Fri, 12 Apr 2002, Alessandro Forghieri wrote: > While building: > if MP_DEBUG is set to 1: MP_DEBUG=1 doesn't work properly on win32 yet. but to get debug symbols, if you build perl with debug flags on, modperl will get built with the same flags. so you get filename/line info in st

Re: on reporting bugs

2002-04-15 Thread Doug MacEachern
On Fri, 12 Apr 2002, Stas Bekman wrote: > - should we reuse the perlbug script, that automatically sends an email? > And just add the relevant to us config parts? if possible, that'd be fine. > - what do we do if there is more than one modperl 2.0 installed on the > system? The older script

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Stas Bekman
Geoffrey Young wrote: > > > Stas Bekman wrote: > >> Geoffrey Young wrote: >> >>> >>> >>> Stas Bekman wrote: >>> >>> > there are taint mode problems with modperl-1.x and the latest >>> > bleadperl (testing with 15887). >>> > >>> > In addition to the taint bugs in Cwd that I'm trying to solv

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Geoffrey Young
Stas Bekman wrote: > Geoffrey Young wrote: > >> >> >> Stas Bekman wrote: >> >> > there are taint mode problems with modperl-1.x and the latest >> > bleadperl (testing with 15887). >> > >> > In addition to the taint bugs in Cwd that I'm trying to solve (see >> > my report at p5p, includi

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Stas Bekman
Geoffrey Young wrote: > > > Stas Bekman wrote: > > > there are taint mode problems with modperl-1.x and the latest > > bleadperl (testing with 15887). > > > > In addition to the taint bugs in Cwd that I'm trying to solve (see > > my report at p5p, including a partial patch), there is ano

Re: giving some context for Perl_croak in xs code

2002-04-15 Thread Geoffrey Young
Stas Bekman wrote: > there are taint mode problems with modperl-1.x and the latest > bleadperl (testing with 15887). > > In addition to the taint bugs in Cwd that I'm trying to solve (see > my report at p5p, including a partial patch), there is another > taint problem when trying to st

Apach2.pm hoses 2.0's make test with perl 5.6.1

2002-04-15 Thread Stas Bekman
The Apache2 trick completely hoses 'make test' with 5.6.1. Can't locate Apache/Const.pm in @INC (@INC contains: /home/stas/perl/5.6.1-ithread/lib/site_perl/5.6.1/Apache2 /home/stas/perl/5.6.1-ithread/lib/site_perl/5.6.1/i686-linux-thread-multi/Apache2 Apache-Test/lib /home/stas/apache.org/mp-