Stas Bekman wrote:
Man, you should at least give us a chance to test patches if you post
them for review and not rushing to commit them. mp2 now can't be even
built.
Mea Culpa, it can't be built only with:
MP_CCOPTS='-Werror'
which you probably don't use. That's the same pragma for C as:
Man, you should at least give us a chance to test patches if you post them for
review and not rushing to commit them. mp2 now can't be even built. Your patch
has several problems. First of all the prototype is wrong, it should be:
apr_port_t modperl_default_port_handler(const request_rec *r)
On Mon, 6 Oct 2003, Steve Hay wrote:
> Hi,
>
> During the course of testing mp1.29-rc1 I ran into a strange problem,
> probably Windows-specific, which I've seen before but never got to the
> bottom of.
>
> I have Apache 1.3.28 installed in C:\apache and Perl 5.8.1 in C:\perl5.
> The latter has al
Stas Bekman wrote:
Geoffrey Young wrote:
this was committed separately, as it's not really part of the
PerlDefaultPortHandler implementation.
open for discussion, though, is whether we want to keep or remove this
kind of logic from modperl_callback.
as I think about it more, I'm kinda agains
Geoffrey Young wrote:
this was committed separately, as it's not really part of the
PerlDefaultPortHandler implementation.
open for discussion, though, is whether we want to keep or remove this
kind of logic from modperl_callback.
as I think about it more, I'm kinda against second-guessing hand
this was committed separately, as it's not really part of the
PerlDefaultPortHandler implementation.
open for discussion, though, is whether we want to keep or remove this kind
of logic from modperl_callback.
as I think about it more, I'm kinda against second-guessing handlers here -
we ought
Andrew Wyllie wrote:
Ok, here it is again with no tabs and 4 space indents (and a couple of
other tweaks.
Thanks Andrew, I did a few more tweaks and committed it.
Is there any preferred way of send the patch - like as an attachment?
I just cut and pasted it below.
Normally we prefer it inli
On Monday, October 6, 2003, at 11:43 AM, Stas Bekman wrote:
Andrew Wyllie wrote:
(I'm resending this as I did not see it go through the first time)
I was running into a problem trying to build MP2 with a name other
than mod_perl.so. After poking around for a while I found that the
MP_LIBNAME ar
Barrie Slaymaker wrote:
On Oct 6 2003, Steve Hay wrote:
Randy Kobes wrote:
test1.pl passes a scalar to run3
test2.pl redirects STDOUT to a scalar and has run3 inherit it
Does
open STDOUT, '>', \$logout;
create a real filehandle at the OS level, or does it use I/O layers
to redirect the per
Stas Bekman wrote:
Steve Hay wrote:
[...]
Any luck with either of the two following patches?
No :-(
I tried them each using a run3 call in TestSmoke.pm that uses a scalar:
my $log = '';
run3 $command, undef, \$log, \$log;
print $log;
and again using a temporary file:
my ($fh, $file
10 matches
Mail list logo
