Re: cvs commit: modperl-2.0/xs/maps modperl_functions.map

Geoffrey Young wrote: Apache::LOG_MARK() is now Apache::Log::LOG_MARK() So it shouldn't be called LOG_MARK, it's an ugly duplication: Log::LOG How about Apache::Log::MARK? I thought about that, but we currently use Apache::Log::LOG_ERR, Apache::Log::LOG_DEBUG, etc for the constants, so I figu

Re: [mp2] exists_config_define

Geoffrey Young wrote: Now we also need to agree whether we do the same change for Connection: i.e. Apache::ConnRec or Apache::ConnectionRec? Since we fully spell RequestRec, FilterRec, and ServerRec, I think I like to fully spell ConnectionRec, i.e. my choice is Apache::ConnectionRec. I think I p

Re: cvs commit: modperl-2.0/xs/maps apache_functions.map

Geoffrey Young wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: geoff 2004/01/19 11:19:45 Modified:t/response/TestAPI rutil.pm server_util.pm xs/maps apache_functions.map Log: Apache::get_status_line is now Apache::Server::get_status_line This function has nothin

Re: cvs commit: modperl-2.0/xs/maps modperl_functions.map

>> Apache::LOG_MARK() is now Apache::Log::LOG_MARK() > > > So it shouldn't be called LOG_MARK, it's an ugly duplication: Log::LOG > > How about Apache::Log::MARK? I thought about that, but we currently use Apache::Log::LOG_ERR, Apache::Log::LOG_DEBUG, etc for the constants, so I figured to k

Re: [mp2] exists_config_define

Stas Bekman wrote: Philippe M. Chiasson wrote: On Mon, 2004-01-19 at 14:06, Geoffrey Young wrote: [...] May be we should take this further and make Apache::Server what Apache:: is used to be: i.e., just the httpd accessors. And create Apache::ServerRec similar to Apache::RequestRec which will g

Re: [mp2] exists_config_define

> Now we also need to agree whether we do the same change for Connection: > i.e. > Apache::ConnRec or Apache::ConnectionRec? > > Since we fully spell RequestRec, FilterRec, and ServerRec, I think I > like to fully spell ConnectionRec, i.e. my choice is Apache::ConnectionRec. I think I prefer the

Re: cvs commit: modperl-2.0/xs/maps apache_functions.map

Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > >> geoff 2004/01/19 11:19:45 >> >> Modified:t/response/TestAPI rutil.pm server_util.pm >>xs/maps apache_functions.map >> Log: >> Apache::get_status_line is now Apache::Server::get_status_line > > > This function h

Re: [mp2] exists_config_define

Philippe M. Chiasson wrote: On Mon, 2004-01-19 at 14:06, Geoffrey Young wrote: [...] May be we should take this further and make Apache::Server what Apache:: is used to be: i.e., just the httpd accessors. And create Apache::ServerRec similar to Apache::RequestRec which will give the access to $s?

Re: cvs commit: modperl-2.0/xs/maps apache_functions.map

[EMAIL PROTECTED] wrote: geoff 2004/01/19 11:19:45 Modified:t/response/TestAPI rutil.pm server_util.pm xs/maps apache_functions.map Log: Apache::get_status_line is now Apache::Server::get_status_line This function has nothing to do with Server. ap_get_status_line is

Re: cvs commit: modperl-2.0/xs/maps modperl_functions.map

[EMAIL PROTECTED] wrote: geoff 2004/01/19 08:25:54 Modified:t/response/TestAPI aplog.pm xs/Apache/Log Apache__Log.h xs/maps modperl_functions.map Log: Apache::LOG_MARK() is now Apache::Log::LOG_MARK() So it shouldn't be called LOG_MARK, it's an ugly d

Re: cvs commit: modperl-2.0 Changes

Geoffrey Young wrote: [EMAIL PROTECTED] wrote: stas2004/01/31 02:06:59 Modified:lib/ModPerl WrapXS.pm t/response/TestAPR pool.pm xs typemap xs/APR/Pool APR__Pool.h xs/maps apr_functions.map xs/tables/current

Re: cvs commit: modperl-2.0 Changes

[EMAIL PROTECTED] wrote: > stas2004/01/31 02:06:59 > > Modified:lib/ModPerl WrapXS.pm >t/response/TestAPR pool.pm >xs typemap >xs/APR/Pool APR__Pool.h >xs/maps apr_functions.map >xs/tables/curren