[EMAIL PROTECTED] wrote: > stas 2004/01/31 02:06:59 > > Modified: lib/ModPerl WrapXS.pm > t/response/TestAPR pool.pm > xs typemap > xs/APR/Pool APR__Pool.h > xs/maps apr_functions.map > xs/tables/current/ModPerl FunctionTable.pm > . Changes > Log: > In order to make Apache-Test compatible with the rest of Perl testing > frameworks, we no longer chdir into t/, but run from the root of the > project (where t/ resides). A test needing to know where it's running > from (e.g. to read/write files/dirs on the filesystem), should do that > relative to the serverroot, documentroot and other server > configuration variables, available via > Apache::Test::vars('serverroot'), Apache::Test::vars('documentroot'), > etc. >
this comment doesn't match what you actually did in this commit :) --Geoff > Index: Changes > =================================================================== > RCS file: /home/cvs/modperl-2.0/Changes,v > retrieving revision 1.316 > retrieving revision 1.317 > diff -u -u -r1.316 -r1.317 > --- Changes 31 Jan 2004 07:17:17 -0000 1.316 > +++ Changes 31 Jan 2004 10:06:59 -0000 1.317 > @@ -12,6 +12,18 @@ > > =item 1.99_13-dev > > +APR.xs has been reimplemented. The problem with the previous > +implementation is that a dead perl pool object could hijack a newly > +created pool, which didn't belong to that object, but which happened > +to be allocated at the same memory location. The problem is that > +apr_pool_user_data_set/get has no mechanism to check whether the pool > +has changed since it was last assigned to (it does but only in the > +debug mode). It really needs some signature mechanism which can be > +verified that the pool is still the same pool. Since apr_pool doesn't > +have this feature, the reference counting has been reimplemented using > +a plain sv reference. Several new (mainly hijacking) tests which badly > +fail with the previous impelementation have been added. [Stas] > + > fix calling $r->subprocess_env() in a void context so that it only > populates %ENV if also called with no arguments. also, make sure it > can be called more than once and still populate %ENV. > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]