Re: APR::Table lost UTF8 flag

2004-09-26 Thread Stas Bekman
Boris Zentner wrote: No, I think the stored strings are correct currently. The example use latin1 chars that by luck are bellow 256 in utf8. In other words we can not convert them back. A conversion back and forth is not possible every-time. But how APR::Table is supposed to know whether it shou

Re: APR::Table lost UTF8 flag

2004-09-26 Thread Boris Zentner
Hi, Am 26.09.2004 um 18:13 schrieb Stas Bekman: Boris Zentner wrote: [...] So you suggest that APR::Table should always look at the perl variable before it stores it, and store the PV string as is if UTF8 flag is not set, otherwise encoded it into a utf8 string and only then store it. That way n

Re: APR::Table lost UTF8 flag

2004-09-26 Thread Stas Bekman
Joe Schaefer wrote: Geoffrey Young <[EMAIL PROTECTED]> writes: [...] before we go ahead with this I'd really like to get some more opinions on it. My thoughts (off the top of my head): 1) During set/merge/add operations, SV keys and SV values should be added to the apr_table_t as if SvPV

Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t

2004-09-26 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] that's already scheduled for 2.0 release: todo/release: * consider changing the allocation method in APR::Bucket::new from malloc/free to bucket_alloc, like all other buckets do If you can work on that, it'd be a great help, Joe.

Re: APR::Table lost UTF8 flag

2004-09-26 Thread Joe Schaefer
Geoffrey Young <[EMAIL PROTECTED]> writes: [...] > before we go ahead with this I'd really like to get some more opinions on > it. My thoughts (off the top of my head): 1) During set/merge/add operations, SV keys and SV values should be added to the apr_table_t as if SvPVbyte were call

Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t

2004-09-26 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: [...] > that's already scheduled for 2.0 release: > todo/release: > > * consider changing the allocation method in APR::Bucket::new from >malloc/free to bucket_alloc, like all other buckets do > > If you can work on that, it'd be a great help, Joe. I

Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t

2004-09-26 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: Joe Schaefer wrote: The problem is that the current modperl_bucket.c implementation needs a proper setaside function. Think about it- the interpreter only hangs around for the request, but the bucket may be setaside in the core output f

Re: APR::Table lost UTF8 flag

2004-09-26 Thread Geoffrey Young
Stas Bekman wrote: > Boris Zentner wrote: > [...] > > So you suggest that APR::Table should always look at the perl variable > before it stores it, and store the PV string as is if UTF8 flag is not > set, otherwise encoded it into a utf8 string and only then store it. > That way no data will eve

Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t

2004-09-26 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > Joe Schaefer wrote: > > > The problem is that the current modperl_bucket.c implementation > > needs a proper setaside function. Think about it- the interpreter > > only hangs around for the request, but the bucket may be setaside > > in the core output fi

Re: APR::Table lost UTF8 flag

2004-09-26 Thread Stas Bekman
Boris Zentner wrote: [...] So you suggest that APR::Table should always look at the perl variable before it stores it, and store the PV string as is if UTF8 flag is not set, otherwise encoded it into a utf8 string and only then store it. That way no data will ever get corrupted. On return it sh

Re: APR::Table lost UTF8 flag

2004-09-26 Thread Boris Zentner
Hi, Am 26.09.2004 um 02:09 schrieb Stas Bekman: Boris Zentner wrote: [...] May be expicitly setting the utf8 flag will work as a temp solution for you? If all your data is stored in utf8, then it will perfectly fine. No, this will not work in my case. Below is the revision of your test program,

Re: mp2 static building problem

2004-09-26 Thread Pratik
I've just tested it with latest mod_perl 2.0 CVS version and the problem I had encountered is now fixed. Thank you, Pratik On Sun, 26 Sep 2004 00:04:52 -0700, Philippe M. Chiasson <[EMAIL PROTECTED]> wrote: > Stas Bekman wrote: > > > Pratik wrote: > > > >> I was building mp2 statically ( latest

Re: HEAD failures

2004-09-26 Thread Philippe M. Chiasson
Stas Bekman wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: It's not your tests that are at fault, Stas. Something else is broken, and that commit brought it out. As I said earlier, I've been having segfault problems with mp2 for a few days now (Tuesday it was the send_fd tests, which I wr

Re: mp2 static building problem

2004-09-26 Thread Philippe M. Chiasson
Stas Bekman wrote: Pratik wrote: I was building mp2 statically ( latest cvs version ) with the following : perl Makefile.PL MP_USE_STATIC=1 MP_INST_APACHE2=1 MP_AP_PREFIX=/home/pratik/src/mp2/httpd-2.0.51 MP_MAINTAINER=1 MP_AP_CONFIGURE="--enable-maintainer-mode --enable-so --enable-rewrite --ena