I'll work something up when I have the chance... in a month or two :)
God do I know the feeling.
Thanks for the good eyes Gozer.
--
Philip M. Gollucci ([EMAIL PROTECTED]) 323 219 4708
Consultant / http://p6m7g8.net/Resume/
> What I mean is that you are leaking a HV. Every connection, if someone uses
> c->pnotes, you will run this code:
>
> if (!ccfg->pnotes) {
> ccfg->pnotes = newHV();
> }
>
> And you have nothing in place to cleanup this newly created HV (and it's
> contents)
ah, yeah. d'oh!
I
On Friday 10 March 2006 04:14 pm, Philippe M. Chiasson wrote:
> The bulk of the idea is not to cleanup pnotes in mod_perl's global request
> pool cleanup handler (spreading pnotes knoledge around) but rather have
> $r->pnotes() register it's own cleanup, keeping the initialization/cleanup
> code s
Geoffrey Young wrote:
> Philippe M. Chiasson wrote:
>>Frank Wiles wrote:
>>
>>> Hey Everyone,
>>>
>>> Saw the thread about $r->read($buf,0) and figured it would be wise
>>> to fix the error message to keep someone else from getting confused.
>>>
>>> Here is a small patch to change "The LENGTH arg
Randy Kobes wrote:
> On Fri, 10 Mar 2006, Philippe M. Chiasson wrote:
>
>
>>Unless anybody has strong objections about this, I'd like
>>to volounteer to RM 2.0.3 sometime next week. I'd like to
>>see Geoff's connection pnotes[1] make it in, but apart
>>from that, I think we've got enough bug f
On Fri, 10 Mar 2006, Philippe M. Chiasson wrote:
Unless anybody has strong objections about this, I'd like
to volounteer to RM 2.0.3 sometime next week. I'd like to
see Geoff's connection pnotes[1] make it in, but apart
from that, I think we've got enough bug fixes (and new
features) to justi
I've been toying around with certain bits of pnotes, and a small cleanup came
to mind. It's conceptually cleaner, IMO, but I'd like to know other folks
opinions.
The bulk of the idea is not to cleanup pnotes in mod_perl's global request pool
cleanup handler (spreading pnotes knoledge around) but
Unless anybody has strong objections about this, I'd like to volounteer to RM
2.0.3 sometime next week. I'd like to see Geoff's connection pnotes[1] make it
in,
but apart from that, I think we've got enough bug fixes (and new features) to
justify making a release.
[1] http://thread.gmane.org/gman
Geoffrey Young wrote:
>>All tests pass for me on various platforms, but...
>>
>>Where do you cleanup HV *modperl_config_con_t->pnotes ? Looks to me
>>like you are leaking it. You'd need something similar to what we
>>are doing for request pnotes:
>>
>>apr_status_t modperl_config_request_cleanup(pTH
Tyler MacDonald wrote:
Tyler MacDonald <[EMAIL PROTECTED]> wrote:
After digging around a bit, it looks like I just have to attach
myself to the "stop-httpd" option instead of the "stop" method, but that's
getting less obvious and more deep into an undocumented API.
Got it in
> All tests pass for me on various platforms, but...
>
> Where do you cleanup HV *modperl_config_con_t->pnotes ? Looks to me
> like you are leaking it. You'd need something similar to what we
> are doing for request pnotes:
>
> apr_status_t modperl_config_request_cleanup(pTHX_ request_rec *r)
>
Geoffrey Young wrote:
>>-plan $r, tests => 9;
>>+# make it ok to call ok() here while plan()ing elsewhere
>>+Apache::Test::init_test_pm($r);
>>+$Test::ntest = 1 + (22 * ($r->args - 1));
>>+$Test::planned = 22;
>
> and of course everyone is wondering what this is. it would he
12 matches
Mail list logo
