Re: [PATCH] 2.1 build foo

2004-08-25 Thread Stas Bekman
Joe Orton wrote: On Wed, Aug 25, 2004 at 09:31:27AM -0700, Stas Bekman wrote: Joe Orton wrote: The thing I really want is to fix out-of-tree apr-util builds anyway, can someone commit that half of the patch if it's OK? What problem does it solve? Is this something needed for httpd 2.1? If fixes an

Re: [PATCH] 2.1 build foo

2004-08-25 Thread Joe Orton
On Wed, Aug 25, 2004 at 09:31:27AM -0700, Stas Bekman wrote: > Joe Orton wrote: > >The thing I really want is to fix out-of-tree apr-util builds anyway, > >can someone commit that half of the patch if it's OK? > > What problem does it solve? Is this something needed for httpd 2.1? If fixes any in

Re: [PATCH] 2.1 build foo

2004-08-25 Thread Stas Bekman
Joe Orton wrote: On Tue, Aug 24, 2004 at 11:52:15PM -0700, Stas Bekman wrote: but Joe, don't let this discussion get on your way, commit the thing (after the 2.0 way) and we will optimise it later. But re-ordering the tests really defeats the point of the change (which was to *skip* all the messy

Re: [PATCH] 2.1 build foo

2004-08-25 Thread Joe Orton
On Tue, Aug 24, 2004 at 11:52:15PM -0700, Stas Bekman wrote: > but Joe, don't let this discussion get on your way, commit the thing > (after the 2.0 way) and we will optimise it later. But re-ordering the tests really defeats the point of the change (which was to *skip* all the messy 2.0 tests an

Re: [PATCH] 2.1 build foo

2004-08-24 Thread Stas Bekman
Philippe M. Chiasson wrote: [...] No, I suggested to figure out whether we are running under 2.0 or 2.1 and then use the appropriate method, without trying both. e.g.: if (httpd 2.0) { # the current way } else { # 2.1 has apxs -q AP[RU]_CONFIG as the definitive location m

Re: [PATCH] 2.1 build foo

2004-08-24 Thread Philippe M. Chiasson
Stas Bekman wrote: Joe Orton wrote: On Wed, Aug 18, 2004 at 12:34:01PM -0700, Stas Bekman wrote: Joe Orton wrote: On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: Joe Orton wrote: Thanks Joe. Any chance this can be rewritte

Re: [PATCH] 2.1 build foo

2004-08-19 Thread Stas Bekman
Joe Orton wrote: On Wed, Aug 18, 2004 at 12:34:01PM -0700, Stas Bekman wrote: Joe Orton wrote: On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: Joe Orton wrote: Thanks Joe. Any chance this can be rewritten to find out what syn

Re: [PATCH] 2.1 build foo

2004-08-19 Thread Joe Orton
On Wed, Aug 18, 2004 at 12:34:01PM -0700, Stas Bekman wrote: > Joe Orton wrote: > >On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: > > > >>On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: > >> > >>>Joe Orton wrote: > >>>Thanks Joe. > >>> > >>>Any chance this can be rewritten

Re: [PATCH] 2.1 build foo

2004-08-18 Thread Stas Bekman
Joe Orton wrote: On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: Joe Orton wrote: Thanks Joe. Any chance this can be rewritten to find out what syntax to use (2.0 or 2.1) once and not do that repeatedly? This function is the c

Re: [PATCH] 2.1 build foo

2004-08-18 Thread Joe Orton
On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: > On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: > > Joe Orton wrote: > > Thanks Joe. > > > > Any chance this can be rewritten to find out what syntax to use (2.0 or > > 2.1) once and not do that repeatedly? This function is

Re: [PATCH] 2.1 build foo

2004-08-18 Thread Joe Orton
On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: > Joe Orton wrote: > Thanks Joe. > > Any chance this can be rewritten to find out what syntax to use (2.0 or > 2.1) once and not do that repeatedly? This function is the cause of the > slow configuration (too many shell calls), so try

Re: [PATCH] 2.1 build foo

2004-08-18 Thread Stas Bekman
Joe Orton wrote: This supports building against a separate apr-util (i.e. where the apr-util installed $includedir != apr $includedir), and also uses the output of `apxs -q APR_CONFIG` where available to pick up ap[ru]-config. I haven't tested that this doesn't break the build against 2.0.x but it

[PATCH] 2.1 build foo

2004-08-18 Thread Joe Orton
This supports building against a separate apr-util (i.e. where the apr-util installed $includedir != apr $includedir), and also uses the output of `apxs -q APR_CONFIG` where available to pick up ap[ru]-config. I haven't tested that this doesn't break the build against 2.0.x but it Should Be OK Rea