Re: scan's diff

2001-09-06 Thread Stas Bekman
On Thu, 6 Sep 2001, Doug MacEachern wrote: > On Thu, 6 Sep 2001, Stas Bekman wrote: > > > OK, can somebody test this patch? the latest httpd source fails to get > > parsed for me (via 'make source_scan'), so I cannot verify my patch. > > whats the error? /home/stas/perl-bleed/bin/perl util/sourc

Re: scan's diff

2001-09-06 Thread Doug MacEachern
On Thu, 6 Sep 2001, Stas Bekman wrote: > OK, can somebody test this patch? the latest httpd source fails to get > parsed for me (via 'make source_scan'), so I cannot verify my patch. whats the error? > +(my $old = $old_content) =~ s/\w{3} \w{3} \d+ \d+:\d+:\d+ \d{4}//; > +(my $

Re: scan's diff

2001-09-06 Thread Stas Bekman
On Wed, 5 Sep 2001, Doug MacEachern wrote: > On Thu, 6 Sep 2001, Stas Bekman wrote: > > > something like that. We need to disregard: 'Sun Aug 19 10:32:24 2001' > > that would be fine. as i suggested eariler, feel free to change the > format of that header which includes the date to make it easie

Re: scan's diff

2001-09-05 Thread Doug MacEachern
On Thu, 6 Sep 2001, Stas Bekman wrote: > something like that. We need to disregard: 'Sun Aug 19 10:32:24 2001' that would be fine. as i suggested eariler, feel free to change the format of that header which includes the date to make it easier to rip this stuff out. i'd rather see this than a

Re: scan's diff

2001-09-05 Thread Stas Bekman
On Wed, 5 Sep 2001, Barrie Slaymaker wrote: > On Thu, Sep 06, 2001 at 10:09:28AM +0800, Stas Bekman wrote: > > On Wed, 5 Sep 2001, Doug MacEachern wrote: > > > > > On Sun, 2 Sep 2001, Stas Bekman wrote: > > > > > > > File::Compare is quite useless. We need to compare a variable against the > > >

Re: scan's diff

2001-09-05 Thread Barrie Slaymaker
On Thu, Sep 06, 2001 at 10:09:28AM +0800, Stas Bekman wrote: > On Wed, 5 Sep 2001, Doug MacEachern wrote: > > > On Sun, 2 Sep 2001, Stas Bekman wrote: > > > > > File::Compare is quite useless. We need to compare a variable against the > > > file. > > > > then use 'eq', really, i just don't see a

Re: scan's diff

2001-09-05 Thread Stas Bekman
On Wed, 5 Sep 2001, Doug MacEachern wrote: > On Sun, 2 Sep 2001, Stas Bekman wrote: > > > File::Compare is quite useless. We need to compare a variable against the > > file. > > then use 'eq', really, i just don't see a need for checksums here. > but File::Compare should be usable, if changes to

Re: scan's diff

2001-09-05 Thread Doug MacEachern
On Sun, 2 Sep 2001, Stas Bekman wrote: > File::Compare is quite useless. We need to compare a variable against the > file. then use 'eq', really, i just don't see a need for checksums here. but File::Compare should be usable, if changes to the header are made so date is not included, so you can

Re: scan's diff

2001-09-02 Thread Stas Bekman
On Wed, 29 Aug 2001, Doug MacEachern wrote: > On Wed, 29 Aug 2001, Stas Bekman wrote: > > > What's the problem with having new dependencies on CPAN? Digest::MD5 seems > > to be a core module. Remember that everybody talks about SDKs, so we will > > end up with dependencies anyways. If we do PRERE

Re: scan's diff

2001-08-29 Thread Doug MacEachern
On Wed, 29 Aug 2001, Stas Bekman wrote: > What's the problem with having new dependencies on CPAN? Digest::MD5 seems > to be a core module. Remember that everybody talks about SDKs, so we will > end up with dependencies anyways. If we do PREREQ_PM, CPAN will > automatically install all the requi

Re: scan's diff

2001-08-28 Thread Stas Bekman
On Tue, 28 Aug 2001, Doug MacEachern wrote: > On Wed, 29 Aug 2001, Stas Bekman wrote: > > > it's still not working perfectly, since it has to fish $dump out of the > > file, and I see that it doesn't work for all current files. > > you could change the warning header to include: > # __END_OF_HEAD

Re: scan's diff

2001-08-28 Thread Doug MacEachern
On Wed, 29 Aug 2001, Stas Bekman wrote: > it's still not working perfectly, since it has to fish $dump out of the > file, and I see that it doesn't work for all current files. you could change the warning header to include: # __END_OF_HEADER__ or something to make it easier to parse/compare. an

Re: scan's diff

2001-08-28 Thread Stas Bekman
> > also are you sure that we need to have this kind of diffs? > > > > # !! > > # ! WARNING: generated by Apache::ParseSource/0.02 > > -# ! Sun Aug 19 10:32:09 2001 > > +# ! Sun Aug 26 01:23:32 2001 > > # ! do NOT edit,

Re: scan's diff

2001-08-25 Thread Doug MacEachern
On Sun, 26 Aug 2001, Stas Bekman wrote: > With a small problem, 'make source_scan' works for me!!! > > I've attached the whole thing (and not inlined, since you can generate it > yourself :)! > > I wanted to ask why on my side I seemingly get a better scanning. If you > look at the snippet belo