Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Tatsuhiko Miyagawa
At Fri, 12 Jul 2002 03:19:41 +, Stas Bekman wrote: > > AFAIK from 2.0.35 on, httpd-2.0 has been considered general > > availability, which means "stable" in some way. it's not beta anymore. > > > > >http:[EMAIL PROTECTED]%3E > > Thanks Tatsuhiko, it's just hard to think of Apache not being

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Stas Bekman
Tatsuhiko Miyagawa wrote: > At Fri, 12 Jul 2002 02:26:04 +, > Stas Bekman wrote: > > >>>we should continue to support older versions of httpd for as long as >>>reasonably possible. >> >>but what's the reason? why would anybody use an older httpd beta with >>the latest mod_perl? > > > AFA

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Tatsuhiko Miyagawa
At Fri, 12 Jul 2002 02:26:04 +, Stas Bekman wrote: > > we should continue to support older versions of httpd for as long as > > reasonably possible. > > but what's the reason? why would anybody use an older httpd beta with > the latest mod_perl? AFAIK from 2.0.35 on, httpd-2.0 has been co

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Stas Bekman
Doug MacEachern wrote: > On Fri, 12 Jul 2002, Stas Bekman wrote: > > >>I thought of that, but why do we need to keep it compiling with httpd < >>2.0.40-dev? aren't people supposed to use 1.99_04 with 2.0.39? or are >>you talking in the case when 1.99_05 is released and 2.0.40 is not? > > > w

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Doug MacEachern
On Fri, 12 Jul 2002, Stas Bekman wrote: > I thought of that, but why do we need to keep it compiling with httpd < > 2.0.40-dev? aren't people supposed to use 1.99_04 with 2.0.39? or are > you talking in the case when 1.99_05 is released and 2.0.40 is not? we should continue to support older ve

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Stas Bekman
Doug MacEachern wrote: > i don't think this will compile with httpd < 2.0.40-dev, will it? > feel free to #ifndef foo #define foo for these macros, or whatever, so > long as it compiles with released versions of httpd. thanks. I thought of that, but why do we need to keep it compiling with http

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2002-07-11 Thread Doug MacEachern
i don't think this will compile with httpd < 2.0.40-dev, will it? feel free to #ifndef foo #define foo for these macros, or whatever, so long as it compiles with released versions of httpd. thanks. On 11 Jul 2002 [EMAIL PROTECTED] wrote: > stas2002/07/10 23:14:10 > > Modified:xs

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2001-12-17 Thread Doug MacEachern
On Tue, 18 Dec 2001, Stas Bekman wrote: > talking about style nits, when initialization should be: i guess it is habit. i do it only when initializing number variables in declarations: int i=0; and in for loops: for (i=0; but wouldn't complain about having spaces in either.

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2001-12-17 Thread Doug MacEachern
On Tue, 18 Dec 2001, Stas Bekman wrote: > 1. how did you detect it? (in-head detector, or something that I could > have used too?) in-head. > 2. why there was a memory leak here. a newAV() was created and never released. ---

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2001-12-17 Thread Stas Bekman
[EMAIL PROTECTED] wrote: > dougm 01/12/17 19:40:02 > > Modified:xs/Apache/SubProcess Apache__SubProcess.h > Log: > avoid calling av_len() more than once. > switch from using av_len() to AvFILLp > add av_items variable to avoid (-1 + 2) when there is no av_argv > > Revisi

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2001-12-17 Thread Stas Bekman
[EMAIL PROTECTED] wrote: > dougm 01/12/17 19:24:49 > > Modified:xs/Apache/SubProcess Apache__SubProcess.h > Log: > plug av_argv memory leak > > Revision ChangesPath > 1.3 +3 -1 modperl-2.0/xs/Apache/SubProcess/Apache__SubProcess.h > > Index: Apache__Su

Re: cvs commit: modperl-2.0/xs/Apache/SubProcess Apache__SubProcess.h

2001-12-17 Thread Stas Bekman
[EMAIL PROTECTED] wrote: > dougm 01/12/17 19:21:22 > > Modified:xs/Apache/SubProcess Apache__SubProcess.h > Log: > a few style fixups and comments > +if (!(*script_in = procnew->in)) { > +/* XXX: this needs to be Perl_croak(aTHX_ ...) > + * or go away s