Re: [mp2] mod_perl test suite fails

2003-12-15 Thread Volker Kroll
On Sun, 2003-12-14 at 03:18, Stas Bekman wrote: > Great. I have now integrated this test into Apache-Test. Can you please verify > that modperl-2.0's 'make test' refuses to run when modperl-2.0 is checked out > under /root? Please use the latest cvs version: > http://perl.apache.org/download/sou

Re: [mp2] mod_perl test suite fails

2003-12-15 Thread Stas Bekman
Volker Kroll wrote: On Sun, 2003-12-14 at 03:18, Stas Bekman wrote: Great. I have now integrated this test into Apache-Test. Can you please verify that modperl-2.0's 'make test' refuses to run when modperl-2.0 is checked out under /root? Please use the latest cvs version: http://perl.apache.org

Re: [mp2] mod_perl test suite fails

2003-12-15 Thread Volker Kroll
On Mon, 2003-12-15 at 10:29, Stas Bekman wrote: > no, no, it has nothing to do with the error_log, Can I see what you get when > running: > > /usr/bin/perl -Mlib=/root/modperl-2.0/Apache-Test/lib -MApache::TestRun \ > -e 'eval {Apache::TestRun::run_root_fs_test(99, 99, q[/root/modperl-2.0/t])}';

[mp2] src/modules/perl/modperl_mgv.c

2003-12-15 Thread Randy Kobes
With the current mp2 sources, a couple of variables in modperl_mgv.c need to be declared earlier for Win32: Index: src/modules/perl/modperl_mgv.c === RCS file: /home/cvs/modperl-2.0/src/modules/

Re: [mp2] apr/finfo test 10 fails on Windows

2003-12-15 Thread Randy Kobes
On Fri, 12 Dec 2003, Steve Hay wrote: > I've just run the mp2 testsuite using the latest CVS version and got one > test failure: > > = > >perl t/TEST -verbose apr/finfo.t > [...] > # Running under perl version 5.008002 for MSWin32 > # Current time local: Fri Dec 12 17:36:14 2003 > # Current t

[mp2] finding apxs on Win32

2003-12-15 Thread Randy Kobes
In lib/Apache/Build.pm, some tries are made to find apxs and apr-config, and success is tested using -x $try. For this test to succeed on Win32 a .bat extension is needed. The following diff: === Index: lib/Apache/Build.pm

[mp2] mod_perl.pm abstract

2003-12-15 Thread Randy Kobes
It might be convenient to add an abstract and name for lib/mod_perl.pm in a pod section, for search.cpan.org and perhaps some other tools (eg, in generating a ppm package). This diff: = Index: Makefile.PL ==

Re: [mp2] apr/finfo test 10 fails on Windows

2003-12-15 Thread Steve Hay
Randy Kobes wrote: >On Fri, 12 Dec 2003, Steve Hay wrote: > > > >>I've just run the mp2 testsuite using the latest CVS version and got one >>test failure: >> >>= >> >perl t/TEST -verbose apr/finfo.t >>[...] >># Running under perl version 5.008002 for MSWin32 >># Current time local: Fri Dec 1

Re: [mp2] apr/finfo test 10 fails on Windows

2003-12-15 Thread Randy Kobes
On Mon, 15 Dec 2003, Steve Hay wrote: > I just retested with the cvs version that I grabbed last Friday and > found that it worked, but only once: thereafter it fails again! > > More testing shows that if I "touch" the file that it is stat()'ing > (t/htdocs/index.html) to give it file times of >1

Re: [mp2] finding apxs on Win32

2003-12-15 Thread Steve Hay
Randy Kobes wrote: >In lib/Apache/Build.pm, some tries are made to find >apxs and apr-config, and success is tested using -x $try. >For this test to succeed on Win32 a .bat extension is >needed. The following diff: > Works for me -- I now have the apr-ext/uuid being run for the first time. (And

Re: [mp2] apr/finfo test 10 fails on Windows

2003-12-15 Thread Steve Hay
Randy Kobes wrote: >On Mon, 15 Dec 2003, Steve Hay wrote: > > > >>I just retested with the cvs version that I grabbed last Friday and >>found that it worked, but only once: thereafter it fails again! >> >>More testing shows that if I "touch" the file that it is stat()'ing >>(t/htdocs/index.html)

Re: cvs commit: modperl-2.0 Changes

2003-12-15 Thread Philippe M. Chiasson
On Sun, 2003-12-14 at 19:13, [EMAIL PROTECTED] wrote: > stas2003/12/14 19:13:36 > > Modified:src/modules/perl modperl_mgv.c >.Changes > Log: > Prevent a problem where an autovivified package (stash) prevents from > modperl_mgv to load the file with that

Re: [mp2] mod_perl test suite fails

2003-12-15 Thread Stas Bekman
Volker Kroll wrote: On Mon, 2003-12-15 at 10:29, Stas Bekman wrote: no, no, it has nothing to do with the error_log, Can I see what you get when running: /usr/bin/perl -Mlib=/root/modperl-2.0/Apache-Test/lib -MApache::TestRun \ -e 'eval {Apache::TestRun::run_root_fs_test(99, 99, q[/root/modperl

Re: [mp2] src/modules/perl/modperl_mgv.c

2003-12-15 Thread Stas Bekman
Randy Kobes wrote: With the current mp2 sources, a couple of variables in modperl_mgv.c need to be declared earlier for Win32: Index: src/modules/perl/modperl_mgv.c === RCS file: /home/cvs/modpe

Re: cvs commit: modperl-2.0 Changes

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: +static void package2filename(apr_pool_t *p, const char *package, + char **filename, int *len) +{ +*filename = apr_palloc(p, (strlen(package)+4)*sizeof(char)); +const char *s; +char *d; Sorry, I know how annoying this prob

Re: [Patch mp2] #2 PerlSections namespace

2003-12-15 Thread Philippe M. Chiasson
On Thu, 2003-12-11 at 15:49, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > Following this discussion: > > http://marc.theaimsgroup.com/?t=10710004043&r=1&w=2 > > > > I've made a few adjustements and cleanups. > > > > The following patch adds ModPerl::Util::file2package() to build a sa

Re: [mp2] finding apxs on Win32

2003-12-15 Thread Stas Bekman
Randy Kobes wrote: In lib/Apache/Build.pm, some tries are made to find apxs and apr-config, and success is tested using -x $try. For this test to succeed on Win32 a .bat extension is needed. The following diff: === Index: lib/Apache/Build.pm =

Re: [mp2] mod_perl.pm abstract

2003-12-15 Thread Stas Bekman
Randy Kobes wrote: It might be convenient to add an abstract and name for lib/mod_perl.pm in a pod section, for search.cpan.org and perhaps some other tools (eg, in generating a ppm package). This diff: = Index: Makefile.PL ===

Re: rfc: ModPerl::ModuleSetup

2003-12-15 Thread Stas Bekman
Geoffrey Young wrote: Here is Makefile.PL from Apache-Peek, most of which should be moved to that module. I'm talking about functions: satisfy_mp_generation; satisfy_perl_generation; wanted_mp_generation; the outer functions look ok. I'd leave satsify_perl_generation for the users themselves, at l

Re: cvs commit: modperl-2.0 Changes

2003-12-15 Thread Philippe M. Chiasson
On Sun, 2003-12-14 at 21:38, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > stas2003/12/14 21:29:35 > > > > Modified:lib/ModPerl BuildOptions.pm > >lib/Apache Build.pm > >.Changes > > Log: > > libgtop config (needed for enabling MOD_PERL

Re: [mp2] finding apxs on Win32

2003-12-15 Thread Randy Kobes
On Mon, 15 Dec 2003, Stas Bekman wrote: > Randy Kobes wrote: > > In lib/Apache/Build.pm, some tries are made to find > > apxs and apr-config, and success is tested using -x $try. > > For this test to succeed on Win32 a .bat extension is > > needed. The following diff: > > =

Re: cvs commit: modperl-2.0 Changes

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: On Sun, 2003-12-14 at 21:38, Stas Bekman wrote: [EMAIL PROTECTED] wrote: stas2003/12/14 21:29:35 Modified:lib/ModPerl BuildOptions.pm lib/Apache Build.pm .Changes Log: libgtop config (needed for enabling MOD_PERL_TRAC

Re: [Patch mp2] #2 PerlSections namespace

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: On Thu, 2003-12-11 at 15:49, Stas Bekman wrote: Philippe M. Chiasson wrote: Following this discussion: http://marc.theaimsgroup.com/?t=10710004043&r=1&w=2 I've made a few adjustements and cleanups. The following patch adds ModPerl::Util::file2package() to build

[Patch mp2] #3 PerlSections namespace

2003-12-15 Thread Philippe M. Chiasson
After making the small changes we discussed, here is a simpler version of the original namespace patch, without exposing it thru ModPerl::Util and a few style tweaks as per stas's recommendations. ? Doxyfile ? SIGNATURE ? dox ? foo ? perlsection.diff ? src.diff ? build/indent ? lib/C ? lib/thread

Re: cvs commit: modperl-2.0 Changes

2003-12-15 Thread Philippe M. Chiasson
On Mon, 2003-12-15 at 12:34, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Sun, 2003-12-14 at 21:38, Stas Bekman wrote: > > > >>[EMAIL PROTECTED] wrote: > >> > >>>stas2003/12/14 21:29:35 > >>> > >>> Modified:lib/ModPerl BuildOptions.pm > >>> lib/Apache Build.pm

Re: cvs commit: modperl-2.0 Changes

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: On Mon, 2003-12-15 at 12:34, Stas Bekman wrote: Philippe M. Chiasson wrote: On Sun, 2003-12-14 at 21:38, Stas Bekman wrote: [EMAIL PROTECTED] wrote: stas2003/12/14 21:29:35 Modified:lib/ModPerl BuildOptions.pm lib/Apache Build.pm

Re: [mp2 patch] introducing Apache::compat "scoping"

2003-12-15 Thread Philippe M. Chiasson
On Sun, 2003-12-14 at 18:33, Stas Bekman wrote: > The following is yet another attempt to avoid collisions between > Apache::compat and the real mp2 APIs. That is indeed an annoying problem. > Similar to 'use' and 'no' pragma, I'm suggesting to introduce the new > functions override_mp2_api and

Re: [mp2 patch] introducing Apache::compat "scoping"

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: On Sun, 2003-12-14 at 18:33, Stas Bekman wrote: The following is yet another attempt to avoid collisions between Apache::compat and the real mp2 APIs. That is indeed an annoying problem. Similar to 'use' and 'no' pragma, I'm suggesting to introduce the new functio

Re: mp2-1.99_12 release next week?

2003-12-15 Thread Philippe M. Chiasson
On Sun, 2003-12-14 at 19:26, Stas Bekman wrote: > I'd like to make the _12 release next week. The usual plan suggestion: > - post a release candidate on Thu-Fri > - release on Monday Sounds good to me! > Unless someone else wishes to wear the RM cap, I'll do this release. I sadly don't have enou

Re: [Patch mp2] #3 PerlSections namespace

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: After making the small changes we discussed, here is a simpler version of the original namespace patch, without exposing it thru ModPerl::Util and a few style tweaks as per stas's recommendations. [...] Looks great! + a few indent comments ;) Index: src/modules/perl/m

Re: mp2-1.99_12 release next week?

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: Unless someone else wishes to wear the RM cap, I'll do this release. I sadly don't have enough free time right now to wear that cap. No problem. I can handle that. If you want something to go in into that release please say that asap. I'd like at least my recursive

Re: [Patch mp2] #3 PerlSections namespace

2003-12-15 Thread Philippe M. Chiasson
On Mon, 2003-12-15 at 16:21, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > After making the small changes we discussed, here is a simpler version > > of the original namespace patch, without exposing it thru > > ModPerl::Util and a few style tweaks as per stas's recommendations. > [...] >

Re: [Patch mp2] #3 PerlSections namespace

2003-12-15 Thread Stas Bekman
Philippe M. Chiasson wrote: On Mon, 2003-12-15 at 16:21, Stas Bekman wrote: Philippe M. Chiasson wrote: After making the small changes we discussed, here is a simpler version of the original namespace patch, without exposing it thru ModPerl::Util and a few style tweaks as per stas's recommendati

Re: cvs commit: modperl-2.0/lib/Apache Build.pm

2003-12-15 Thread Stas Bekman
[EMAIL PROTECTED] wrote: randyk 2003/12/15 18:39:00 Modified:lib/Apache Build.pm Log: Reviewed by: stas In testing for the existence of the apxs and apr-config utilities, Win32 needs candidates to have a .bat extension for the -x file test to succeed. It's probably a good idea