Re: [mp2] Perl Sections in .htaccess files leak memory

2004-09-09 Thread Philippe M. Chiasson
Incredibly thorough bug reporting, many thanks. You correctly identified a leak and can you give the following patch a spin and let me know if it plugs it? Rici Lake wrote: On 8-Sep-04, at 5:24 PM, Philippe M. Chiasson wrote: Could you please post the 2 .htaccess files you've been using ? [EMAIL P

Re: [mp2] introducing PerlOptions +GlobalServer

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: I'm trying to fix the logging functions in the vhost environment. In the mp1 all the methods/functions called on anything but $r/$s was relying on Apache->request. In mp2 Apache->request will be unavailable outside of the httpd protocol. So in order to be able to redirect war

Re: cvs commit: modperl-2.0/t/response/TestModules reload.pm

2004-09-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: Index: Reload.pm === RCS file: /home/cvs/modperl-2.0/lib/Apache/Reload.pm,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- Reload.pm 11 Mar 2004 06:34:24 - 1.

Re: cvs commit: modperl-2.0/t/response/TestModules reload.pm

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: [EMAIL PROTECTED] wrote: Index: Reload.pm === RCS file: /home/cvs/modperl-2.0/lib/Apache/Reload.pm,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- Reload.pm 11 Mar 2004 06:34:2

Re: [mp2] Perl Sections in .htaccess files leak memory

2004-09-09 Thread Philippe M. Chiasson
Rici Lake wrote: On 9-Sep-04, at 12:50 PM, Philippe M. Chiasson wrote: Incredibly thorough bug reporting, many thanks. We aim to please ;) You correctly identified a leak and can you give the following patch a spin and let me know if it plugs it? The patch fixes the override problem but it see

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2004-09-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/09/09 15:16:38 +/* XXX: There is no XS accessible splice() */ +static void modperl_av_remove_entry(pTHX_ AV *av, I32 index) +{ +I32 i; +AV *tmpav = newAV(); + +/* stash the entries _before_ the item to delete */ +for (i=0; i

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/09/09 15:16:38 +/* XXX: There is no XS accessible splice() */ +static void modperl_av_remove_entry(pTHX_ AV *av, I32 index) +{ +I32 i; +AV *tmpav = newAV(); + +/* stash the entries _before_ the item to delete */ +

better name to ModPerl::Util::unload_module?

2004-09-09 Thread Stas Bekman
After looking at the doc again, I think it's misleading to call this function unload_module. Since it's doesn't undo what the module has loaded. It unloads a specific stash (package name) no more and no less. A module could have inserted things into other packages, and other modules may have ad

Re: better name to ModPerl::Util::unload_module?

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: After looking at the doc again, I think it's misleading to call this function unload_module. Since it's doesn't undo what the module has loaded. It unloads a specific stash (package name) no more and no less. It's not quite that simple, it gets rids of a module in preparation

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2004-09-09 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/09/09 15:16:38 +/* XXX: There is no XS accessible splice() */ +static void modperl_av_remove_entry(pTHX_ AV *av, I32 index) +{ +I32 i; +AV *tmpav = newAV(); + +/* stash the entries _before

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/09/09 15:16:38 +/* XXX: There is no XS accessible splice() */ +static void modperl_av_remove_entry(pTHX_ AV *av, I32 index) +{ +I32 i; +AV *tmpav = newAV(); + +/* stash the e

Re: better name to ModPerl::Util::unload_module?

2004-09-09 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: After looking at the doc again, I think it's misleading to call this function unload_module. Since it's doesn't undo what the module has loaded. It unloads a specific stash (package name) no more and no less. It's not quite that simple, it gets rid

Re: better name to ModPerl::Util::unload_module?

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: After looking at the doc again, I think it's misleading to call this function unload_module. Since it's doesn't undo what the module has loaded. It unloads a specific stash (package name) no more and no less. It's not quite that

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2004-09-09 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/09/09 15:16:38 +/* XXX: There is no XS accessible splice() */ +static void modperl_av_remove_entry(pTHX_ AV *av, I32 index) +{ +I32 i; +AV *tmpav = ne

Re: better name to ModPerl::Util::unload_module?

2004-09-09 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: After looking at the doc again, I think it's misleading to call this function unload_module. Since it's doesn't undo what the module has loaded. It unloads a specific stash (package name) no more and n

Re: cvs commit: modperl-2.0/xs/tables/current/ModPerl FunctionTable.pm

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/09/09 15:16:38 +/* XXX: There is no XS accessible splice() */ +static void modperl_av_remove_entry(pTHX_ AV *av, I32 index) +{ +I32 i

Re: better name to ModPerl::Util::unload_module?

2004-09-09 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: After looking at the doc again, I think it's misleading to call this function unload_module. Since it's doesn't undo what the module has loaded. It unloads a specific stash (packag

Re: better name to ModPerl::Util::unload_module?

2004-09-09 Thread Geoffrey Young
Stas Bekman wrote: > After looking at the doc again, I think it's misleading to call this > function unload_module. Since it's doesn't undo what the module has > loaded. It unloads a specific stash (package name) no more and no less. > A module could have inserted things into other packages, and

Re: [mp2] introducing PerlOptions +GlobalServer

2004-09-09 Thread Geoffrey Young
Philippe M. Chiasson wrote: > > > Stas Bekman wrote: > >> I'm trying to fix the logging functions in the vhost environment. In >> the mp1 all the methods/functions called on anything but $r/$s was >> relying on Apache->request. In mp2 Apache->request will be unavailable >> outside of the httpd

Re: [mp2] introducing PerlOptions +GlobalServer

2004-09-09 Thread Stas Bekman
Geoffrey Young wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: I'm trying to fix the logging functions in the vhost environment. In the mp1 all the methods/functions called on anything but $r/$s was relying on Apache->request. In mp2 Apache->request will be unavailable outside of the httpd p

Apache::Util::escape_html() and UTF-8

2004-09-09 Thread David Wheeler
Hi All, I got bit by a bug with Apache::Util's escape_html() function in mod_perl 1. It seems that it doesn't like Perl's Unicode encoded strings! This patch demonstrates the issue (be sure that your editor understands utf-8): --- modperl/t/net/perl/util.pl.~1.18.~ Sun May 25 03:54:08 2003