[
https://issues.apache.org/jira/browse/PHOENIX-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339039#comment-15339039
]
Hudson commented on PHOENIX-2952:
-
FAILURE: Integrated in Phoenix-master #1269 (See
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339037#comment-15339037
]
Hudson commented on PHOENIX-3005:
-
SUCCESS: Integrated in Phoenix-master #1268 (See
[
https://issues.apache.org/jira/browse/PHOENIX-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338996#comment-15338996
]
Josh Elser commented on PHOENIX-2940:
-
{quote}
I'd do ImmutableBytesPtr since this is the key the
[
https://issues.apache.org/jira/browse/PHOENIX-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan resolved PHOENIX-2952.
-
Resolution: Fixed
Pushed to master and 4.x branches. Thanks for the
[
https://issues.apache.org/jira/browse/PHOENIX-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338982#comment-15338982
]
Lars Hofhansl commented on PHOENIX-1304:
The patch looks good BTW. Just coming back to this.
[
https://issues.apache.org/jira/browse/PHOENIX-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ramkrishna.s.vasudevan updated PHOENIX-2952:
Attachment: PHOENIX-2952_1.patch
Patch with the fix and testcase.
>
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl resolved PHOENIX-3005.
Resolution: Fixed
Assignee: Lars Hofhansl
Committed to 4.x* and master.
Thanks for
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated PHOENIX-3005:
---
Description:
It turns out that PHOENIX-2965 has some bugs with indexes:
# COUNT(DISTINCT )
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated PHOENIX-3005:
---
Description:
It turns out that
Was:
Currently the optimization in PHOENIX-258 is not used
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated PHOENIX-3005:
---
Summary: Fixes for COUNT(DISTINCT...) with DistinctPrefixFilter and indexes
(was: Use
[
https://issues.apache.org/jira/browse/PHOENIX-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338911#comment-15338911
]
Pranavan commented on PHOENIX-2166:
---
Hi James
I did a code formatting for the entire files that I
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338894#comment-15338894
]
Lars Hofhansl commented on PHOENIX-3005:
mvn package passes all unit tests... Going to commit
[
https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338874#comment-15338874
]
Hadoop QA commented on PHOENIX-2931:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338870#comment-15338870
]
Lars Hofhansl commented on PHOENIX-3005:
Is this change safe?
{code}
-if
[
https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alicia Ying Shu updated PHOENIX-2931:
-
Attachment: PHOENIX-2931-v1.patch
> Phoenix client asks users to provide configs in cli
[
https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alicia Ying Shu updated PHOENIX-2931:
-
Attachment: (was: PHOENIX-2931-v1.patch)
> Phoenix client asks users to provide
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338867#comment-15338867
]
James Taylor commented on PHOENIX-3005:
---
+1. Thanks, [~lhofhansl]!
> Use DistinctPrefixFilter for
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338851#comment-15338851
]
Lars Hofhansl commented on PHOENIX-3005:
Just your patch? No. It needed all the other changes
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338850#comment-15338850
]
James Taylor commented on PHOENIX-3005:
---
Does my patch work too, [~lhofhansl]? I think that's the
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated PHOENIX-3005:
---
Attachment: 3005-v2.txt
-v2 should do it.
[~giacomotaylor], can you have a look?
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338848#comment-15338848
]
Lars Hofhansl commented on PHOENIX-3005:
The QueryOptimizer changes are no longer needed.
> Use
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated PHOENIX-3005:
---
Attachment: 3005-wip-v1.txt
WIP-v1 passes all test (including some new ones I added).
I do
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-3005:
--
Attachment: PHOENIX-3005_v1.patch
Try this patch and see if it's better, [~lhofhansl]. There
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338830#comment-15338830
]
Lars Hofhansl commented on PHOENIX-3005:
This is after I make this change in GroupBy.compile:
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338829#comment-15338829
]
Lars Hofhansl commented on PHOENIX-3005:
Looks like to COUNT(DISTINCT pk1) is chooses the index
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338825#comment-15338825
]
James Taylor commented on PHOENIX-3005:
---
You may have already discovered, but it looks like the
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338826#comment-15338826
]
Lars Hofhansl commented on PHOENIX-3005:
The other part I notice is that as soon as I add an
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338815#comment-15338815
]
Lars Hofhansl commented on PHOENIX-3005:
I need the early our or COUNT(DISTINCT) queries are
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338815#comment-15338815
]
Lars Hofhansl edited comment on PHOENIX-3005 at 6/19/16 10:19 PM:
--
I
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338811#comment-15338811
]
Lars Hofhansl commented on PHOENIX-3005:
OK... The reason is this in GroupBy.compile:
{code}
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lars Hofhansl updated PHOENIX-3005:
---
Summary: Use DistinctPrefixFilter for COUNT(DISTINCT...) index scans (was:
Use
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338807#comment-15338807
]
Lars Hofhansl commented on PHOENIX-3005:
So specifically, {{SELECT c1 FROM T GROUP BY c1}} works
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338806#comment-15338806
]
Lars Hofhansl commented on PHOENIX-3005:
I see that {{SELECT c1 FROM T GROUP BY c1}} does indeed
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338805#comment-15338805
]
Lars Hofhansl commented on PHOENIX-3005:
In the debugger I see that we happen to detect to that
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338797#comment-15338797
]
Lars Hofhansl commented on PHOENIX-3005:
I'm seeing something different... Hmm... Lemme double
[
https://issues.apache.org/jira/browse/PHOENIX-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338747#comment-15338747
]
Haoran Zhang commented on PHOENIX-2405:
---
Hi [~maryannxue],
I just made a pull request which is
[
https://issues.apache.org/jira/browse/PHOENIX-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338744#comment-15338744
]
ASF GitHub Bot commented on PHOENIX-2405:
-
GitHub user RCheungIT opened a pull request:
GitHub user RCheungIT opened a pull request:
https://github.com/apache/phoenix/pull/175
PHOENIX-2405 Not for merge, just request a review to check whether I'm on
the right way
https://issues.apache.org/jira/browse/PHOENIX-2405
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338662#comment-15338662
]
James Taylor commented on PHOENIX-3005:
---
Looks to be working fine. The index is used as expected.
[
https://issues.apache.org/jira/browse/PHOENIX-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338622#comment-15338622
]
James Taylor commented on PHOENIX-2166:
---
There's a bunch of changes in that patch completely
[
https://issues.apache.org/jira/browse/PHOENIX-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranavan updated PHOENIX-2166:
--
Attachment: PHOENIX-2166.patch
> Prevent writing to tracing table when tracing data collected
>
[
https://issues.apache.org/jira/browse/PHOENIX-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranavan updated PHOENIX-2166:
--
Attachment: (was: PHOENIX-2166.patch)
> Prevent writing to tracing table when tracing data
Hi Rajesh,
I have added the patch for $subject. Can you give feedbacks on it?
Link - https://issues.apache.org/jira/browse/PHOENIX-2166
Thanks
*T. Pranavan*
*Junior Consultant | Department of Computer Science & Engineering
,University of Moratuwa*
*Mobile| *0775136836
[
https://issues.apache.org/jira/browse/PHOENIX-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranavan updated PHOENIX-2166:
--
Attachment: PHOENIX-2166.patch
I have added the patch. Can someone review it?
> Prevent writing to
[
https://issues.apache.org/jira/browse/PHOENIX-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranavan updated PHOENIX-2166:
--
Comment: was deleted
(was: Hi Mujtaba Chohan
Shall we go for a lock based solution? Then at a time
[
https://issues.apache.org/jira/browse/PHOENIX-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338442#comment-15338442
]
Hudson commented on PHOENIX-3006:
-
FAILURE: Integrated in Phoenix-master #1267 (See
[
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338413#comment-15338413
]
James Taylor commented on PHOENIX-3005:
---
Should get compiled twice, once using data table and once
47 matches
Mail list logo
