Github user shuxiong closed the pull request at:
https://github.com/apache/phoenix/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26445767
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDouble.java ---
@@ -17,15 +17,16 @@
*/
package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26445142
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDouble.java ---
@@ -17,15 +17,16 @@
*/
package org.apache.phoenix.schema
Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26443842
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDouble.java ---
@@ -17,15 +17,16 @@
*/
package org.apache.phoenix.schema.typ
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/45#issuecomment-79185104
Couple of very minor items, but otherwise we're good to go. Excellent work,
@shuxiong. Nice first contribution.
---
If your project is set up for it, you can reply
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26407007
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDouble.java ---
@@ -17,15 +17,16 @@
*/
package org.apache.phoenix.schema
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26406807
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apach
Github user shuxiong commented on the pull request:
https://github.com/apache/phoenix/pull/45#issuecomment-78868573
Hi @JamesRTaylor , I already revert the changes and combine all commits
into a single one.
---
If your project is set up for it, you can reply to this email and have y
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/45#issuecomment-78853991
@shuxiong - you're doing a great job so far. Just revert SignFunction back
to your original version, keep the PWholeNumber and PRealNumber classes you
created but ma
Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26368458
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache So
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340462
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PWholeNumber.java ---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Softwa
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340267
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PRealNumber.java ---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Softwar
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340384
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PUnsignedWholeNumber.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apac
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340175
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PInteger.java ---
@@ -272,4 +273,10 @@ public PhoenixArray newArray(PDataType type,
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340133
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PFloat.java ---
@@ -305,4 +306,10 @@ public PhoenixArray newArray(PDataType type, Ob
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340356
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PUnsignedRealNumber.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apach
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340280
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PSmallint.java ---
@@ -256,4 +257,10 @@ public PhoenixArray newArray(PDataType type,
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340181
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PLong.java ---
@@ -328,4 +329,10 @@ public PhoenixArray newArray(PDataType type, Obj
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340105
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDouble.java ---
@@ -308,4 +309,10 @@ public PhoenixArray newArray(PDataType type, O
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26340049
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDecimal.java ---
@@ -402,4 +402,25 @@ public String toStringLiteral(Object o, Forma
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26339983
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apach
Github user shuxiong commented on the pull request:
https://github.com/apache/phoenix/pull/45#issuecomment-78433212
Hi @JamesRTaylor ,
I update the code, adding two more types, PWholeNumber and PRealNumber. and
rename the function from getSign to signum.
Thanks.
---
If y
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26272833
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PInteger.java ---
@@ -272,4 +273,10 @@ public PhoenixArray newArray(PDataType type,
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/45#discussion_r26272695
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDouble.java ---
@@ -308,4 +309,28 @@ public PhoenixArray newArray(PDataType type, O
GitHub user shuxiong opened a pull request:
https://github.com/apache/phoenix/pull/45
PHOENIX-1715 Implement Build-in Math function sign
1. Add Build-in Math Function Sign
2. Add a new Type, PNumericType, which is superclass of all numeric type,
such as PInteger, PFloat etc.
Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/40#discussion_r26134544
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache So
Github user shuxiong closed the pull request at:
https://github.com/apache/phoenix/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/40#discussion_r26112698
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache So
Github user shuxiong commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/40#discussion_r26112576
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache So
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/40#discussion_r26103663
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/SignFunction.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apach
GitHub user shuxiong opened a pull request:
https://github.com/apache/phoenix/pull/40
PHOENIX-1715 Implement Build-in Math function sign
Hi,
I am a student from Peking University, and I'd like to participate GSOC2015.
This patch is an implementation of Build-in math
31 matches
Mail list logo
