Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/124#issuecomment-151491230
How's this look, @JamesRTaylor / @ravimagham ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/124#discussion_r42826328
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java ---
@@ -459,19 +459,30 @@ public static ColumnInfo getColumnInfo(PTable
Github user navis commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/124#discussion_r42825749
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java ---
@@ -459,19 +459,30 @@ public static ColumnInfo getColumnInfo(PTable table,
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/124#issuecomment-150397877
Thanks for the pull request, @navis. A couple of minor comments, but
overall it looks great. FYI, our PDataType class is stateless (it was an enum
originally), so
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/124#discussion_r42823983
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java ---
@@ -459,19 +459,30 @@ public static ColumnInfo getColumnInfo(PTable
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/124#issuecomment-15027
This looks great @navis
The Spark portion looks fine. I'll leave the updates to ColumnInfo for
@ravimagham @JamesRTaylor et. al. to review
---
If your proje
GitHub user navis opened a pull request:
https://github.com/apache/phoenix/pull/124
PHOENIX-2288 Phoenix-Spark: PDecimal precision and scale aren't carried
through to Spark DataFrame
from jira description
>When loading a Spark dataframe from a Phoenix table with a 'DECIMAL'
