Github user chrajeshbabu closed the pull request at:
https://github.com/apache/phoenix/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/phoenix/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48991061
bq. just add a .patch to the url for the pull request and you'll have the
patch file to apply against the normal/updatable repo
That's nice. I tried it, it works. :
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14899559
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply(
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14899221
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java ---
@@ -238,7 +240,12 @@ private void
doColumnProjectionOptimizati
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48949296
Resolved the conflicts after PHOENIX-1002 also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898689
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java ---
@@ -238,7 +240,12 @@ private void
doColumnProjectionOptimizati
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898383
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply(
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14898287
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply(
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897879
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java ---
@@ -169,6 +170,7 @@
SQLViewTypeFunction(SQLViewTypeFun
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897862
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -1134,8 +1135,15 @@ public static SelectStatement
optimize(Phoen
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897277
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java
---
@@ -96,6 +96,11 @@ public ParseNode visit(ColumnParseNode
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14897250
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -568,8 +629,13 @@ public MutationState createIndex(CreateIndexSt
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48945719
bq. Just add the check to disable creating local indexes on a table with
immutable rows and then let's check this in.
Changed pull request to disallow local index
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48941536
@ramkrish86 - just add a .patch to the url for the pull request and you'll
have the patch file to apply against the normal/updatable repo. The github repo
is read-onl
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48927901
I think I don't have write access to do this merge.
Only those with write access to this repository can merge pull
requests.
---
If your project is set up f
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48926040
Just committing it JAmes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14873050
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelIterators.java ---
@@ -238,7 +240,12 @@ private void
doColumnProjectionOptimizati
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48887938
@ramkrish86 - would you have time to check this in to master? We can add
this minor check in a follow up commit. @chrajeshbabu - will an alternate patch
be required f
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14867224
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply(
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/3#issuecomment-48853884
Just a few very minor items. Just add the check to disable creating local
indexes on a table with immutable rows and then let's check this in. Great
work, @chrajeshba
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860610
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -140,7 +142,14 @@ public boolean apply(
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860588
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java ---
@@ -169,6 +170,7 @@
SQLViewTypeFunction(SQLViewTypeFun
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860115
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -1134,8 +1135,15 @@ public static SelectStatement
optimize(Phoen
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860092
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java
---
@@ -96,6 +96,11 @@ public ParseNode visit(ColumnParseNode
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14860075
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -568,8 +629,13 @@ public MutationState createIndex(CreateIndexSt
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14859858
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/StatementContext.java ---
@@ -112,6 +120,36 @@ public StatementContext(StatementContext st
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14859843
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java ---
@@ -169,7 +170,7 @@ private boolean
hasImmutableIndexWithKeyValue
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/3#discussion_r14859660
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java ---
@@ -169,7 +170,7 @@ private boolean
hasImmutableIndexWithKeyValue
GitHub user chrajeshbabu opened a pull request:
https://github.com/apache/phoenix/pull/3
PHOENIX-933 Local index support to Phoenix
Updated pull request after resolving conflicts and handling James review
comments.
You can merge this pull request into a Git repository by running:
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48839791
Sounds good, @chrajeshbabu. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48839233
bq. Cleanest might be to just implement a simple
ParallelIteratorRegionSplitter for use when a local index is used that just
returns all regions:
I will add new P
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14858124
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
SkipRangePa
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48825943
Related to the revert of the ScanRanges change, you'll need to make this
change to prevent the SkipRangeParallelIteratorRegionSplitter from being used
(as you always
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14855032
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java
---
@@ -54,7 +55,8 @@ protected
SkipRangePa
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14854253
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -100,7 +109,7 @@ public static void serializeIntoScan(
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14853806
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -51,21 +51,38 @@ public static void doSetup() throws Excep
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14853783
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -100,7 +109,7 @@ public static void serializeIntoScan(
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14852129
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -51,21 +51,38 @@ public static void doSetup() throws Excep
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14852114
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseTenantSpecificViewIndexIT.java
---
@@ -117,26 +139,38 @@ private Connection createTenan
Github user chrajeshbabu commented on the pull request:
https://github.com/apache/phoenix/pull/1#issuecomment-48798867
Thanks for review @JamesRTaylor. I have resolved the conflicts and handled
all the comments locally. I will submit it once I verify OrderedResultIterator
scenario.
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850789
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java
---
@@ -100,7 +109,7 @@ public static void serializeIntoScan(
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850794
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/ColumnRef.java ---
@@ -113,7 +117,12 @@ public ColumnExpression newColumnExpression() {
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850792
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/BasicQueryPlan.java ---
@@ -141,6 +163,25 @@ public final ResultIterator iterator(final
L
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850795
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/LocalIndexDataColumnRef.java
---
@@ -0,0 +1,49 @@
+package org.apache.phoenix.schema;
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850781
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -387,6 +420,11 @@ private RegionScanner
s
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14850777
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
---
@@ -366,6 +384,21 @@ private RegionScanner
s
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14835161
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/TrackOrderPreservingExpressionCompiler.java
---
@@ -69,6 +70,7 @@
boolean is
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14835033
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/StatementContext.java ---
@@ -81,6 +93,20 @@ public StatementContext(PhoenixStatement stat
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14835021
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ---
@@ -1037,8 +1038,13 @@ public static SelectStatement
optimize(State
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834954
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java
---
@@ -96,6 +96,12 @@ public ParseNode visit(ColumnParseNode
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834905
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
@@ -320,7 +322,21 @@ public Expression visitLeave(FunctionPar
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834896
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
@@ -282,7 +286,7 @@ public Expression visitLeave(FunctionPars
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834867
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java
---
@@ -47,6 +51,21 @@ public MutationPlan compile(final CreateI
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14834683
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
---
@@ -51,21 +51,38 @@ public static void doSetup() throws Excep
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/1#discussion_r14762643
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/TrackOrderPreservingExpressionCompiler.java
---
@@ -69,6 +70,7 @@
boolean is
56 matches
Mail list logo
