Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26342261
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwa
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26341741
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Softwa
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26341117
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the A
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26341134
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the A
Github user codymarcel commented on the pull request:
https://github.com/apache/phoenix/pull/41#issuecomment-78597830
I think I have addressed any outstanding concerns. Let me know if there is
anything else.
---
If your project is set up for it, you can reply to this email and have y
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26339859
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Softwar
Github user samarthjain commented on the pull request:
https://github.com/apache/phoenix/pull/41#issuecomment-78348649
This is fantastic @codymarcel and @mujtabachohan. Just a few concurrency
issues to be ironed out, otherwise looking good!
---
If your project is set up for it, you
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26244969
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the Apache Softwa
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241118
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwa
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239765
--- Diff: phoenix-pherf/pom.xml ---
@@ -0,0 +1,291 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-inst
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239385
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Scenario.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache S
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238762
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26231562
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/loaddata/DataLoader.java
---
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache Softw
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26256441
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwar
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26256135
--- Diff: phoenix-pherf/README.md ---
@@ -0,0 +1,105 @@
+Pherf is a performance test framework that exercises HBase through Apache
Phoenix, a SQL layer
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26244788
--- Diff: phoenix-pherf/README.md ---
@@ -0,0 +1,105 @@
+Pherf is a performance test framework that exercises HBase through Apache
Phoenix, a SQL lay
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26244805
--- Diff: phoenix-pherf/cluster/pherf.sh ---
@@ -0,0 +1,33 @@
+#!/bin/bash
--- End diff --
Subsequent patch is fine.
---
If your projec
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243827
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwar
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243640
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwa
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243599
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwar
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243501
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwa
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243302
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwar
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243169
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwar
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26243047
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Scenario.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache So
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26242921
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwa
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241491
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Ap
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241357
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Softwa
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26241095
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Ap
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26240525
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedRunner.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apa
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239994
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239779
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239616
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239550
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java
---
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the A
Github user mujtabachohan commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239493
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedRunner.java
---
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239341
--- Diff: phoenix-pherf/config/pherf.properties ---
@@ -0,0 +1,61 @@
+#
--- End diff --
Fixed
---
If your project is set up for it, you c
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26239164
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Query.java
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Soft
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238858
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238794
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238739
--- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mujtabachohan commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238686
--- Diff: phoenix-pherf/pom.xml ---
@@ -0,0 +1,291 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-i
Github user mujtabachohan commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26238510
--- Diff: phoenix-pherf/config/pherf.properties ---
@@ -0,0 +1,61 @@
+#
--- End diff --
Minor nit: multiple license headers
---
If you
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26231675
--- Diff:
phoenix-pherf/src/main/resources/scenario/prod_test_unsalted_scenario.xml ---
@@ -0,0 +1,342 @@
+
+
+
+
+
+
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26231197
--- Diff: phoenix-pherf/cluster/pherf.sh ---
@@ -0,0 +1,33 @@
+#!/bin/bash
--- End diff --
Yea, I planned to convert this to python post co
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26230867
--- Diff: phoenix-pherf/README.md ---
@@ -0,0 +1,105 @@
+Pherf is a performance test framework that exercises HBase through Apache
Phoenix, a SQL layer
Github user white-bee commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26190768
--- Diff:
phoenix-pherf/src/main/resources/scenario/prod_test_unsalted_scenario.xml ---
@@ -0,0 +1,342 @@
+
+
+
+
+
+
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/41#issuecomment-78206018
Fantastic work, Cody and Mujtaba. Would be good if you reviewed this too,
@mujtabachohan. As a follow on check-in:
* Change your test that rely on a cluster to us
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26189248
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/loaddata/DataLoader.java
---
@@ -0,0 +1,366 @@
+/*
+ * Licensed to the Apache Sof
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26189190
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/PherfConstants.java ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software F
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26189140
--- Diff: phoenix-pherf/cluster/pherf.sh ---
@@ -0,0 +1,33 @@
+#!/bin/bash
--- End diff --
Please convert this to a python script and put
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26189106
--- Diff: phoenix-pherf/README.md ---
@@ -0,0 +1,105 @@
+Pherf is a performance test framework that exercises HBase through Apache
Phoenix, a SQL lay
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/41#discussion_r26189030
--- Diff: phoenix-assembly/pom.xml ---
@@ -20,131 +20,139 @@
-->
-http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2
GitHub user codymarcel opened a pull request:
https://github.com/apache/phoenix/pull/41
working additions of pherf to phoenix as a project module
"mvn clean package" builds everything correctly.
All tests pass.
You can merge this pull request into a Git repository by running:
52 matches
Mail list logo