[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326674#comment-15326674 ] Hudson commented on PHOENIX-2886: - FAILURE: Integrated in Phoenix-master #1257 (See

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15312598#comment-15312598 ] Alicia Ying Shu commented on PHOENIX-2886: -- I uploaded the patch for coerce expression issue to

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304750#comment-15304750 ] Hadoop QA commented on PHOENIX-2886: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304643#comment-15304643 ] Alicia Ying Shu commented on PHOENIX-2886: -- Modified the lines that were longer than 100 chars.

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303764#comment-15303764 ] Hadoop QA commented on PHOENIX-2886: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303039#comment-15303039 ] Alicia Ying Shu commented on PHOENIX-2886: -- Uploaded a revised patch with more test cases >

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302729#comment-15302729 ] Alicia Ying Shu commented on PHOENIX-2886: -- My tests reveals that checking sortOrder helped

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302556#comment-15302556 ] Alicia Ying Shu commented on PHOENIX-2886: -- Agree that we need to check MaxLength and max Scale

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302272#comment-15302272 ] Sergey Soldatov commented on PHOENIX-2886: -- All we need is to check if 2 data types are

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301195#comment-15301195 ] Alicia Ying Shu commented on PHOENIX-2886: -- Need take PChar.INSTANCE from the checking list >

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299621#comment-15299621 ] Sergey Soldatov commented on PHOENIX-2886: -- [~ayingshu] As I mentioned before it will require

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299615#comment-15299615 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~sergey.soldatov] Noticed the different lengths

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299596#comment-15299596 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~sergey.soldatov] I noticed the different lengths

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297858#comment-15297858 ] Sergey Soldatov commented on PHOENIX-2886: -- [~aliciashu] as [~jamestaylor] mentioned, we need

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297586#comment-15297586 ] Sergey Soldatov commented on PHOENIX-2886: -- Sure, I will > Union ALL with Char column not

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297584#comment-15297584 ] James Taylor commented on PHOENIX-2886: --- Did you update the tests too? Upload a patch and I'll

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297549#comment-15297549 ] Alicia Ying Shu commented on PHOENIX-2886: -- Yes. I added all other stuff: nullable scale,

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297537#comment-15297537 ] James Taylor commented on PHOENIX-2886: --- Did you do all the other stuff I recommended too? I don't

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297528#comment-15297528 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] I have the patch ready. I removed

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297494#comment-15297494 ] James Taylor commented on PHOENIX-2886: --- [~sergey.soldatov] - if you have any spare cycles, maybe

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296793#comment-15296793 ] Hadoop QA commented on PHOENIX-2886: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296769#comment-15296769 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] I uploaded UnionAllIT.java.diff that

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296477#comment-15296477 ] James Taylor commented on PHOENIX-2886: --- [~ayingshu] - I don't understand the context of the

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296048#comment-15296048 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] Is the coerce expression such as

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295837#comment-15295837 ] James Taylor commented on PHOENIX-2886: --- Please let me know what query you're running and what

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295829#comment-15295829 ] Alicia Ying Shu commented on PHOENIX-2886: -- Filed PHOENIX-2934. Thanks. > Union ALL with Char

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295793#comment-15295793 ] James Taylor commented on PHOENIX-2886: --- My point was that checking for a coerce at the top level

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295779#comment-15295779 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] ok, got my env working. Ran with my

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295396#comment-15295396 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] Yes. I got that error message when I

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295086#comment-15295086 ] James Taylor commented on PHOENIX-2886: --- [~ayingshu] - so you get that error message when you try

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294800#comment-15294800 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] Thanks for the review! The special

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294632#comment-15294632 ] James Taylor commented on PHOENIX-2886: --- Thanks for the patch, [~ayingshu] and the reviews,

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294032#comment-15294032 ] Sergey Soldatov commented on PHOENIX-2886: -- LGTM, [~jamestaylor], [~maryannxue] what do you

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293898#comment-15293898 ] Alicia Ying Shu commented on PHOENIX-2886: -- Attached v3 modified the lines longer than 100

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292897#comment-15292897 ] Hadoop QA commented on PHOENIX-2886: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292173#comment-15292173 ] Alicia Ying Shu commented on PHOENIX-2886: -- The pherf test failures were irrelevant to the

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291906#comment-15291906 ] Hadoop QA commented on PHOENIX-2886: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291512#comment-15291512 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~sergey.soldatov] That looks good. Thanks! >

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290541#comment-15290541 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~sergey.soldatov] Thanks for the review! Attached

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288625#comment-15288625 ] Sergey Soldatov commented on PHOENIX-2886: -- Thanks. Don't forget to change the test case to

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288619#comment-15288619 ] Alicia Ying Shu commented on PHOENIX-2886: -- My bad when I cleaned up the code, I switched a

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288562#comment-15288562 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~sergey.soldatov] That was a debug code and it

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288156#comment-15288156 ] Sergey Soldatov commented on PHOENIX-2886: -- Actually the test case is incorrect. {noformat}

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287689#comment-15287689 ] Alicia Ying Shu commented on PHOENIX-2886: -- Fixed the test failures. Uploaded the patch. >

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287290#comment-15287290 ] Sergey Soldatov commented on PHOENIX-2886: -- [~jamestaylor], sure. > Union ALL with Char column

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287235#comment-15287235 ] James Taylor commented on PHOENIX-2886: --- [~sergey.soldatov] - would you have some spare cycles to

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287022#comment-15287022 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] Uploaded the patch that fixed the

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283134#comment-15283134 ] James Taylor commented on PHOENIX-2886: --- Yes, exactly, [~sergey.soldatov], thanks. That's a much

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283125#comment-15283125 ] Sergey Soldatov commented on PHOENIX-2886: -- [~jamestaylor] can't we just collect all types let

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283083#comment-15283083 ] James Taylor commented on PHOENIX-2886: --- That's close, [~ayingshu]. At a high level, you want to

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282960#comment-15282960 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~jamestaylor] Data type conversion can get

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282376#comment-15282376 ] Alicia Ying Shu commented on PHOENIX-2886: -- Yes. I am working on this. Will give a patch soon.

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282070#comment-15282070 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~maryannxue] With current architecture, we compile

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281103#comment-15281103 ] Maryann Xue commented on PHOENIX-2886: -- I do think the types should be coerced for both sides at

[jira] [Commented] (PHOENIX-2886) Union ALL with Char column not present in the table in Query 1 but in Query 2 throw exception

[ https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280911#comment-15280911 ] Alicia Ying Shu commented on PHOENIX-2886: -- [~maryannxue] [~jamestaylor] The culprit of the