[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135301#comment-16135301 ] James Taylor commented on PHOENIX-3994: --- Please resolve this if fixed, [~samarthjain]. > Index

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101257#comment-16101257 ] William Yang commented on PHOENIX-3994: --- I've done the test that

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088942#comment-16088942 ] Hudson commented on PHOENIX-3994: - FAILURE: Integrated in Jenkins build Phoenix-master #1690 (See

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088523#comment-16088523 ] William Yang commented on PHOENIX-3994: --- First, I'm deeply sorry for the committed patch not

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086649#comment-16086649 ] Hudson commented on PHOENIX-3994: - FAILURE: Integrated in Jenkins build Phoenix-master #1686 (See

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086602#comment-16086602 ] Samarth Jain commented on PHOENIX-3994: --- Yes, I did. Although, under the hood, HBaseConfiguration

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086534#comment-16086534 ] James Taylor commented on PHOENIX-3994: --- >From Ted over on HBASE-18378: Have you tried this method

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086263#comment-16086263 ] Samarth Jain commented on PHOENIX-3994: --- bq. One other question: shouldn't we be using the

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086260#comment-16086260 ] James Taylor commented on PHOENIX-3994: --- One other question: shouldn't we be using the coprocessor

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086193#comment-16086193 ] James Taylor commented on PHOENIX-3994: --- Thanks for the updated patch, [~samarthjain]. Would you

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086062#comment-16086062 ] Vincent Poon commented on PHOENIX-3994: --- v4 patch lgtm, [~samarthjain] > Index RPC priority still

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085137#comment-16085137 ] Hadoop QA commented on PHOENIX-3994: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084832#comment-16084832 ] Andrew Purtell commented on PHOENIX-3994: - You have to clone a Configuration. Feel free to file

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084802#comment-16084802 ] James Taylor commented on PHOENIX-3994: --- [~apurtell] - if you get the Configuration from an HTable

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084820#comment-16084820 ] James Taylor commented on PHOENIX-3994: --- Let's make sure we clone it only once and save it as a

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084815#comment-16084815 ] Vincent Poon commented on PHOENIX-3994: --- [~samarthjain] I looked at the comment you linked to

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084813#comment-16084813 ] Samarth Jain commented on PHOENIX-3994: --- bq. if you go the route of using the config on the htable

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084810#comment-16084810 ] Samarth Jain commented on PHOENIX-3994: --- [~jamestaylor], at least in our case, we are creating an

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084778#comment-16084778 ] Samarth Jain commented on PHOENIX-3994: --- Thanks for the comment [~apurtell]. [~jamestaylor],

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084733#comment-16084733 ] James Taylor commented on PHOENIX-3994: --- I like [~vincentpoon]'s idea: how about setting the

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084753#comment-16084753 ] Andrew Purtell commented on PHOENIX-3994: - Coprocessors get their own environments but

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084664#comment-16084664 ] Samarth Jain commented on PHOENIX-3994: --- [~vincentpoon] - from what I understand, every

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084641#comment-16084641 ] Vincent Poon commented on PHOENIX-3994: --- [~samarthjain] changes LGTM overall, but had one question

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084652#comment-16084652 ] Samarth Jain commented on PHOENIX-3994: --- OK, confirmed that adding RpcSchedulerFactory in the

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084582#comment-16084582 ] Samarth Jain commented on PHOENIX-3994: --- One possibility I could think of is to set the RPC

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084538#comment-16084538 ] James Taylor commented on PHOENIX-3994: --- The main thing I'm after is reducing the burden on users

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084535#comment-16084535 ] Samarth Jain commented on PHOENIX-3994: --- I am not sure if adding the

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084468#comment-16084468 ] James Taylor commented on PHOENIX-3994: --- Thanks for the patch, [~samarthjain]. This is a tricky

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084109#comment-16084109 ] Samarth Jain commented on PHOENIX-3994: --- The two tests reported by HADOOP QA passed locally. We

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083838#comment-16083838 ] Hudson commented on PHOENIX-3994: - FAILURE: Integrated in Jenkins build Phoenix-master #1680 (See

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083613#comment-16083613 ] Hadoop QA commented on PHOENIX-3994: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083559#comment-16083559 ] Samarth Jain commented on PHOENIX-3994: --- For clarity, I am going to revert my original patch and

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083136#comment-16083136 ] Hudson commented on PHOENIX-3994: - FAILURE: Integrated in Jenkins build Phoenix-master #1678 (See

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082968#comment-16082968 ] Samarth Jain commented on PHOENIX-3994: --- Looks like my checkin broke some tests. Taking a look. >

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082537#comment-16082537 ] James Taylor commented on PHOENIX-3994: --- Thanks, [~samarthjain]. +1 with the addition of the

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081709#comment-16081709 ] Samarth Jain commented on PHOENIX-3994: --- bq. Just to confirm, your patch causes our existing

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081435#comment-16081435 ] James Taylor commented on PHOENIX-3994: --- Thanks for the patch, [~samarthjain]. Just to confirm,

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077347#comment-16077347 ] Sergey Soldatov commented on PHOENIX-3994: -- Heh. That was the topic we just discussed

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077332#comment-16077332 ] James Taylor commented on PHOENIX-3994: --- I think that's a reasonable solution (and not just for

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077210#comment-16077210 ] Samarth Jain commented on PHOENIX-3994: --- An 0.98 only (since the branch is EOL'ed) alternative

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077207#comment-16077207 ] Samarth Jain commented on PHOENIX-3994: --- Ah, my bad. I misread local updates as updates happening

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077203#comment-16077203 ] James Taylor commented on PHOENIX-3994: --- It's an HBase optimization and it doesn't have anything

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077183#comment-16077183 ] Samarth Jain commented on PHOENIX-3994: --- bq. Index updates that happen to be local bypass the RPC

[jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml

[ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077146#comment-16077146 ] James Taylor commented on PHOENIX-3994: --- I think we'd lose an important optimization if we don't