[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681170#comment-14681170 ] ASF GitHub Bot commented on PHOENIX-978: Github user elilevine commented on the

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-08-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681169#comment-14681169 ] ASF GitHub Bot commented on PHOENIX-978: Github user elilevine closed the pull

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625695#comment-14625695 ] Hudson commented on PHOENIX-978: SUCCESS: Integrated in Phoenix-master #833 (See

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-13 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625458#comment-14625458 ] Samarth Jain commented on PHOENIX-978: -- Thanks for the updated patch [~tdsilva]

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-13 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625430#comment-14625430 ] James Taylor commented on PHOENIX-978: -- One minor item: can you change all of the

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-10 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623012#comment-14623012 ] Samarth Jain commented on PHOENIX-978: -- [~tdsilva] and I went through the code

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-09 Thread Eli Levine (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620929#comment-14620929 ] Eli Levine commented on PHOENIX-978: Thanks for the comments, [~jamestaylor].

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-09 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620969#comment-14620969 ] James Taylor commented on PHOENIX-978: -- Are there other edge cases than the one I

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-09 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621461#comment-14621461 ] Thomas D'Silva commented on PHOENIX-978: After discussing this further we decided

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619756#comment-14619756 ] ASF GitHub Bot commented on PHOENIX-978: Github user elilevine commented on a

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619757#comment-14619757 ] ASF GitHub Bot commented on PHOENIX-978: Github user elilevine commented on a

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-08 Thread Eli Levine (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619770#comment-14619770 ] Eli Levine commented on PHOENIX-978: [~tdsilva], can you take a look at the pull

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619727#comment-14619727 ] ASF GitHub Bot commented on PHOENIX-978: GitHub user elilevine opened a pull

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-08 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619876#comment-14619876 ] James Taylor commented on PHOENIX-978: -- Those aren't rounding errors, [~elilevine].

[jira] [Commented] (PHOENIX-978) Allow views to extend base table's PK (only if last PK column is fixed length)

2015-07-08 Thread Eli Levine (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619730#comment-14619730 ] Eli Levine commented on PHOENIX-978: Working on fixing AlterTableIT now... Allow