Belated +1
Ran my usually tests. With upserts, deleted, global and local indexes, larger
upsert/selects, etc. Nothing undue in the logs, all works.
-- Lars
On Thursday, November 8, 2018, 3:55:07 PM PST, Vincent Poon
wrote:
The vote is now closed and passes with 4 binding +1s and no 0
+1
Ran mvn verify on all branches. A few errors passed after manually
running. Otherwise everything passed.
On Wed, Nov 7, 2018 at 10:12 AM James Taylor wrote:
> +1
>
> Ran various manual sanity tests around loading/querying/indexing data
>
> On Tue, Nov 6, 2018 at 3:53 PM Thomas D'Silva
>
The vote is now closed and passes with 4 binding +1s and no 0 or -1 votes.
Thanks to those who voted. We'll work on pushing out the bits next.
On Thu, Nov 8, 2018 at 3:52 PM Vincent Poon
wrote:
> +1
> Ran mvn verify on all branches. A few errors passed after manually
> running. Otherwise
+1
Ran various manual sanity tests around loading/querying/indexing data
On Tue, Nov 6, 2018 at 3:53 PM Thomas D'Silva
wrote:
> +1
>
> Ran some manual tests with indexes, sequences.
> Regarding Artem's question in PhoenixDatabaseMetdata.getDriverVersion() we
> only return the
+1
Ran some manual tests with indexes, sequences.
Regarding Artem's question in PhoenixDatabaseMetdata.getDriverVersion() we
only return the majorVersion.minorVersion
perhaps you can file a JIRA to also inlcude the patch version.
On Fri, Nov 2, 2018 at 11:47 AM, Josh Elser wrote:
> +1
+1 (binding)
Some observations:
* Some cruft (0.98, 1.2, and 1.3 seem to have this), not a blocker,
but good to ensure is cleaned up in the future:
./bin/phoenix_utils.pyc
Everything else looks good to me.
- Josh
On Tue, Oct 30, 2018 at 4:47 PM Vincent Poon wrote:
>
> Hello Everyone,
>
> This
vote: 4.14.1 RC0
+1 (non-binding)
signatures and sums for src and bin: OK
installed on pseudodistributed hadoop 2.7.7 with hbase 1.4.8: OK
sqlline various commands: OK
compile from src OpenJDK 1.8.0_191: OK
build with fast tests: OK
performance.py 1M: OK
One question I have is should we show
