[jira] [Updated] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4685: -- Attachment: PHOENIX-4685_addendum3.patch > Properly handle connection caching for Phoenix

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477591#comment-16477591 ] James Taylor commented on PHOENIX-4685: --- [~rajeshbabu]. I'm running the tests with the addendum3

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477608#comment-16477608 ] Rajeshbabu Chintaguntla commented on PHOENIX-4685: -- [~jamestaylor] Yes exactly that's

[jira] [Updated] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4685: -- Attachment: PHOENIX-4685_addendum4.patch > Properly handle connection caching for Phoenix

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477830#comment-16477830 ] James Taylor commented on PHOENIX-4685: --- Attaching addendum4 that puts shutdown in finally block.

[jira] [Updated] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-4701: --- Attachment: PHOENIX-4701_addendum.patch > Write client-side metrics asynchronously to

[jira] [Updated] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-4701: --- Attachment: (was: PHOENIX-4701_addendum.patch) > Write client-side metrics

[jira] [Updated] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-4701: --- Attachment: PHOENIX-4701_addendum.patch > Write client-side metrics asynchronously to

[jira] [Created] (PHOENIX-4739) Update phoenix 5.0 with hive new API getBufferedRowCount

2018-05-16 Thread Ankit Singhal (JIRA)
Ankit Singhal created PHOENIX-4739: -- Summary: Update phoenix 5.0 with hive new API getBufferedRowCount Key: PHOENIX-4739 URL: https://issues.apache.org/jira/browse/PHOENIX-4739 Project: Phoenix

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478316#comment-16478316 ] Ankit Singhal commented on PHOENIX-4685: [~jamestaylor], bq. Was thinking the same. I seem to

[jira] [Updated] (PHOENIX-4739) Update phoenix 5.0 with hive new API getBufferedRowCount

2018-05-16 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-4739: --- Attachment: PHOENIX-4739.patch > Update phoenix 5.0 with hive new API getBufferedRowCount >

[jira] [Commented] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478389#comment-16478389 ] Hudson commented on PHOENIX-4701: - ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #134 (See

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-05-16 Thread ortutay
Github user ortutay commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r188777161 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java --- @@ -77,57 +153,164 @@ public MemoryManager getMemoryManager() {

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478123#comment-16478123 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on a diff in the pull

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478124#comment-16478124 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on a diff in the pull

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-05-16 Thread ortutay
Github user ortutay commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r188777276 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java --- @@ -77,57 +153,164 @@ public MemoryManager getMemoryManager() {

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478140#comment-16478140 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on a diff in the pull

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-05-16 Thread ortutay
Github user ortutay commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r188778970 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java --- @@ -159,6 +161,10 @@ protected void finalize() throws

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-05-16 Thread ortutay
Github user ortutay commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r188778824 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -314,7 +314,8 @@ protected QueryPlan

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478142#comment-16478142 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on a diff in the pull

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478169#comment-16478169 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on the issue:

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-05-16 Thread ortutay
Github user ortutay commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r188783687 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCacheImpl.java --- @@ -77,57 +153,164 @@ public MemoryManager getMemoryManager() {

[GitHub] phoenix issue #298: PHOENIX-4666 Persistent subquery cache for hash joins

2018-05-16 Thread ortutay
Github user ortutay commented on the issue: https://github.com/apache/phoenix/pull/298 > Another question to consider besides the suggested changes: do we need a SQL command to remove a specific cache entry and/or purge the entire persistent cache? I think that's a good idea

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478166#comment-16478166 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on a diff in the pull

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478167#comment-16478167 ] ASF GitHub Bot commented on PHOENIX-4666: - Github user ortutay commented on a diff in the pull

[jira] [Commented] (PHOENIX-4666) Add a subquery cache that persists beyond the life of a query

2018-05-16 Thread Marcell Ortutay (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478175#comment-16478175 ] Marcell Ortutay commented on PHOENIX-4666: -- [~maryannxue] I've updated the PR to respond to

[GitHub] phoenix pull request #298: PHOENIX-4666 Persistent subquery cache for hash j...

2018-05-16 Thread ortutay
Github user ortutay commented on a diff in the pull request: https://github.com/apache/phoenix/pull/298#discussion_r188783472 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java --- @@ -383,7 +384,7 @@ protected QueryPlan

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477924#comment-16477924 ] Ankit Singhal commented on PHOENIX-4685: [~jamestaylor], I think this is related to Metric

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477935#comment-16477935 ] James Taylor commented on PHOENIX-4685: --- Thanks, Ankit. Was thinking the same. I seem to remember

[jira] [Commented] (PHOENIX-4685) Properly handle connection caching for Phoenix inside RegionServers

2018-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478492#comment-16478492 ] Hudson commented on PHOENIX-4685: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #135 (See

[jira] [Commented] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478518#comment-16478518 ] James Taylor commented on PHOENIX-4701: --- One more addendum necessary, [~an...@apache.org]. This

[jira] [Updated] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4701: -- Attachment: PHOENIX-4701_addendum2.patch > Write client-side metrics asynchronously to

[jira] [Commented] (PHOENIX-4701) Write client-side metrics asynchronously to SYSTEM.LOG

2018-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478562#comment-16478562 ] Hudson commented on PHOENIX-4701: - ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1893