[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060227#comment-14060227 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on th

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/3#issuecomment-48853884 Just a few very minor items. Just add the check to disable creating local indexes on a table with immutable rows and then let's check this in. Great work, @chrajeshba

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060225#comment-14060225 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14860610 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java --- @@ -140,7 +142,14 @@ public boolean apply(

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060224#comment-14060224 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14860588 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java --- @@ -169,6 +170,7 @@ SQLViewTypeFunction(SQLViewTypeFun

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060214#comment-14060214 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14860115 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java --- @@ -1134,8 +1135,15 @@ public static SelectStatement optimize(Phoen

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060213#comment-14060213 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14860092 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java --- @@ -96,6 +96,11 @@ public ParseNode visit(ColumnParseNode

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060212#comment-14060212 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14860075 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -568,8 +629,13 @@ public MutationState createIndex(CreateIndexSt

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060206#comment-14060206 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14859858 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/StatementContext.java --- @@ -112,6 +120,36 @@ public StatementContext(StatementContext st

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060205#comment-14060205 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14859843 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java --- @@ -169,7 +170,7 @@ private boolean hasImmutableIndexWithKeyValue

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060204#comment-14060204 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/3#discussion_r14859660 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java --- @@ -169,7 +170,7 @@ private boolean hasImmutableIndexWithKeyValue

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060189#comment-14060189 ] ASF GitHub Bot commented on PHOENIX-933: GitHub user chrajeshbabu opened a pull r

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread chrajeshbabu
GitHub user chrajeshbabu opened a pull request: https://github.com/apache/phoenix/pull/3 PHOENIX-933 Local index support to Phoenix Updated pull request after resolving conflicts and handling James review comments. You can merge this pull request into a Git repository by running:

[jira] [Updated] (PHOENIX-1035) Performance test local indexing against global indexing

2014-07-13 Thread rajeshbabu (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rajeshbabu updated PHOENIX-1035: Issue Type: Sub-task (was: Bug) Parent: PHOENIX-933 > Performance test local indexing ag

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060099#comment-14060099 ] ASF GitHub Bot commented on PHOENIX-933: Github user JamesRTaylor commented on th

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread JamesRTaylor
Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/1#issuecomment-48839791 Sounds good, @chrajeshbabu. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060096#comment-14060096 ] ASF GitHub Bot commented on PHOENIX-933: Github user chrajeshbabu commented on th

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread chrajeshbabu
Github user chrajeshbabu commented on the pull request: https://github.com/apache/phoenix/pull/1#issuecomment-48839233 bq. Cleanest might be to just implement a simple ParallelIteratorRegionSplitter for use when a local index is used that just returns all regions: I will add new P

[jira] [Commented] (PHOENIX-933) Local index support to Phoenix

2014-07-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060094#comment-14060094 ] ASF GitHub Bot commented on PHOENIX-933: Github user chrajeshbabu commented on a

[GitHub] phoenix pull request: PHOENIX-933 Local index support to Phoenix

2014-07-13 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/phoenix/pull/1#discussion_r14858124 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/SkipRangeParallelIteratorRegionSplitter.java --- @@ -54,7 +55,8 @@ protected SkipRangePa

Re: How can we add new keywords to Phoenix?‏

2014-07-13 Thread James Taylor
Hi Ahmed, If the motivation is to make SQL simple enough for an end-user unfamiliar with it to write queries, then I'd recommend putting a GUI front-end on top of Phoenix. You'd then have the GUI generate standard SQL. This is a very typical scenario in the world of business applications. The miss

[jira] [Commented] (PHOENIX-1057) Phoenix wrong range query result

2014-07-13 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060085#comment-14060085 ] James Taylor commented on PHOENIX-1057: --- Actually, I don't know that 0.98.0 doesn'

[jira] [Commented] (PHOENIX-1057) Phoenix wrong range query result

2014-07-13 Thread Pham Phuong Tu (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060082#comment-14060082 ] Pham Phuong Tu commented on PHOENIX-1057: - You may know that Hbase 0.98.0 and 0.

[jira] [Updated] (PHOENIX-1016) Support MINVALUE, MAXVALUE, and CYCLE options in CREATE SEQUENCE

2014-07-13 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-1016: -- Attachment: AddSeqColumns.txt Thanks for tracking this down, [~tdsilva]. You're hitting a bug